| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-19 | |||
| 16:35:38 | bauzas | it's confusing indeed | |
| 16:35:42 | sean-k-mooney | i am pretty sure it does not have to be a number | |
| 16:35:47 | dansmith | could we make it -NotYet, +Prio, +HighPrio ? | |
| 16:35:49 | bauzas | I don't know, we need to look at gerrit acls | |
| 16:36:06 | dansmith | or -Low, +Med, +High | |
| 16:36:06 | sean-k-mooney | i can check but this si just a cutom lable | |
| 16:36:24 | dansmith | don't do it just for me, but just relating my frustration with it on the glance side | |
| 16:36:24 | bauzas | dansmith: man, we got this https://review.opendev.org/c/openstack/project-config/+/837595 open for a while, you know your very good comment would have been more than appreciated then ? :D | |
| 16:36:46 | bauzas | anyway, it took us 6 months to get it | |
| 16:36:50 | dansmith | bauzas: sorry, but it has taken actual experience to realize it's annoying | |
| 16:37:02 | bauzas | I'm pretty sure we can take one month more to find if we can change the acls and to get it merged :p | |
| 16:37:08 | sean-k-mooney | bauzas: well thats just ebcause we didnt agree on what it shoudl be | |
| 16:37:13 | sean-k-mooney | if we can set a custom value | |
| 16:37:15 | bauzas | sean-k-mooney: not exactly | |
| 16:37:21 | sean-k-mooney | and we want too we can get it updated quickly | |
| 16:37:30 | dansmith | I will help push for reviews on a change if you want to do it | |
| 16:37:33 | bauzas | sean-k-mooney: it took us nearly a cycle to agree and then nearly a midcycle to get it merged | |
| 16:37:39 | dansmith | again, not trying to mess anything up, just conveying my experience | |
| 16:37:47 | bauzas | dansmith: your comment is legit | |
| 16:37:57 | sean-k-mooney | bauzas: thats just because i had asked them to wait until i went back to them | |
| 16:37:58 | bauzas | and I don't want contributors to mess this up | |
| 16:38:18 | gibi | I would go for +P (contributor review promise) +CP (core review promise) | |
| 16:38:25 | bauzas | someone thinking he would +1 a patch and instead saying "yay, I'm committed on reviewing it soon" | |
| 16:38:30 | dansmith | is that what you meant by +1 +2? :) | |
| 16:38:34 | dansmith | if so, the labels would be much more useful | |
| 16:38:42 | bauzas | yup | |
| 16:38:51 | sean-k-mooney | https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_value | |
| 16:38:53 | bauzas | we'll figure it out | |
| 16:38:58 | sean-k-mooney | so it might need to be an int | |
| 16:39:39 | sean-k-mooney | the name can be anything we want | |
| 16:40:10 | sean-k-mooney | we can proably move on and confrim outside the meeting | |
| 16:40:14 | dansmith | ++ | |
| 16:40:23 | gibi | ack | |
| 16:40:34 | bauzas | ++ | |
| 16:41:19 | bauzas | we have someone having added https://review.opendev.org/c/openstack/nova-specs/+/816542 to the agenda | |
| 16:41:44 | bauzas | Spec for modifiable user_data was accepted / merged, but implementations are still pending final review / merge | |
| 16:41:57 | bauzas | so I guess he's raising our attention to : | |
| 16:42:15 | bauzas | #link https://review.opendev.org/c/openstack/nova/+/816157 server implementation | |
| 16:42:19 | bauzas | #link https://review.opendev.org/c/openstack/python-novaclient/+/816158 novaclient | |
| 16:42:25 | bauzas | #link https://review.opendev.org/c/openstack/python-openstackclient/+/847792 openstackclient | |
| 16:42:28 | sean-k-mooney | yep i skimmed that | |
| 16:42:28 | bauzas | #link https://review.opendev.org/c/openstack/python-novaclient/+/816158 novaclient | |
| 16:42:40 | bauzas | this is one of the API changes we have | |
| 16:42:46 | bauzas | 2.94 ? | |
| 16:43:14 | sean-k-mooney | im not sure if its reday to merge but its an api change yes | |
| 16:43:29 | bauzas | I'll add it to the etherpad | |
| 16:44:26 | bauzas | moving on | |
| 16:44:35 | bauzas | #topic Stable Branches | |
| 16:44:40 | bauzas | elodilles: are you around ? | |
| 16:44:42 | elodilles | yes | |
| 16:44:47 | elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | |
| 16:44:59 | elodilles | #info stable/train is blocked, fix exists but hasn't merged yet due to intermittent failures + now nova-grenade-multinode & nova-live-migration started to fail @ devstack 'create' phase | |
| 16:45:24 | elodilles | so train is now 'more' broken | |
| 16:46:00 | elodilles | i could not reproduce the devstack issue locally yet | |
| 16:46:08 | bauzas | looks like the French SNCF rail | |
| 16:46:16 | elodilles | :) | |
| 16:47:18 | elodilles | anyway, i'll try to look into the issue, but any hint is appreciated | |
| 16:48:27 | elodilles | (i've added some details to the nova-stable-branch-ci, but haven't created a bug yet) | |
| 16:48:54 | bauzas | elodilles: honesly, I'm under the water as I speak | |
| 16:49:28 | elodilles | bauzas: ok, no problem, it's just a heads up for everyone who is interested in train branch :) | |
| 16:49:49 | bauzas | *some* may be interested | |
| 16:50:14 | elodilles | and that's it about stable branches from me i think | |
| 16:52:01 | bauzas | unfortunately, let's move on, then | |
| 16:52:15 | bauzas | #topic Open discussion | |
| 16:52:21 | bauzas | (sean) https://review.opendev.org/c/openstack/nova-specs/+/849488 spec freeze exception for spice compression | |
| 16:52:38 | bauzas | so yeah I wrote we could discuss this now | |
| 16:52:48 | bauzas | to see whether we punt it for Zed or we accept it | |
| 16:53:10 | bauzas | anyone having opinions about it ? | |
| 16:53:15 | bauzas | tbh, I'm meh to it | |
| 16:53:35 | bauzas | trying to honestly balance the risks vs. the benefits | |
| 16:53:54 | sean-k-mooney | risk shoudl be small since this is not user faceing | |
| 16:53:59 | yoctozepto | o/ | |
| 16:54:06 | sean-k-mooney | there is no api impact to this | |
| 16:54:17 | bauzas | this is configurable, right? | |
| 16:54:24 | yoctozepto | right | |
| 16:54:25 | sean-k-mooney | via host level config options only | |
| 16:54:30 | yoctozepto | and defaults to previous default | |
| 16:54:37 | bauzas | yeah, so basically a regression wouldn't be a big deal | |
| 16:54:47 | sean-k-mooney | we might want to default to unset | |
| 16:54:51 | bauzas | changing the options and that's it | |
| 16:54:53 | sean-k-mooney | but we could defer that to the implemation | |
| 16:54:56 | bauzas | yeah | |
| 16:54:59 | sean-k-mooney | to keep it entirly off by defualt | |
| 16:55:13 | bauzas | if that's purely additive and host-config based only, doesn't sound a big deal | |
| 16:55:23 | yoctozepto | i.e., "do not touch this part of libvirt's xml" by default? | |
| 16:55:30 | bauzas | correct | |
| 16:55:34 | yoctozepto | makes sense | |
| 16:55:34 | bauzas | no upgrade impact | |
| 16:55:38 | sean-k-mooney | right we cuurrently dont generate the elements | |
| 16:55:44 | sean-k-mooney | so we coudl continue to do that by default | |
| 16:55:51 | yoctozepto | agreed | |
| 16:55:58 | gibi | I'm OK to grant the exception for this. | |
| 16:56:13 | bahnwaerter | sean-k-mooney: Yeah, I could change that. It makes more sense to only set the libvirt entries if they are specified in a nova.conf | |
| 16:56:20 | bauzas | yoctozepto: do you have open changes against it ? | |
| 16:56:33 | bauzas | oh, that's bahnwaerter's question then | |
| 16:56:41 | sean-k-mooney | there is a nova change and nova-specs change open | |
| 16:56:50 | yoctozepto | ++ | |
| 16:56:52 | sean-k-mooney | so if we grant the excption we can update the sepc before we merge it | |
| 16:56:54 | bauzas | ok, so there is already a poc | |
| 16:57:01 | sean-k-mooney | yes | |