| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-12 | |||
| 09:35:46 | gibi | ack, I'm not against having exta UTs too, just stated why I ' | |
| 09:35:47 | bauzas | and the functests are done on the latter patch | |
| 09:35:49 | gibi | why I'm OK as is | |
| 09:40:07 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 09:42:00 | Uggla | bauzas, you mean the conditionals with host and az ? There are fully tested with functional tests. Am I missing something ? | |
| 09:44:13 | bauzas | Uggla: you test them on the functests in https://review.opendev.org/c/openstack/nova/+/845897/4/nova/tests/functional/test_servers.py | |
| 09:44:20 | bauzas | which is the latter patch | |
| 09:44:41 | bauzas | Uggla: but you also touch https://review.opendev.org/c/openstack/nova/+/831507/17/nova/tests/unit/compute/test_shelve.py in the compute patch | |
| 09:44:54 | bauzas | you're actually just reindenting a few calls | |
| 09:45:15 | bauzas | but you could also test the host param in some other tests | |
| 09:46:48 | opendevreview | Merged openstack/nova master: Catch an exception in power off procedure https://review.opendev.org/c/openstack/nova/+/817176 | |
| 09:46:56 | opendevreview | Merged openstack/nova master: Optimize _local_delete calls by compute unit tests https://review.opendev.org/c/openstack/nova/+/844285 | |
| 09:47:47 | sean-k-mooney | bauzas: ill review your api removal patch shortly. i spend a lot of time reviewing this morning before going up to the office so im getting a little burnt out by it but i can do one or two more | |
| 09:48:01 | sean-k-mooney | bauzas: the centos 9 patch is on its way to merging | |
| 09:49:16 | sean-k-mooney | bauzas: gibi im going to leave the unshleve to host serise to ye. ping me if needed but since ye had open comments on them ill let ye take lead on teh review of that | |
| 09:49:38 | gibi | sean-k-mooney: ack, make sense | |
| 09:49:41 | sean-k-mooney | bauzas: regarding the external power manamgment i have not had time to look at it but its on my todo list for today | |
| 09:50:16 | gibi | sean-k-mooney: my only concern is that bauzas is off the rest of this week and I'd like to merge the unshelve | |
| 09:50:41 | sean-k-mooney | gibi: i can review just proably not today | |
| 09:50:58 | gibi | sean-k-mooney: superb, thanks | |
| 09:51:04 | bauzas | thanks | |
| 09:51:06 | sean-k-mooney | if ye agree on the path forward ill review when Uggla respins the patch to adress your comments | |
| 10:05:05 | bauzas | sean-k-mooney: gibi: we deserve to be humble with Uggla https://review.opendev.org/c/openstack/os-traits/+/832769 | |
| 10:07:26 | gibi | Uggla, bauzas: I'm -1 on https://review.opendev.org/c/openstack/os-traits/+/832769 | |
| 10:08:17 | bauzas | gibi: excellent point | |
| 10:08:27 | gibi | easy to fix :) | |
| 10:08:52 | opendevreview | Manuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 10:11:24 | opendevreview | Manuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 10:14:15 | frickler | sean-k-mooney: wow, you really get me wondering now why gerrit is sending me mails about a nova patch, which it usually doesn't. finding out that I reviewed it 5 years ago was ... interesting ;) | |
| 10:15:47 | opendevreview | Manuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 10:56:45 | sean-k-mooney | frickler: i have a dashboard that i sometimes use when i want to find patches to review | |
| 10:57:06 | sean-k-mooney | i went througyh some of hte small ones this moringin then looked for ones with one +2 that were not in merge conflict | |
| 10:57:17 | sean-k-mooney | then looked at a few form my normal todo list | |
| 10:57:24 | sean-k-mooney | so ya some of those were old | |
| 10:58:11 | sean-k-mooney | https://review.opendev.org/dashboard/?foreach=%28+project%3Aopenstack%2Fnova+OR%0Aproject%3Aopenstack%2Fpython-novaclient+OR%0Aproject%3Aopenstack%2Fnova-specs+OR%0Aproject%3Aopenstack%2Fos-vif+OR%0Aproject%3Aopenstack%2Fos-traits+%29%0Astatus%3Aopen%0ANOT+owner%3Aself%0ANOT+label%3AWorkflow%3C%3D-1%0Alabel%3AVerified%3E%3D1%2Czuul%0ANOT+reviewedby%3Aself%0Abranch%3Amaster&tit | |
| 10:58:14 | sean-k-mooney | le=Nova+Review+Inbox&Small+patches=%28project%3Aopenstack%2Fnova+OR+project%3Aopenstack%2Fpython-novaclient+OR+project%3Aopenstack%2Fos-vif+OR+project%3Aopenstack%2Fos-traits%29+NOT+label%3ACode-Review%3E%3D2%2Cself+NOT+label%3ACode-Review%3C%3D-1%2Cnova-core+NOT+message%3A%22DNM%22+delta%3A%3C%3D10&Needs+final+%2B2=%28project%3Aopenstack%2Fnova+OR+project%3Aopenstack%2Fpython | |
| 10:58:16 | sean-k-mooney | -novaclient+OR+project%3Aopenstack%2Fos-vif+OR+project%3Aopenstack%2Fos-traits%29+NOT+label%3ACode-Review%3E%3D2%2Cself+label%3ACode-Review%3E%3D2+limit%3A50&Bug+fix%2C+Passed+Zuul%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2%2Cself+NOT+label%3ACode-Review%3C%3D-1%2Cnova-core+message%3A%22bug%3A+%22+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+las | |
| 10:58:18 | sean-k-mooney | t+two+days%29=NOT+label%3ACode-Review%3C%3D-1+NOT+label%3ACode-Review%3E%3D1+age%3A2d+limit%3A50&Needs+feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D-1+NOT+label%3ACode-Review%3E%3D1+age%3A5d+limit%3A50&Passed+Zuul%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Need | |
| 10:58:20 | sean-k-mooney | s+revisit+%28You+were+a+reviewer+but+haven%27t+voted+in+the+current+revision%29=reviewer%3Aself+limit%3A50&Specs=project%3Aopenstack%2Fnova-specs+status%3Aopen+limit%3A20 | |
| 10:58:22 | sean-k-mooney | ok thats longer then i tought it was | |
| 10:58:36 | sean-k-mooney | its also a little buggy sometimes | |
| 10:59:01 | sean-k-mooney | like it sometimes need to be opened twice to get current data | |
| 11:04:02 | opendevreview | Amit Uniyal proposed openstack/nova master: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/849104 | |
| 11:04:03 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 12:01:19 | opendevreview | sean mooney proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 12:02:06 | sean-k-mooney | auniyal_: ^ | |
| 12:02:13 | sean-k-mooney | that fixes your release note issue | |
| 12:03:03 | sean-k-mooney | but now i need to rebase them both | |
| 12:03:33 | opendevreview | sean mooney proposed openstack/nova master: add regression test case for bug 1978983 https://review.opendev.org/c/openstack/nova/+/849104 | |
| 12:03:33 | opendevreview | sean mooney proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 12:03:59 | sean-k-mooney | auniyal_: so now gerrit sees them both as the most recent revision | |
| 12:03:59 | auniyal_ | ack | |
| 13:23:42 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds link in releasenotes for hw machine type bug https://review.opendev.org/c/openstack/nova/+/849532 | |
| 13:25:38 | opendevreview | ribaudr proposed openstack/os-traits master: Add 'COMPUTE_STORAGE_VIRTIO_FS', 'COMPUTE_MEM_BACKING_FILE' https://review.opendev.org/c/openstack/os-traits/+/832769 | |
| 13:28:13 | Uggla | bauzas, do you have prepared the notes for today's meeting ? | |
| 13:57:11 | bauzas | Uggla: done : https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 13:57:17 | bauzas | and thanks | |
| 14:03:38 | Uggla | bauzas, thx | |
| 14:06:13 | Uggla | gibi, you will start the meeting right ? | |
| 14:06:58 | bauzas | I have to drop by now | |
| 14:07:03 | bauzas | see you folks, you'll be missed | |
| 14:07:10 | gibi | bauzas: o/ have a nice one | |
| 14:07:39 | gibi | Uggla: as you would like to. I can start and run it until 18:30 CEST and then pass the rest to you. Or you can start from the beginning and I can be just your support running the meeting | |
| 14:08:21 | Uggla | gibi, option 1 is fine. | |
| 14:08:31 | gibi | OK, then I will start | |
| 14:11:03 | Uggla | gibi, I would rather because sometime I'm not fully available to start at 18h. | |
| 14:11:16 | gibi | sure, no problemo :) | |
| 14:45:34 | ralonsoh | sean-k-mooney, https://review.opendev.org/c/openstack/releases/+/849544 | |
| 14:45:43 | ralonsoh | is it ok to have a new os-vif version? | |
| 14:45:50 | ralonsoh | we need the trunks improvement | |
| 14:46:31 | sean-k-mooney | sure we can do one for m2 | |
| 14:46:38 | sean-k-mooney | i can propose a patch | |
| 14:46:53 | sean-k-mooney | ralonsoh: oh you already have | |
| 14:47:03 | ralonsoh | hehehe yes | |
| 15:31:42 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 15:43:56 | gibi | foks, weekly nova meeting starts in 15 minutes here in the channel | |
| 16:00:38 | gibi | #startmeeting nova | |
| 16:00:38 | opendevmeet | Meeting started Tue Jul 12 16:00:38 2022 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:38 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:38 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:53 | gibi | #chairs gibi Uggla | |
| 16:00:56 | gibi | #chair gibi Uggla | |
| 16:00:56 | opendevmeet | Current chairs: Uggla gibi | |
| 16:01:04 | gibi | o/ folks | |
| 16:01:08 | Uggla | o/ | |
| 16:01:27 | gibi | bauzas is away for the rest of the week so Uggla and I will be your host today | |
| 16:01:59 | gibi | lets wait a bit and see if there are others here for the meeting :) | |
| 16:03:45 | gibi | really? only me an Uggla? then it will be a quick meeting :) | |
| 16:03:56 | gibi | #topic Bugs (stuck/critical) | |
| 16:04:01 | gibi | #info One Critical bug | |
| 16:04:06 | gibi | #link https://bugs.launchpad.net/nova/+bug/1979047 Centos 9 Stream bug failure | |
| 16:04:10 | gibi | #link https://review.opendev.org/c/openstack/nova/+/849463 move the C9S job to both experimental and periodic-weekly | |
| 16:04:16 | gibi | #action bauzas to track results of this job on nova weekly meeting | |
| 16:04:21 | elodilles | o/ | |
| 16:04:22 | gibi | I actually closed that critical | |
| 16:04:35 | gibi | as we merged the move of the job to our periodic queue today | |
| 16:04:41 | gibi | so no need to track this as a critical bug | |
| 16:04:47 | gibi | elodilles: o./ | |
| 16:05:04 | gibi | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 11 new untriaged bugs (+1 since the last meeting) | |
| 16:05:10 | gibi | #link https://storyboard.openstack.org/#!/project/openstack/placement 27 open stories (+0 since the last meeting) in Storyboard for Placement | |