| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-06 | |||
| 12:51:04 | bauzas | yeah, simple and trivial fix I discussed with ratailor__ | |
| 12:51:18 | sean-k-mooney | ya rajesh is correct casts shoudl not return anything | |
| 12:51:29 | bauzas | sean-k-mooney: I think it was just a copy/paste problem | |
| 12:51:36 | bauzas | when people created those calls | |
| 12:51:37 | sean-k-mooney | and techinaly beofre and after this call if you assinged the result to avar the content would be None | |
| 12:51:50 | sean-k-mooney | ya ok that what i assumed too | |
| 12:51:53 | bauzas | cctxt.cast() retunrs None anyone | |
| 12:51:56 | bauzas | anyway* | |
| 12:52:20 | sean-k-mooney | yep and the default result fo a fucntion that does not return is None | |
| 12:52:25 | sean-k-mooney | if you assign it to a var | |
| 12:52:33 | sean-k-mooney | so i dont think this changes the interface in any way | |
| 12:52:50 | sean-k-mooney | just being extra carful since its in the rpc api | |
| 12:56:22 | bauzas | sean-k-mooney: proof of evidence https://github.com/openstack/oslo.messaging/blob/f1b47b6ba8ee4888f6cba1efac0fbf747c5406e6/oslo_messaging/rpc/client.py#L476 | |
| 12:56:34 | bauzas | sorry, took me a while, my laptop is burning CPU | |
| 12:58:00 | sean-k-mooney | hehe ya i know it does not have a return | |
| 12:58:38 | sean-k-mooney | the other reason i was +1 and not +2 is the lack of a bug | |
| 12:58:46 | sean-k-mooney | bauzas: so without adding that we cant backport | |
| 12:59:29 | bauzas | sean-k-mooney: mmmm, I'm maybe wrong, but we don't need to file a bug report for backporting to stable branches | |
| 12:59:43 | bauzas | I can verify the stable policy tho | |
| 13:00:03 | sean-k-mooney | i tought that was a requirement but if not i guess its fine | |
| 13:00:10 | sean-k-mooney | this does not really fix anything | |
| 13:00:20 | sean-k-mooney | so its not really something i would backport | |
| 13:00:27 | sean-k-mooney | unless it help with a differnt issue | |
| 13:00:43 | sean-k-mooney | if it did then we would just backport it as part of that other bug fix | |
| 13:00:46 | bauzas | "It’s nevertheless allowed to backport fixes for other bugs if their safety can be easily proved. For example, documentation fixes, debug log message typo corrections, test only changes, patches that enhance test coverage, configuration file content fixes can apply to all supported branches. For those types of backports, stable maintainers will decide on case by case basis." | |
| 13:01:01 | bauzas | https://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes | |
| 13:01:07 | sean-k-mooney | ack | |
| 13:02:19 | sean-k-mooney | ok if your happy with the patch as is i can upgrade to +2 | |
| 13:02:54 | bauzas | sean-k-mooney: I added the github link to oslo.messaging cast() to prove the absence of change | |
| 13:03:02 | bauzas | so you're free to vote | |
| 13:04:07 | bauzas | I'm just adding the stable policy clarification | |
| 13:04:45 | sean-k-mooney | ya i dont think stable policy should be an issue | |
| 13:04:52 | sean-k-mooney | im not expecting use to backport this | |
| 13:05:09 | sean-k-mooney | since it will have no viable impact | |
| 13:05:17 | bauzas | I left a comment for backport reviewers | |
| 13:05:41 | bauzas | the policy says it's up to the stable cores to decide whether this is useful or not | |
| 13:05:51 | bauzas | but nothing prevents it to be proposed | |
| 13:06:15 | sean-k-mooney | sure but i dont think its useful | |
| 13:06:39 | sean-k-mooney | if we want to backport it for a backport of a diffeent patch to avoid a merge conflict | |
| 13:06:43 | sean-k-mooney | then im fine with it | |
| 13:06:51 | sean-k-mooney | but otherwise i would just leave it on master | |
| 18:22:07 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 21:09:41 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 21:20:06 | opendevreview | Merged openstack/nova stable/yoga: Fix typos in help messages https://review.opendev.org/c/openstack/nova/+/846260 | |
| 23:29:34 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Ignore LibvirtConfigObject kwargs https://review.opendev.org/c/openstack/nova/+/830644 | |
| 23:29:35 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Remove unnecessary TODO https://review.opendev.org/c/openstack/nova/+/830645 | |
| 23:29:35 | opendevreview | Rico Lin proposed openstack/nova master: add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | |
| 23:29:36 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 23:29:36 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| #openstack-nova - 2022-07-07 | |||
| 11:12:47 | sean-k-mooney | dansmith: melwitt gibi by they way i just read over the ironic spec again. i think until we get feedback from TheJulia or the ironic core team there is not much more we can do right now | |
| 11:13:20 | sean-k-mooney | well other then plan a ptg session on this or something like that | |
| 11:14:44 | gibi | I agree | |
| 11:25:48 | sean-k-mooney | we might have a gate bug by the way | |
| 11:25:57 | sean-k-mooney | i have seen a lot of failure wiht die 2385 'Neutron did not start' | |
| 11:26:09 | sean-k-mooney | in nova-next | |
| 11:26:27 | sean-k-mooney | and the nova-ovs-hybrid-plug job | |
| 11:27:11 | sean-k-mooney | Jul 06 16:21:46.640517 ubuntu-focal-rax-ord-0030301377 neutron-server[90491]: ERROR neutron.common.experimental [-] Feature 'linuxbridge' is experimental and has to be explicitly enabled in 'cfg.CONF.experimental' | |
| 11:27:50 | sean-k-mooney | ok its because we have linuxbrdge in the default mech drivers in those jobs in addtion to ovs | |
| 11:33:11 | sean-k-mooney | ok i sent a mail to the list please hold of recheks in nova until i fix this | |
| 11:33:45 | sean-k-mooney | ill file a gate bug then fix the job configs and reference the neuton change that broke things in the commit once i find it | |
| 11:43:16 | sean-k-mooney | https://bugs.launchpad.net/os-vif/+bug/1980948 | |
| 11:43:35 | sean-k-mooney | or https://bugs.launchpad.net/nova/+bug/1980948 | |
| 11:43:44 | sean-k-mooney | im going to use the same bug for both and fix both | |
| 11:49:49 | opendevreview | sean mooney proposed openstack/nova master: update nova-next and nova-ovs-hybrid-plug to disable linuxbridge https://review.opendev.org/c/openstack/nova/+/848948 | |
| 11:56:45 | opendevreview | sean mooney proposed openstack/os-vif master: update ci since linuxbridge is now experimental https://review.opendev.org/c/openstack/os-vif/+/848949 | |
| 11:59:38 | sean-k-mooney | ci is still pendign but gibi stephenfin bauzas can you review those | |
| 13:05:47 | gibi | sean-k-mooney: +2 on both thanks for detecting and fixing it | |
| 13:09:44 | sean-k-mooney | gibi: thanks | |
| 13:14:15 | TheJulia | sean-k-mooney: and that requires finding time to do so, unfortunately | |
| 13:37:30 | bauzas | gibi: sean-k-mooney: sorry I got a network issue with my F36 upgrade :( | |
| 13:48:17 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 13:54:23 | gibi | bauzas: ack | |
| 14:36:56 | Uggla | gibi, can you keep some time for me tomorrow morning. I'm blocked with notification. | |
| 14:37:21 | gibi | Uggla: yes, I can. We can have a session. | |
| 14:38:22 | gibi | Uggla: I think I will be available from 10:00 CEST til 17:30 CEST tomorrow | |
| 14:38:32 | Uggla | gibi, great it will be good. | |
| 14:41:59 | Uggla | gibi, are you aware of any specific stuff regarding cells in TestInstanceNotificationSampleWithMultipleCompute ? | |
| 14:42:57 | Uggla | gibi, sorry my bad TestInstanceNotificationSample | |
| 14:46:23 | gibi | Uggla: cells in func test are coming from https://github.com/openstack/nova/blob/512fbdfa9933f2e9b48bcded537ffb394979b24b/nova/test.py#L393-L419 when the compute service is created. As far as I see TestInstanceNotificationSample does not specify any cell so all compute is created in cell1 by default | |
| 14:52:38 | gibi | so if you need computes in different cells then you have to create compute services will cell_name parameter provided | |
| 15:10:21 | opendevreview | Merged openstack/os-vif master: update ci since linuxbridge is now experimental https://review.opendev.org/c/openstack/os-vif/+/848949 | |
| 16:07:33 | sean-k-mooney[m] | my laptop decided to power off | |
| 16:08:31 | sean-k-mooney[m] | im not sure why but im starting it again | |
| 16:16:36 | bauzas | sean-k-mooney1: our laptops are fun | |
| 16:17:08 | bauzas | I have a T14s with 8 CPUs but it's still playing worst than my old 8-year laptop | |
| 17:09:11 | opendevreview | Rajesh Tailor proposed openstack/nova stable/yoga: Remove return from rpc cast https://review.opendev.org/c/openstack/nova/+/848993 | |
| 20:46:57 | opendevreview | Merged openstack/nova master: update nova-next and nova-ovs-hybrid-plug to disable linuxbridge https://review.opendev.org/c/openstack/nova/+/848948 | |
| #openstack-nova - 2022-07-08 | |||
| 04:58:36 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848886 | |
| 07:34:47 | bauzas | good Friday Nova | |
| 08:04:10 | Uggla | bauzas, hello did you upgrade to F36 ? | |
| 08:04:17 | bauzas | yup | |
| 08:04:31 | bauzas | had an issue with my network, but this was on me | |
| 08:05:00 | bauzas | my perf issues with Wayland and any video stream eating all my CPU aren't fixed | |
| 08:05:51 | bauzas | I have to try to see whether I could use hardware acceleration (I have an intel gpu) for those streams | |
| 08:06:01 | bauzas | intel soc I mean | |
| 08:06:53 | Uggla | bauzas, any diff if you use xorg ? | |
| 08:07:06 | bauzas | Uggla: haven't tested yet | |
| 08:07:18 | bauzas | but I need a reproducible test | |
| 08:07:28 | bauzas | I'll use webrtc | |
| 08:07:47 | bauzas | sar gives me a lot of information | |