| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-01 | |||
| 14:02:41 | Uggla | *conditional dictionary comprehension | |
| 14:03:14 | sean-k-mooney | ack you shouldnt worry about asking things like that | |
| 14:03:44 | sean-k-mooney | the channel is for devleopement including expliaing how/why we did things a certen way | |
| 14:04:23 | sean-k-mooney | Uggla: i assume its condtional base in the presence of a tag | |
| 14:04:35 | sean-k-mooney | i have not looked at that in a long time | |
| 14:05:13 | Uggla | sean-k-mooney, I don't worry asking. But I dislike asking things without trying to search on my side first. | |
| 14:05:50 | sean-k-mooney | fair | |
| 14:06:06 | Uggla | sean-k-mooney, fyi tagged_bdms = {_get_device_name(bdm): bdm for bdm in bdms if bdm.tag} in the driver _build_device_metadata method. | |
| 14:06:27 | sean-k-mooney | ah th if bdm.tag | |
| 14:06:31 | sean-k-mooney | ya | |
| 15:24:21 | opendevreview | Merged openstack/nova master: Adds validation for hw machine type in host caps https://review.opendev.org/c/openstack/nova/+/847126 | |
| 18:34:04 | opendevreview | sean mooney proposed openstack/nova master: update default overcommit https://review.opendev.org/c/openstack/nova/+/830829 | |
| 18:51:51 | opendevreview | sean mooney proposed openstack/nova master: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/832330 | |
| 18:51:52 | opendevreview | sean mooney proposed openstack/nova master: [WIP] add sorce dev parsing for vdpa interfaces https://review.opendev.org/c/openstack/nova/+/841016 | |
| 18:51:52 | opendevreview | sean mooney proposed openstack/nova master: [WIP] fix suspend for non hostdev sriov ports https://review.opendev.org/c/openstack/nova/+/841017 | |
| 18:51:53 | opendevreview | sean mooney proposed openstack/nova master: [WIP] Add VDPA support for suspend and livemigrate https://review.opendev.org/c/openstack/nova/+/841012 | |
| 18:55:59 | opendevreview | sean mooney proposed openstack/nova master: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/832330 | |
| 18:55:59 | opendevreview | sean mooney proposed openstack/nova master: [WIP] add sorce dev parsing for vdpa interfaces https://review.opendev.org/c/openstack/nova/+/841016 | |
| 18:56:00 | opendevreview | sean mooney proposed openstack/nova master: [WIP] fix suspend for non hostdev sriov ports https://review.opendev.org/c/openstack/nova/+/841017 | |
| 18:56:00 | opendevreview | sean mooney proposed openstack/nova master: [WIP] Add VDPA support for suspend and livemigrate https://review.opendev.org/c/openstack/nova/+/841012 | |
| #openstack-nova - 2022-07-04 | |||
| 07:31:19 | gibi | o/ | |
| 08:00:02 | bauzas | \o | |
| 09:29:05 | opendevreview | ribaudr proposed openstack/nova-specs master: libvirt: Allow Manila shares to be directly attached to instances https://review.opendev.org/c/openstack/nova-specs/+/833669 | |
| 10:21:52 | ralonsoh | folks, how do I find a new compute node I added with devstack? | |
| 10:22:10 | ralonsoh | "hypervisors list" only returns 1 compute but I have 2 | |
| 10:22:25 | ralonsoh | it was something related to nova cell... but I don't find the command | |
| 10:23:39 | gibi | ralonsoh: nova-manage cell_v2 discover_hosts | |
| 10:23:48 | ralonsoh | gibi, nova-manage cell_v2 discover_hosts | |
| 10:23:49 | gibi | that will add the new compute to cell1 | |
| 10:23:50 | ralonsoh | right! | |
| 10:23:54 | ralonsoh | https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&cad=rja&uact=8&ved=2ahUKEwi3ytaBgt_4AhUHixoKHXrYCe4QFnoECAsQAQ&url=https%3A%2F%2Fstackoverflow.com%2Fquestions%2F72521133%2Fopenstack-additional-compute-node-set-up-questions&usg=AOvVaw2YfAyPGDVFWFjzYaU9eQzO | |
| 10:33:18 | sean-k-mooney | ralonsoh: you could also do the hack we do in ci | |
| 10:33:33 | sean-k-mooney | ralonsoh: we have a periodic task you can turn on that will do that automatically | |
| 10:33:48 | sean-k-mooney | its a hack only in that it does not scale well in production | |
| 10:34:01 | ralonsoh | sean-k-mooney, yeah but this is just for testing (live migraiton) | |
| 10:35:00 | sean-k-mooney | i used to kick off both the contoler and compute at the same time but use a sleep on the compute to get it to complete after nova had started on the contoller | |
| 10:35:26 | sean-k-mooney | no i use ansible playbooks to do a multi node install instead | |
| 10:35:41 | sean-k-mooney | *now | |
| 12:52:55 | opendevreview | Rajesh Tailor proposed openstack/placement master: Fix typo in mapping schema https://review.opendev.org/c/openstack/placement/+/848634 | |
| 13:03:35 | opendevreview | Rajesh Tailor proposed openstack/placement master: Fix typos https://review.opendev.org/c/openstack/placement/+/848636 | |
| 13:25:34 | opendevreview | Vladislav Belogrudov proposed openstack/nova master: Nova instance snapshot should wait for volumes https://review.opendev.org/c/openstack/nova/+/848638 | |
| 13:31:26 | opendevreview | sean mooney proposed openstack/nova master: enable blocked VDPA move operations https://review.opendev.org/c/openstack/nova/+/832330 | |
| 15:42:57 | gibi | bauzas: I re-used https://bugs.launchpad.net/nova/+bug/1960346 to tack the qemu detach fix as a gate-failure bug for nova | |
| 16:16:31 | bauzas | gibi: cool thanks | |
| 16:32:29 | sean-k-mooney | bauzas: gibi by the way this would be nice to merge sooner rather then later https://review.opendev.org/c/openstack/nova/+/830829 | |
| 16:32:49 | sean-k-mooney | its the overcommit default change we defered form m3 last cycle | |
| 16:35:37 | sean-k-mooney | i would like to merge that before m2 if we can | |
| 16:55:58 | gibi | sean-k-mooney: provided feedback now | |
| 17:14:19 | sean-k-mooney | gibi: thanks ill looke at it shortly | |
| 18:08:58 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds check, if admin has set compute service down https://review.opendev.org/c/openstack/nova/+/848660 | |
| #openstack-nova - 2022-07-05 | |||
| 07:10:35 | bauzas | happy spec review day everyone | |
| 07:18:19 | opendevreview | Vladislav Belogrudov proposed openstack/nova master: Nova instance snapshot should wait for volumes https://review.opendev.org/c/openstack/nova/+/848638 | |
| 11:39:51 | bauzas | cores, need a second jab on https://review.opendev.org/c/openstack/nova-specs/+/833669 | |
| 11:48:16 | gibi | bauzas: I've started checking the manila spec | |
| 12:02:13 | sean-k-mooney | ill be switching form downstream stuff to spec review shortly | |
| 12:13:22 | gibi | Uggla, bauzas, sean-k-mooney: I'm OK with the manila spec https://review.opendev.org/c/openstack/nova-specs/+/833669 I hold +A for sean-k-mooney to check it. | |
| 12:13:28 | bauzas | ++ | |
| 12:14:32 | gibi | bauzas: did you managed to add some feedback to the ironic spec? | |
| 12:14:40 | bauzas | gibi: not yet | |
| 12:14:46 | Uggla | gibi, \o/ | |
| 12:14:59 | gibi | i've just started reading it, but I have to jump on a call soon so probably finish it after | |
| 12:15:03 | bauzas | I had to leave it given we have a meeting today and I didn't have time to look at the bugs before | |
| 12:15:13 | gibi | ack | |
| 13:00:43 | opendevreview | Vladislav Belogrudov proposed openstack/nova master: Nova instance snapshot should wait for volumes https://review.opendev.org/c/openstack/nova/+/848638 | |
| 13:20:20 | ozzzo_home_ | We accidentally created a flavor without swap, and we need to add it. What will happen to VMs using that flavor if we delete and re-create the flavor with swap added? Will they still be able to restart, migrate, etc.? | |
| 13:20:36 | ozzzo_home_ | Is changing it in the database a viable alternative? | |
| 13:26:18 | sean-k-mooney | ozzzo_home_: yes they will however they will not have swap | |
| 13:26:36 | sean-k-mooney | the correct thing to do woudl be to create a new flavor | |
| 13:26:42 | sean-k-mooney | resize the existing isntnaces to that | |
| 13:26:46 | sean-k-mooney | and then delete the old flaovr | |
| 13:27:14 | sean-k-mooney | ozzzo_home_: when you boot a vm we copy the current flavor and embed that in the instnace_extra table | |
| 13:27:24 | sean-k-mooney | so that we preserve the state as it was when the vm was booted | |
| 13:27:52 | sean-k-mooney | that is imporant to make sure that chagnes such as adding swap or other changes that affect resouce usage do not propagate to the vm | |
| 13:28:30 | sean-k-mooney | as that woudl potentially violate the current secheduling desicion and woudl invalidate the placment resouce allcoations | |
| 13:31:57 | ozzzo_home_ | in the doc where it says " Nova has historically intentionally not included an API to update a flavor because that would be confusing for instances already created with that flavor. " - confusing means that the placement database would contain incorrect information about existing VMs using that flavor? | |
| 13:33:25 | ozzzo_home_ | the reason we're considering changing it in the database is because we have standard flavor names, and if the flavor names change it would be a huge upheaval for customers who have that name hardcoded into their automation | |
| 13:35:06 | ozzzo_home_ | the client won't let me create a flavor with the same name, so it seems like the alternatives are delete first and then re-create, or else change in the DB | |
| 13:41:45 | bauzas | gibi: I'll need to leave earlier the meeting after 40 mins, could you then please chair it for the last 20 mins ? | |
| 13:42:15 | gibi | sure | |
| 13:42:29 | gibi | but we need you for the centos 9 stream topic | |
| 13:43:41 | sean-k-mooney | ozzzo_home_: placement would have the correct information based on the flaovr that was used at boot | |
| 13:44:02 | sean-k-mooney | ozzzo_home_: if you just update the flavor in the nova db you will make the nova db inconsitnet with the placment db | |
| 13:44:26 | bauzas | gibi: yeah we'll discuss it first | |
| 13:44:47 | gibi | ack | |
| 13:44:50 | sean-k-mooney | ozzzo_home_: nova has no supported mechanium for changing flaovr they are read only | |
| 13:45:05 | sean-k-mooney | ozzzo_home_: so any modifcation you do will be outside the supprot of nova | |
| 13:45:18 | ozzzo_home_ | sean-k-mooney: How can I explain to my co-workers why changing it in the DB is a bad idea? What would be the customer-facing consequences of DB inconsistency? | |
| 13:45:47 | sean-k-mooney | well if you update just the flavor the existing vms would not user any swap | |
| 13:45:51 | sean-k-mooney | but new vms would | |
| 13:46:27 | sean-k-mooney | if you also updated the existing vms embeded flavor copy you woudl break the resouce usage view tracked in palcment | |
| 13:46:43 | sean-k-mooney | which means you could have scheuling issues in the future as you might run out of disk space | |
| 13:46:53 | sean-k-mooney | since the vms will be using more disk for swap | |
| 13:47:19 | sean-k-mooney | if you also fix the placment allcoations then it would work but you have then doen two highly error prone operations on two differnt dbs | |
| 13:47:31 | ozzzo_home_ | What if we delete the flavor first and then create a new one with the same name. Will that cause the same problem? | |
| 13:47:47 | sean-k-mooney | it will have no affect on exsitng vms | |
| 13:48:03 | sean-k-mooney | but new vms will use the new resouces specified in teh flavor | |
| 13:48:06 | sean-k-mooney | if any of your custoemr were using the falvor uuid | |
| 13:48:11 | sean-k-mooney | it will break | |
| 13:48:19 | sean-k-mooney | if they just use the name it would use the new flavor | |
| 13:49:20 | sean-k-mooney | ozzzo_home_: if you updated the flavor in the db and updated the embded flavor in the instnace_extra table and upded the embeded flavor in the request spec then a cold migrate would fix the plamcent allcoaitons | |