| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-22 | |||
| 09:34:34 | sean-k-mooney[m] | and having the api check for the same should be sufficent | |
| 09:35:09 | sean-k-mooney[m] | operators can use traits for the former if they want to enforce that or they can use host aggreates or az to model which host has file backed memory | |
| 09:35:28 | sean-k-mooney[m] | and just tell there users to select that az | |
| 09:35:58 | sean-k-mooney[m] | so i dont think we need to modify the flavor/image for this feature | |
| 09:38:59 | sean-k-mooney[m] | bauzas: gibi https://review.opendev.org/c/openstack/nova/+/847001 now has a functional test and i made the other changes we discussed yesterday too. | |
| 09:40:17 | gibi | sean-k-mooney[m]: it is OK to me not asking for any specific from the user in image/falvor, but checking the prereqs | |
| 09:40:39 | gibi | sean-k-mooney[m]: I will check https://review.opendev.org/c/openstack/nova/+/847001 shortly | |
| 09:41:32 | Uggla | sean-k-mooney[m], maybe I'm missing something. How can you be sure the instance will be started on a host with the proper requirement without flavor/extra spec ? | |
| 09:41:58 | sean-k-mooney[m] | the curret spec if i recall say we will check in the api if the instance has hugepages or is on a host with file backed memory adn reject the request if that is not the case | |
| 09:42:50 | Uggla | yes | |
| 09:42:53 | sean-k-mooney[m] | if the falvor request hugepages it will be on a valid host or if the user select an az that is mapped to file backed memroy | |
| 09:43:11 | sean-k-mooney[m] | so we dont need anythign explict in the flavor for file backed mory | |
| 09:43:22 | sean-k-mooney[m] | we just need to document that requirement | |
| 09:43:32 | sean-k-mooney[m] | they can also add the trait if they like | |
| 09:43:38 | sean-k-mooney[m] | but they dont need too | |
| 09:44:06 | sean-k-mooney[m] | its the same for vhost-user networking with ovs-dpdk | |
| 09:44:24 | sean-k-mooney[m] | we just document that you need file backed memory or hugepages | |
| 09:44:49 | sean-k-mooney[m] | we dont require you to use traits but you could use a cutom trait for that if you wanted too | |
| 09:45:40 | sean-k-mooney[m] | most operators are not going to want to resize all there workload to be able to start using this feature so its imporant that we dont force that when its not required. | |
| 09:45:49 | sean-k-mooney[m] | does that make sense? | |
| 09:49:45 | sean-k-mooney[m] | by the way are we accpeting translations in tree again? | |
| 09:50:58 | sean-k-mooney[m] | i just noticed https://review.opendev.org/c/openstack/nova/+/846876 | |
| 09:51:14 | sean-k-mooney[m] | but i would kind of prefer to not have those in tree | |
| 09:52:18 | Uggla | hum I think so. I'm just wonder how to check for trait at the Rest API level. (atm looking at the code for an example) | |
| 09:52:45 | sean-k-mooney[m] | you can just call placment to do a traits list on the host | |
| 09:53:51 | bauzas | sean-k-mooney: yes | |
| 09:53:56 | bauzas | +2/+Wd for me | |
| 09:53:58 | sean-k-mooney[m] | hum i guess we do get thos octaionally https://github.com/openstack/nova/commits/master/nova/locale | |
| 09:54:27 | gibi | Uggla: nova.scheduler.client.report.SchedulerReportClient.get_provider_traits | |
| 09:55:44 | bauzas | sean-k-mooney: we only had a very few translations patches since 2020 | |
| 09:55:45 | bauzas | https://docs.openstack.org/i18n/latest/reviewing-translation-import.html#reviewing | |
| 09:56:31 | sean-k-mooney[m] | yep thats why i tought we had stop doing this | |
| 09:57:51 | sean-k-mooney[m] | its fine we can proably merge it but if we are not doing a review of the content ectra it would be nicer if we just had this in a sperate repo that the i18n team could mange | |
| 09:58:07 | sean-k-mooney[m] | i guess if its that infrequent its fine | |
| 09:58:47 | sean-k-mooney[m] | if we start getting a lot of patches this way we should look at a different solution then we have currently. | |
| 09:58:49 | bauzas | sean-k-mooney: the problem is with the i18n team | |
| 09:59:00 | bauzas | sean-k-mooney: no, we won't have a lot of patches | |
| 09:59:23 | bauzas | sean-k-mooney: even if they have a lot of i18n contributors, we will only have one change | |
| 09:59:38 | bauzas | as it's an automatic import from Zanata | |
| 09:59:40 | sean-k-mooney[m] | i dont like haveing a seperate review workflow for stuff or not being able to review the change and just merging it | |
| 10:00:15 | sean-k-mooney[m] | so if that the workflwo we are going to have it think it would be better to have it entirly out of tree | |
| 10:00:18 | bauzas | everything is done by https://translate.openstack.org/?dswid=2287 | |
| 10:00:30 | sean-k-mooney[m] | as a stevador plugin for example that is loaded by nova | |
| 10:00:37 | bauzas | sean-k-mooney: we had this workflow since 2013 IIRC | |
| 10:00:46 | bauzas | and it was working | |
| 10:00:57 | bauzas | we only need one single nova-core review | |
| 10:01:33 | sean-k-mooney[m] | sure it works i just dont think its the right way to do things | |
| 10:01:44 | bauzas | https://translate.openstack.org/project/view/nova?dswid=-7176 | |
| 10:02:08 | bauzas | sean-k-mooney: if you have concerns, then you should be discussing with the i18n team, not here | |
| 10:02:24 | Uggla | gibi, thx, I think it is ok. | |
| 10:02:24 | sean-k-mooney[m] | why | |
| 10:02:40 | sean-k-mooney[m] | i can but this is also a project desicion | |
| 10:02:44 | sean-k-mooney[m] | and discussion | |
| 10:03:27 | sean-k-mooney[m] | im wondering if we still want to ship tanslations as a project in tree and if we should change that going forward and remove them form the souce tree | |
| 10:04:23 | bauzas | sean-k-mooney: because it's a TC question https://docs.openstack.org/project-team-guide/i18n.html | |
| 10:04:38 | bauzas | and again, this is simple and it works | |
| 10:04:55 | bauzas | anyway, I merged it | |
| 10:05:10 | bauzas | I could even write some translations from French, if that helps :) | |
| 10:05:44 | bauzas | Only 43% of Nova is translated in French :p | |
| 10:07:10 | sean-k-mooney[m] | if you want too :P | |
| 10:16:11 | gibi | we need more French! | |
| 10:19:20 | opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/846876 | |
| 11:00:55 | mnasiadka | Hello - is there a way to specify Cinder volume-type for boot from volume in flavour extra-specs? | |
| 11:35:09 | gibi | mnasiadka: you have to pre-create the volume in cinder with the desired volume-type and then pass the volume to nova to boot from | |
| 12:04:31 | mnasiadka | gibi: oh ok, thanks | |
| 12:21:45 | bauzas | gibi: Uggla: sean-k-mooney : can we punt our session by 30 mins ? I have something at the moment | |
| 12:22:04 | sean-k-mooney | i wont be able to do it sorry | |
| 12:22:10 | bauzas | ie. 15:00 for CEST and 14:00 for BSR | |
| 12:22:10 | sean-k-mooney | im in a meeting till the top of the hour | |
| 12:22:15 | bauzas | BSTR* | |
| 12:22:19 | bauzas | graaah | |
| 12:22:21 | bauzas | BST* | |
| 12:22:24 | sean-k-mooney | and then i have a dental apointmnt in an hour | |
| 12:22:43 | sean-k-mooney | so it would have to be later today or you and gibi can proceed with Uggla without me | |
| 12:22:43 | bauzas | ok, then let's discuss about Uggla's spec later then | |
| 12:22:51 | gibi | later then | |
| 12:23:07 | gibi | but as far as I see sean-k-mooney stated his oppinion above and I agreed | |
| 12:24:16 | Uggla | bauzas, sean-k-mooney bauzas, I better understand sean-k-mooney proposal that sounds good. | |
| 12:25:31 | bauzas | kk | |
| 12:25:37 | sean-k-mooney | i just pushed my comments on the sepc too | |
| 13:09:46 | Uggla | bauzas, gibi if you can have a look at my latest comments on https://review.opendev.org/c/openstack/nova/+/831507. On 2 points your opinions diverge and I can make both of you pleased at the same time. So I need a consensus between both of you to implement the solution you agree on. | |
| 13:13:50 | bauzas | Uggla: sure, will look | |
| 13:24:26 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds validation for hw machine type in host caps https://review.opendev.org/c/openstack/nova/+/847126 | |
| 13:26:45 | gibi | Uggla: responded, fine with bauzas' suggestions | |
| 13:31:26 | bauzas | gibi: Uggla: replied too | |
| 13:33:25 | bauzas | Uggla: we already this kind of sentinel for example in https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L114 | |
| 13:34:15 | bauzas | that's how we flag an unset param | |
| 13:34:59 | bauzas | this is a simple pattern | |
| 13:38:50 | gibi | I think the special case here is that the caller needs differentiate too if some AZ value is needed to pass forward or the param should not be provided | |
| 13:39:58 | bauzas | gibi: not sure I understand | |
| 13:40:09 | bauzas | gibi: either the AZ is passed or not | |
| 13:40:15 | bauzas | but the value can be None | |
| 13:40:16 | bauzas | right? | |
| 13:40:38 | gibi | by making the new_az optional the caller either needs to pass a value (including None) or not pass the parameter at all | |
| 13:40:58 | gibi | that will be either a conditional on the caller | |
| 13:41:17 | bauzas | https://specs.openstack.org/openstack/nova-specs/specs/zed/approved/unshelve-to-host.html#proposed-change | |
| 13:41:19 | gibi | or the caller could pass the sentinel and avoif the conditional | |
| 13:41:35 | bauzas | ah I see your concern | |
| 13:41:47 | bauzas | well, in general we do this kind of conditional | |
| 13:41:48 | gibi | I'm fine with that extra conditional on the caller side | |