| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-06-21 | |||
| 16:54:06 | elodilles | (i've lost in the links :)) | |
| 16:54:11 | artom | No, stuff like https://review.opendev.org/c/openstack/nova/+/791481/1 | |
| 16:54:14 | artom | For example | |
| 16:54:38 | gibi | elodilles: changes that are not adding a bugfix but refactoring the functional test infrastrucutre | |
| 16:54:49 | gibi | like backporting helpers from newer branches | |
| 16:54:51 | artom | I mean, if https://review.opendev.org/c/openstack/nova/+/751364 is allowed... | |
| 16:54:59 | bauzas | sorry, it took longer than expected :( | |
| 16:55:10 | artom | And https://review.opendev.org/c/openstack/nova/+/751363/3 | |
| 16:55:28 | artom | Honestly, with those last 2, we've set the precedent that func test refactors are fair game | |
| 16:55:46 | sean-k-mooney | artom: wasnt the main issue with the backport you did that you skipped ussui by the way | |
| 16:56:01 | artom | sean-k-mooney, that's a different series, and I fixed that | |
| 16:56:07 | sean-k-mooney | oh ok | |
| 16:56:12 | sean-k-mooney | nevermind then | |
| 16:56:24 | gibi | we are running out of time and still had on point on the agenda | |
| 16:56:39 | elodilles | artom: we did backport simple&small func test refactors in the past | |
| 16:57:33 | elodilles | gibi: if we are waiting for my vote: as i said, i'd prefer not, but not against :) | |
| 16:57:50 | elodilles | so no -2 from me | |
| 16:57:57 | gibi | OK, so if you are not blocking such backport then we are done | |
| 16:58:06 | gibi | artom: anything else? | |
| 16:58:13 | bauzas | so, MHO is that we should be picky if needed | |
| 16:58:33 | elodilles | bauzas: +2 | |
| 16:58:34 | bauzas | anyway, time flies | |
| 16:58:53 | gibi | sure still proper review on those patches but not blanket -2 | |
| 16:59:02 | bauzas | my other point can be deferred to next week | |
| 16:59:02 | artom | gibi, nope, I'm coming away from this with the understanding that func test refactors are fair game if they help make the fixes cleaner and easier to backport (and increase confidence in the reproducer test) | |
| 16:59:10 | gibi | ack | |
| 16:59:21 | gibi | moving on then | |
| 16:59:22 | gibi | (bauzas) Opportunities for low-hanging-fruits, anyone ? (only if we have time left) | |
| 16:59:31 | gibi | 40 secs :) | |
| 16:59:32 | bauzas | no time, let's punt to next week | |
| 16:59:36 | gibi | ack | |
| 16:59:46 | gibi | any last minute issue to raise today? | |
| 16:59:50 | bauzas | tl;dr: think about how to help on-off contributors like interns | |
| 17:00:10 | gibi | #endmeeting | |
| 17:00:10 | opendevmeet | Meeting ended Tue Jun 21 17:00:10 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:00:10 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-06-21-15.59.html | |
| 17:00:10 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-06-21-15.59.txt | |
| 17:00:10 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-06-21-15.59.log.html | |
| 17:00:21 | gibi | thanks folks for joining | |
| 17:00:23 | elodilles | thanks gibi o/ | |
| 17:00:26 | bauzas | thanks a lot gibi for running this one, I owe you some coin | |
| 17:00:37 | gibi | keerthi: sorry for the delay | |
| 17:00:50 | gibi | keerthi: so lets try that now | |
| 17:03:16 | keerthi | thanks sean | |
| 17:03:29 | artom | bauzas, hopefully not bitcoin | |
| 17:03:41 | gibi | nah it is cheap now | |
| 17:03:53 | keerthi | sean, this is the blueprint https://blueprints.launchpad.net/nova/+spec/define-max-volume-limit-at-flavor | |
| 17:03:54 | artom | Cheap, or worthless? :) | |
| 17:03:55 | bauzas | artom: just a nickel | |
| 17:05:12 | opendevreview | Merged openstack/nova master: add repoducer test for bug 1890244 https://review.opendev.org/c/openstack/nova/+/847000 | |
| 17:09:02 | keerthi | sean did you get chance to review the blueprint ? | |
| 17:12:09 | opendevreview | Rajesh Tailor proposed openstack/nova master: Remove unnecessary if condition https://review.opendev.org/c/openstack/nova/+/844418 | |
| 18:14:57 | opendevreview | sean mooney proposed openstack/nova master: ignore deleted server groups in validation https://review.opendev.org/c/openstack/nova/+/847001 | |
| #openstack-nova - 2022-06-22 | |||
| 03:52:50 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/846876 | |
| 06:09:13 | opendevreview | Amit Uniyal proposed openstack/nova master: Added validation for hw machine type in host capabilities https://review.opendev.org/c/openstack/nova/+/847126 | |
| 06:20:26 | opendevreview | Amit Uniyal proposed openstack/nova master: Added validation for hw machine type in host capabilities https://review.opendev.org/c/openstack/nova/+/847126 | |
| 07:03:28 | bauzas | good morning Nova | |
| 07:06:41 | gibi | bauzas: o/ | |
| 07:06:58 | bauzas | gibi: thanks for having written the email about the PCI series | |
| 07:07:05 | bauzas | gibi: today is review day for me | |
| 07:07:26 | gibi | bauzas: I felt I needed to give some guide to encourage reviewers | |
| 07:10:00 | bauzas | :) | |
| 07:10:16 | bauzas | I guess we will be only a few of them | |
| 07:10:32 | gibi | bauzas: I have to respin the series due to a doc issue | |
| 07:10:49 | gibi | just I want to finish the downstream backport review first | |
| 07:10:51 | bauzas | gibi: ok, no worries, I'll start with Uggla series | |
| 07:11:06 | bauzas | after a coffee... | |
| 07:11:35 | gibi | sure | |
| 08:37:56 | bauzas | Uggla: voted on https://review.opendev.org/c/openstack/nova/+/831507/14 | |
| 08:38:25 | bauzas | Uggla: tl;dr: yeah IMHO you could squash your patch with gibi's one but I'd also want you to modify how you use the sentinel | |
| 08:40:16 | Uggla | bauzas, ok I'm going to have a look and propose an updated version ASAP. | |
| 08:40:23 | bauzas | Uggla: thanks | |
| 08:40:41 | bauzas | with gibi's patch and just the thing I ask you, I don't think this is massive change | |
| 08:40:56 | bauzas | Uggla: one thing I also wrote, please bear with logs | |
| 08:41:27 | bauzas | Uggla: the point is, logs are very well appreciated, but large public clouds tend to disagree with us adding more logs :) | |
| 08:42:01 | bauzas | in particular when you can get information from other services, like scheduler | |
| 08:42:18 | Uggla | bauzas, oh ok. | |
| 08:42:34 | bauzas | no worries, this is something not largely known | |
| 08:42:53 | bauzas | but yeah, logs rotation are costly for them | |
| 08:43:13 | bauzas | DEBUG level is a bit different tho | |
| 08:43:23 | bauzas | but with INFO, we need to be cautious | |
| 08:43:56 | bauzas | I'll then switch to your Manila spec | |
| 08:44:16 | bauzas | the sooner we have it, the earlier we could merge the os-traits change | |
| 08:46:59 | Uggla | bauzas, anyway thx for the review | |
| 08:47:12 | bauzas | np pb, apologies this was that late | |
| 08:47:42 | bauzas | Uggla: I briefly reviewed your REST change, nothing controversial appeared | |
| 08:47:48 | bauzas | but I didn't vote | |
| 08:48:51 | Uggla | bauzas, regarding the manila one, Goutham sent comments yesterday. | |
| 08:49:18 | bauzas | nice | |
| 08:51:07 | Uggla | bauzas, remaining blocking point is the "extra spec / trait" if we want to have this explicit or not. I would rather explicit one. But we need a consensus here. | |
| 08:51:59 | Uggla | I would like to discuss this point with bauzas, gibi, sean-k-mooney. | |
| 08:52:30 | gibi | I'm around | |
| 08:53:16 | Uggla | gibi, o/ | |
| 08:54:28 | gibi | o/ | |
| 08:58:29 | bauzas | Uggla: gibi: give me 30 mins so I can recharge the context by reviewing the spec :) | |
| 08:58:52 | gibi | bauzas, Uggla: do we want to wait for sean-k-mooney too? | |
| 08:59:18 | bauzas | gibi: probably, again I need to review the spec | |
| 08:59:31 | gibi | sure go ahead an review | |
| 08:59:31 | Uggla | gibi, if possible yes. | |
| 09:00:21 | bauzas | gibi: Uggla: we could do some session by 14:30 our time if needed | |