Earlier  
Posted Nick Remark
#openstack-nova - 2022-06-13
13:17:38 bauzas gibi: yup
13:18:15 bauzas gibi: yeah, I provided all my receipts to concur thanks to the android app when waiting for my flight :)
13:18:31 bauzas gibi: but eventually I got some problem with a meal and for my hotel expense
13:19:03 sean-k-mooney bauzas: not to add to your paper work but are you plannign to send a writeup or operator feedback to the list or similar
13:19:06 bauzas but eventually, today I used the webapp and I was able to modify the expenses correctly
13:19:43 bauzas sean-k-mooney: we'll be discussing this tomorrow during the meeting and after that, I'll provide a feedback to the list
13:19:49 sean-k-mooney ack
13:19:59 bauzas sean-k-mooney: but most of the operators told they don't want to have a lot of emails from us
13:20:11 sean-k-mooney while you were away there was a request to do a release of stable yoga and xena by the way
13:20:17 sean-k-mooney i was going to bring that up in the meeting
13:20:23 bauzas sean-k-mooney: oh ok
13:20:31 sean-k-mooney i have not looked at whats pending but we have not done a release of yoga yet
13:20:52 sean-k-mooney so there proably are some valid bugfixes that would be good to release
13:22:28 sean-k-mooney bauzas: i asked mainly for people outside of redhat i was going to ask you about your feedback in our downstream meeting but if were planing to send somethign to the list anyway i was happy enough to just read that
13:23:17 bauzas sean-k-mooney: yeah I understand it about the feedback
13:23:41 bauzas like I said, I'd first discuss with our folks tomorrow before replying
13:24:05 sean-k-mooney no worries. did you enjoy the conference
13:24:17 bauzas sean-k-mooney: we had a problem with the etherpad, it became chinese but eventually thanks to fungi it was fixed
13:24:37 sean-k-mooney ah did we forget to add teh disclaminer at the top
13:24:48 bauzas sean-k-mooney: I actually prefered to discuss with the operators on hallways
13:25:02 fungi there was a disclaimer at the top, it was just ignored apparently
13:25:21 bauzas sean-k-mooney: we had the same issue with the ptg one, which had the disclaimer
13:25:24 sean-k-mooney fungi:ack it happens thanks for helping to fix it
13:25:28 fungi np
13:26:10 sean-k-mooney bauzas: ya when we are done with the ptg we shoudl share/archive the readonly link
13:26:33 fungi highly recommended
13:26:55 bauzas sean-k-mooney: if you see my feedback email from the ptg, I was providing the readonly link
13:27:08 sean-k-mooney ack
13:27:17 bauzas but if someone finds the writable one, then...
13:27:48 sean-k-mooney ya you can alway go back in the timeline and find the orginal content but thats hassel
13:28:02 bauzas I think the ptg one was changed because I provided a link to the writable etherpad in the session etherpad too
13:28:02 sean-k-mooney look liek we are starting to see videos form the summit
13:28:06 gibi at some point I was wondering how hard it would be to detect the translator from the etherpad software and bring up a warning
13:28:43 sean-k-mooney i would guess its clientside
13:28:52 sean-k-mooney so proably not trivial
13:28:57 bauzas so, if someone was looking at the operator session etherpad with a chinese translation app and if she/he was clicking the ptg etherpad from it...
13:29:09 gibi sean-k-mooney: yeah it would need some js magic
13:29:12 bauzas but that's a guess
13:29:29 sean-k-mooney bauzas: or right ya crosslinking would cause issues
13:29:50 sean-k-mooney its too bad there isnt a settign to mark teh main one readonly when we are done
13:29:55 sean-k-mooney i.e. to lock it
13:30:18 bauzas yeah
13:30:26 sean-k-mooney still i like the flexiblity that etherpad has so im still happy we have it
13:30:54 sean-k-mooney well the simplicty and the autour color trackign more then flexiblity
13:35:25 fungi etherpad has a pluggable extension architecture, so maybe there's a plugin opendev could add for it to provide that feature (or maybe someone who likes js could write one)
13:36:24 fungi we try to stay current with upstream releases, making it easy to develop against their master branch and latest api
13:39:58 sean-k-mooney i dont see one that jumps out at me on https://static.etherpad.org/index.html but ya maybe
13:41:25 bauzas ideally a click button to lock/unlock would suffice
13:41:35 fungi agreed
13:41:47 bauzas but... I wrote JS a while ago
13:41:56 sean-k-mooney oh https://www.npmjs.com/package/ep_disable_reset_authorship_colours
13:41:59 sean-k-mooney we should add that one
13:42:58 fungi has clearing the authorship colors been a problem for folks? i tend to use that a lot when i'm writing some large bit of prose and want only subsequent edits highlighted
13:43:10 sean-k-mooney fungi: just the keybinding
13:43:17 fungi ahh, okay
13:43:23 sean-k-mooney i think its ctrl shift c
13:43:28 fungi what i end up seeing as more of a problem is when someone accidentally deletes everything and then pastes it back in
13:43:33 sean-k-mooney so doign it by mistack when copy pasting
13:43:57 fungi interesting, i didn't even realize there was a keybind for that, but i agree that sounds like a trap
13:44:30 sean-k-mooney yep we add that to the header now too since i did it by mistake when i tought i had selected my terminial but had not
13:44:44 sean-k-mooney so just disbaleing that one keybind would be nice
13:45:04 sean-k-mooney we can keep the feature but the keybind is not a good default
13:45:33 fungi if you want to propose that addition, you can push a change for our image builds here: https://opendev.org/opendev/system-config/src/branch/master/docker/etherpad/Dockerfile#L33
13:45:43 fungi looks like it's already in the commented-out example even?
13:46:55 sean-k-mooney im not sure if that plugin disables it outright or just the keybind or if its configurable
13:47:00 sean-k-mooney just llook at the source now
13:47:50 sean-k-mooney https://github.com/ether/ep_disable_reset_authorship_colours/blob/main/static/js/disable_reset_authorship_colours.js looks like its just hiding the button
13:47:55 sean-k-mooney so that wont actully help
13:48:45 sean-k-mooney but ya good to know we can look into it sometime
15:14:16 opendevreview Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627
15:19:26 bauzas gibi: sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/829248 got a second +2 with comments
15:19:33 bauzas nothing urgent to read, just left some notes
15:19:49 bauzas honestly, this was hard to review in terms of testing modifications
15:20:01 bauzas the patch in question is simple, but the impact is larged
15:20:03 bauzas large
15:20:11 bauzas but I trust you both
15:21:40 sean-k-mooney ack ill read over them after our downstream call
15:21:54 bauzas those are mostly bikeshed comments
15:22:07 bauzas not requiring a rebased
15:52:04 gibi bauzas: I read through your comments. I replied to them. I don't think anything needs to be changed with the patch per se. If you insist on some of the comments the please do and I will push a follow up patch
15:52:31 bauzas gibi: cool, wasn't an ask
15:52:41 gibi coolio
15:52:44 gibi thanks for the review
15:52:58 bauzas I'll click the submit button
15:53:50 gibi thanks
16:06:35 bauzas sent to the gate
16:09:25 gibi \o/
16:12:15 opendevreview Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627
17:04:02 opendevreview Artom Lifshitz proposed openstack/nova master: libvirt: remove default cputune shares value https://review.opendev.org/c/openstack/nova/+/824048
17:04:08 artom sean-k-mooney, ^^
17:25:16 opendevreview Merged openstack/nova master: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/829248
17:37:01 sean-k-mooney artom: comments inline
17:37:57 artom sean-k-mooney, fair point on the partial
17:50:49 sean-k-mooney i think im ok with the patch over all but i want to see the ci result to see if libvirt is ok with the empty cputune element
17:51:35 sean-k-mooney i woudl prefer if we did not set it if it had not atributes or child elements but if libvirt does not care then we proably could proceed as you currently have it
17:51:57 sean-k-mooney i would like to look at the other quotas however and see if there are other we set by defualt like this
17:52:04 sean-k-mooney i dont think we do but we shoudl check
17:52:43 artom Yeah, I didn't check with a real libvirt for an empty cputune
17:53:51 sean-k-mooney ok ill check back on the zuul resulst tomorrow o/
18:06:18 elodilles erlon bauzas : we can discuss on tomorrow's nova meeting if we want to wait for any patch or can release these >>> https://review.opendev.org/q/project:openstack/releases+is:open+intopic:nova

Earlier   Later