| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-31 | |||
| 14:21:39 | kashyap | I don't know what is "black" here. Maybe I'm being too dense | |
| 14:21:47 | bauzas | kashyap: https://pypi.org/project/black/ | |
| 14:22:02 | kashyap | Ah, it's a tool! | |
| 14:22:06 | kashyap | Thanks | |
| 14:23:34 | bauzas | kashyap: and there is blue, a fork of black https://pypi.org/project/blue/ | |
| 14:23:57 | bauzas | see, we diverted from a very interesting ping from dansmith | |
| 14:24:01 | kashyap | bauzas: Yeah, I recall seeing that in passing; th | |
| 14:24:01 | dansmith | black's coding style is so ugly | |
| 14:24:05 | kashyap | s/th/thx/ | |
| 14:24:09 | bauzas | dansmith: stay, please | |
| 14:24:26 | bauzas | I need to convince a few people here | |
| 14:25:29 | bauzas | dansmith: do you remember if we discuss the file-backed memory case in a meeting or somewhere else ? | |
| 14:25:51 | dansmith | bauzas: it was downstream in a meeting I think, I don't remember the context | |
| 14:25:57 | bauzas | hah | |
| 14:26:23 | bauzas | well, I'd say this is just a libvirt knob | |
| 14:26:34 | bauzas | so, to answer your question, worth merging yeah | |
| 14:26:39 | dansmith | aight | |
| 14:27:09 | dansmith | presumably we need a test case that uses/enables it | |
| 14:27:14 | bauzas | I like the 'you can't overcommit memory if you file-back your memory" ting | |
| 14:27:16 | dansmith | which probably existed as a depends-on to this somewhere | |
| 14:29:08 | bauzas | yeah, this is a very old patch | |
| 14:29:41 | bauzas | damn, needs to run, forgot my kid | |
| 14:33:20 | sean-k-mooney | dansmith: sorry in a meeting | |
| 14:34:15 | sean-k-mooney | dansmith: you were askign about file backed memory | |
| 14:34:29 | sean-k-mooney | dansmith: we have some support | |
| 14:34:51 | sean-k-mooney | dansmith: we dont support live migration between file backed and non file backed ectra | |
| 14:35:03 | dansmith | sean-k-mooney: I know, I worked on the support in nova with the original author :) | |
| 14:35:05 | sean-k-mooney | was there a specific question you had | |
| 14:35:16 | dansmith | sean-k-mooney: I also wrote this devstack support for him to finish, but that never happened | |
| 14:35:29 | sean-k-mooney | dansmith: no devstack support is required | |
| 14:35:29 | dansmith | so I'm wondering if I should abandon or finish this patch | |
| 14:35:46 | sean-k-mooney | dansmith: i manullay tested it when it was beeing merged :) | |
| 14:35:59 | sean-k-mooney | dansmith: the docs are curently wrong about needignto create a partion | |
| 14:36:22 | dansmith | sean-k-mooney: um | |
| 14:36:34 | dansmith | we have a conf flag for it, no? | |
| 14:36:46 | sean-k-mooney | yes | |
| 14:37:06 | sean-k-mooney | but you can set that with [[post-conf| $NOVA_CPU_CONF]] | |
| 14:37:08 | dansmith | ... | |
| 14:37:19 | sean-k-mooney | its what i have done every time i used that | |
| 14:37:26 | dansmith | sure, but also we need to enable it in libvirtd? or did at the time | |
| 14:37:28 | sean-k-mooney | and we dont want to mount the file backed memory on tempfs | |
| 14:37:32 | sean-k-mooney | no | |
| 14:37:37 | sean-k-mooney | you dont need to enable anything in libvirt | |
| 14:38:13 | dansmith | to what, end up with memory file-backed on your root disk? | |
| 14:38:35 | sean-k-mooney | yes that is how its ment to be used | |
| 14:38:43 | sean-k-mooney | the file is cached in ram using the hosts page cache | |
| 14:38:51 | dansmith | no, it's not.. or not how this feature was intended | |
| 14:39:01 | dansmith | the original author had a box that looked like a memory-backed filesystem over IB fabric or whatever, so they needed to configure libvirt to use that mount for the memory | |
| 14:39:28 | dansmith | so part of this was so they could actually configure a devstack to do that, and not stack, then configure and restart libvirt | |
| 14:39:28 | sean-k-mooney | dansmith: i was also raisign adding supprot for this for dpdk before that autro got there feature merged | |
| 14:40:00 | sean-k-mooney | dansmith: to be clear i brought up supporting filebacked memroy for dpdk and it was rejected | |
| 14:40:11 | sean-k-mooney | then later tehy brought it up for a security usecse and it was accpeted | |
| 14:40:19 | sean-k-mooney | file backed memmroy can use a file on disk | |
| 14:40:31 | sean-k-mooney | you dont need to do any config in libvirt | |
| 14:41:01 | dansmith | I understand you *can* but I'm not sure why you would, unless you have something very fast that looks like a disk, but isn't, in which case you'd need to tell libvirt where to put it specifically | |
| 14:41:18 | sean-k-mooney | dansmith: so that you can have more "ram" the system ram | |
| 14:41:24 | dansmith | but whatever, sounds like you think I should not finish this because we don't need it for CI testing specifically | |
| 14:41:45 | sean-k-mooney | i also dont think you shoudl deploy it in production on temfs | |
| 14:41:51 | dansmith | sean-k-mooney: right but "more ram a the speed of a disk" is not very useful | |
| 14:42:14 | sean-k-mooney | if your disk are fast optane ssd it is | |
| 14:42:14 | dansmith | the tempfs was so that it didn't generate IO in the workers | |
| 14:42:44 | sean-k-mooney | and as i said the host page cache also acclerates recently acccess part of the files | |
| 14:43:46 | sean-k-mooney | dansmith: are you working on addign file backed memory testing to ci by the way | |
| 14:43:54 | sean-k-mooney | or were you just automating it in devstack for local use | |
| 14:43:58 | dansmith | I'm not doing anything | |
| 14:44:20 | sean-k-mooney | oh i was confused by https://review.opendev.org/c/openstack/devstack/+/574792 but i guess matt was the last uploader | |
| 14:44:53 | sean-k-mooney | an it was revived 3 days ago | |
| 14:45:29 | sean-k-mooney | dansmith: sorry i was trying to figure out teh context of this | |
| 14:52:49 | artom | How to break git blame 101. | |
| 14:53:28 | dansmith | I'm also not in favor of reformatting more code than is necessary during a change, because that also make history look like more was changed | |
| 14:53:50 | artom | In fact, that argument would prevent us from ever switching to an automatic formatter, unless it can be smart enough to only touch code that's already being changed in a commit. | |
| 14:58:33 | opendevreview | Merged openstack/placement stable/victoria: Use 'functional-without-sample-db-tests' tox env for placement nova job https://review.opendev.org/c/openstack/placement/+/840767 | |
| 15:08:01 | bauzas | dansmith: artom: sean-k-mooney: as I said, we can create a consensus in the documentation for explaining we should not have a specific styling guideline more than using https://github.com/openstack/nova/blob/master/nova/hacking/checks.py | |
| 15:08:33 | bauzas | so, we wouldn't need to have the black formatter | |
| 15:09:01 | bauzas | that said, | |
| 15:09:10 | bauzas | nova meeting in 50 mins now here | |
| 15:11:35 | sean-k-mooney | bauzas: sure but i think that is a wrong thing fore the heal of the project longterm | |
| 15:24:22 | elodilles | bauzas: may i update the wiki (stable section)? or do you want to do it by yourself? | |
| 15:37:53 | bauzas | elodilles: feel free to do it, I'm done | |
| 15:38:58 | elodilles | bauzas: ack | |
| 15:40:33 | elodilles | done | |
| 15:41:33 | opendevreview | Merged openstack/os-vif master: Delete trunk bridges to avoid race with Neutron https://review.opendev.org/c/openstack/os-vif/+/841499 | |
| 15:47:13 | bauzas | reminder: nova meeting in 13 min here. | |
| 16:00:35 | opendevmeet | Meeting started Tue May 31 16:00:35 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:35 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:35 | bauzas | #startmeeting nova | |
| 16:00:35 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:40 | bauzas | EHLO | |
| 16:00:53 | elodilles | o/ | |
| 16:00:56 | Uggla | qo/ | |
| 16:01:03 | gmann | o/ | |
| 16:01:45 | bauzas | not sure if gibi is around, but let's start to discuss (he told me he couldn't be in our meeting) | |
| 16:02:59 | bauzas | #topic Bugs (stuck/critical) | |
| 16:03:04 | bauzas | #info No Critical bug | |
| 16:03:09 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 14 new untriaged bugs (-1 since the last meeting) | |
| 16:03:12 | bauzas | thanks elodilles :) | |
| 16:03:18 | bauzas | #link https://storyboard.openstack.org/#!/project/openstack/placement 26 open stories (0 since the last meeting) in Storyboard for Placement | |
| 16:03:18 | elodilles | o:) | |
| 16:03:26 | bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:03:36 | bauzas | elodilles: do you want to discuss about some bug ? | |