| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-26 | |||
| 11:47:22 | kevko | hmm | |
| 11:47:23 | kevko | understand | |
| 11:47:43 | sean-k-mooney | you coudl do that with metadata on host aggrats and then a weigher or filter that used that datacenter metadata | |
| 11:49:02 | sean-k-mooney | so 1 AZ that spans both datacheners 1 host aggreate per datacenter and a filter/weigher that used a datacenter tag on the host aggreate + server group infor to implment antiafinity | |
| 11:49:36 | sean-k-mooney | but its much simpelr to have 1 AZ per datacenter and have octaivr just schdule differnt loadbanceer to differnt AZs | |
| 11:49:59 | kevko | and this is not possible :/ | |
| 11:50:00 | sean-k-mooney | its cleaner form an api level and more efficnt form a schdulign perspecitve | |
| 11:50:08 | kevko | because octavia has only one AZ to configure | |
| 11:50:19 | sean-k-mooney | right you woudl have to change octavia | |
| 11:50:39 | sean-k-mooney | so im suggestign you make a featur equest to octavia instead of nova | |
| 11:50:47 | kevko | yeah | |
| 11:50:52 | kevko | thank you ! | |
| 11:50:58 | kevko | you are always replying ;-) | |
| 11:52:01 | sean-k-mooney | perhaps i reply too much on ocation | |
| 11:52:35 | sean-k-mooney | but when people have ligtimate usecase i try to help them find a solution | |
| 11:52:48 | sean-k-mooney | you do i just dont think the clean solution is in nova | |
| 11:53:29 | sean-k-mooney | for older release you coud do this as i descibe with an out of tree weigher/filter if you have 1 AZ and multiple host aggreates but thats messy for a number of reasons | |
| 11:56:11 | kevko | still thank you | |
| 12:16:34 | opendevreview | Miguel proposed openstack/nova master: Pin autopep8 to 1.5.5 in tox https://review.opendev.org/c/openstack/nova/+/843443 | |
| 12:26:40 | kevko | sean-k-mooney last question : Can i import octaviaclient in my own custom nova filter ? :P | |
| 12:26:58 | sean-k-mooney | its your filter so :) | |
| 12:27:08 | sean-k-mooney | upstrem no | |
| 12:27:29 | sean-k-mooney | filters are not ment to make any db or api calls in general | |
| 12:27:49 | sean-k-mooney | filters run per host so we really dont want to do that on large clouds | |
| 12:28:32 | kevko | hmm, ok | |
| 12:28:53 | kevko | can I write filter which will check security group assigned ? | |
| 12:29:18 | sean-k-mooney | security groups? or server groups | |
| 12:31:28 | kevko | both :D | |
| 12:32:16 | kevko | i mean, if it is possible to check server groups it will be better, if no .. security group is same also | |
| 12:32:58 | sean-k-mooney | for server groups you can use the existin filter as a refernce | |
| 12:33:00 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/affinity_filter.py#L82-L165= | |
| 12:33:09 | sean-k-mooney | but you cant add new policies | |
| 12:33:34 | sean-k-mooney | so you cant jsut add an AZ-anti-affinity policy | |
| 12:34:48 | sean-k-mooney | kevko: we dont have any example of the security gorups but if its in teh request spec then yes | |
| 12:35:15 | kevko | i will have to try | |
| 12:35:33 | sean-k-mooney | kevko: filters are passed 2 objects the hoststate object and a request spec object | |
| 12:35:35 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L42= | |
| 12:35:51 | sean-k-mooney | kevko: which has security groups https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L98= | |
| 12:36:00 | sean-k-mooney | but only the security groups used for nova created ports | |
| 12:36:22 | kevko | but no server group :/ | |
| 12:36:22 | sean-k-mooney | it will not have the security groups of neutron ports that are passed in as uuids | |
| 12:37:19 | sean-k-mooney | kevko: its called instance_group i think https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L91= | |
| 12:37:43 | kevko | yeah, i just saw it | |
| 12:40:00 | sean-k-mooney | the network request whil it has the port uuid https://github.com/openstack/nova/blob/e44b1a940fdc45cc9dbb08e193a8c25052cf64e7/nova/objects/network_request.py#L39= does not have any port secuirty groups | |
| 13:21:36 | sean-k-mooney | gibi: stephenfin hopefully a quick one https://review.opendev.org/c/openstack/os-vif/+/843432 | |
| 13:21:47 | sean-k-mooney | just changing the template to zed since the py36 job is failing | |
| 13:24:30 | gibi | sean-k-mooney: do you want to drop 3.6 support from the setup.cfg at the same time as we stop testing with 3.6? | |
| 13:24:48 | sean-k-mooney | oh ya i can do that | |
| 13:25:17 | sean-k-mooney | should i add a release note then too | |
| 13:26:19 | gibi | yepp that a reno would make sense | |
| 13:26:34 | sean-k-mooney | ok ill do that now | |
| 13:40:22 | stephenfin | sean-k-mooney: replied | |
| 13:40:27 | opendevreview | sean mooney proposed openstack/os-vif master: update job template to zed https://review.opendev.org/c/openstack/os-vif/+/843432 | |
| 13:40:37 | sean-k-mooney | stephenfin: hehe well ^ is an updated version | |
| 13:41:02 | sean-k-mooney | stephenfin: no we are not release independent | |
| 13:41:21 | sean-k-mooney | i raised at the ptg and we said no keep it as release-with-intermidary | |
| 13:41:27 | sean-k-mooney | so we shoudl not use the unversioned one | |
| 13:41:39 | sean-k-mooney | if we want to make it release independent then sure | |
| 13:43:58 | opendevreview | sean mooney proposed openstack/os-vif master: update job template to zed https://review.opendev.org/c/openstack/os-vif/+/843432 | |
| 13:44:04 | sean-k-mooney | actully some typos fixed ^ | |
| 13:44:20 | sean-k-mooney | ill leave it for now for ye to review but if you want me to change anything i can | |
| 13:44:49 | sean-k-mooney | stephenfin: by the way your dont happen to be a bindep core? | |
| 13:45:15 | gibi | sean-k-mooney: so we say py 3.10 is supported, which probably works, but I'm not sure the overall Zed release will go out with py3.10 supportr | |
| 13:45:41 | sean-k-mooney | gibi: debain and ubuntu ship yoga on 3.10 | |
| 13:46:05 | sean-k-mooney | so zed will be released on at least 3.10 by them | |
| 13:46:27 | sean-k-mooney | its technially not in the testing runtimes but we have tests using it so i think it will be fine | |
| 13:46:27 | gibi | yeah, hence my statement that it probably works without problem | |
| 13:46:43 | gibi | OK, I'm convinced +@ | |
| 13:46:44 | gibi | +2 | |
| 13:46:53 | sean-k-mooney | i can drop that from the list if you like untile we have a 22.04 based job | |
| 13:47:01 | sean-k-mooney | but i could also do that as a follow up | |
| 13:47:16 | sean-k-mooney | i.e. add a 22.04 job | |
| 13:47:18 | gibi | no, it is OK, we run py3.10 on os-vif so we know it works | |
| 13:47:27 | sean-k-mooney | cool | |
| 13:49:21 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: DNM: Testing live migration with local attach https://review.opendev.org/c/openstack/nova/+/843146 | |
| 14:50:17 | opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: Reproduce live migration rollback w/o multi port bindings error https://review.opendev.org/c/openstack/nova/+/843336 | |
| 14:50:18 | opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: Fix LM rollback w/o multi port bindings extension https://review.opendev.org/c/openstack/nova/+/843337 | |
| 14:58:23 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Reproduce live migration rollback w/o multi port bindings error https://review.opendev.org/c/openstack/nova/+/843338 | |
| 14:58:24 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Fix LM rollback w/o multi port bindings extension https://review.opendev.org/c/openstack/nova/+/843339 | |
| 15:34:59 | kashyap | gibi: Hey, before I go out on PTO I can't get this to completion this week :-( - https://review.opendev.org/q/topic:bp%252Fcpu-selection-with-hypervisor-consideration | |
| 15:35:53 | gibi | kashyap: is there anything I can help with there? | |
| 15:36:56 | kashyap | gibi: Stephen has a bunch of valid comments; need to address those and get it in. | |
| 15:37:05 | gibi | ack | |
| 15:38:29 | kashyap | gibi: Also, one more is the separate config class to parse the "cpu" bit from `virsh domcapabilitles` | |
| 15:38:53 | gibi | yeah I remember | |
| 15:38:57 | gibi | that | |
| 15:39:14 | kashyap | Also have to address your own good comments on this patch: https://review.opendev.org/c/openstack/nova/+/762330 | |
| 15:40:40 | kashyap | gibi: Ah, forgot that I already have the patch here for: https://review.opendev.org/c/openstack/nova/+/838191 (libvirt/config: Parse the 'cpu' element in domainCapabilities) | |
| 15:40:45 | kashyap | (Modulo test) | |
| 15:41:27 | gibi | yeah only test needed | |
| 15:41:44 | kashyap | Actually, no that's not it...it's not adding a separate config class there | |
| 15:42:34 | kashyap | gibi: From IRC log | |
| 15:42:46 | kashyap | (Of this channel): | |
| 15:42:47 | kashyap | 17:13 < kashyap> gibi: To tie up the lose end on caps vs domCaps -- the guidance from the libvirt folks is (a) no, we can't treat the caps == domCaps w/ 'host-model' mode; and (b) we should use domCaps wherever possible. | |
| 15:42:51 | kashyap | 17:13 < kashyap> gibi: So that means, we should introduce a new config object | |
| 15:42:54 | kashyap | 17:13 < gibi> kashyap: ack, make sense | |
| 15:43:19 | gibi | hehh, I'm just following you guid here :) | |
| 15:43:30 | kashyap | So, to sum up: | |
| 15:44:14 | kashyap | (1) address your + Stephen's comments; (2) add the separate config object class to parse "cpu" element from domCaps, and work that in "properly" | |
| 15:44:45 | kashyap | I could definitely use some help, if you have some time for this! I keep duking around this and never quite managing it fully | |