| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-19 | |||
| 14:01:28 | bauzas | and return synchronously a "sorry dude" | |
| 14:01:51 | bauzas | instead of trying to manage a late persistence or a rollback of the reqspec | |
| 14:02:51 | Uggla | agree, it sounds simpler. | |
| 14:03:27 | bauzas | and this is synchronous | |
| 14:04:26 | sean-k-mooney | bauzas: ok but we still need to handel rollback of the request spec if we fail to unshleve for any reason | |
| 14:04:53 | bauzas | sean-k-mooney: agreed | |
| 14:05:07 | bauzas | which wasn't the case now, right? | |
| 14:05:35 | sean-k-mooney | well i have not looked at he code to check | |
| 14:05:38 | bauzas | I see the .save() call, but I don't see the conductor managing the exception | |
| 14:05:45 | sean-k-mooney | do you have a link | |
| 14:05:57 | bauzas | yup, sec | |
| 14:06:04 | bauzas | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4470 | |
| 14:06:10 | sean-k-mooney | i guess we can also just document that the request spec will always be updted | |
| 14:06:18 | bauzas | sec, better with a permalink | |
| 14:06:19 | bauzas | https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/compute/api.py#L4470 | |
| 14:06:21 | sean-k-mooney | i just generally effect failed operation to not change things | |
| 14:07:02 | sean-k-mooney | ya so right now it changing it uncondtionaly | |
| 14:07:05 | sean-k-mooney | i guess that fine | |
| 14:07:13 | sean-k-mooney | its also doing the validation now | |
| 14:07:17 | bauzas | https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/conductor/manager.py#L1040-L1045 | |
| 14:07:18 | sean-k-mooney | https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/compute/api.py#L4454= | |
| 14:07:20 | sean-k-mooney | in the api | |
| 14:07:34 | bauzas | the conductor is not handling the AZ case on the NoValidHost case | |
| 14:07:58 | sean-k-mooney | ya | |
| 14:07:59 | bauzas | so, now, if you unshelve to another AZ, and you fail, your instance gets pinned in the new AZ | |
| 14:08:07 | sean-k-mooney | yep | |
| 14:08:09 | bauzas | still shelved but pinned | |
| 14:08:25 | sean-k-mooney | so we either maintain that behavior | |
| 14:08:32 | sean-k-mooney | or we treat it as a bug | |
| 14:08:38 | sean-k-mooney | and fix that spereatly | |
| 14:08:53 | bauzas | good point | |
| 14:08:56 | bauzas | this is a bug | |
| 14:09:06 | sean-k-mooney | ok then we dont need to cover it in the spec | |
| 14:09:13 | bauzas | fixing it now would benefit to the unshelve to host implementation | |
| 14:09:23 | bauzas | but wait | |
| 14:09:30 | bauzas | the rollback isn't trivial | |
| 14:09:46 | bauzas | what field should we set if we rollback ? | |
| 14:09:59 | opendevreview | Merged openstack/nova-specs master: Proposes to remove keypair generation https://review.opendev.org/c/openstack/nova-specs/+/840217 | |
| 14:09:59 | bauzas | I mean, what value for reqspec.az to restore ? | |
| 14:10:08 | bauzas | thanks whoever it was ^ | |
| 14:11:30 | bauzas | anyway, I'm bikeshedding | |
| 14:11:35 | bauzas | this is unrelated to the spedc | |
| 14:11:52 | bauzas | we won't fix all the first-class problems of the world with this spec | |
| 14:12:08 | sean-k-mooney | aw | |
| 14:12:15 | sean-k-mooney | but what about world hunger | |
| 14:12:23 | bauzas | (technically, Placement could resolve the World-class starvation issue we have) | |
| 14:12:26 | sean-k-mooney | surely that is in scope right | |
| 14:12:35 | bauzas | heh, placement can help | |
| 14:13:18 | bauzas | atm, this is just some western countries who use specific required traits | |
| 14:13:33 | bauzas | and gather all the resources | |
| 14:13:53 | gibi | so a failed unshelve can be retried so I'm not worrying about persisting the wrong data, as that can be overwritten by the next unshelve trial | |
| 14:13:59 | sean-k-mooney | hehe Uggla for context the example demo of placment was makign a sandwich and tracking inventories of food in your fridge | |
| 14:14:19 | bauzas | sean-k-mooney: I showcased him during our knowledge transfert :) | |
| 14:14:37 | bauzas | I used cdent's slides about ham and leafs | |
| 14:14:39 | sean-k-mooney | gibi: ya it can i dont think its a big issue | |
| 14:14:47 | bauzas | gibi: you make a valid point | |
| 14:14:58 | bauzas | we should open a bug report for not forgeting it | |
| 14:15:03 | gibi | ack | |
| 14:15:04 | bauzas | the resolution isn't trivial | |
| 14:15:24 | bauzas | but at least we can assess in the report that a workaround is to ask for another unshelve | |
| 14:15:49 | bauzas | damn, I need to taxi again my kid | |
| 14:36:57 | Uggla | bauzas sold me that unshelve to host would be an easy trivial change, self contained to start learning.... ;) | |
| 14:39:11 | gibi | Uggla: at least the original use case was clear and agreed. We just made sure that all the possible state transitions are covered | |
| 14:39:20 | gibi | and that took a bit of time | |
| 14:40:36 | gibi | but this is still fairly simple | |
| 14:42:13 | Uggla | gibi, yes I'm just kidding at bauzas. ;) | |
| 14:43:08 | gibi | :) | |
| 14:48:50 | opendevreview | John Garbutt proposed openstack/nova master: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/842478 | |
| 15:49:16 | opendevreview | Merged openstack/nova master: neutron: Unbind remaining ports after PortNotFound https://review.opendev.org/c/openstack/nova/+/842528 | |
| 17:48:02 | opendevreview | Stephen Finucane proposed openstack/nova stable/yoga: neutron: Unbind remaining ports after PortNotFound https://review.opendev.org/c/openstack/nova/+/842584 | |
| 17:53:49 | opendevreview | Stephen Finucane proposed openstack/nova stable/xena: neutron: Unbind remaining ports after PortNotFound https://review.opendev.org/c/openstack/nova/+/842586 | |
| 17:57:22 | opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: neutron: Unbind remaining ports after PortNotFound https://review.opendev.org/c/openstack/nova/+/842587 | |
| 17:57:46 | opendevreview | Stephen Finucane proposed openstack/nova stable/victoria: neutron: Unbind remaining ports after PortNotFound https://review.opendev.org/c/openstack/nova/+/842588 | |
| 17:58:29 | opendevreview | Stephen Finucane proposed openstack/nova stable/victoria: neutron: Unbind remaining ports after PortNotFound https://review.opendev.org/c/openstack/nova/+/842588 | |
| 17:59:35 | opendevreview | Stephen Finucane proposed openstack/nova stable/ussuri: neutron: Unbind remaining ports after PortNotFound https://review.opendev.org/c/openstack/nova/+/842590 | |
| 18:03:05 | opendevreview | Stephen Finucane proposed openstack/nova stable/train: neutron: Unbind remaining ports after PortNotFound https://review.opendev.org/c/openstack/nova/+/842592 | |
| 22:30:30 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing py38|9 fips on c8|9s https://review.opendev.org/c/openstack/nova/+/842640 | |
| 22:36:51 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing py38|9 fips on c8|9s https://review.opendev.org/c/openstack/nova/+/842640 | |
| #openstack-nova - 2022-05-20 | |||
| 03:08:16 | melwitt | gmann: (leaving a message for tomorrow) I just saw a failure on stable/train where it failed while trying to install upper constraints from the master branch ... don't know why. it sounds familiar and I think it's happened before and iirc you fixed it. wondering if you can easily tell why this is happening https://review.opendev.org/c/openstack/nova/+/837323/1#message-a2501ae08ac62c8edd9cc41d76898796ab7cbe34 cc elodilles | |
| 06:46:10 | opendevreview | norman shen proposed openstack/nova master: Fixing rebooting/rebooting_hard instances after rebooting nova-compute https://review.opendev.org/c/openstack/nova/+/842671 | |
| 08:22:06 | opendevreview | melanie witt proposed openstack/nova master: Workaround qemu query-migrate bug during live migration https://review.opendev.org/c/openstack/nova/+/842687 | |
| 08:56:27 | opendevreview | John Garbutt proposed openstack/nova master: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/842478 | |
| 10:24:06 | andrea_gargano | hi all, I want to ask to you about nova, when i create a vm with a specified image qcow2 (all our images are qcow2) i get into db connection_info --> block_device_mapping --> nova ..."format": "qcow2"... but normally I've ..."format": "raw"... , could you say me where nova takes this information?Thank you in advance. Andrea | |
| 12:16:22 | sean-k-mooney | andrea_gargano: nova gets the format info form glance but i would check your nova.conf and see if you have configure nova to use raw iamges | |
| 12:17:39 | sean-k-mooney | i have not checked bu if https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.images_type is set to raw we would expect a format conversion to happen on the comptue manager | |
| 12:18:27 | sean-k-mooney | this can also be influcenced by https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.use_cow_images | |
| 13:33:19 | andrea_gargano | sean-k-mooney: Thanky you Sean, we have #images_type=default #force_raw_images=true commented in our nova.conf | |
| 13:34:24 | andrea_gargano | # # VM Images format. # # If default is specified, then use_cow_images flag is used instead of this # one. # # Related options: # # * virt.use_cow_images # * images_volume_group # (string value) # Allowed values: raw, flat, qcow2, lvm, rbd, ploop, default #images_type=default | |
| 15:15:07 | gmann | melwitt: ack, I will check today. | |
| 16:31:42 | opendevreview | melanie witt proposed openstack/nova master: Workaround qemu query-migrate bug during live migration https://review.opendev.org/c/openstack/nova/+/842687 | |
| 19:27:28 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing grenade 842799 https://review.opendev.org/c/openstack/nova/+/842800 | |
| 19:27:44 | opendevreview | Ghanshyam proposed openstack/nova stable/yoga: DNM: testing grenade 842799 https://review.opendev.org/c/openstack/nova/+/842732 | |
| 19:27:53 | opendevreview | Ghanshyam proposed openstack/nova stable/xena: DNM: testing grenade 842799 https://review.opendev.org/c/openstack/nova/+/842733 | |
| 21:18:56 | opendevreview | Ghanshyam proposed openstack/nova stable/train: Use Tempest's run upper constraints from devstack https://review.opendev.org/c/openstack/nova/+/842813 | |
| 21:21:19 | gmann | melwitt: ^^ this should fix the issue, I will keep eyes on gate. | |
| 21:22:21 | gmann | melwitt: dansmith also, I observed grenade-skip-level job is running on all the older stable which is supposed to be run only on stable/yoga onwards (and on SLURP release only). I am fixing that in https://review.opendev.org/c/openstack/grenade/+/842799 | |
| 22:25:58 | opendevreview | Ghanshyam proposed openstack/nova stable/train: Use Tempest's run upper constraints from devstack https://review.opendev.org/c/openstack/nova/+/842813 | |
| 23:51:48 | opendevreview | Ghanshyam proposed openstack/nova stable/train: Use Tempest's run upper constraints from devstack https://review.opendev.org/c/openstack/nova/+/842813 | |
| #openstack-nova - 2022-05-21 | |||
| 01:18:05 | opendevreview | Ghanshyam proposed openstack/nova stable/train: Use Tempest's run upper constraints from devstack https://review.opendev.org/c/openstack/nova/+/842813 | |
| 02:16:18 | opendevreview | Ghanshyam proposed openstack/nova stable/train: Use Tempest's run upper constraints from devstack https://review.opendev.org/c/openstack/nova/+/842813 | |