| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-19 | |||
| 12:34:17 | sean-k-mooney | hehe well there are pros and cons to that technially you are ment to wait for the spec to be approve to start on the code however doing a quick poc can help with writing the spec in some cases | |
| 12:35:03 | sean-k-mooney | often it can be helpfull to get something mostly working but defer the docs and test code till after the spec is approved | |
| 12:35:12 | sean-k-mooney | but only for small changes | |
| 12:35:34 | Uggla | sean-k-mooney, I agree, for the unshelve one I would have wait before redoing it. On the virtiofs, doing it in // helps me to better understand and to have questions. | |
| 12:38:44 | Uggla | gibi, fyi I have removed the point for today's call. | |
| 12:39:33 | Uggla | sean-k-mooney, gibi I'm gonna update the spec with these new data. If you are ok ? | |
| 12:39:35 | sean-k-mooney | for spec design stuff we try to keep as much of it public as we can anyway | |
| 12:40:10 | sean-k-mooney | Uggla: am sure you could | |
| 12:41:31 | sean-k-mooney | Uggla: when we bring up topic in internal calls it generally for high level brain stroming and we dig into the detail in specs,mailing list or public irc | |
| 12:42:37 | Uggla | sean-k-mooney, ok | |
| 12:42:45 | sean-k-mooney | basically we gather ideas privately and publicly but try to do all decision making and deep technical discusion as public as possibel to allow others to chime in. so we would not have made a discusion in the internal call anyway | |
| 12:43:50 | gibi | sean-k-mooney: re spawn_n, OK, cool, maybe we can add mnaser to that patch | |
| 12:44:11 | gibi | Uggla: maybe before you update the spec ping bauzas to look at the table :D | |
| 12:44:24 | bauzas | hmmm ? | |
| 12:44:56 | gibi | bauzas: we have a new behavior table in https://etherpad.opendev.org/p/unshelve-to-host#L166 for unshelve | |
| 12:45:11 | gibi | it changes around couple of things | |
| 12:45:45 | Uggla | gibi don't want to disturb bauzas during the nap time... :D | |
| 12:45:51 | gibi | nap time :D | |
| 12:46:21 | bauzas | not really napping | |
| 12:46:29 | bauzas | just sweating here | |
| 12:46:43 | bauzas | 28°c in the office room | |
| 12:47:21 | bauzas | Uggla: tbc, I hate the AZ hack for create | |
| 12:47:36 | gibi | yesterday was cold enough that I was able to bring down the room temp to 22C here | |
| 12:47:39 | bauzas | Uggla: I mean, the -az az_anything:host one | |
| 12:48:01 | Uggla | bauzas, 27°C here as well. | |
| 12:48:20 | bauzas | Uggla: I would have preferred to have a specific --host parameter instead of using the --az one | |
| 12:48:35 | sean-k-mooney | bauzas: you shoudl tell use how you really feel about it :P | |
| 12:48:44 | gibi | bauzas: yeah --az is a mess | |
| 12:49:08 | sean-k-mooney | bauzas: yep which we have now | |
| 12:49:10 | bauzas | sean-k-mooney: about the weather, you mean ? | |
| 12:49:33 | bauzas | or about the AZ hack ? :D | |
| 12:49:36 | sean-k-mooney | no i was being sarcatic im well aware of you "love"/hate of --az | |
| 12:50:11 | sean-k-mooney | i dont disagree with you either its one of the warts in our api | |
| 12:50:34 | sean-k-mooney | escpailly since they dont even really exist form a data model point of view | |
| 12:50:48 | sean-k-mooney | everything about AZs is a bit of a hack | |
| 12:51:07 | sean-k-mooney | fortunetly palcement aggreates have learned form that mistake | |
| 12:58:52 | Uggla | bauzas, regarding the hack, you are consistent, I think this is one of the fist thing you told me. Probably in my 2nd day at RH :D | |
| 12:59:19 | bauzas | hah | |
| 13:04:22 | Uggla | bauzas, but what do you think of Gibi's behavior proposed table ? | |
| 13:04:38 | bauzas | otp | |
| 13:04:44 | bauzas | over the phone for brian | |
| 13:27:42 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: PCI device tracking in Placement https://review.opendev.org/c/openstack/nova-specs/+/791047 | |
| 13:28:42 | gibi | sean-k-mooney, melwitt: hopefully the last update. I fixed the small nits and made a decision about pci alias forbidden / required traits ^^ | |
| 13:39:20 | bauzas | gibi: I need to review your spec | |
| 13:39:35 | bauzas | just for my knowledge at least :p | |
| 13:39:44 | gibi | sure, go for it | |
| 13:39:46 | bauzas | Uggla: /me looks at the etherpad again | |
| 13:40:05 | bauzas | gibi: your spec is open as a tab for a too long time | |
| 13:40:30 | gibi | bauzas: you have the benefit now that the content is settled and questions are answered | |
| 13:41:16 | bauzas | :) | |
| 13:43:04 | bauzas | gibi: sean-k-mooney: melwitt: gmann: I captured the agreement on my spec, can we move forward and accept it ? https://review.opendev.org/c/openstack/nova-specs/+/840217 | |
| 13:43:43 | gibi | bauzas: I let the others pull the trigger on that :) | |
| 13:44:47 | bauzas | :) | |
| 13:50:29 | sean-k-mooney | i can set +w if ther are no outstanding questions | |
| 13:50:47 | sean-k-mooney | im stil happy with it as it is so i was just waiting for gibi and melwitt to review | |
| 13:51:00 | sean-k-mooney | gibi: if your good to proceed ill send it on its way | |
| 13:51:02 | gibi | I accept it | |
| 13:51:04 | bauzas | cool, no rush | |
| 13:51:27 | gibi | so go and send it | |
| 13:51:38 | sean-k-mooney | done | |
| 13:52:27 | sean-k-mooney | gibi: im going to take a look at the pci spec again soon | |
| 13:52:43 | gibi | sean-k-mooney: thanks. only the pci alias part changed the rest is just fixing nits | |
| 13:52:48 | bauzas | Uggla: gibi: I don't see in https://etherpad.opendev.org/p/unshelve-to-host#L166 what we should do with original_az=None, host=hostB and AZ=something | |
| 13:53:01 | sean-k-mooney | ack | |
| 13:53:08 | bauzas | should we conflict or verify that the host is within the requested AZ ? | |
| 13:53:18 | bauzas | this was an open question in the spec review | |
| 13:53:32 | gibi | ahh good point I will add a line | |
| 13:53:41 | gibi | or you cabn | |
| 13:54:24 | gibi | I think that should be similar to AZ1 -> AZ2 + host1 case | |
| 13:54:40 | sean-k-mooney | bauzas: personally no | |
| 13:54:51 | sean-k-mooney | bauzas: i think we should let the scheduler handel that | |
| 13:55:14 | bauzas | sean-k-mooney: gibi: ok I added a line | |
| 13:55:17 | gibi | thanks | |
| 13:55:28 | sean-k-mooney | if its not we will get a no valid host but i was ok with leaving that to the patch review honestly | |
| 13:55:38 | sean-k-mooney | i dotn really mind checin in the api | |
| 13:55:44 | gibi | I'm OK to let the schedule reject it | |
| 13:55:47 | gibi | all these cases | |
| 13:55:56 | sean-k-mooney | but there are many other factors that could cause it to rejected | |
| 13:56:14 | sean-k-mooney | so schduler/placment is really the only thing that know if that is ok or not | |
| 13:56:40 | sean-k-mooney | like isolated_aggrate/tenating isolation filter/host aggreate metadta ectra | |
| 13:56:47 | bauzas | gibi: there could be a corner case tho | |
| 13:56:51 | gibi | yeah, we cloud do a check in the api and make a better error message but that is not strictly needed | |
| 13:57:09 | bauzas | gibi: if we leave the scheduler return NoValidHost, | |
| 13:57:24 | bauzas | the RequestSpec would have been modified before | |
| 13:57:32 | gibi | ohh true | |
| 13:57:33 | bauzas | so we're not idempotent | |
| 13:57:37 | sean-k-mooney | well we proably should not save it until after schduing | |
| 13:57:48 | gibi | yepp we need to rollback the change or not save it | |
| 13:58:02 | gibi | if that is not possible architecturally then lets do a check in the API | |
| 13:58:38 | sean-k-mooney | well we will need to cacht the novaild host and rollback in anycase if we do the save before | |
| 13:58:38 | bauzas | wai | |
| 13:58:39 | bauzas | wait | |
| 13:58:52 | bauzas | in order to verify that the host is in an AZ | |
| 13:59:04 | bauzas | we need to lookup its aggregate, right | |
| 13:59:09 | sean-k-mooney | yep | |
| 13:59:12 | bauzas | but, | |
| 13:59:17 | bauzas | this is cell-specific | |
| 13:59:21 | sean-k-mooney | no its not | |
| 13:59:23 | sean-k-mooney | its in the api db | |
| 13:59:32 | sean-k-mooney | the host aggreate are in teh api db | |