| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-19 | |||
| 11:20:44 | gibi | sean-k-mooney: "--availability-zone :gibi-devstack-aio" is allowed and it forces the host | |
| 11:20:59 | sean-k-mooney | that is not documented anywhere that im aware of | |
| 11:21:03 | sean-k-mooney | i would have filed a bug for that | |
| 11:21:16 | gibi | but does not set the AZ in the request spec | |
| 11:21:37 | sean-k-mooney | so your saying this feature is alreay supported | |
| 11:21:56 | gibi | we can force the host without pinning to the AZ of the host | |
| 11:21:56 | sean-k-mooney | well we dont allow host for unshleve in the az | |
| 11:22:10 | sean-k-mooney | gibi: well you can force and pin too | |
| 11:22:15 | gibi | yepp | |
| 11:22:15 | sean-k-mooney | by passing the correct az | |
| 11:22:19 | stephenfin | sean-k-mooney: gibi: That's a dead simple nova/neutron patch for whenever you've time ^ | |
| 11:22:36 | gibi | stephenfin: ack | |
| 11:22:38 | sean-k-mooney | ack | |
| 11:23:20 | gibi | sean-k-mooney: so based on this I think it is OK to decouple the host from AZ in unshelve too | |
| 11:23:21 | sean-k-mooney | that reminds me we dont currently unbind port when we shelve offload. we really shoudl fix that | |
| 11:23:57 | sean-k-mooney | i summareised my toughs "again" on line 139+ | |
| 11:24:10 | gibi | sean-k-mooney: just not blinding unbind but keep the device_id set and check with neutron that this keeps the port reserved | |
| 11:24:19 | gibi | sean-k-mooney: thanks | |
| 11:24:23 | sean-k-mooney | Uggla: rememebr when we said this was a simple non contoversial spec | |
| 11:24:56 | sean-k-mooney | gibi: unbinding never touches the device_id | |
| 11:24:59 | sean-k-mooney | that woudl be a detach | |
| 11:25:14 | sean-k-mooney | unbinding is just resetting the binding:host-id | |
| 11:25:41 | sean-k-mooney | and possible you could clear the port_profile bits | |
| 11:25:59 | sean-k-mooney | but ya we shoudl keep device_id set when unbinding for shelve_offload | |
| 11:26:06 | sean-k-mooney | to keep the port owned by the vm | |
| 11:27:32 | sean-k-mooney | stephenfin: i was going to ask why the continue but i sse wew try and use the port profile later | |
| 11:27:41 | sean-k-mooney | ya this looks correct to me. | |
| 11:28:27 | stephenfin | Yeah. I'm not too sure about that second exception handler (if we can't fetch the port, I'm not sure how much we will fare with updating it) but that's a problem for another day ;-) | |
| 11:28:52 | stephenfin | Unrelated, but if anyone hasn't gotten an ultrawide monitor yet, you need to get on that | |
| 11:28:53 | stephenfin | <3 | |
| 11:29:21 | sean-k-mooney | well the second excpetion handeler | |
| 11:29:28 | sean-k-mooney | is only invoked if we do find the port | |
| 11:29:33 | sean-k-mooney | but there is a differnt excption | |
| 11:29:34 | stephenfin | (new purchase this week - what have I been doing all these years? the extra pixel density makes the world of difference too) | |
| 11:29:53 | sean-k-mooney | but i guess that still means we dont have the port object | |
| 11:30:02 | sean-k-mooney | so ya it likely is not correct | |
| 11:30:03 | kashyap | stephenfin: What is the model that you have? | |
| 11:30:07 | kashyap | (Monitor model, i.e.) | |
| 11:30:15 | stephenfin | HP M34d | |
| 11:30:35 | sean-k-mooney | stephenfin: you have seeen the one on my desk | |
| 11:31:03 | stephenfin | 34" ultrawide, 3440x1440 resolution, USB C Power Delivery (which is A+) | |
| 11:31:23 | sean-k-mooney | mine is similar 34" 21:9 | |
| 11:31:40 | sean-k-mooney | 3440x1440@100hz | |
| 11:31:44 | stephenfin | Only thing it's lacking is Thunderbolt which would be handy since I could daisy chain a second monitor. As things stand, I'm just using my laptop screen | |
| 11:31:50 | sean-k-mooney | predates usbc however | |
| 11:32:28 | stephenfin | sean-k-mooney: sure have. This can do 100Hz if you're willing to put up with USB 2.0 speeds for the other ports, but Fedora seems not to drive 60Hz regardless | |
| 11:32:34 | stephenfin | I'm not gaming so it doesn't matter much anyway | |
| 11:32:49 | sean-k-mooney | i have been debating between going to 2 ultrawids or 1 large 4k display for a while but didnt find a cheep ultrawide | |
| 11:34:39 | sean-k-mooney | hum also curved | |
| 11:34:44 | stephenfin | This was a 479€ which seemed reasonable for what it had. I could justify more than doubling that for a 49" | |
| 11:34:44 | stephenfin | This was a 479€ which seemed reasonable for what it had. I could justify more than doubling that for a 49" | |
| 11:34:57 | sean-k-mooney | that is the one think i didnt want on this | |
| 11:35:05 | stephenfin | Also, you'd *have* to step up to Thunderbolt for that | |
| 11:35:20 | stephenfin | Don't think even USB 3.2 has the bandwidth for that | |
| 11:35:39 | sean-k-mooney | am maybe with display stream compression | |
| 11:35:43 | stephenfin | (i.e. 5120 x 1440 resolution) | |
| 11:35:46 | sean-k-mooney | but it depsn on the resolution | |
| 11:35:53 | sean-k-mooney | ya 4k ultrawid is nice | |
| 11:35:59 | sean-k-mooney | that is what i was loking at | |
| 11:36:02 | sean-k-mooney | but $$$ | |
| 11:37:34 | sean-k-mooney | i have basically been thinking about getting rid of my virtical monitor and laptop off my desk and addin a seocnd ultrawid on top of my current one for email and irc | |
| 11:38:34 | sean-k-mooney | right now my laptop (left of ultra wide) is my email screen and portait monitor (right of ultra wide) is irc | |
| 11:38:45 | sean-k-mooney | im just worried they might be two high | |
| 11:47:26 | gibi | sean-k-mooney: see the new table at https://etherpad.opendev.org/p/unshelve-to-host#L166 | |
| 11:47:34 | gibi | is this what you are after? | |
| 11:52:22 | sean-k-mooney | kind of i woudl prefer if we use null and queted strings to be explcit still reading it | |
| 11:52:55 | gibi | when I say "no AZ" it means the availability_zone field is not in the request body | |
| 11:53:07 | sean-k-mooney | yep i know | |
| 11:53:17 | sean-k-mooney | i was talkign about AZ=None | |
| 11:53:20 | gibi | so that is not the same as availability_zone = null | |
| 11:53:22 | gibi | ahh | |
| 11:53:23 | gibi | OK | |
| 11:53:23 | sean-k-mooney | that is ambiquious | |
| 11:53:32 | gibi | let me fix that | |
| 11:53:41 | sean-k-mooney | that could mean AZ="None" or AZ=null | |
| 11:54:03 | sean-k-mooney | cool | |
| 11:54:05 | gibi | done | |
| 11:55:11 | gibi | yepp thanks for the quotes | |
| 11:56:03 | sean-k-mooney | so yes that is what i was thinking | |
| 11:56:07 | gibi | cool | |
| 11:56:18 | sean-k-mooney | i was also thinking of just leaving the host->az check to the schduler | |
| 11:56:36 | sean-k-mooney | we could do it in the api if we want too | |
| 11:56:49 | gibi | Uggla, bauzas, dansmith: please check the table in https://etherpad.opendev.org/p/unshelve-to-host#L166 at least Sean and I agree on that now | |
| 11:56:55 | sean-k-mooney | but we could jsut convert the no valid host to a better error | |
| 11:57:36 | gibi | yeah, good point | |
| 11:57:49 | gibi | that will be NoValid host if we not check in the api | |
| 11:57:51 | gibi | but that is fine | |
| 11:58:34 | sean-k-mooney | im going to get coffee quickly brb | |
| 12:00:56 | gibi | sean-k-mooney: about the unbind, stephenfin's patch just shows that unbind removes the device_id from the port so we cannot bindly unbind at offload | |
| 12:05:41 | sean-k-mooney | gibi: that is not an unbind then | |
| 12:05:58 | gibi | the function is called unbind :) | |
| 12:06:00 | sean-k-mooney | at least not at the nutron api level | |
| 12:06:06 | sean-k-mooney | right its miss named | |
| 12:06:17 | sean-k-mooney | that is unbind_and_detach | |
| 12:06:18 | gibi | https://review.opendev.org/c/openstack/nova/+/842528/2/nova/network/neutron.py#616 | |
| 12:06:49 | sean-k-mooney | ya that function should be renamed | |
| 12:06:58 | sean-k-mooney | that is actully a detach | |
| 12:07:18 | sean-k-mooney | its a detach and clearing of dns_name | |
| 12:08:19 | sean-k-mooney | actully does this even do an unbind | |
| 12:08:52 | sean-k-mooney | ah i t does line644 | |