| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-18 | |||
| 09:49:25 | sean-k-mooney | cool one -1 down for the day now for the next :P | |
| 09:50:02 | sean-k-mooney | Uggla: i dont see a new comment form you since the last ones i posted | |
| 09:50:14 | sean-k-mooney | which one specifically did you want me to look at | |
| 09:55:00 | sean-k-mooney | bauzas: before you do | |
| 09:55:10 | sean-k-mooney | bauzas: can you respond to gmann on yoru spec | |
| 09:55:18 | bauzas | sean-k-mooney: sure, will look | |
| 09:55:30 | sean-k-mooney | bauzas: can you pull in the change to allow @ in the keypair name | |
| 09:56:27 | sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/785674 | |
| 09:56:42 | sean-k-mooney | this comment https://review.opendev.org/c/openstack/nova-specs/+/840217/3#message-81ccda58cd8f18ba84569bec794083b5572eb1e0= | |
| 09:57:03 | bauzas | gosh, I got lost with all the back-and-forths | |
| 09:57:11 | bauzas | and I forgot to upload my comments | |
| 09:57:59 | bauzas | oh, merging with another spec, I see | |
| 09:58:12 | sean-k-mooney | its a really trivial spec so if you can merge that into your it woudl be nice to do both in one micro verion | |
| 09:58:19 | sean-k-mooney | ya it just add ing @ and . | |
| 09:58:22 | sean-k-mooney | to the regex | |
| 09:58:38 | sean-k-mooney | so you can name the keypair me@my.domain | |
| 09:59:54 | sean-k-mooney | bauzas: if your ok with that we could also make that update as a FUP | |
| 10:00:04 | sean-k-mooney | assuming that works for gmann | |
| 10:00:10 | bauzas | sean-k-mooney: will add a new revision | |
| 10:00:16 | bauzas | better than a FUP | |
| 10:00:54 | sean-k-mooney | cool ill be AFK for 20 mins or so but ill review it as soon as im back if its up | |
| 10:04:35 | Uggla | sean-k-mooney, bauzas, oops sorry I forget to hit the reply button. | |
| 10:05:15 | Uggla | sean-k-mooney, bauzas, my comment should be available now. | |
| 10:13:35 | opendevreview | Rajat Dhasmana proposed openstack/nova-specs master: Repropose volume backed server rebuild spec https://review.opendev.org/c/openstack/nova-specs/+/840155 | |
| 10:15:31 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes to remove keypair generation https://review.opendev.org/c/openstack/nova-specs/+/840217 | |
| 10:22:26 | bauzas | gmann: sean-k-mooney: honestly the xena spec was not explaining how to modify the parameters | |
| 10:22:58 | bauzas | gmann: sean-k-mooney: because we validate the keypair name not by the API but rather by a specific method https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/compute/api.py#L6615 | |
| 10:24:07 | bauzas | so we'll need to either pass a parameter down to the compute api to tell about the microversion, or create a different parameter type for the older microversions (and remove this method) | |
| 10:24:16 | bauzas | not that simple honestly | |
| 10:24:34 | songwenping | Hi team, my env meet the error when boot vm: Failed to create PTY:no such file or dirctory, the qemu version is 2.10.0 and libvirt is 3.9.0, any guys have any solutions? | |
| 10:24:36 | bauzas | the simpliest is passing down some flag to the compute API of course | |
| 10:43:03 | sean-k-mooney | bauzas: honestly my prefence would be to not require a microversion and jsut start accpeting . and @ | |
| 10:44:10 | sean-k-mooney | gmann: is a microverions stictly required here | |
| 10:44:23 | sean-k-mooney | to me the spec was required becauses it is an api change | |
| 10:44:40 | sean-k-mooney | i was not sold on needing to opt into this behavior with a microverion | |
| 10:47:03 | sean-k-mooney | i know we have an exemtimption for 500->200 in this case its 400->200 but this partaclar change seams harmless to me | |
| 10:48:30 | bauzas | sean-k-mooney: I'm going afk for lunch but let's discuss this around 1230UTC if you want with gmann | |
| 10:48:31 | sean-k-mooney | bauzas: by the way this is not actully happenign in the comptue agent is it | |
| 10:48:44 | sean-k-mooney | bauzas: the keyparis are in teh api db | |
| 10:48:58 | sean-k-mooney | and we can crete them without any instnace or host | |
| 10:49:11 | bauzas | yeah, it's just a API DB | |
| 10:49:12 | sean-k-mooney | so this cant actully be runnign in the compute-agent | |
| 10:49:36 | sean-k-mooney | so there is not rpc impact here | |
| 10:49:44 | sean-k-mooney | this is executing in the api service | |
| 10:50:19 | sean-k-mooney | bauzas: its called directly from the api here https://github.com/openstack/nova/blob/4939318649650b60dd07d161b80909e70d0e093e/nova/api/openstack/compute/keypairs.py#L113 | |
| 10:50:35 | bauzas | yes | |
| 10:50:59 | sean-k-mooney | ok lets discuss when your back | |
| 10:51:08 | sean-k-mooney | but this looks like a trivial change to me honestly | |
| 10:51:13 | sean-k-mooney | since its all in the same process | |
| 10:51:25 | sean-k-mooney | we dont need to worry about rpc impact if we jsut add a paramater | |
| 10:51:53 | sean-k-mooney | its not remotable | |
| 10:52:54 | bauzas | the question is not about the remotable usage, but rather about the microversion needed or not | |
| 10:53:17 | sean-k-mooney | well it certenly does not need a second microversion | |
| 10:53:30 | sean-k-mooney | im not sure it need one at all since it backwards compatible | |
| 10:53:44 | bauzas | as we validate the name in the compute.api module, we need to pass some flag to it if we want a microversion for that | |
| 10:53:55 | sean-k-mooney | or we move the funciton | |
| 10:54:07 | sean-k-mooney | the only caller is in nova/api/openstack/compute/keypairs.py | |
| 10:54:08 | bauzas | we could | |
| 10:54:21 | bauzas | actually, it could be better | |
| 10:55:02 | sean-k-mooney | we could leave that to the patch review honestly im not sure it needs to be in the spec | |
| 10:55:10 | sean-k-mooney | this is an internal detail within the api process | |
| 10:55:20 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes to remove keypair generation https://review.opendev.org/c/openstack/nova-specs/+/840217 | |
| 10:55:21 | sean-k-mooney | go have lunch | |
| 10:55:31 | sean-k-mooney | we can chat when you are back | |
| 11:13:33 | gibi | sean-k-mooney: I've pushed a new PS for the tempest SSHABLE fix based on you suggestion, so we will see | |
| 11:21:36 | sean-k-mooney | i breifly looked at the tempest config and it looked liek verification was configured | |
| 11:22:14 | sean-k-mooney | so i would have expected it to trigger your chage | |
| 11:23:19 | sean-k-mooney | so notre really sure why your orgininal patch would not work other then maybe we have to wait for both | |
| 11:23:37 | opendevreview | Balazs Gibizer proposed openstack/nova master: Revert "zuul: Skip block migration with attached volumes tests due to bug #1931702" https://review.opendev.org/c/openstack/nova/+/812473 | |
| 11:24:24 | kashyap | gibi: So we're indeed skipping that | |
| 11:24:37 | kashyap | Err, it's a revert | |
| 11:24:59 | kashyap | Yep, makes sense, from reading the commit message. | |
| 11:25:21 | gibi | kashyap: I have no information why it should work now, but at least we can gather that information | |
| 11:25:36 | kashyap | Yeah | |
| 11:25:44 | gibi | it is related to another SSHABLE tempest fix in https://review.opendev.org/c/openstack/tempest/+/817772 | |
| 11:33:28 | tobias-urdin | sean-k-mooney: please have a quick look at https://review.opendev.org/c/openstack/nova/+/838976 when you have time, i need to go afk for a while but will be back later today | |
| 11:35:43 | sean-k-mooney | sure | |
| 11:36:05 | sean-k-mooney | oh this is for the nodedev name change | |
| 11:36:09 | sean-k-mooney | ya im aware of that | |
| 11:36:26 | tobias-urdin | ack :) | |
| 11:37:19 | gibi | I've just finished reviewing that | |
| 11:37:40 | gibi | I have some comments and a request for tests | |
| 11:38:39 | sean-k-mooney | just seeing them as i click | |
| 11:47:31 | sean-k-mooney | gibi: replied inline | |
| 11:51:29 | gibi | thanks | |
| 12:44:54 | opendevreview | Merged openstack/nova stable/train: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838037 | |
| 12:49:29 | opendevreview | Mohammed Naser proposed openstack/nova master: Fix race condition in _get_pci_passthrough_devices https://review.opendev.org/c/openstack/nova/+/840993 | |
| 13:07:25 | sean-k-mooney | gibi: are you working on https://bugs.launchpad.net/nova/+bug/1971760 i was going to try and find time today to push a patch to make spawn_n actully be spwan and see if that helps | |
| 13:08:31 | gibi | sean-k-mooney: I have an env where I try to reproduce the leak itself but I had no time to kick that env enough. I'm not sure I can reproduce the leak in a reproducible way | |
| 13:08:43 | gibi | so it is hard to test any changesd | |
| 13:09:21 | sean-k-mooney | i think it will hapen if a thread that is invoked with spawn_n raises an excpeiton | |
| 13:09:35 | sean-k-mooney | that is not caugt before the entry porint of the spawn_n call | |
| 13:09:43 | gibi | I tried that | |
| 13:09:48 | gibi | it does not create the leak | |
| 13:10:07 | gibi | I tried vif plug timeout | |
| 13:10:21 | sean-k-mooney | well my other tought was maybe itst related to https://bugs.launchpad.net/oslo.messaging/+bug/1949964 | |
| 13:10:42 | gibi | I havent looked at ^^ yet | |
| 13:11:24 | gibi | so feel free to propose a patch but it will be hard to prove it solved the issue except if mnaser are willing to take that patch to his env and let it running for a while | |
| 13:16:10 | sean-k-mooney | i was hoping to be able to tweak https://github.com/eventlet/eventlet/issues/731#issue-1032856809 to repoduce it but ya i just want to see if we do https://github.com/eventlet/eventlet/issues/731#issuecomment-968135262 will it help | |
| 13:16:45 | sean-k-mooney | well will it work with nova | |