| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-10 | |||
| 16:35:52 | sean-k-mooney | but for our unit tests to pass traits need to be in a release version of os-traits | |
| 16:35:54 | bauzas | for the library release on zed-1, gotcha | |
| 16:36:04 | sean-k-mooney | yes | |
| 16:36:07 | bauzas | surely, we can make it | |
| 16:36:39 | bauzas | sean-k-mooney: let's coordinate tomorrow for some review effort on the libs changes then | |
| 16:36:51 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce bug 1952745 https://review.opendev.org/c/openstack/nova/+/841170 | |
| 16:36:51 | opendevreview | Artom Lifshitz proposed openstack/nova master: Move evacuated instance destruction to new post_start_hook https://review.opendev.org/c/openstack/nova/+/841308 | |
| 16:37:10 | sean-k-mooney | sure its not the end of the world if we dont have them merge by m1 | |
| 16:37:29 | sean-k-mooney | i just blocks us mergin the nova code until we do an os-triats release whihc is cheap | |
| 16:37:33 | bauzas | sean-k-mooney: the only problem with the change you just proposed is that it depends on a spec which hasn't been approved yet :) | |
| 16:37:47 | bauzas | sean-k-mooney: yup, we had that problem in the past | |
| 16:37:56 | sean-k-mooney | yep | |
| 16:38:14 | sean-k-mooney | so we may have approves specs today that added traits. not sure we did | |
| 16:38:21 | bauzas | maybe let's focus on reviewing specs that have library dependencies | |
| 16:38:44 | sean-k-mooney | jsut wanted to highlight for peopel if you own one fo those spec then please submit a os-tirat patch if it had traits and ill be happy to review | |
| 16:38:46 | bauzas | sean-k-mooney: no, but I can personnally focus my effort on such specs | |
| 16:38:58 | bauzas | moving on tho, time flies | |
| 16:39:04 | bauzas | #topic Review priorities | |
| 16:39:11 | bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+label:Review-Priority%252B1 | |
| 16:39:15 | bauzas | #link https://review.opendev.org/c/openstack/project-config/+/837595 Gerrit policy for Review-prio contributors flag. Naming bikeshed in there. | |
| 16:39:22 | bauzas | #link https://docs.openstack.org/nova/latest/contributor/process.html#what-the-review-priority-label-in-gerrit-are-use-for Documentation we already have | |
| 16:39:43 | bauzas | sean-k-mooney: I just noticed we allow any contributor to flag with +1 | |
| 16:39:59 | bauzas | but the doc says we should not allow the owner to do it directly | |
| 16:40:07 | sean-k-mooney | correct | |
| 16:40:12 | sean-k-mooney | we cant make that distinction | |
| 16:40:30 | sean-k-mooney | i tried with chanve_owner:0 | |
| 16:40:43 | bauzas | ok, then we'll need to have a smarter Gerrit query | |
| 16:40:43 | sean-k-mooney | but that will not override registered owner | |
| 16:40:56 | sean-k-mooney | or we can just discuage it when we see it | |
| 16:41:08 | sean-k-mooney | the doc still says they should not flag there own change | |
| 16:41:21 | bauzas | yup, educational enforcement :) | |
| 16:41:34 | opendevreview | Artom Lifshitz proposed openstack/nova-specs master: Domain names in metadata https://review.opendev.org/c/openstack/nova-specs/+/840974 | |
| 16:41:39 | sean-k-mooney | if it ends up being a proablem we can revaluate | |
| 16:41:40 | bauzas | ok, let's bikeshed on the names in the gerrit change itself | |
| 16:42:07 | bauzas | I don't wanna drag this meeting's time by us disagreeing on how we would label those rights | |
| 16:42:19 | sean-k-mooney | ok if there are no objection to the names as written i think we could ask infra to review | |
| 16:42:35 | bauzas | but if people care about naming such things, they should review the change | |
| 16:43:12 | bauzas | sean-k-mooney: gibi had an objection, but let's continue off this meeting | |
| 16:43:20 | sean-k-mooney | ah ok | |
| 16:43:23 | bauzas | (about the +2 naming) | |
| 16:43:31 | bauzas | #topic Stable Branches | |
| 16:43:37 | bauzas | elodilles: are you around N? | |
| 16:43:42 | elodilles | yepp | |
| 16:43:51 | bauzas | cool | |
| 16:44:12 | elodilles | i did not update the page, though, as there's no news unfortunately, | |
| 16:44:54 | elodilles | from yoga till victoria the gate looks OK afaik | |
| 16:44:58 | bauzas | ok, then | |
| 16:45:05 | bauzas | #info ussuri and older branches are blocked until 'l-c drop' patches merge - https://review.opendev.org/q/I514f6b337ffefef90a0ce9ab0b4afd083caa277e | |
| 16:45:17 | bauzas | #info other branches are OK | |
| 16:45:30 | elodilles | yepp, still valid ^^^ | |
| 16:45:49 | elodilles | did not get there to investigate more on ussuri | |
| 16:45:53 | elodilles | :-/ | |
| 16:45:56 | bauzas | s/should be/are for the last item :) | |
| 16:46:06 | bauzas | thanks elodilles | |
| 16:46:16 | bauzas | last topic | |
| 16:46:18 | bauzas | #topic Open discussion | |
| 16:46:22 | bauzas | (sean-k-mooney) VDPA | |
| 16:46:42 | bauzas | sean-k-mooney: we're listening to you | |
| 16:46:50 | sean-k-mooney | :) | |
| 16:47:21 | sean-k-mooney | so short version is as agreed at the ptg i filed a bug for the move operation that were blocked but actully working | |
| 16:47:33 | sean-k-mooney | and i have a patch to adress it | |
| 16:47:45 | bauzas | cool | |
| 16:47:52 | sean-k-mooney | i then have 3 patches that follow up adding the remaining life cycle operations | |
| 16:48:06 | sean-k-mooney | i would like to proceed with those as a specless blueprint | |
| 16:48:12 | sean-k-mooney | those are inteface detach | |
| 16:48:17 | sean-k-mooney | suspend which need detach | |
| 16:48:36 | sean-k-mooney | and hotplug live migration which just need detach and adding vdpa to a list | |
| 16:48:49 | sean-k-mooney | and a compute version bump+ conductor check | |
| 16:49:06 | sean-k-mooney | idential to sriov hotplug migraiton | |
| 16:49:13 | sean-k-mooney | how do people feel about that | |
| 16:49:36 | sean-k-mooney | i have the code writen for everything excpot the compute service bump | |
| 16:49:48 | bauzas | hmmmm | |
| 16:49:49 | sean-k-mooney | test code is still need so patches are WIP | |
| 16:50:11 | bauzas | sean-k-mooney: no RPC changes on the compute service, just a version bump for API check ? | |
| 16:50:50 | sean-k-mooney | yep like this https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L34-L44= | |
| 16:51:10 | sean-k-mooney | the sriov live migration code works for vdpa too | |
| 16:51:21 | bauzas | I'd say a specless BP seems OK to me | |
| 16:51:23 | sean-k-mooney | just need to tell it to hot unplug the interface as we do for direct passthough | |
| 16:51:41 | bauzas | for exposing the new lifecycle ops | |
| 16:51:53 | sean-k-mooney | the compute service bump is just need for rooling upgrades | |
| 16:52:02 | bauzas | I know | |
| 16:52:09 | bauzas | but this means there is an upgrade impact | |
| 16:52:18 | bauzas | seamless for ops tho | |
| 16:52:42 | bauzas | but I don't see any controversial requiring a spec | |
| 16:52:46 | sean-k-mooney | yep so the api block will move form the api to conductor baseed on compute service version | |
| 16:52:59 | bauzas | so, looks like a feature, but less paper-ish | |
| 16:53:25 | bauzas | sean-k-mooney: this will be explained in a feature relnote, so definitely a blueprint | |
| 16:53:50 | bauzas | like 'now, nova supports this, only if you have your whole cloud uptodate' | |
| 16:53:53 | sean-k-mooney | ok we can continue to discuss in gerrit https://blueprints.launchpad.net/nova/+spec/vdpa-suspend-detach-and-live-migrate is the blueprint | |
| 16:54:23 | sean-k-mooney | but yes i can detial this in the release note | |
| 16:54:24 | bauzas | we have 5 mins for officially blessing it | |
| 16:54:37 | bauzas | do you want to propose https://blueprints.launchpad.net/nova/+spec/vdpa-suspend-detach-and-live-migrate as a specless BP ? | |
| 16:55:01 | sean-k-mooney | yes | |
| 16:55:20 | bauzas | okay, then anyone DISAGREEING with this ? | |
| 16:56:14 | bauzas | looks not, | |
| 16:56:47 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/vdpa-suspend-detach-and-live-migrate approved for Zed release as a specless BP, no objections so far be seen | |
| 16:56:53 | bauzas | voila | |
| 16:57:20 | bauzas | sean-k-mooney: a short summary and a better title may help | |
| 16:57:31 | bauzas | but I'll approve your BP | |
| 16:58:18 | bauzas | that's it for today, any other lastminute item to discuss ? | |