| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-05-09 | |||
| 12:56:33 | gibi | eventually | |
| 12:56:36 | sean-k-mooney | yep | |
| 12:56:48 | gibi | OK, I think I got my answers | |
| 12:56:55 | gibi | thank you for your time | |
| 12:56:59 | gibi | I really appreciate it | |
| 12:57:00 | sean-k-mooney | which again can use current and min service version to disable the healing when its not needed | |
| 12:57:04 | sean-k-mooney | no worries | |
| 12:57:12 | sean-k-mooney | im excited to see this moving forward | |
| 12:57:20 | sean-k-mooney | will you summerise this in the spec | |
| 12:57:26 | sean-k-mooney | perhaps like to the irc logs | |
| 12:57:33 | sean-k-mooney | *link | |
| 12:57:36 | gibi | I will do the summary | |
| 12:57:41 | gibi | and linking to the log | |
| 12:57:47 | gibi | then I will respin the spec | |
| 12:58:02 | gibi | and trim the questions | |
| 12:58:34 | gibi | I'm excited to stat coding up some of these in nova and watch them fail in the func env :) | |
| 12:58:39 | gibi | it will be fun | |
| 12:59:02 | sean-k-mooney | gibi: on a related not you reviewed Uggla spec. there was kind of an open question regarding updating hte AZ when you specify a host did you weigh in on that. | |
| 12:59:33 | gibi | I saw it and I think it was settled, I had no objection. But then I will doulecheck | |
| 12:59:38 | gibi | doublecheck | |
| 12:59:57 | sean-k-mooney | gibi: ack ill try and review it again shortly so | |
| 13:01:11 | sean-k-mooney | gibi: on a more selfish note i could also use your input on something else but its not super urgent https://review.opendev.org/c/openstack/nova/+/841017/1/nova/virt/libvirt/driver.py | |
| 13:02:02 | sean-k-mooney | i dont think that is 100% correct but i works for vdpa i need to test it with VFs and other vnic-types | |
| 13:02:48 | sean-k-mooney | basically we are curently unpluging neutron interface using _detach_pci_dev for suspend | |
| 13:03:07 | sean-k-mooney | that does not work for vdpa and im pretty sure it does not work in general | |
| 13:03:41 | sean-k-mooney | so i need to verify that and file a bug | |
| 13:07:15 | gibi | I never tried suspend with PCI / neutron SRIOV. So I neither confirm now deny that it works | |
| 13:07:38 | sean-k-mooney | it used to but its been a very long time since i checked it. | |
| 13:08:01 | sean-k-mooney | so ya i need to test it with differnt backends | |
| 13:08:15 | gibi | but your comments seems valid that if something is an interface then that cannot be detached as a hostdev | |
| 13:09:29 | sean-k-mooney | i have the ablity to test hardware offloaded ovs and sriov at home and i still have the servers i was usign for vdpa although ill be giving those abck today | |
| 13:10:08 | sean-k-mooney | so i can see if i can test the differnt combinations | |
| 13:10:34 | sean-k-mooney | i think self.detach_interface(context, instance, vif) shoudl work however in all cases | |
| 13:10:53 | sean-k-mooney | i dont really know why we have sepcial handelign for the host dev elements | |
| 13:11:03 | sean-k-mooney | detach_interface | |
| 13:11:26 | sean-k-mooney | is ment to be the abstraction here and its what is called when we call detach form the api | |
| 13:12:19 | gibi | yepp detach inteface dynamically use hostdev or interface config object | |
| 13:12:53 | sean-k-mooney | so i think i can just factor out the common code form https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L9811-L9829= | |
| 13:13:09 | sean-k-mooney | making the migrate_data optionall effectivly | |
| 13:13:29 | gibi | yepp | |
| 13:13:33 | gibi | that seems doable | |
| 13:13:52 | sean-k-mooney | basically i woudl jsut take in a list of vifs | |
| 13:14:57 | sean-k-mooney | so what im wonderign is it better to adapt the curent fucion as i did in the wip patch | |
| 13:15:06 | sean-k-mooney | or jsut do the refactor | |
| 13:15:24 | sean-k-mooney | and call detach_interface | |
| 13:15:49 | sean-k-mooney | via _detach_direct_passthrough_vifs | |
| 13:15:53 | gibi | I would do the refactor and call detach_inteface but I'm biased with the detach_interface code :D | |
| 13:16:12 | sean-k-mooney | well see i trust the detach_inteface code more | |
| 13:16:19 | sean-k-mooney | its better tested | |
| 13:17:06 | sean-k-mooney | ok thanks ill try and confirm my sepculation that suspend was broken and file a bug | |
| 13:17:11 | gibi | cool | |
| 13:18:10 | sean-k-mooney | one thing i need to bring up in the team meeting tomorrow is how to track the vdpa work | |
| 13:18:26 | sean-k-mooney | https://review.opendev.org/q/topic:bug%252F1970467 the non WIP patch is the bug fix | |
| 13:18:37 | sean-k-mooney | for the move operation that actully work | |
| 13:19:00 | sean-k-mooney | the next 3 add attach/detach, suspend and hotplug live migration | |
| 13:19:16 | sean-k-mooney | i feel like the last 3 shoudl be a specless blueprint or maybe a small spec | |
| 13:27:26 | gibi | I'm OK with both direction. If there is no API change then I'm fine with specless but if you have open questions then those are easy to discuss via a spec | |
| 13:29:30 | sean-k-mooney | there are no api change other then me removing the api block on the operation however i think i should be adding a compute service version bump for live migration | |
| 13:29:39 | sean-k-mooney | to supprot rolling upgade | |
| 13:29:48 | sean-k-mooney | i dont have that in the wip code | |
| 13:31:42 | gibi | I think this still can fly as specless | |
| 13:32:14 | sean-k-mooney | ack that is what i was hoping but if other felt differently i just wanted to get the spec up quickly | |
| 13:32:55 | gibi | yeah it is worth to ask | |
| 14:36:37 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: PCI device tracking in Placement https://review.opendev.org/c/openstack/nova-specs/+/791047 | |
| 14:36:49 | gibi | sean-k-mooney: updated according to our discussion ^^ | |
| 16:55:19 | opendevreview | ribaudr proposed openstack/python-novaclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-novaclient/+/831651 | |
| 17:24:26 | opendevreview | Merged openstack/nova stable/xena: Test aborting queued live migration https://review.opendev.org/c/openstack/nova/+/836145 | |
| 17:24:34 | opendevreview | Merged openstack/nova stable/xena: Add functional tests to reproduce bug #1960412 https://review.opendev.org/c/openstack/nova/+/836146 | |
| 17:24:41 | opendevreview | Merged openstack/nova stable/xena: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/836147 | |
| 19:05:11 | opendevreview | Merged openstack/nova stable/yoga: Retry in CellDatabases fixture when global DB state changes https://review.opendev.org/c/openstack/nova/+/840734 | |
| 21:26:02 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce bug 1952745 https://review.opendev.org/c/openstack/nova/+/841170 | |
| 21:26:44 | artom | I'm kinda proud of ^^ | |
| 21:36:49 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce bug 1952745 https://review.opendev.org/c/openstack/nova/+/841170 | |
| 21:41:36 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce bug 1952745 https://review.opendev.org/c/openstack/nova/+/841170 | |
| 23:55:07 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Define new functional test tox env for placement gate to run https://review.opendev.org/c/openstack/nova/+/840771 | |
| #openstack-nova - 2022-05-10 | |||
| 00:14:23 | opendevreview | Mohammed Naser proposed openstack/nova master: Fix race condition in _get_pci_passthrough_devices https://review.opendev.org/c/openstack/nova/+/840993 | |
| 00:18:47 | opendevreview | Takashi Kajinami proposed openstack/osc-placement master: Remove six https://review.opendev.org/c/openstack/osc-placement/+/841181 | |
| 01:03:40 | opendevreview | Jorhson Deng proposed openstack/nova master: Clear the ignore_hosts before starting evacuate https://review.opendev.org/c/openstack/nova/+/841089 | |
| 05:34:57 | opendevreview | melanie witt proposed openstack/placement stable/ussuri: Use 'functional-without-sample-db-tests' tox env for placement nova job https://review.opendev.org/c/openstack/placement/+/840773 | |
| 05:34:58 | opendevreview | melanie witt proposed openstack/placement stable/ussuri: placement-status: check only consumers in allocation table https://review.opendev.org/c/openstack/placement/+/840703 | |
| 07:39:41 | Uggla | Hello nova o/ | |
| 07:41:26 | gibi | Uggla: o/ | |
| 07:41:35 | gibi | happy spec review day :) | |
| 08:14:13 | sean-k-mooney | ah yes | |
| 08:14:25 | sean-k-mooney | well i guess i know what im doing today then | |
| 08:14:51 | bauzas | gibi: indeed, thanks for explaining it | |
| 08:16:39 | bauzas | starting out loud with https://review.opendev.org/c/openstack/nova-specs/+/840217 for people | |
| 08:17:25 | sean-k-mooney | opened in a tab ill get to it after i do a pass on the pci spec and the manilla shares spec. | |
| 08:18:35 | sean-k-mooney | just an fyi for people my arbiter spec need a respin with some largeish changes so you can ignore it for now. i might push it back up later today | |
| 08:18:49 | opendevreview | Jorhson Deng proposed openstack/nova master: Clear the ignore_hosts before starting evacuate https://review.opendev.org/c/openstack/nova/+/841089 | |
| 08:24:28 | bauzas | Uggla: I'm afraid that unshelve modifies the RequestSpec.az field :( | |
| 08:24:47 | bauzas | it shouldn't I think | |
| 08:24:51 | bauzas | but this is a bug | |
| 08:24:59 | bauzas | not your spec | |
| 08:26:41 | Uggla | bauzas, hum no from what I checked it seems the behavior is fine. Or I may miss what you mean. | |
| 08:29:51 | Uggla | I had some tests here maybe it will clarify: https://review.opendev.org/c/openstack/nova/+/831507/7/nova/tests/functional/test_availability_zones.py | |
| 08:30:49 | Uggla | bauzas, BTW I added tests to unshelve to an az that were missing. | |
| 08:32:44 | bauzas | Uggla: added my comments | |
| 08:33:04 | bauzas | now, I see why a lof of our customers prefer unshelve... | |
| 08:33:12 | bauzas | because of the open bug | |