| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-04-26 | |||
| 16:44:23 | gibi | the pci_devices table contains available PF and unavailable children VF rows | |
| 16:44:39 | gibi | this basically an impossible situation | |
| 16:44:54 | gibi | the VF should be available if the PF is available | |
| 16:45:04 | gibi | or the VF should be allocated | |
| 16:45:12 | gibi | anyhow | |
| 16:45:26 | gibi | I propsed a fix https://review.opendev.org/c/openstack/nova/+/838555 | |
| 16:45:40 | gibi | it removes some of the strictness of the state check during the PCI claim | |
| 16:45:56 | gibi | basically allows allocating the available PF if the children VFs are unavailable | |
| 16:46:06 | gibi | this would heal the inconsistent DB state | |
| 16:46:13 | gibi | artom had a good point in the review | |
| 16:46:32 | gibi | that we tend to handle DB healing via nova-manage CLI instead | |
| 16:46:45 | bauzas | not true | |
| 16:46:59 | sean-k-mooney | we heal some things on object load form the db | |
| 16:47:02 | bauzas | we had db healing made thru data migrations | |
| 16:47:51 | artom | Right, but those fixes are from "we had thing X a long time ago, and it might still be in the DB, so now when we load it we convert to thing X" | |
| 16:47:59 | sean-k-mooney | we do have the heal allcoation type commands but i think healing this on agent start is the right thing | |
| 16:48:01 | bauzas | we only heal things thru the CLI if this is for example something due to some relationship between two DBs | |
| 16:48:08 | artom | vs examples like placement-audit and Lee's connection_info update | |
| 16:48:09 | sean-k-mooney | as we are also fixing the in memroy representation | |
| 16:48:18 | bauzas | sean-k-mooney: correct, because two DBs were involved | |
| 16:48:52 | artom | My other point was - the DB somehow got into an inconsistent state, wouldn't it be wiser to at least let the operator know, vs siltently fixing it? | |
| 16:48:58 | bauzas | in the case of placement audit, this was about reconciling two datastores kept from two different projects | |
| 16:49:05 | sean-k-mooney | artom: i dont think so | |
| 16:49:17 | bauzas | I agree with sean-k-mooney | |
| 16:49:25 | bauzas | we could log such thing | |
| 16:49:32 | sean-k-mooney | artom: i think this happened beacue of how the custoemr recreated the compute node after the hdd died | |
| 16:49:32 | bauzas | but no need to claim it loud | |
| 16:49:34 | artom | OK :) Not a hill I want to die on, but wanted to at least raise the question | |
| 16:49:35 | gibi | I've added a WARNING log in the patch | |
| 16:49:52 | sean-k-mooney | i dont think this is something that most operators would hit | |
| 16:49:52 | artom | Seems like I'm outnumbered :) | |
| 16:50:12 | bauzas | artom: I won't ask you how many divisions you have | |
| 16:50:19 | gibi | sean-k-mooney: one more thing, you said it should be fixed at agent restart. Now my patch fixes it during PCI claim | |
| 16:50:31 | artom | bauzas, divisions o_O? | |
| 16:50:51 | bauzas | gibi: I like the pci claim approach | |
| 16:51:05 | sean-k-mooney | i have not reviewd the third patch yet | |
| 16:51:08 | gibi | sean-k-mooney: and I have a separate patch for the agent restart + remove VF + inconsistent state case | |
| 16:51:24 | gibi | sean-k-mooney: ahh, OK, let me know you opininon once you reviewed it | |
| 16:51:27 | bauzas | artom: sorry, I'll DM you the reference :) | |
| 16:51:40 | sean-k-mooney | ack we can proceed on the gerrit review | |
| 16:51:47 | artom | It's going to be an obscure French thing, isn't it :P | |
| 16:52:28 | gibi | artom, sean-k-mooney, bauzas: thanks, we can move on | |
| 16:52:37 | bauzas | ++ | |
| 16:52:56 | bauzas | sounds we got a consensus : review gibi's patch | |
| 16:52:56 | gibi | I will comment on the patch linking to the meeting logs | |
| 16:53:28 | bauzas | #agreed let's continue to review gibi's work with pci claims fixing the inconstitency | |
| 16:53:45 | bauzas | that's all we had for the meeting | |
| 16:53:55 | bauzas | any last minute item people wanna raise ? | |
| 16:54:32 | bauzas | looks not, | |
| 16:54:37 | gibi | - | |
| 16:54:37 | bauzas | thanks all ! | |
| 16:54:39 | gibi | thanks! | |
| 16:54:46 | bauzas | #endmeeting | |
| 16:54:46 | opendevmeet | Meeting ended Tue Apr 26 16:54:46 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:54:46 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-04-26-16.00.html | |
| 16:54:46 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-04-26-16.00.txt | |
| 16:54:46 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-04-26-16.00.log.html | |
| 16:54:48 | elodilles | thanks o/ | |
| 16:54:59 | gibi | bauzas: I hope you did not forget to leave around 18:30 :) | |
| 16:55:38 | bauzas | gibi: well, I chose to stay :) | |
| 16:55:45 | artom | He replaced himself with a very small shellscript | |
| 16:55:56 | bauzas | Sophie will stare at me when I go off the office room | |
| 16:56:00 | artom | Turns out we was getting bash'ed this whole time | |
| 16:56:09 | gibi | artom: lol | |
| 16:56:17 | bauzas | artom: I wish I could | |
| 16:57:11 | bauzas | artom: but I've been told any IA bot turns crazy after you let people discussing with it | |
| 16:58:02 | gibi | it is our, humans, fault to make AI bots crazy | |
| 16:58:23 | artom | So we're to AIs what demons are to us, The Corruptors? | |
| 16:58:38 | sean-k-mooney | lol | |
| 16:58:41 | sean-k-mooney | but yes | |
| 16:58:42 | gibi | at least the naming sounds badass | |
| 16:59:20 | artom | "I'm a Corruptor" "What does that mean?" "Oh I make chatbots says rude words and stuff" | |
| 17:02:14 | bauzas | or I could sleep on the couch | |
| 20:36:45 | opendevreview | Merged openstack/nova master: Move centos stream testing to centos-9-stream https://review.opendev.org/c/openstack/nova/+/839275 | |
| 21:15:49 | melwitt | bauzas: could you also add https://review.opendev.org/c/openstack/nova/+/821348 to your stable review list please? the -2 from zuul is bc I accidentally voted on it earlier | |
| #openstack-nova - 2022-04-27 | |||
| 03:13:16 | mnaser | sean-k-mooney, bauzas: ricolin on our side will help drive this and i'll also be helping in shaping it from our side. we don't have a whole *lot* of background knowledge about it but we can do a bunch of testing about the vIOMMU stuff | |
| 03:38:14 | opendevreview | Merged openstack/nova stable/yoga: Fix eventlet.tpool import https://review.opendev.org/c/openstack/nova/+/836788 | |
| 05:03:24 | opendevreview | Merged openstack/nova stable/ussuri: Fix the vGPU dynamic options race https://review.opendev.org/c/openstack/nova/+/831524 | |
| 07:14:07 | gibi | good morning | |
| 07:16:51 | bauzas | gibi: morning | |
| 07:16:59 | bauzas | mnaser: ack, very much appreciated | |
| 07:26:30 | bauzas | elodilles: I made my homework I promised | |
| 07:26:41 | bauzas | melwitt: sent to the gate | |
| 08:12:00 | elodilles | bauzas: cool, thanks \o/ | |
| 09:25:46 | opendevreview | Andrew Bonney proposed openstack/nova master: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/839361 | |
| 10:00:03 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 10:00:03 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add conductor RPC interface for rebuild https://review.opendev.org/c/openstack/nova/+/831219 | |
| 10:00:04 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 10:21:47 | ricolin | bauzas: for vIOMMU, I will work on BP asap for further discussion. Also I'm not that familar with nova future develop, are these also require to raise a meeting topic, or BP is enough for first step | |
| 10:33:41 | sean-k-mooney | ricolin: you should ideally draft a spec | |
| 10:33:49 | sean-k-mooney | rather then just a blueprint | |
| 10:39:15 | ricolin | sean-k-mooney: agree | |
| 10:43:49 | sean-k-mooney | are you familar enough with that process https://github.com/openstack/nova-specs/blob/master/specs/zed-template.rst | |
| 10:44:06 | sean-k-mooney | the poc patch is a good start | |
| 10:44:20 | sean-k-mooney | and i left most of my feed back in that patch already from a design point of view | |
| 10:45:06 | sean-k-mooney | so for the spec really waht i am looking for is to defien the scope of the chagne, the interfac (extra_specs and image proerties) and the usecasses we want to adress. | |
| 10:45:44 | sean-k-mooney | there is also a schduling question e.g. can we rely based on min libvirt version on all host suport this or do we need a compute capablity trait and prefileter for schduling | |
| 10:46:05 | sean-k-mooney | i havent checked thet min version to determin that | |
| 10:47:03 | sean-k-mooney | the vIOMMU has been aroudn a while so i think our min version support it but the adress space option is newer so not sure about that part | |
| 11:27:19 | gibi | bauzas: you probably interested in https://review.opendev.org/c/openstack/nova/+/839361 as it fixes a bug in the routed net pre-filter | |