| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-04-14 | |||
| 10:51:17 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Rename some config objects https://review.opendev.org/c/openstack/nova/+/830647 | |
| 10:51:17 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Shuffle methods around https://review.opendev.org/c/openstack/nova/+/830648 | |
| 10:51:18 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary kwargs https://review.opendev.org/c/openstack/nova/+/837853 | |
| 10:52:04 | sean-k-mooney | stephenfin: is that the next series i shoudl add to my list :P | |
| 10:53:05 | stephenfin | sean-k-mooney: nope, that's https://review.opendev.org/q/topic:sqlalchemy-20+project:openstack/nova+is:open 0:) | |
| 10:54:11 | sean-k-mooney | :) added to the folder | |
| 12:10:32 | opendevreview | Merged openstack/nova master: Fix the PCI device capability dict creation https://review.opendev.org/c/openstack/nova/+/833899 | |
| 12:10:39 | opendevreview | Merged openstack/nova master: refactor: remove duplicated logic https://review.opendev.org/c/openstack/nova/+/834382 | |
| 12:59:11 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Store pf_mac_address and vf_num in extra_info https://review.opendev.org/c/openstack/nova/+/834006 | |
| 13:09:33 | dmitriis | artom_: hey, apologies, just saw your message above about the lock_path option. I haven't managed to get to the bottom of it yet but I'm still getting it on my workstation: I get around 5 failures while running `tox -e py39` but not on the upstream CI. | |
| 13:10:23 | dmitriis | Will likely do an upgrade to 22.04 soon and see if it's still broken with updated packages | |
| 13:12:32 | sean-k-mooney | i didnt see those on a clean clone on 21.10 so ya maybe that will help | |
| 13:13:29 | sean-k-mooney | dmitriis: ill try and review https://review.opendev.org/c/openstack/nova/+/834006 later today but ill be off until tuesday so if i dont get to it today feel free to ping me when im back next week | |
| 13:14:11 | sean-k-mooney | gibi: by the way https://review.opendev.org/c/openstack/nova/+/829248 is not in merge confict and will need to be rebased | |
| 13:16:51 | sean-k-mooney | dmitriis gibi ye might want to stack both of ye're patches so that they dont conflict | |
| 13:17:51 | sean-k-mooney | techinially they are indepented (recordign the mac in the port forfile and recording it in the exta_info of the pci device) but also related | |
| 13:18:01 | dmitriis | sean-k-mooney: ack, ty | |
| 13:18:35 | sean-k-mooney | gerrit is not actully showing the patches as a confilct but im not sure if that will be the case when gibi rebases | |
| 13:19:00 | gibi | sean-k-mooney: thanks for the notice, I will rebase it | |
| 13:20:45 | sean-k-mooney | hehe | |
| 13:20:48 | sean-k-mooney | # TODO(stephenfin): The mock of 'migrate_disk_and_power_off' should | |
| 13:20:50 | sean-k-mooney | # probably be less...dumb | |
| 13:21:03 | sean-k-mooney | we are copy pasting that enough that we proably want to centralise that | |
| 13:21:26 | sean-k-mooney | stephenfin: did you have a fixture patch for that at some point | |
| 13:21:44 | stephenfin | not that I'm aware of, no. I tried a few times but it was hard | |
| 13:21:55 | sean-k-mooney | ack | |
| 13:22:18 | sean-k-mooney | right now we do with mock.patch('nova.virt.libvirt.driver.LibvirtDriver' | |
| 13:22:19 | sean-k-mooney | '.migrate_disk_and_power_off', return_value='{}'): | |
| 13:22:48 | sean-k-mooney | i was thinking of just putting that into one of the base class setup fucntion and keeping the comment | |
| 13:23:12 | sean-k-mooney | i actully dont know if we need to do somethign less dmub in most of the cases | |
| 13:23:22 | sean-k-mooney | so as a default thats proably fine | |
| 13:28:42 | artom_ | sean-k-mooney, so, for context, we're hitting it downstream in our OSP 17 unit tests on py39 | |
| 13:29:16 | artom_ | So I was (not so) secretly hoping that dmitriis solved it for us :) | |
| 13:30:43 | sean-k-mooney | i think it depend on your enviornment | |
| 13:31:03 | sean-k-mooney | ill spin up a c9s vm in a sec and see if i can repoduce | |
| 13:31:45 | sean-k-mooney | 17 would be stable wallaby i guess. i wonder if its stable branch specific or if it happens on master | |
| 13:43:37 | bauzas | stephenfin: https://review.opendev.org/c/openstack/placement/+/801104/9/placement/objects/allocation.py#166 hmpf, I'm a bit sad we need to use a private field for getting the mapping | |
| 13:43:52 | bauzas | sounds weird and anti-pattern | |
| 13:44:19 | bauzas | I tried to read the SQLA doc about the deprecation warning you mentioned, but this didn't help | |
| 13:45:31 | stephenfin | bauzas: agreed but I fixed it later https://review.opendev.org/c/openstack/placement/+/801107/9 | |
| 13:45:53 | bauzas | ah ok, I stopped on reading the series on that one | |
| 13:47:15 | sean-k-mooney | bauzas: stephen kept refactor to not use it seperate form the deprecation fix but i had the same feeling when reviewing it initally | |
| 13:47:30 | bauzas | sean-k-mooney: I just commented | |
| 13:47:45 | bauzas | oh by the way, I hate my bias | |
| 13:48:01 | bauzas | I said loudly "STOP DOING BLIND RECHECKS" and I fuckingly made one | |
| 13:48:18 | bauzas | bad manners are so easy to keep | |
| 13:48:43 | sean-k-mooney | hehe i noticed stephenfin actully copyt the fact that they rechecked beause the base patch failed to merge which made me happy :) | |
| 15:56:25 | opendevreview | Merged openstack/placement master: db: Update 'select()' calls https://review.opendev.org/c/openstack/placement/+/801103 | |
| 15:56:27 | opendevreview | Merged openstack/placement master: db: Remove use of non-integer/slice indices https://review.opendev.org/c/openstack/placement/+/801104 | |
| 15:56:30 | opendevreview | Merged openstack/placement master: db: Replace deprecated 'FromClause.select().whereclause' parameter https://review.opendev.org/c/openstack/placement/+/801105 | |
| 15:56:32 | opendevreview | Merged openstack/placement master: db: Use explicit transactions https://review.opendev.org/c/openstack/placement/+/801106 | |
| 16:06:25 | opendevreview | Merged openstack/placement master: db: Remove unnecessary use of '_mapping' https://review.opendev.org/c/openstack/placement/+/801107 | |
| 18:41:32 | opendevreview | Elod Illes proposed openstack/nova stable/yoga: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838000 | |
| 18:41:36 | elodilles | melwitt: if this passes then i'll cherry pick them to older branches ^^^ | |
| 18:42:31 | melwitt | elodilles: thanks! I will watch it | |
| 19:16:38 | opendevreview | Elod Illes proposed openstack/nova stable/xena: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838007 | |
| 19:16:55 | elodilles | melwitt: though the gate is not finished still it seems the job settings (and e.g. requirements-check job) are OK, so I started cherry picking ^^^ | |
| 19:17:30 | melwitt | elodilles: ack, thanks! | |
| 19:24:40 | opendevreview | Elod Illes proposed openstack/nova stable/wallaby: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838030 | |
| 19:26:34 | opendevreview | Elod Illes proposed openstack/nova stable/victoria: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838032 | |
| 19:31:05 | opendevreview | Elod Illes proposed openstack/nova stable/ussuri: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838033 | |
| 19:40:18 | opendevreview | Merged openstack/placement master: tests: Restore - don't reset - warning filters https://review.opendev.org/c/openstack/placement/+/828119 | |
| 19:41:24 | opendevreview | Elod Illes proposed openstack/nova stable/train: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838037 | |
| 19:47:38 | opendevreview | Elod Illes proposed openstack/nova stable/stein: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838038 | |
| 20:02:08 | melwitt | elodilles: hm, looks like this is saying on master too https://lists.openstack.org/pipermail/openstack-discuss/2022-April/028199.html so I guess it's not supposed to be stable-only? | |
| 20:05:18 | opendevreview | Elod Illes proposed openstack/nova stable/rocky: [stable-only] Drop lower-constraints job https://review.opendev.org/c/openstack/nova/+/838041 | |
| 20:06:50 | elodilles | melwitt: yes, though i wanted to wait for the resolution to drop it on master | |
| 20:07:08 | melwitt | ok | |
| 20:25:17 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Lookup nic feature by PCI address https://review.opendev.org/c/openstack/nova/+/838042 | |
| 20:26:03 | opendevreview | Merged openstack/placement master: db: Use Row, not LegacyRow https://review.opendev.org/c/openstack/placement/+/828305 | |
| 20:26:06 | opendevreview | Merged openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | |
| 23:08:20 | opendevreview | melanie witt proposed openstack/nova stable/train: Lookup nic feature by PCI address https://review.opendev.org/c/openstack/nova/+/838050 | |
| 23:47:15 | gmann | elodilles: melwitt +1, for master we can wait for resolution to merge but it is all good to drop from stable as they are broken | |
| 23:47:40 | melwitt | gmann: understood, thanks | |
| 23:50:49 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Lookup nic feature by PCI address https://review.opendev.org/c/openstack/nova/+/838042 | |
| 23:55:22 | opendevreview | melanie witt proposed openstack/nova stable/train: Lookup nic feature by PCI address https://review.opendev.org/c/openstack/nova/+/838050 | |
| #openstack-nova - 2022-04-15 | |||
| 07:34:52 | bauzas | good Friday Nova | |
| 12:28:38 | chateaulav | happy friday! | |
| 14:06:08 | bauzas | gmann: I know you're not around till' Tuesday, but this bug seems valid to me https://bugs.launchpad.net/nova/+bug/1969054 | |
| 15:01:55 | kashyap | bauzas: Is upstream Gerrit down? | |
| 15:01:56 | kashyap | Duuuh | |
| 15:02:00 | kashyap | Yeah, it is | |
| 15:02:10 | kashyap | "a few minutes" :D | |
| 15:03:45 | bauzas | kashyap: yup, see notice ^ | |
| 15:07:08 | kashyap | Yep, saw it | |
| 15:07:14 | kashyap | Have a good weekend! | |
| 15:07:23 | kashyap | It's actually back up | |
| 15:28:25 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace compareCPU() with compareHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/762330 | |
| 15:28:26 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt/config: Parse the 'cpu' element in domainCapabilities https://review.opendev.org/c/openstack/nova/+/838191 | |
| 15:28:26 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: fixtures: Add libvirt domCapabilities data for s390x and PPC* https://review.opendev.org/c/openstack/nova/+/838192 | |
| 15:28:27 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt/host: Introduce _get_hypervisor_info() https://review.opendev.org/c/openstack/nova/+/838193 | |
| 15:28:27 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: libvirt: Replace baselineCPU() with baselineHypervisorCPU() https://review.opendev.org/c/openstack/nova/+/838194 | |
| 15:28:28 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: test_report_cpu_traits: Update stale comment https://review.opendev.org/c/openstack/nova/+/838195 | |
| 16:38:20 | gmann | bauzas: sure, let me check after my lunch. | |
| 17:30:19 | gmann | bauzas: added details in that bug: https://bugs.launchpad.net/nova/+bug/1969054/comments/3 | |
| 17:31:59 | gmann | bauzas: in summary: this is exact issue we solved in Yoga with new RBAC direction (decoupled the scope from new defaults). reported issue is in Victoria. to solve it in victoria, I will say to override the external event policy but there might be some other isuse which we are not sure. | |
| 17:33:13 | gmann | bauzas: as we cannot backport the new policy changes done in yoga to victoria, we can say "new defaults from ussuri to xena does not work as expected so please do not try those, start trying those from Yoga release". | |
| 17:33:42 | gmann | or any other better way to notify this ^^ to users. | |
| 17:57:21 | opendevreview | Takashi Natsume proposed openstack/python-novaclient master: Remove unnecessary packages in bindep.txt https://review.opendev.org/c/openstack/python-novaclient/+/838199 | |
| #openstack-nova - 2022-04-16 | |||
| 08:35:33 | opendevreview | ZhouYanbing proposed openstack/nova master: correct the wrong word in the notes https://review.opendev.org/c/openstack/nova/+/838205 | |