| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-03-29 | |||
| 13:51:13 | noonedeadpunk | oh | |
| 13:51:54 | sean-k-mooney | presumable icelake reference cpu feature flags that are not present on the host correct | |
| 13:52:03 | sean-k-mooney | perhaps tsk | |
| 13:52:06 | sean-k-mooney | *tsz | |
| 13:52:10 | sean-k-mooney | ... tsx | |
| 13:52:10 | noonedeadpunk | well, the only "streight" way is to add dozen of extra flags to cover difference... | |
| 13:53:04 | noonedeadpunk | sean-k-mooney: so the falg that is missing is MPX which is sunset since 2019... But #virt said they can't jsut drop it for $reasons | |
| 13:53:36 | noonedeadpunk | and they just suggested to mask it as they don't have other option | |
| 13:55:01 | sean-k-mooney | ya https://paste.opendev.org/show/bmfNxhnzVYp54W9LQK0J/ so mpx is listed in the cpu model | |
| 13:55:56 | noonedeadpunk | and I mean - https://lore.kernel.org/lkml/tip-eb012ef3b4e331ae479dd7cd9378041d9b7f851c@git.kernel.org/ and Intel also said that since 2019 no CPU will have it | |
| 13:56:53 | noonedeadpunk | so I'm kind of... either use cpu model from 2014 or have dozens of flags specified in extras... | |
| 13:57:05 | noonedeadpunk | or manually edit cpu_map which is too bad | |
| 13:57:22 | sean-k-mooney | well that is a abi break on intels part which libvirt could accoutn for by adding a no_MPX verison of the cpu model | |
| 13:57:32 | sean-k-mooney | but looking at https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L982-L1008 | |
| 13:57:56 | sean-k-mooney | we coudl rework this os that we apply the extra cpu flags to the model before we do the compat test | |
| 13:58:21 | sean-k-mooney | that woudl allow you to add cpu_model_extra_flags=-mpx | |
| 13:59:01 | sean-k-mooney | and provide that combination was valid it would proceed | |
| 13:59:28 | noonedeadpunk | well, self._get_cpu_info() is jsut `virsh capabilities`? | |
| 13:59:29 | sean-k-mooney | right now it checks that the each model is valid on its own and then the default mode + the extra flags is valid | |
| 13:59:47 | noonedeadpunk | and `virsh capabilities` falls back to Broadwell | |
| 14:00:02 | noonedeadpunk | because all else have that damn MPX | |
| 14:00:24 | sean-k-mooney | yes again its an abi break by intel effectivly | |
| 14:00:59 | sean-k-mooney | this might be address by the new cpu compare api that we are moving too | |
| 14:01:07 | sean-k-mooney | but if not we can rework that validation | |
| 14:01:17 | sean-k-mooney | the curertn two pahse apprch is not really correct | |
| 14:01:25 | sean-k-mooney | it predates the ablity to remove flags | |
| 14:01:42 | sean-k-mooney | when we added the ability to remove flags this shoudl have been factored into one loop | |
| 14:02:09 | sean-k-mooney | for now yes your only option is to ude broadwall and add the missing flags | |
| 14:04:00 | noonedeadpunk | sean-k-mooney: ok, thanks a lot for help) | |
| 14:04:16 | noonedeadpunk | hopefully it will be better soon ) | |
| 14:04:52 | sean-k-mooney | well the currnt patch has been draging on for 3 cycle it might be betere to just rework this check as a simple backportable bugfix | |
| 14:05:47 | noonedeadpunk | tbh that would be perfect but I can't say I see easy way how to re-work it | |
| 14:07:46 | sean-k-mooney | something like this https://paste.opendev.org/show/b6PI9EzL6ucJUN7FKIBL/ | |
| 14:08:28 | sean-k-mooney | that would allow you to set cpu_model=Icelake cpu_model_extra_flags=-mpx | |
| 14:08:47 | sean-k-mooney | at least i think that would work | |
| 14:09:13 | sean-k-mooney | the important thing is we apply the flag modification to the model before we ask libvirt to see if its compatible | |
| 14:11:24 | sean-k-mooney | that quick refactor woudl loose some granualrity in the error message but i think it would allow better flexiblity | |
| 14:12:36 | sean-k-mooney | we could just print the requested feature and the host features and let it to the reader to do the intersection to get back most of the the previously useful info form the error | |
| 14:13:57 | noonedeadpunk | But I think it won't affect _get_cpu_info result? | |
| 14:14:24 | noonedeadpunk | as libvirt still would provide Broadwell as an aswer to that | |
| 14:14:55 | noonedeadpunk | and we're comparing flags requested vs cpu model provided but virsh capabilities iirc | |
| 14:15:05 | sean-k-mooney | _get_cpu_info i think shoudl provide the host cpu info | |
| 14:18:54 | noonedeadpunk | not really I guess | |
| 14:18:59 | noonedeadpunk | ant least not on Xena | |
| 14:21:03 | noonedeadpunk | sean-k-mooney: I added some logging https://paste.opendev.org/show/b0AFUQdxdydGrXHQHn6o/ | |
| 14:21:52 | noonedeadpunk | so _get_cpu_info for me looks exactly as `virsh capabilities` output | |
| 14:22:28 | sean-k-mooney | yes we use libvirt as our interface to collect host infomation | |
| 14:22:48 | noonedeadpunk | or welll | |
| 14:22:55 | noonedeadpunk | flags are not from broadwell | |
| 14:23:11 | sean-k-mooney | the flags should be the same or simlar to lscpu | |
| 14:23:25 | noonedeadpunk | ok, yes, then your suggestion can make sense | |
| 14:24:11 | sean-k-mooney | the model that is listed is the closet model that matches the cpu if i undersand correctly | |
| 14:25:51 | noonedeadpunk | yeah, I think you're right here | |
| 14:53:27 | ade_lee | dansmith, so what changed to make https://review.opendev.org/c/openstack/nova/+/831844 pass? | |
| 14:53:51 | dansmith | ade_lee: the wait-for-sshable I think | |
| 14:54:14 | ade_lee | ah ok | |
| 14:54:26 | dansmith | there were a number of changes to various tests to make that work, but that seemed to be the problem with the quick boot-attach-detach workflow which was in a number of places | |
| 14:56:01 | ade_lee | dansmith, excellent - we're going to run the cinder and glance fips tests again now to see if they pass | |
| 15:01:59 | dansmith | I was seeing those qemu crashes in cs8, so I'm interested to see if those still pop up in cs9 now that this always-fail stuff is resolved | |
| 15:13:25 | gmann | ade_lee: dansmith device tag test also is now ssh-able so may be that making it pass. | |
| 15:13:43 | gmann | recently ssh-able | |
| 15:36:05 | bauzas | reminder (special for EU folks) : nova meeting in 25 mins here | |
| 15:36:18 | bauzas | we'll have a very short meeting | |
| 16:00:06 | bauzas | #startmeeting nova | |
| 16:00:06 | opendevmeet | Meeting started Tue Mar 29 16:00:06 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:06 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:06 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:12 | bauzas | hola everybody | |
| 16:00:23 | gmann | o/ | |
| 16:00:25 | bauzas | let's do a very quick meeting (up to 15 mins) as I need to move on | |
| 16:00:27 | elodilles | o/ | |
| 16:00:30 | gmann | sure | |
| 16:00:37 | bauzas | DST change here, lovely | |
| 16:00:40 | gibi | o/ | |
| 16:00:56 | bauzas | if someone wants to continue discussing, I can pass the chair baton | |
| 16:01:19 | bauzas | but given next week will be PTG, I don't think we have a lot of things to discuss | |
| 16:01:29 | bauzas | let's start then | |
| 16:01:42 | gmann | ah its already 29. not DST is in sync in EU and USA :) | |
| 16:01:44 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:48 | gmann | *now | |
| 16:01:56 | bauzas | #topic Bugs (stuck/critical) | |
| 16:02:00 | bauzas | #info No Critical bug | |
| 16:02:03 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 31 new untriaged bugs (+3 since the last meeting) | |
| 16:02:07 | bauzas | #help Nova bug triage help is appreciated https://wiki.openstack.org/wiki/Nova/BugTriage | |
| 16:02:11 | bauzas | #link https://storyboard.openstack.org/#!/project/openstack/placement 26 open stories (0 since the last meeting) in Storyboard for Placement | |
| 16:02:14 | bauzas | nothing to say | |
| 16:02:25 | bauzas | moving on | |
| 16:02:28 | bauzas | #topic Gate status | |
| 16:02:32 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | |
| 16:02:36 | bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status | |
| 16:02:39 | bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | |
| 16:02:46 | bauzas | moving on too | |
| 16:02:50 | bauzas | #topic Release Planning | |
| 16:02:54 | bauzas | #link https://releases.openstack.org/yoga/schedule.html#y-final Yoga GA is planned on Wed | |
| 16:02:58 | bauzas | #info no RC2 was needed | |
| 16:03:14 | bauzas | there, we go to the main meat | |
| 16:03:19 | bauzas | #topic PTG preparation | |
| 16:03:23 | bauzas | #link https://etherpad.opendev.org/p/nova-zed-ptg Nova Zed PTG etherpad | |
| 16:03:27 | bauzas | #action all please add your topics before Thursday EOB | |
| 16:03:39 | bauzas | as you can see, we don't have a lof of topics | |