Earlier  
Posted Nick Remark
#openstack-nova - 2022-03-21
13:50:49 sean-k-mooney erlon: minor issue in https://review.opendev.org/c/openstack/nova/+/815324
13:51:10 erlon let me check
13:51:35 sean-k-mooney just the fixme comment its now fixed
13:51:48 erlon pw, tru, missed that one
13:51:54 erlon let me fix
13:54:14 opendevreview Erlon R. Cruz proposed openstack/nova master: Fix pre_live_migration rollback https://review.opendev.org/c/openstack/nova/+/815324
13:55:06 sean-k-mooney cool im am runing htat version now ill leave it for 10 mins and then ill review it again
13:55:18 sean-k-mooney thanks for updating it quickly
13:59:30 bauzas erlon: sorry, but like I said in the bug report, it's not a regression so we can't fix it for yoga RC2
14:00:15 erlon bauzas: ok, I had forgotten about the RC policies, but sean suggested us to merge it on master and backport it
14:00:25 bauzas erlon: yup
14:00:42 bauzas but we can only backport after Yoga release
14:00:53 erlon right
14:00:56 erlon it can wait
14:01:38 erlon thanks for given attention to it
14:10:06 sean-k-mooney the test seams stable locally at least so i reinstated my +2 on both patches
14:11:51 sean-k-mooney the releas should be thrusday week so the back port can be done from april 1st once the master version is merged
14:21:54 bauzas sean-k-mooney: Yoga GA is on Wed next week
14:22:13 bauzas ie. March 30th
14:22:21 sean-k-mooney oh they are not going with the normal "thursday" fo the week convention
14:22:24 sean-k-mooney ok
14:22:33 bauzas sean-k-mooney: they always release on Wednesdays
14:22:44 bauzas the GA, I mean
14:22:51 sean-k-mooney really? ok didnt know that
14:23:03 sean-k-mooney i guess it give more time for press releases ectra
14:23:07 bauzas lemme verify but I'm 99% on it
14:23:27 bauzas https://releases.openstack.org/xena/schedule.html#xena-release
14:23:33 sean-k-mooney i dont think it changes the math much. tl;dr we can start backporting after that release is done
14:23:44 bauzas https://releases.openstack.org/wallaby/schedule.html#wallaby-release
14:23:49 bauzas etc.
14:24:33 bauzas erlon: if I have time, I'll try to look at your change tomorrow
14:24:51 bauzas sean-k-mooney: have you seen my ping about https://bugs.launchpad.net/nova/+bug/1964995 ?
14:24:57 bauzas sean-k-mooney: not sure it's a regression
14:26:39 erlon no, let me see
14:27:22 bauzas I just added the tag to make sure we don't forget about it
14:27:29 bauzas for the moment, we don't have any needs for a RC2
14:27:44 bauzas https://review.opendev.org/q/project:openstack/nova+branch:stable/yoga is super empty
14:27:58 sean-k-mooney bauzas: am so vpd was added this cycle and it intoduced the bug
14:28:03 bauzas elodilles: ^ for your knowledge
14:28:07 sean-k-mooney however nothing uses the network capablities
14:28:19 sean-k-mooney so to me its a regression but it wont break anything
14:28:55 sean-k-mooney we only merged half of the network capablities feature e.g. the reportign into the db we did not merge the other half that consumes that info
14:30:17 sean-k-mooney bauzas: so i think that should be fixed but im not conviced we need an RC2 for it
14:30:41 sean-k-mooney its more tech debth then somethign that will break any user of nova
14:30:50 bauzas sean-k-mooney: if nothing was used in Xena, it's not a regression
14:31:08 bauzas sean-k-mooney: ok, so I'll remove the tag and I'll change the title
14:31:37 sean-k-mooney i was orginaly hoping to get that in rc1 by the way now that that has shiped i think it can just be a normal bugfix after the release
14:37:07 bauzas sean-k-mooney: yeah, we can merge any bugfix before RC1 but after, the ship has sailed
14:37:21 bauzas like erlon's bugfix
14:37:42 bauzas those are just policies for distro vendors and ops, which I can understand
14:46:26 elodilles bauzas: sean-k-mooney: yepp, GA is always Wednesday (compared to milestone and other deadlines, which are on Thursdays)
14:47:48 elodilles bauzas: ack, so we have one bug that does not need an RC2, as it seems now
15:10:53 sean-k-mooney bauzas: can we retarget https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration to zed yet or do we need to wait
15:11:22 sean-k-mooney it looks like yoga is still set as the current branch in launchpad
15:11:41 sean-k-mooney i assume you are waitign till the actual release to swap it over
15:13:23 sean-k-mooney should we add that blueprint to the meeting adgenda or wait untill after the release
15:22:17 sean-k-mooney elodilles: could you take a look at https://review.opendev.org/c/openstack/nova/+/828413/2 the follow up has +2+w and is waiting on the job being enabled
15:29:31 elodilles sean-k-mooney: hmmm, jobs aren't backported usually, and as I see it's non-voting
15:31:14 sean-k-mooney well we dont currently have coverage for hybrid plug in xena
15:31:25 sean-k-mooney it was the default before xena
15:31:44 sean-k-mooney but we did not readd it when we changed the devstack default
15:32:22 sean-k-mooney so this is really just add back coverage we had for wallaby to xena
15:32:40 sean-k-mooney which we now have on yoga again
15:33:15 elodilles (at least the new job nicely shows that the bug fix works)
15:33:20 sean-k-mooney it is non voting but it actully should get fliped to voting at some point
15:33:31 sean-k-mooney i think that is in the follow up patch
15:33:32 elodilles yes, i see now
15:34:02 sean-k-mooney yep so we were using that like a regression test to demonstrate the issue
15:54:41 elodilles sean-k-mooney: +2+W'd, thanks for the details about the fix
15:56:59 sean-k-mooney :)
16:00:19 bauzas sean-k-mooney: I prepared the zed cycle
16:00:33 bauzas sean-k-mooney: but actually I forgot to update the launchpad main branch
16:15:00 artom bauzas, sean-k-mooney, https://review.opendev.org/c/openstack/nova/+/806049/
16:17:54 sean-k-mooney thanks :)
16:52:56 bauzas fwiw, I'm about to give a go to https://review.opendev.org/c/openstack/nova/+/833440 as it won't harm our future tick-tock cadence
16:53:20 bauzas this is about removing Xena computes support for Zed
16:53:34 bauzas but we definitely need to discuss this at the PTG
17:30:55 gibi_pto bauzas: correct, we have to change that limitation in the future to support N-2 -> N upgrades
17:31:29 bauzas I'll leave this change open until tomorrow and we'll discuss at the nova meeting
17:31:34 sean-k-mooney gibi_pto: well that is the topic to discuss at the PTG apprently we dont actully have too but likely should
17:32:12 sean-k-mooney gibi_pto: just repeating what i have heard but appretly live rolling upgrade supprot for n-2 is left to the projects to opt in too
17:33:08 sean-k-mooney so if we elect to supprot n-2 rolling upgrades upstream then we shoudl alter that check and add a job to validate it if we dont then we could keep it at n-1
17:33:27 gibi_pto ahh, OK, lets talk that through on the PTHG
17:33:29 gibi_pto PTG
17:33:57 gibi_pto bauzas: that change fails in grenade on the service version check
17:34:11 gibi_pto https://zuul.opendev.org/t/openstack/build/a24b974ae9fd487694724da795bfcd2a/log/controller/logs/screen-n-cond.txt#1140
17:34:12 dansmith bauzas: I think we should have something like this for nova: https://docs.openstack.org/cinder/latest/contributor/gerrit.html#ci-job-rechecks
17:34:36 dansmith some discussion of late in the tc about how most people just do blind rechecks all the time
17:35:09 dansmith probably don't need that much detail for nova given that we don't have all the drivers, but still, I see a lot of "recheck" with no explanation, which I think often means no inspection
17:35:40 dansmith I'm hoping we'll have some general direction out of the tc about this, but would be nice to jumpstart in the nova community with reminders and constructive peer pressure :)
17:36:50 gibi_pto dansmith: I suppor that idea!
17:37:11 dansmith gibi_pto: I support your support :)
17:37:21 sean-k-mooney we used to have a section that said you should file a bug and add an elastic recheck query i think
17:37:23 dansmith however, I do not support you spending pto hanging out in irc :P
17:37:24 gmann like neutron, we can monitor how many recheck for this week we had
17:38:05 dansmith sean-k-mooney: yeah, but we need more constructive peer pressure regardless.. clear documentation to point to would be helpful when doing that
17:38:16 gmann s/gibi_pto/gibi_pto_but_work_on_irc :)
17:38:24 dansmith sean-k-mooney: if we've got it, then cool, but a concerted team-wide effort is needed I think
17:38:40 dansmith gmann: paid time on work is just work :P
17:38:40 gibi_pto nah, I just randomly hanging around :)

Earlier   Later