| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-03-10 | |||
| 13:01:00 | sean-k-mooney | gibi: sorry was making coffee did you determin why its unstable by the way? i did not fully read your bug report | |
| 13:01:55 | gibi | sean-k-mooney: no, I had not time to actually look deeply into it. I has not been able to reproduce it locally yet. | |
| 13:02:03 | gibi | *was not able | |
| 13:03:23 | sean-k-mooney | ok its odd the test is pretty simple | |
| 13:03:42 | sean-k-mooney | i mean for a live migration test | |
| 13:05:13 | sean-k-mooney | gibi: did you mean to put that patch on top of master rather then the fix | |
| 13:05:31 | sean-k-mooney | actully i guess that makes sense too | |
| 13:07:20 | sean-k-mooney | if noone else reviews the skip by the end of the day ill fast approve to make sure its included in rc1 | |
| 13:07:46 | gibi | sean-k-mooney: thanks | |
| 13:08:12 | sean-k-mooney | the followup failed grenade by the way | |
| 13:08:12 | gibi | I have some calls this afternoon, so I'm not sure I will have time to figure out today why it fails | |
| 13:11:54 | bauzas | gibi: sean-k-mooney: sorry was afk, a tl;dr ? | |
| 13:12:18 | bauzas | gibi: I see your comment on https://review.opendev.org/c/openstack/nova/+/815324/10 | |
| 13:12:22 | gibi | bauzas: the functional test added here https://review.opendev.org/c/openstack/nova/+/821840 is unsatble | |
| 13:12:32 | gibi | so I pushed https://review.opendev.org/c/openstack/nova/+/833079 | |
| 13:12:43 | gibi | the we can figure out the stability issue | |
| 13:12:45 | gibi | *then | |
| 13:12:55 | bauzas | gibi: maybe we should revert the functional test then | |
| 13:13:17 | bauzas | gibi: hah | |
| 13:13:18 | gibi | bauzas: we can do that as well, revert the func test and the revert the fix | |
| 13:13:29 | bauzas | gibi: yeah I think it's better | |
| 13:13:34 | bauzas | gibi: can you revert it ? | |
| 13:13:39 | bauzas | erlon is not around | |
| 13:13:42 | gibi | I can | |
| 13:13:49 | bauzas | thanks | |
| 13:14:35 | opendevreview | Balazs Gibizer proposed openstack/nova master: Revert "Adds regression test for bug LP#1944619" https://review.opendev.org/c/openstack/nova/+/832902 | |
| 13:14:48 | gibi | bauzas, sean-k-mooney: ^^ revert then | |
| 13:15:48 | sean-k-mooney | ok that works for me too | |
| 13:16:10 | sean-k-mooney | although it would still be nice to fix this this cycle but i guess we can backport | |
| 13:16:30 | sean-k-mooney | i assuem we dont want to pull this into an RC2 right | |
| 13:16:39 | sean-k-mooney | since tis not really a regression form this cycle | |
| 13:17:09 | sean-k-mooney | its just a bug in the orginal sriov live migration feature | |
| 13:17:33 | sean-k-mooney | so it can wait and be backported as normla | |
| 13:18:21 | bauzas | sean-k-mooney: given the issue is not a regression it can't be a RC2 one | |
| 13:18:36 | bauzas | sean-k-mooney: but I'm OK to backport it to 25.0.1 once we open it | |
| 13:18:56 | bauzas | this is just, we're close to RC1 deadline and erlon isn't around | |
| 13:19:23 | sean-k-mooney | yep that is what i was thinking too | |
| 13:20:02 | bauzas | gib: iI can't find the nova doc where we agree on having a quick and single +2/+W for reverts | |
| 13:20:32 | sean-k-mooney | i can get it but i +w it | |
| 13:21:56 | sean-k-mooney | so there is https://github.com/openstack/nova/blob/master/doc/source/contributor/policies.rst#reverts-for-retrospective-vetos | |
| 13:22:16 | sean-k-mooney | but i tought we had something else too | |
| 13:24:49 | sean-k-mooney | ya i dont see anything else relevent | |
| 13:25:19 | sean-k-mooney | in anycase i think we can agree that reverting a regression test that is unstable is ok given the followup fix has not merged yet | |
| 13:35:09 | gibi | I agree that fixing the gate is enough reason to quick approve a revert | |
| 13:35:15 | gibi | (or a test skip patch) | |
| 13:36:19 | bauzas | gibi: anyway, sean found the doc but also +Wd it | |
| 13:39:10 | sean-k-mooney | three cores walk into a bar, first core submits a patch to fix it, second core approves, third core say ouch how put this bar here | |
| 13:39:29 | gibi | :D | |
| 13:43:32 | gibi | yeah | |
| 13:50:25 | opendevreview | Merged openstack/nova master: Fix migration with remote-managed ports & add FT https://review.opendev.org/c/openstack/nova/+/829974 | |
| 13:59:28 | bauzas | sean-k-mooney: indeed, I missed bars, I'm so foo | |
| 13:59:49 | sean-k-mooney | lol :) | |
| 14:00:38 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs(db+object) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 14:00:39 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs(manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 14:00:39 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Enable and use COMPUTE_STORAGE_VIRTIO_FS and COMPUTE_MEM_BACKING_FILE traits. https://review.opendev.org/c/openstack/nova/+/833090 | |
| 14:01:08 | sean-k-mooney | noonedeadpunk: ^ see virtio-fs work | |
| 14:01:42 | bauzas | sean-k-mooney: are you ok with me removing the yoga-rc-potential flag ? https://bugs.launchpad.net/nova/+bug/1960412 and https://bugs.launchpad.net/nova/+bug/1949808 ? | |
| 14:02:50 | sean-k-mooney | yes although the fix should hopefully merge shortly | |
| 14:03:14 | bauzas | oh wait indeed | |
| 14:03:20 | bauzas | haven't seen gibi voting | |
| 14:03:21 | noonedeadpunk | oh, wow | |
| 14:03:22 | bauzas | we can hold | |
| 14:03:23 | sean-k-mooney | it failed on the flaky func test | |
| 14:04:13 | gibi | yeah I found out about the flaky test by reviewing that other bugfix :) | |
| 14:04:50 | gibi | ohh it failed again :/ | |
| 14:05:02 | gibi | then we need the revert first | |
| 14:05:30 | sean-k-mooney | ath least this time its looking ok https://zuul.openstack.org/status#828570 | |
| 14:05:53 | sean-k-mooney | not that im watching it on my other monitor right now or anything | |
| 14:05:56 | sean-k-mooney | tottally not | |
| 14:06:36 | gibi | :) | |
| 14:16:11 | opendevreview | Merged openstack/nova master: Revert "Adds regression test for bug LP#1944619" https://review.opendev.org/c/openstack/nova/+/832902 | |
| 15:04:52 | bauzas | gibi: I guess we can +W https://review.opendev.org/c/openstack/nova/+/832292 | |
| 15:04:58 | bauzas | sean-k-mooney: ^ | |
| 15:05:04 | bauzas | we need it for the RC1 | |
| 15:05:08 | gibi | done | |
| 15:05:16 | bauzas | thanks | |
| 15:05:26 | sean-k-mooney | hehe i was about to say looks like gibi already has | |
| 15:05:40 | bauzas | let's wait then for both https://review.opendev.org/c/openstack/nova/+/832292 and https://review.opendev.org/c/openstack/nova/+/828570 be merged | |
| 15:05:42 | bauzas | elodilles: ^ | |
| 15:05:57 | bauzas | elodilles: once both are merged, we could modify the RC1 nova change | |
| 15:06:06 | bauzas | and then we'll be done :) | |
| 15:10:49 | dansmith | chateaulav: did you ever float a patch to run the emulation job less? | |
| 15:16:49 | elodilles | bauzas: ack :] | |
| 15:22:38 | chateaulav | dansmith: no, i can | |
| 15:48:24 | dansmith | chateaulav: cool, thanks | |
| 15:54:11 | opendevreview | Artom Lifshitz proposed openstack/nova master: Explicitly set OS_DEBUG=0 when running default logging test https://review.opendev.org/c/openstack/nova/+/833115 | |
| 16:07:46 | opendevreview | Merged openstack/nova master: Clean up when queued live migration aborted https://review.opendev.org/c/openstack/nova/+/828570 | |
| 16:07:54 | opendevreview | Merged openstack/nova master: Add the Yoga prelude section https://review.opendev.org/c/openstack/nova/+/832292 | |
| 16:08:10 | gibi | we are done \o/ :D | |
| 16:14:55 | sean-k-mooney | :) | |
| 16:15:57 | bauzas | cool | |
| 16:33:03 | opendevreview | ribaudr proposed openstack/nova master: Fix unit tests when they are run we OS_DEBUG=True https://review.opendev.org/c/openstack/nova/+/833115 | |
| 16:47:14 | elodilles | bauzas: should we wait for something else, or may I update the nova RC1 patch? | |
| 16:47:47 | bauzas | elodilles: I was about to do it but I'm in some brainstrorming internal meeting that tramples my brain | |
| 16:47:51 | bauzas | elodilles: so, shoot | |
| 16:48:33 | elodilles | bauzas: no problem, doing it in a sec! o/ | |
| 16:48:42 | bauzas | SHA1 to use : 60094e663c30fd11bb0b1c6923de9e5056adf8be | |
| 16:48:47 | bauzas | elodilles: ^ | |
| 16:50:35 | elodilles | yepp, added that | |
| 16:50:58 | elodilles | bauzas: there you go: https://review.opendev.org/c/openstack/releases/+/832412 | |