| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-25 | |||
| 15:28:08 | dansmith | for something like this that'd always be my plan | |
| 15:29:15 | whoami-rajat | ack, I'm still working on passing the reimage_boot_volume parameter from API->Compute, bumping up RPC versions for conductor, compute, tests for it etc that is more work than i anticipated | |
| 15:29:43 | whoami-rajat | almost done with it | |
| 15:30:11 | dansmith | whoami-rajat: ah, I thought that was done in the latest.. | |
| 15:30:26 | whoami-rajat | but again, I don't want to force any decisions, if the team doesn't want to include this as part of Yoga, we can continue work in Z | |
| 15:30:38 | whoami-rajat | dansmith, completed it in manager but the 3rd patch is getting larger and larger | |
| 15:30:45 | whoami-rajat | will update that in sometime | |
| 15:31:12 | whoami-rajat | need to deal with the breaking tests since there's a new parameter in like 10-15 methods | |
| 15:31:28 | whoami-rajat | so the 2nd patch is ready for review | |
| 15:31:32 | whoami-rajat | but 3rd needs some more work | |
| 15:32:57 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 15:34:14 | chateaulav | just running my one ci job, please dont think im trying to kill the pippeline. lol | |
| 15:36:07 | bauzas | whoami-rajat: we'll open the Zed release in two weeks | |
| 15:36:23 | bauzas | I mean, the master will be Zed in two weeks | |
| 15:36:47 | plibeau1 | gibi: Hello, I have reply on your question for this change: https://review.opendev.org/c/openstack/nova/+/803713 | |
| 15:36:55 | bauzas | whoami-rajat: so I propose you to provide again the spec for Zed as just a pre-approved spec | |
| 15:37:08 | bauzas | we could accept this spec quickly | |
| 15:37:24 | gibi | plibeau1: I've added your patch to my review queue | |
| 15:37:25 | bauzas | so we could just review your implementation changes again in less than one month | |
| 15:37:39 | plibeau1 | gibi: thx | |
| 15:37:40 | sean-k-mooney | chateaulav: no worries did you see my comment | |
| 15:37:54 | bauzas | gibi: do you know where I could find a document for the -2 comment ? :) | |
| 15:38:08 | bauzas | gibi: I mean, when I'll -2 the existing changes | |
| 15:38:13 | gibi | I don't think it is documented in the PTL guide | |
| 15:38:23 | chateaulav | sean-k-mooney: yeah it was acting weird the first couple times when i did just that, think i got it set right now | |
| 15:38:40 | gibi | I just used a sentece stating that we are in feature freeze | |
| 15:39:07 | sean-k-mooney | chateaulav: you still hae the templates mind if i quickly fix it for you | |
| 15:39:19 | bauzas | gibi: yeah, that's what I thought | |
| 15:39:24 | bauzas | gibi: I'm pretty sure I can find it | |
| 15:39:48 | kashyap | bauzas: Thx for the paperwork here - https://blueprints.launchpad.net/nova/+spec/virtio-as-default-display-device | |
| 15:39:51 | kashyap | ! | |
| 15:41:26 | opendevreview | sean mooney proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 15:41:47 | sean-k-mooney | chateaulav: ^ that should just run your job in check and check for merge conflicts | |
| 15:43:17 | sean-k-mooney | oh the alias | |
| 15:45:07 | opendevreview | sean mooney proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 15:47:23 | sean-k-mooney | chateaulav: if you want to keep an eye on it you can see it running here https://zuul.openstack.org/status#828372 | |
| 15:47:48 | whoami-rajat | bauzas, ack | |
| 15:57:16 | sean-k-mooney | im going to go to the store at the top of the hour then work form my laptop. when i get back so ill be off irc for a bit | |
| 16:14:11 | bauzas | gmann: melwitt: I trust you for rechecking again your already approved patches in case you have problems with the CI | |
| 16:14:42 | bauzas | I'll do a quick check on Monday morning my time to see if everything is merged | |
| 16:21:24 | gmann | bauzas: yeah. release time and CI will behave like that :) | |
| 16:26:34 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 16:26:50 | whoami-rajat | dansmith, ^ done with final patch | |
| 16:27:01 | dansmith | ack | |
| 16:40:48 | opendevreview | Merged openstack/nova master: Make unified limits APIs return reserved of 0 https://review.opendev.org/c/openstack/nova/+/712141 | |
| 16:50:01 | bauzas | ok, I'm done for this (busy) week | |
| 16:50:05 | bauzas | see ya folks | |
| 16:56:52 | whoami-rajat | dansmith, hey, the OSC client rebuild call is calling novaclient (AFAICS) so we do need the change in novaclient as well right? https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L3541 | |
| 16:57:27 | whoami-rajat | or there will be a structural change proposal to remove dependency of novaclient somehow... | |
| 16:57:30 | dansmith | whoami-rajat: I'm not on top of the state of that stuff.. I expect there are a bunch of calls not converted to native that still use novaclient? not sure | |
| 16:57:51 | dansmith | but if rebuild is currently going through novaclient today, I doubt anyone is going to make you change that before you merge :) | |
| 16:59:07 | whoami-rajat | ack, I'm totally confused with the deprecating novaclient and proposing changes directly to OSC first then... | |
| 16:59:19 | whoami-rajat | sean-k-mooney, can you help with my query above? ^ | |
| 17:00:42 | dansmith | whoami-rajat: yeah just not sure, but you're right to be confused/frustrated.. I'll look for sean-k-mooney to answer aw well | |
| 17:00:43 | dansmith | *as | |
| 17:03:07 | whoami-rajat | good to know I'm not the only one :) | |
| 17:16:14 | whoami-rajat | so this is my patch for OSC but it won't work without the novaclient patch https://review.opendev.org/c/openstack/python-openstackclient/+/831014 | |
| 17:17:28 | whoami-rajat | similar to the --hostname parameter introduced in 2.90 which depends on the novaclient patch https://github.com/openstack/python-openstackclient/commit/8e833a3ed26467a1190ba69d8ba716a7cd1cccb3 | |
| 17:19:37 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 17:39:14 | dmitriis | sean-k-mooney: I ended up getting the same result while trying to do a revert for an instance with a non-remote-managed PCI device https://paste.opendev.org/show/blQLSgsFtQbryq3q6ZJM/. I'll see if I can modify the fixture in a follow-up to test this. | |
| 17:55:21 | sean-k-mooney | whoami-rajat: we deprecated the nova cli not the python-novaclient package | |
| 17:55:57 | sean-k-mooney | it can still be used as a lib but we declared we woudl not continue to extend the nova command line clint and only add new microversion to osc | |
| 17:59:25 | sean-k-mooney | whoami-rajat: you can helps to novaclient, openstack sdk or just osc direclty without updating novaclient | |
| 18:01:16 | dansmith | the latter would require him to refactor all of the rebuild code in osc, so not likely right? | |
| 18:01:26 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 18:02:16 | sean-k-mooney | yes. we idealy want people to update sdk instead of nova python client | |
| 18:03:22 | sean-k-mooney | the only thing we decided to deprecate this cycle was the nova cli so im fine with removing the -2 form the novaclient patch after rc1 if we remove the addtion of the new partmar to the cli | |
| 18:04:01 | whoami-rajat | if i update my novaclient patch without the shell changes (not extending nova CLI) and modify the rebuild method called by OSC, would it be acceptable? | |
| 18:04:20 | sean-k-mooney | yep | |
| 18:04:24 | sean-k-mooney | that is perfectly fine | |
| 18:04:40 | whoami-rajat | ack | |
| 18:04:53 | sean-k-mooney | we will be keeping it as a lib for other projefct to use to programticaly call nova for a few releases | |
| 18:05:03 | sean-k-mooney | eventually we would like heat ectra to use the sdk | |
| 18:05:21 | sean-k-mooney | but we have not made plans to remove it as a lib in the near term | |
| 18:06:15 | sean-k-mooney | but now that we have feature partiy for api microversion in osc we dont wnat ot continute adding support for microversion in nova client | |
| 18:10:27 | whoami-rajat | got it | |
| 18:10:32 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 18:15:27 | opendevreview | Rajat Dhasmana proposed openstack/python-novaclient master: Add support to rebuild boot volume https://review.opendev.org/c/openstack/python-novaclient/+/827163 | |
| 18:32:59 | sean-k-mooney[m] | whoami-rajat: I dropped -2 on ^ but the release note still reference the nova cli change you dropped | |
| 18:34:34 | whoami-rajat | sean-k-mooney[m], ack, will update it | |
| 18:35:18 | opendevreview | Rajat Dhasmana proposed openstack/python-novaclient master: Add support to rebuild boot volume https://review.opendev.org/c/openstack/python-novaclient/+/827163 | |
| 19:15:39 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 19:19:23 | chateaulav | sean-k-mooney: last individual run, then i should be able to tie a bow on the ci job | |
| 20:18:40 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 21:37:49 | opendevreview | Merged openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | |
| 21:58:32 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 21:59:49 | chateaulav | sean-k-mooney: ci is good to go, I uncommented the other jobs and moved it under the other nova-XX jobs. let me know if you need anything further for it. | |
| 21:59:56 | chateaulav | o/ | |
| 22:20:08 | opendevreview | Merged openstack/nova master: Log which instance event was timed out https://review.opendev.org/c/openstack/nova/+/819817 | |
| 22:29:55 | opendevreview | Merged openstack/nova master: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/817632 | |
| #openstack-nova - 2022-02-26 | |||
| 00:22:10 | sean-k-mooney[m] | chateaulav: nice ill take a look at it on Monday but cool to see it green | |
| 01:52:55 | opendevreview | Merged openstack/nova master: Server actions APIs scoped to project scope https://review.opendev.org/c/openstack/nova/+/824358 | |
| 01:53:02 | opendevreview | Merged openstack/nova master: Modify remaining APIs as per RBAC new guidelines https://review.opendev.org/c/openstack/nova/+/828994 | |
| 06:38:59 | opendevreview | Takashi Natsume proposed openstack/nova master: doc: mark the max microversion for yoga https://review.opendev.org/c/openstack/nova/+/831075 | |
| 06:46:02 | opendevreview | Takashi Natsume proposed openstack/nova master: Update compute rpc version alias for yoga https://review.opendev.org/c/openstack/nova/+/831077 | |
| 08:46:30 | opendevreview | Merged openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | |
| 09:08:45 | opendevreview | Merged openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | |
| 09:08:53 | opendevreview | Merged openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | |
| 11:44:37 | opendevreview | Merged openstack/nova master: Separate flavor extra specs policy for server APIs https://review.opendev.org/c/openstack/nova/+/829626 | |
| 12:39:50 | opendevreview | Merged openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | |