| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-25 | |||
| 10:54:50 | sean-k-mooney | gibi: bauzas FF also applies to docs changes? | |
| 10:54:57 | bauzas | no | |
| 10:55:13 | sean-k-mooney | ok stephen has https://review.opendev.org/q/topic:notifications-docs and i was going to go review them | |
| 10:55:39 | sean-k-mooney | they will need a second +2 anyway but just wonderingif they should wait until after rc1 | |
| 10:56:01 | sean-k-mooney | if they can merge before it ill try and review them later today | |
| 10:56:18 | sean-k-mooney | otherwise i was going to wait and come back in a few weeks | |
| 11:12:31 | opendevreview | sean mooney proposed openstack/nova master: reenable greendns in nova. https://review.opendev.org/c/openstack/nova/+/830966 | |
| 11:23:46 | elodilles | bauzas sean-k-mooney : fyi, yesterday was the deadline for yoga-milestone-3 client library releases, python-novaclient - https://review.opendev.org/c/openstack/releases/+/830249 , and osc-placement - https://review.opendev.org/c/openstack/releases/+/830227 | |
| 11:24:04 | elodilles | if you have a sec and could review them that would be awesome :) | |
| 11:24:35 | sean-k-mooney | ack ill look at them now | |
| 11:24:45 | elodilles | sean-k-mooney: thanks \o/ | |
| 11:25:10 | sean-k-mooney | thanks for the reminder i forgot that m3 was the release deadline for client libs | |
| 11:25:25 | sean-k-mooney | /libs// | |
| 11:32:49 | elodilles | no worries :) | |
| 11:41:43 | opendevreview | sean mooney proposed openstack/nova master: reenable greendns in nova. https://review.opendev.org/c/openstack/nova/+/830966 | |
| 11:41:55 | sean-k-mooney | the nova client one looks correct so ill +1 that shortly | |
| 11:50:06 | sean-k-mooney | gibi: i have not reviewed this yet but do we want to try and land https://review.opendev.org/c/openstack/osc-placement/+/828545 | |
| 11:50:18 | sean-k-mooney | before we do the osc-pacement release later today | |
| 12:01:36 | whoami-rajat | sean-k-mooney, Hi, I'm not totally sure if which of the two reason is for the -2 on my patch (https://review.opendev.org/c/openstack/python-novaclient/+/827163) | |
| 12:01:52 | whoami-rajat | 1) if it's regarding proposing changes directly to OSC (in favor of deprecation of novaclient), i can do that sure | |
| 12:02:39 | whoami-rajat | 2) If it's regarding client freeze (due to which my patch wouldn't land in yoga) then the patch is up for review since long time and noone provided this feedback before | |
| 12:10:08 | sean-k-mooney | whoami-rajat: the freeze was yesterday | |
| 12:10:32 | sean-k-mooney | am but as of this cycle we are nolonger addign feature to novaclients cli | |
| 12:10:38 | sean-k-mooney | so that is the main rason for -2 | |
| 12:10:49 | sean-k-mooney | if you want to add helper funciton its fine | |
| 12:11:00 | sean-k-mooney | but in this case i think just adding it to osc is the way to go | |
| 12:12:26 | sean-k-mooney | im not sure is see a usecase wehre other projects will want to import nova client to trigger a rebuild but i guess heat coudl leverage that so im not againt having the libary functions in novaclient | |
| 12:12:37 | sean-k-mooney | the sdk woudl be better in the long run | |
| 12:13:00 | sean-k-mooney | but we intend to keep supporting novaclient as a python lib for a few cycles until sdk has full parity | |
| 12:15:09 | sean-k-mooney | whoami-rajat: i know -2 can seam a bit harsh but it was a mix of procedual and directional i would have just left a -1 if we were not past the feature freeze for the cycle | |
| 12:26:23 | sean-k-mooney | whoami-rajat: by the way just incase you are not aware -2 does not mean never it means the review has an objection directonaly or procerdurally beyond the content or quality of the code under review. if you recive a -2 it should always have an explaination as to why and you shoudl always feel free to reach out and discuss how to move forward as you have | |
| 13:08:39 | gibi | sean-k-mooney: regarding the osc-placement change, I will take that later as the lib FF happend last week | |
| 13:10:21 | gibi | ohh the yoga schedul has the client FF at the same time as the service FF | |
| 13:10:50 | gibi | still it is not super important | |
| 13:10:51 | sean-k-mooney | yes | |
| 13:10:59 | gibi | this part of placement is mostly for machine consumption | |
| 13:11:02 | sean-k-mooney | technially it would have been yesterday | |
| 13:11:25 | sean-k-mooney | ok in that case i guess this can wait till next cycle | |
| 13:11:33 | sean-k-mooney | and i can approve the release patch | |
| 13:17:25 | gibi | yes it can wait | |
| 13:17:33 | gibi | thanks for looking at the release patches | |
| 13:17:48 | gibi | I had a crazy morning so I will only start really looking at gerit now | |
| 13:18:25 | sean-k-mooney | thats ok | |
| 13:19:01 | sean-k-mooney | i signed up to be release liason this cycle so i really shoudl have done it yesterday but i was kind of tired after all the reviews this week | |
| 13:19:45 | sean-k-mooney | its not that any of them were hard really but all that context switching has a way of catching up with you that other work does not | |
| 13:20:56 | gibi | yes, the last two days was really review heavy | |
| 13:21:05 | gibi | but I think we have a farly good FF period | |
| 13:21:10 | gibi | *fairly | |
| 13:44:27 | chateaulav | sean-k-mooney: with all the changes merged yesterday. is it best to rebase and then continue the ci job patchset | |
| 13:48:33 | kashyap | chateaulav: Thank you for the work on https://blueprints.launchpad.net/nova/+spec/pick-guest-arch-based-on-host-arch-in-libvirt-driver | |
| 13:49:05 | kashyap | chateaulav: Hehe, you also added RISC-V too | |
| 13:49:54 | kashyap | Sorry that I couldn't take a deeper look earlier! I trust the existing reviews :) | |
| 13:50:40 | chateaulav | kashyap: lol, well tried, that will be another cycle. hit some roadblocks with ovo and there is some other things in its early stages that will help for eaiser implementation later | |
| 13:50:54 | chateaulav | thanks and no worries | |
| 13:51:18 | kashyap | chateaulav: ;-) For RISC-V stuff, check out the blog of Rich Jones (of libguestfs) here: https://rwmj.wordpress.com/tag/risc-v/ | |
| 13:51:32 | kashyap | He does a lot of testing w/ new hardware. And also maintains the Fedora RISC-V | |
| 13:53:51 | chateaulav | will do, i got to the point of having it somewhat function, i was working through the loading custom firmware descriptor files for riscv becuase it uses specific uboot and opensbi | |
| 13:54:14 | chateaulav | have a lot of links and hadnt stumbled upon that one, so def will help | |
| 13:58:54 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Fix migration with remote-managed ports & add FT https://review.opendev.org/c/openstack/nova/+/829974 | |
| 14:02:14 | sean-k-mooney | chateaulav: am you could rebase the zuul patch altohg if you do while you are working on it its proably better to disable the other jobs | |
| 14:02:14 | dmitriis | sean-k-mooney, gibi: addressed comments in https://review.opendev.org/c/openstack/nova/+/829974 Tried testing revert_resize with cold migration but connection info doesn't seem to be updated to the right state (of the node an instance was migrated from) - would prefer to figure out why that is in a follow-up if possible | |
| 14:02:32 | sean-k-mooney | chateaulav: just comment them out until you get your jobs working | |
| 14:02:39 | sean-k-mooney | then you can uncomment them | |
| 14:02:44 | sean-k-mooney | chateaulav: it just saves ci time | |
| 14:02:55 | chateaulav | k | |
| 14:03:32 | sean-k-mooney | dmitriis: ack sure we can likely cover revert seperatly in a differnt patch | |
| 14:03:44 | sean-k-mooney | dmitriis: have you tried it locally | |
| 14:03:50 | gibi | dmitriis: thanks. I will try to look at the patch | |
| 14:04:15 | sean-k-mooney | dmitriis: as in does it work in reality and this is a func test issue or is revert actully broken | |
| 14:05:04 | dmitriis | sean-k-mooney: I've only tried in a func test form, need to do that with updated packages on a real env and 2 nodes | |
| 14:05:26 | dmitriis | still need to set up a virtualized setup with only 1 DPU - will work on that | |
| 14:10:34 | dmitriis | sean-k-mooney: fwiw, I think the issue might not be specific to remote-managed ports as I get something like this: | |
| 14:10:43 | dmitriis | > /home/ubuntu/src/opendev/nova/nova/tests/fixtures/libvirt.py(1226)verify_hostdevs_interface_are_vfs() | |
| 14:10:43 | dmitriis | -> pci_info_from_connection = self._connection.pci_info.devices[ | |
| 14:10:43 | dmitriis | n | |
| 14:10:43 | dmitriis | KeyError: 'pci_0000_80_00_4' | |
| 14:11:04 | sean-k-mooney | dmitriis: technially resize can be doen on a singel host | |
| 14:11:04 | dmitriis | I'll try adding a test case to regular SR-IOV suite and see if it fails in the same way | |
| 14:11:10 | sean-k-mooney | so you can resize to a new flavor | |
| 14:11:13 | sean-k-mooney | then tell it to revert | |
| 14:11:30 | sean-k-mooney | resize and cold migration use the same code | |
| 14:11:42 | sean-k-mooney | cold migration is implemetned as a resize to the same flaovr | |
| 14:12:30 | sean-k-mooney | dmitriis: ack, im not sure if we have revert resize test for sriov | |
| 14:12:41 | sean-k-mooney | so ya it might just be a defect in the fixture | |
| 14:12:50 | dmitriis | sean-k-mooney: yeah, I'll try to add one but I'll probably run into the same | |
| 14:29:54 | whoami-rajat | sean-k-mooney, yes, and if i would've got the feedback that the patch is not acceptable in novaclient, I would've worked on the OSC alternative before feature freeze as my patch was proposed on Jan 31st | |
| 14:30:21 | whoami-rajat | the problem is the nova side changes have merged and to make the full feature working, we need nova side changes as well | |
| 14:30:47 | whoami-rajat | even if we get the nova API patch merged, without the client, i don't see much use of it for an end user | |
| 14:31:02 | whoami-rajat | I suppose they rely on clients rather than directly hitting the API | |
| 14:32:05 | whoami-rajat | s/nova/cinder side changes have merged for the feature | |
| 14:33:47 | sean-k-mooney | well i guess we can try and do a early osc release after rc1 | |
| 14:34:16 | sean-k-mooney | technially it would be teh Zed version but that would be an option | |
| 14:34:53 | sean-k-mooney | once rc1 is tagged the stable branches get created and master reopens for the next release | |
| 14:34:57 | sean-k-mooney | thats in about 2 weeks time | |
| 14:35:38 | sean-k-mooney | so if the osc team were open to it you coudl still proably get it in a osc release before the zed release is widely available | |
| 14:36:32 | whoami-rajat | sean-k-mooney, ack, i will explore that option, thanks | |
| 14:38:59 | sean-k-mooney | it looks like we have not actully compelte ll the work items form the last ptg | |
| 14:39:03 | sean-k-mooney | whoami-rajat: https://etherpad.opendev.org/p/nova-yoga-ptg#L513 | |
| 14:39:30 | sean-k-mooney | specificaly we have not update dthe sepc template to call out the requriemtn for sdk/osc | |
| 14:39:52 | sean-k-mooney | ill try and update the zed one to make that more clear to other going forward | |