| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-23 | |||
| 15:58:43 | gmann | bauzas: gibi thanks for reviews. I need to go away for 20 min (taking breakfast) and then will return if any query while review. | |
| 16:17:37 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Ignore LibvirtConfigObject kwargs https://review.opendev.org/c/openstack/nova/+/830644 | |
| 16:17:37 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary TODO https://review.opendev.org/c/openstack/nova/+/830645 | |
| 16:17:38 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 16:17:38 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Rename some config objects https://review.opendev.org/c/openstack/nova/+/830647 | |
| 16:17:39 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Shuffle methods around https://review.opendev.org/c/openstack/nova/+/830648 | |
| 16:17:39 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: libvirt: Remove handling for older libvirt versions https://review.opendev.org/c/openstack/nova/+/830649 | |
| 16:17:40 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: libvirt: Return objects from Guest.get_interfaces https://review.opendev.org/c/openstack/nova/+/830650 | |
| 16:17:40 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: libvirt: Don't fetch guest architecture repeatedly https://review.opendev.org/c/openstack/nova/+/830651 | |
| 16:17:41 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: libvirt: Prepare for manual PCIe address management https://review.opendev.org/c/openstack/nova/+/830652 | |
| 16:17:42 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: libvirt: Start managing PCIe address allocation https://review.opendev.org/c/openstack/nova/+/830653 | |
| 16:18:01 | stephenfin | Ignore those. They're nowhere near done. Just pushing so I remember to finish them at some point | |
| 16:19:03 | sean-k-mooney | stephenfin: am... i tought we were not gong to tdo that | |
| 16:19:06 | sean-k-mooney | but ok | |
| 16:19:51 | sean-k-mooney | i mean its been in our downstream backlog for ever | |
| 16:21:57 | opendevreview | Pedro Monteiro Azevedo de Moura Almeida proposed openstack/nova master: Update live_migration_downtime definition https://review.opendev.org/c/openstack/nova/+/828387 | |
| 16:26:31 | opendevreview | Elod Illes proposed openstack/nova stable/wallaby: skip test_tagged_attachment in nova-next https://review.opendev.org/c/openstack/nova/+/830656 | |
| 16:27:37 | bauzas | gmann: once you're back, question in https://review.opendev.org/c/openstack/nova/+/829626/9/nova/api/openstack/compute/views/servers.py#443 | |
| 16:28:17 | gmann | checking | |
| 16:31:49 | bauzas | gibi: other cores : I'm +2 on the whole new-policy-rules series except one patch, reviews welcome | |
| 16:33:33 | bauzas | gmann: can you then please answer my question ? | |
| 16:33:57 | bauzas | I have a hardstop in 30 mins and I want to briefly look at the last unified-limits patch before I go | |
| 16:34:43 | gmann | ok | |
| 16:39:00 | gmann | bauzas: replied, by default if target are not passed in policy it take context'sproject_id itself | |
| 16:39:44 | gmann | and DB query are based on requester project_id so it gets only requesting project instances until all-tenant is requested | |
| 16:40:36 | bauzas | gmann: ok, then I'm confused, why did we need to add the target be explicitely project_id ? | |
| 16:41:55 | gmann | bauzas: same as discussed before. PROJECT_ADMIN|MEMBER|READER has project_id i check_str of rule so we need to pass project_id in target which can pass. it is done to separate out the system user if scope are disabled. otherwise system reader can also pass policy. | |
| 16:42:18 | stephenfin | sean-k-mooney: We're still not necessarily going to do it, but it's come up so often that it seems something we should _eventually_ do | |
| 16:42:20 | gmann | bauzas: once we remove the enforce_scope as configurable (enable it hardcoded) then we can remove those and cleanup | |
| 16:42:29 | stephenfin | Now just to find the time to actually do it, heh | |
| 16:42:55 | gmann | bauzas: passing requester project_id and checking that against requester itself is ally bogus thing we have to do for now. | |
| 16:43:20 | bauzas | ok, it's a bit of a spaghetti code to me but I trust you | |
| 16:43:40 | bauzas | either way, +2d the whole series | |
| 16:43:57 | bauzas | you need to find someone next to jab it | |
| 16:43:57 | gmann | bauzas: this is TODO to cleanup once scope are enabled https://github.com/openstack/nova/blob/134c4791ff8233264b7862db692e058f60ae2f80/nova/policy.py#L180 | |
| 16:44:10 | gmann | bauzas: thanks a lot. | |
| 16:44:21 | bauzas | gmann: ok, I see | |
| 16:44:28 | bauzas | thanks for the explanations | |
| 16:44:53 | gmann | bauzas: and other key bit we need to improve after secure rbac is to remove the admin checks from DB which will make it more cleaner | |
| 16:45:03 | gmann | but those are things to do after we ship secure rbac as default | |
| 17:01:40 | sean-k-mooney | stephenfin: ack | |
| 17:03:41 | bauzas | also +2d the whole unified-limits series, melwitt | |
| 17:04:21 | bauzas | don't be afraid folks, if you get +2/+W before Friday, you're all good | |
| 17:08:02 | melwitt | thank you bauzas! | |
| 17:32:23 | gibi | bauzas: ack, I will look first thing in the morning tomorrow | |
| 18:07:04 | whoami-rajat | dansmith, bauzas hey, just to clear my understanding regarding your comments on change https://review.opendev.org/c/openstack/nova/+/820368 | |
| 18:07:39 | whoami-rajat | the ask is to divide the patch into two parts, one adding new event (requires MV bump) and other adding rebuild support (requires yet another MV bump) | |
| 18:07:52 | whoami-rajat | so the two patches will be 2.91 and 2.92 | |
| 18:07:57 | dansmith | no, | |
| 18:08:05 | dansmith | the event doesn't need a version bump, just your api change | |
| 18:08:12 | dansmith | event first, then api change | |
| 18:08:34 | dansmith | I would put the cinder volume change and test in a separate early patch too and we can sink that quickly, IMHO | |
| 18:10:22 | whoami-rajat | hmm, I'm still slightly confused, the addition of a new event has required an MV bump, so you're saying don't do the bump at all or use 2.91 for it as well ? https://review.opendev.org/c/openstack/nova/+/820368/8/nova/api/openstack/compute/schemas/server_external_events.py | |
| 18:11:43 | dansmith | uh | |
| 18:12:18 | dansmith | okay I didn't realize we started adding microversions for new event names | |
| 18:13:03 | dansmith | pretty sure that didn't happen in the earlier days (was never my intent) but clearly has been happening since v51 or so | |
| 18:13:28 | dansmith | so yeah maybe not worth splitting in that case, I guess | |
| 18:13:40 | dansmith | I'd update with the other comments and then we can see what bauzas thinks | |
| 18:13:54 | dansmith | it's just such a large cut of things all over the API | |
| 18:15:36 | whoami-rajat | I can understand it's a burden to review it but having no prior experience working in nova, I also don't have much ideas to do it in a better way | |
| 18:15:53 | whoami-rajat | I will update with the given tests (and continue work on the tempest test) until then | |
| 18:16:00 | whoami-rajat | s/tests/comments | |
| 18:16:05 | dansmith | yep, sounds good | |
| 18:16:19 | whoami-rajat | cool, thanks! | |
| 18:17:06 | whoami-rajat | dansmith, i think we also have novaclient release this week right? | |
| 18:17:48 | dansmith | I dunno, but seems likely | |
| 18:18:26 | whoami-rajat | So i also have a novaclient patch modifying the rebuild command https://review.opendev.org/c/openstack/python-novaclient/+/827163 | |
| 18:18:42 | whoami-rajat | it's currently failing on docs since it can't find MV 2.91 in docs (will be available after API patch merges) | |
| 18:19:22 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 18:19:23 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 18:19:28 | dansmith | whoami-rajat: okay I would have thought depends-on would take care of that, but yeah if it's just the doc failure that's easy to overlook | |
| 18:20:55 | whoami-rajat | I had the same thought and I'm not sure how this has worked in the past since every client change (having MV bump) requires API change to merge first | |
| 18:22:41 | dansmith | yeah | |
| 18:22:53 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 18:25:02 | chateaulav | have a good day everyone, I have the emulation ci running now to see if it corrects the IDE error, and will have that finished tomorrow | |
| 20:12:05 | opendevreview | Merged openstack/nova master: Update live_migration_downtime definition https://review.opendev.org/c/openstack/nova/+/828387 | |
| 20:38:38 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 23:42:07 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 23:45:12 | sean-k-mooney[m] | depends-on does not work for tox but it can work for devstack based test if the project is listed in the jobs required_projects | |
| 23:47:33 | sean-k-mooney[m] | so yes if you are working on a client change the api change need to merge first if you are dont test that alls the api or otherwise depend on the microversion unless you have mocked the nova api | |
| #openstack-nova - 2022-02-24 | |||
| 00:22:12 | clarkb | sean-k-mooney[m]: it actually can be made to work with tox | |
| 00:22:18 | clarkb | but ya a lot of projects don't bother with that | |
| 00:22:30 | clarkb | (we have what we call tox siblings support in the tox jobs which enables this) | |
| 01:02:21 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Register defaults for undefined hw image properties https://review.opendev.org/c/openstack/nova/+/800708 | |
| 01:02:22 | opendevreview | melanie witt proposed openstack/nova master: manage: Add image_property commands https://review.opendev.org/c/openstack/nova/+/824392 | |
| 01:07:58 | opendevreview | Ghanshyam proposed openstack/nova master: Add DB and scheduler filter method for getting nodes,RP https://review.opendev.org/c/openstack/nova/+/830704 | |
| 04:32:20 | melwitt | gibi: I respun https://review.opendev.org/c/openstack/nova/+/824392 and https://review.opendev.org/c/openstack/nova/+/800708 to address stephenfin's comments | |
| 04:32:51 | melwitt | gibi: also the top two unified limits patches have +2 from bauzas if you might be able to take a look | |
| 04:46:23 | opendevreview | Ghanshyam proposed openstack/nova master: API change to allow project admin to boot server on specific host https://review.opendev.org/c/openstack/nova/+/830543 | |
| 07:55:13 | gibi | melwitt: o/ sure I will take look at both | |
| 09:04:00 | yuval | Guys good morning | |
| 09:04:33 | gibi | yuval: o/ good morning | |
| 09:04:41 | yuval | this have +1 from zuul passed lightbits ci and +2 from gibi, can another core check it out: https://review.opendev.org/c/openstack/nova/+/821606 | |
| 09:05:06 | yuval | today is the deadline right? | |
| 09:05:21 | gibi | yuval: yes, today is the deadline | |
| 09:05:28 | yuval | ok | |
| 09:05:37 | gibi | but I think you are in a good position | |
| 09:06:12 | yuval | thank you | |
| 10:20:01 | bauzas | yuval: gibi: looking at it | |
| 11:00:55 | bauzas | sean-k-mooney: ha | |