Earlier  
Posted Nick Remark
#openstack-nova - 2022-02-22
16:21:49 bauzas but,
16:22:09 bauzas as you can look at the comments, we saw it was actually a feature
16:22:51 bauzas that's why I accepted to have a discussion in this meeting to see whether folks accept to merge this one even if we had not accepted the blueprint before
16:23:08 bauzas for the moment, there is a procedural -2 from me
16:23:38 bauzas but if folks agree here to have an exception for https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath as a specless bp, then I could remove it
16:24:07 bauzas now, the question : is https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath a specless BP and are folks accepting it as a exception ?
16:24:54 gibi I've nothing against it. It is just a volume driver so no spec needed. And the change is really small
16:25:12 bauzas correct
16:26:02 bauzas change is small and only touching a very few places
16:26:27 sean-k-mooney i am supprotive fo doign it as a specless blueprint
16:26:42 bauzas ok, anyone having concern ?
16:26:45 sean-k-mooney its after teh cutoff but the scale of it is small enought that i think an excption can be made
16:26:55 bauzas yeah
16:27:08 opendevreview Merged openstack/placement master: Extend the RP db query to support any-traits https://review.opendev.org/c/openstack/placement/+/825848
16:27:10 opendevreview Merged openstack/placement master: DB layer should only depend on trait id not names https://review.opendev.org/c/openstack/placement/+/826490
16:27:12 bauzas basically we have deadlines for accepted blueprints because they change lots of things
16:27:13 opendevreview Merged openstack/placement master: Enhance doc of _get_trees_with_traits https://review.opendev.org/c/openstack/placement/+/825780
16:27:16 opendevreview Merged openstack/placement master: Extend the RP tree DB query to support any-traits https://review.opendev.org/c/openstack/placement/+/825849
16:27:18 opendevreview Merged openstack/placement master: Add any-traits support for listing resource providers https://review.opendev.org/c/openstack/placement/+/826491
16:27:45 bauzas so we're procedural not for the sake of being it, but for making sure we are sure how this works
16:27:57 bauzas here, I don't see a problem
16:28:04 gibi I agree
16:29:00 bauzas ok so,
16:30:25 bauzas #agreed specless BP for https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath as an exception
16:30:35 bauzas liorf95: I'll then remove my -2
16:30:41 bauzas and +W it
16:30:45 bauzas that's it I had
16:31:00 liorf95 Thanks a lot for your efforts here
16:33:28 bauzas any other topic to discuss as a last minute ?
16:33:36 gibi -
16:34:16 bauzas looks not
16:34:18 bauzas thanks all
16:34:22 bauzas #endmeeting
16:34:22 opendevmeet Meeting ended Tue Feb 22 16:34:22 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
16:34:22 opendevmeet Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-22-16.02.html
16:34:22 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-22-16.02.txt
16:34:22 opendevmeet Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-22-16.02.log.html
16:34:23 gibi thanks
16:34:28 elodilles thanks bauzas o/
16:34:30 liorf95 Thanks
16:34:45 gibi sean-k-mooney: just a reminder you only left +1 on https://review.opendev.org/c/openstack/placement/+/82649 yesterday :)
16:35:34 chateaulav thanks o/
16:35:47 gmann thanks
16:38:53 gibi kashyap: https://logserver.rdoproject.org/83/38983/2/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset035-victoria/67d64d4/logs/undercloud/var/log/tempest/stestr_results.html.gz the tempest logs does not contain either the server uuid or the request id for the snapshot command :/
16:39:01 gibi I cannot correlate the logs :/
16:39:01 kashyap gibi: Good news!
16:39:04 gibi oh
16:39:18 kashyap gibi: I just talked to Peter Krempa on #virt, he already identified it as a libvirt bug ...
16:39:22 kashyap gibi: The problem is this, in short:
16:39:55 kashyap [quote]
16:39:56 kashyap libvirt has a piece of code which ensures that thh backing image of the reused destination image is added only when finishing the job. On cancellation of the [copy] job, we want to unplug the image, but the backing image was not yet plugged in.
16:40:00 kashyap [/quote]
16:40:08 kashyap It assumes a bit of libvirt storage knowledge, but Peter is already working on a fix
16:41:13 kashyap gibi: I'm filing RHEL bugs to get it backported to CentOS 8 and 9
16:41:43 gibi awesome
16:41:48 gibi thanks for the info
16:44:53 kashyap gibi: But Peter is again asking what is the test "exactly doing"
16:44:57 kashyap Is this exactly it?
16:45:02 kashyap "boot servers, then snapshot the server and upload the image to Glance"
16:45:27 kashyap Did you mean boot a "server", as opposed to plural?
16:47:36 gibi kashyap: create a server, and then create a snapshot
16:47:45 gibi kashyap: the test case itself create multiple servers
16:48:04 kashyap I see
16:57:14 kashyap gibi: https://bugzilla.redhat.com/show_bug.cgi?id=2057067
16:57:28 kashyap gibi: But Peter also says there might be another issue too, because:
16:57:40 kashyap ... "this is on a code path that can't propagate errors to the caller"
16:57:48 kashyap gibi: Anyway, he posted a patch here: https://listman.redhat.com/archives/libvir-list/2022-February/msg00790.html
17:19:45 gibi kashyap: ack. I would need a tripleoo job result where I can correlate logs better to be able to look more into it
17:20:03 gibi kashyap: I serched for the QEMU error in the upstream nova job results and there is a lot of hit
17:20:16 gibi but I guess it is a generic error message
17:20:51 gibi as the QEMU error does not correlate with the tempest test failure
17:21:11 gibi I stop for today but happy to help tomorrow if there are things to look at
18:53:42 opendevreview Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368
18:53:58 opendevreview Merged openstack/nova master: Support use_multipath for NVME driver https://review.opendev.org/c/openstack/nova/+/823941
19:18:20 opendevreview Dmitrii Shcherbakov proposed openstack/nova master: Fix migration with remote-managed ports & add FT https://review.opendev.org/c/openstack/nova/+/829974
19:33:25 opendevreview Rajat Dhasmana proposed openstack/python-novaclient master: Add parameter to rebuild boot volume https://review.opendev.org/c/openstack/python-novaclient/+/827163
19:37:04 whoami-rajat dansmith, Hey, if you get some time, can you take a look at my feature patches?
19:37:06 whoami-rajat nova: https://review.opendev.org/c/openstack/nova/+/820368
19:37:11 whoami-rajat novaclient: https://review.opendev.org/c/openstack/python-novaclient/+/827163
19:37:53 dansmith whoami-rajat: ah I didn't see that you had updated them.. is it working now?
19:39:33 dansmith whoami-rajat: ah I didn't see that you had updated them.. is it working now?
19:39:45 dansmith whoami-rajat: I assume you've got a tempest patch somewhere (or planned) to poke it
19:39:46 dansmith ?
19:40:28 opendevreview Merged openstack/placement master: Add any-traits support for allocation candidates https://review.opendev.org/c/openstack/placement/+/826492
19:40:40 whoami-rajat dansmith, just updated everything and yes it is working now. thanks!
19:41:01 opendevreview Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053
19:41:01 opendevreview Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372
19:41:04 whoami-rajat dansmith, I've mostly tested this manually but i can work on a tempest test, the problem is deadline is close
19:41:30 whoami-rajat dansmith, If i can get an FFE or propose the test after feature freeze then it will be great
19:42:18 dansmith I mean, I think a tempest test should be part of the requirements here.. was that not in the spec for this?
19:42:41 dansmith I would think it'd be easy right? take an existing rebuild test, make it use BFV, and pass the right version on rebuild?
19:43:25 dansmith if the tempest test shows it works and just needs some work after the deadline to get it into a merge-able shape, I think that's fine
19:44:15 whoami-rajat sure, I haven't looked at existing tests but if there's already one for rebuild, it should be pretty straightforward
19:44:40 dansmith yeah, tempest test is in the testing section of the spec...
19:48:15 whoami-rajat dansmith, I will try and get something working by tomorrow
19:48:21 dansmith ack
19:48:35 whoami-rajat thanks!
20:20:05 opendevreview Merged openstack/placement master: Remove unused compatibility code https://review.opendev.org/c/openstack/placement/+/826493
20:23:53 opendevreview Merged openstack/placement master: Add microversion 1.39 to support any-trait queries https://review.opendev.org/c/openstack/placement/+/826719
20:26:12 gmann dansmith: rbac series is ready, added release notes also in last patch please check if that is ok https://review.opendev.org/q/topic:bp/policy-defaults-refresh-2+status:open

Earlier   Later