| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-17 | |||
| 12:30:22 | sean-k-mooney | yes in some places | |
| 12:30:31 | gibi | ahh so they have some thight loops | |
| 12:30:41 | gibi | then those needs some careful yields | |
| 12:30:59 | sean-k-mooney | https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/lightos.py#L164-L182 | |
| 12:31:38 | sean-k-mooney | so this yeild because monitor_db does some writes to a file and those sleeps | |
| 12:32:11 | sean-k-mooney | monitor_message_queue wont yeild unless the log satement casue it to happen | |
| 12:32:29 | sean-k-mooney | but it will terminate when the queue is empty | |
| 12:32:52 | gibi | I see | |
| 12:33:41 | sean-k-mooney | isci is potentally worse | |
| 12:33:43 | sean-k-mooney | https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L723-L780 | |
| 12:34:04 | sean-k-mooney | it spawns a bunch of threds then joins in the multipath code | |
| 12:34:47 | sean-k-mooney | the join shoudl cause a yeild and those threads will be interleaved with nova | |
| 12:35:11 | sean-k-mooney | but this type of raw threadign is really not a good thing with eventlets in the mix | |
| 12:35:31 | gibi | jeah that seem a lot more complex. but still it works or we would have strange bugs | |
| 12:35:36 | sean-k-mooney | they also have sleeps https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L777 | |
| 12:36:35 | sean-k-mooney | ya so that will do io an dthe sleep will yeild which the do on each iteration | |
| 12:37:11 | sean-k-mooney | i just think the use of thread in general in os-brick is problematic | |
| 12:45:37 | opendevreview | Imran Hussain proposed openstack/nova master: [nova/libvirt] Support for checking and enabling SMM when needed https://review.opendev.org/c/openstack/nova/+/825496 | |
| 14:15:22 | IPO | Hello, all ! What are the next steps toward https://review.opendev.org/c/openstack/nova/+/805649 ? Or it is ok,it is needed just wait a bit ? | |
| 14:18:37 | gibi | IPO: I guess we need a second core | |
| 14:18:58 | gibi | sean-k-mooney: you were +2 before on that patch ^^ | |
| 14:26:57 | IPO | gibi: I see, thanks for info ! | |
| 14:42:29 | yuval_ | sean-k-mooney other the monitor thread - anything is a concern? | |
| 15:05:15 | sean-k-mooney | yuval_: that is my main one. | |
| 15:06:32 | sean-k-mooney | yuval_: gibi listed other issue liek py2 support ectra inline | |
| 15:07:15 | sean-k-mooney | yuval_: so other then the monitor thread and the comments that gibi has already reaied i dont really have other issues with it | |
| 15:11:52 | bauzas | melwitt: gibi: question about InstanceMapping records vs. shelved-offloaded instances and how we quota them | |
| 15:12:01 | bauzas | melwitt: gibi: https://review.opendev.org/c/openstack/nova/+/713301/34/nova/limit/placement.py#80 | |
| 15:12:42 | bauzas | iirc, we don't have quota usage for shelved-offloaded instances, right? | |
| 15:12:43 | sean-k-mooney | shelved instance shoudl consume the same quota for disk as running but they should not consume quota for cpu or ram | |
| 15:13:12 | sean-k-mooney | bauzas: it depend on if it BFV really i think | |
| 15:13:22 | bauzas | sean-k-mooney: my question is about the instances/servers quota usage | |
| 15:13:38 | sean-k-mooney | well i t should consume isntance quota | |
| 15:14:13 | sean-k-mooney | that is a limit on the number of non deleted instance you can have in the db | |
| 15:14:16 | bauzas | surely, but I don't remember about the current behaviour | |
| 15:14:18 | sean-k-mooney | its independt fo the state | |
| 15:14:34 | sean-k-mooney | it wont be tracked in placment currently | |
| 15:14:42 | sean-k-mooney | since we dont consume allocations of instance | |
| 15:14:47 | sean-k-mooney | but i guess | |
| 15:14:57 | sean-k-mooney | you coudl count allocation by consumer type maybe | |
| 15:15:39 | sean-k-mooney | when its in shelve offloaded i dont know if we still have any allcoation in placment at all | |
| 15:15:51 | sean-k-mooney | if we had local disk i think we should for storage | |
| 15:16:00 | sean-k-mooney | e.g. if you were usign the rbd image backend | |
| 15:16:15 | sean-k-mooney | but sicne we dont have a host it might not be there | |
| 15:16:46 | sean-k-mooney | melwitt: how does that work with unified limits? | |
| 15:17:22 | bauzas | sean-k-mooney: look at the change | |
| 15:17:33 | bauzas | sean-k-mooney: there is a TODO for consumer types | |
| 15:17:44 | bauzas | sean-k-mooney: for the moment, we look at instance mappings | |
| 15:17:48 | bauzas | hence my question | |
| 15:17:51 | sean-k-mooney | right but consuemr types is not enough | |
| 15:18:08 | sean-k-mooney | a shelve offloaded instance does not have a host | |
| 15:18:23 | sean-k-mooney | so it cant have allcoation against an rp today | |
| 15:18:46 | sean-k-mooney | since the only resouce usage it has are floating ips, and disk really | |
| 15:19:32 | sean-k-mooney | so without creating a RP per compute with inventories of instance,floating ip ectra we cant tack the useage in palcment | |
| 15:19:52 | sean-k-mooney | so we woudl have to tack this in keystone? | |
| 15:20:25 | bauzas | I don't know, we haven't discussed it in https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/unified-limits-nova.html | |
| 15:20:40 | bauzas | tbc, I don't want to trample this series because of this question | |
| 15:20:55 | sean-k-mooney | well for now we can just count it in nova | |
| 15:21:05 | bauzas | my only concern is about making sure we continue to have the same behaviour from the before | |
| 15:21:53 | sean-k-mooney | right so we shoudl continue to count instnace using the instance cell mapings in the nova api db proably for yoga | |
| 15:22:38 | sean-k-mooney | in Zed we could eitehr create an RP per porject with invetoires of diffent quata type like instance or tack it somewhere else | |
| 15:23:03 | sean-k-mooney | the question really is should you be able to get all usage just by looking at placment or not | |
| 15:25:29 | sean-k-mooney | bauzas: ""All the resource class usage will be counted using placement, but server count will make use of instance mappings."" | |
| 15:25:35 | sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/unified-limits-nova.html#enforcing-unified-limits | |
| 15:26:17 | bauzas | sean-k-mooney: nah I was saying about shelved instances | |
| 15:26:25 | sean-k-mooney | yes | |
| 15:26:32 | sean-k-mooney | that fact its shelved does nto change that | |
| 15:26:41 | bauzas | ok, then it was a nit | |
| 15:28:27 | sean-k-mooney | i honestly dont see an impedment to counting server ectra via sharing rps at some point in the futre if we need too or other things like floating ip that are out of scope of the current spec | |
| 15:30:25 | gibi | I agree that offloaded servers if holding floating ips then it should consume quota | |
| 15:30:55 | gibi | and yes we cannot count that with consumer types as no instance allocation exists for offloaded servers in placement | |
| 16:01:42 | melwitt | bauzas, sean-k-mooney: the tl;dr is that unified limits is not meant to have the same behavior as before. shelved offloaded will not consume quota | |
| 16:02:08 | bauzas | melwitt: cool then, I'll switch to +2 | |
| 16:09:36 | melwitt | bauzas: I dunno if you've seen this but this is one place where we document the expected differences when counting from placement https://docs.openstack.org/nova/latest/admin/quotas.html#quota-usage-from-placement | |
| 16:09:54 | melwitt | and unified limits builds on top of that | |
| 16:10:01 | bauzas | melwitt: oh thanks, I think I saw it already but forgot | |
| 16:10:17 | bauzas | my fucking brain is so bad... | |
| 16:10:18 | melwitt | and changes a few more things like no more user_id scoped quotas | |
| 16:10:41 | bauzas | and you documented the shelved thing, good | |
| 16:10:53 | bauzas | "Behavior will be different for servers in SHELVED_OFFLOADED state. A server in SHELVED_OFFLOADED state will not have placement allocations, so it will not consume quota usage for cores and ram. Note that because of this, it will be possible for a request to unshelve a server to be rejected if the user does not have enough quota available to support the cores and ram needed by the server to be unshelved." | |
| 16:11:04 | bauzas | perfect, definitely +2 once we're done with the internal meeting | |
| 16:11:37 | melwitt | yeah I aimed to document all differences for operators, it's also in the config option help and was in the release note | |
| 16:23:06 | bauzas | melwitt: my bad, I haven't yet looked at the reno change | |
| 16:23:49 | opendevreview | Felix Huettner proposed openstack/nova stable/ussuri: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/829506 | |
| 16:23:50 | melwitt | bauzas: sorry I meant the release note for the counting from placement in the past | |
| 16:24:02 | bauzas | ah | |
| 16:24:05 | bauzas | gotchaz | |
| 16:24:22 | melwitt | I was saying I tried to put the info everywhere :) | |
| 16:25:09 | melwitt | reno for the counting from placement is in this list https://docs.openstack.org/releasenotes/nova/train.html#relnotes-20-0-0-stable-train-upgrade-notes | |
| 16:35:28 | opendevreview | Julia Kreger proposed openstack/nova master: WIP Ironic - Handle instance/node host on rebalance https://review.opendev.org/c/openstack/nova/+/813897 | |
| 16:37:01 | opendevreview | Julia Kreger proposed openstack/nova master: Ironic - Don't query the API for instance counts https://review.opendev.org/c/openstack/nova/+/829613 | |
| 16:38:18 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 16:38:18 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 16:38:19 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 16:51:21 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 16:51:22 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 16:51:22 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 18:07:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Record SRIOV PF MAC in the binding profile https://review.opendev.org/c/openstack/nova/+/829248 | |
| 18:10:47 | opendevreview | Merged openstack/nova master: Document remote-managed port usage considerations https://review.opendev.org/c/openstack/nova/+/827513 | |
| 18:43:05 | sean-k-mooney | gibi: im going to call it a day there ill try and review the rest of your placment patches on monday | |