| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-09 | |||
| 18:27:22 | sean-k-mooney | but since zuul does not enforece the same restrcions | |
| 18:27:27 | sean-k-mooney | and the test pass | |
| 18:27:34 | sean-k-mooney | there is a disconenct | |
| 18:31:09 | sean-k-mooney | stephenfin: i proably dont have the brain capasity today to review https://review.opendev.org/q/topic:notifications-docs properly so ill leave the tab open and try to review them tomorrow | |
| 18:31:35 | stephenfin | sean-k-mooney: oh yeah, I just meant https://review.opendev.org/c/openstack/nova/+/828601 | |
| 18:31:43 | stephenfin | the others can wait, for sure :) | |
| 18:32:06 | sean-k-mooney | by the way im off friday and monday so if i dont get to it tomrrow ping me on tuesday and ill review them then | |
| 18:35:20 | chateaulav | sean-k-mooney: I seperated the patch into 3. As clarification on submitting them for review, do i follow this process? https://docs.opendev.org/opendev/infra-manual/latest/developers.html#adding-a-dependency | |
| 18:36:39 | sean-k-mooney | you can normally i just do "git review -t <gerrit topic>" from the top patch | |
| 18:36:51 | sean-k-mooney | so if you have the 3 commits locally | |
| 18:36:59 | sean-k-mooney | i rebase againt master | |
| 18:37:18 | sean-k-mooney | then git review -t <bp/<blueprint name> | |
| 18:37:37 | sean-k-mooney | that will submit all patches not on the target branch and update the relevent reviews | |
| 18:38:10 | sean-k-mooney | you only need to do git review -d $PARENT_CHANGE_NUMBER and git review -x $CHILD_CHANGE_NUMBER | |
| 18:38:31 | sean-k-mooney | if you are changing the base and dont want to do an rebase | |
| 18:38:40 | sean-k-mooney | or interactive rebase | |
| 18:38:53 | sean-k-mooney | chateaulav: does that make sense | |
| 18:39:50 | sean-k-mooney | chateaulav: i assume the dep you need is the os-traits bump | |
| 18:40:03 | chateaulav | https://www.irccloud.com/pastebin/S4uju6sp/ | |
| 18:40:37 | chateaulav | sean-k-mooney: the os-trait one i got. it is for the 3 patchsets within nova | |
| 18:41:10 | sean-k-mooney | ya so the simplet thing to do in your case is do git-reveiew -d <os-traits patch> | |
| 18:41:29 | sean-k-mooney | then git review -x your thee pathces | |
| 18:41:52 | sean-k-mooney | then do git review -t <topic> | |
| 18:42:03 | sean-k-mooney | but before you do that give me one sec | |
| 18:42:50 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/826675 | |
| 18:43:00 | sean-k-mooney | the os-traits patch has not merged yet and is in the ci | |
| 18:43:12 | sean-k-mooney | so whwen you do the git-review you need to ensure you do not rebase that | |
| 18:43:20 | sean-k-mooney | or it will restat the ci jobs | |
| 18:43:31 | sean-k-mooney | so either wait for that to merge which should happen this evening | |
| 18:43:48 | chateaulav | k | |
| 18:43:48 | sean-k-mooney | or when you do the finall git review pass -R i belive to prevent git review form rebasing | |
| 18:44:12 | chateaulav | that makes more sense, appreciate it. | |
| 18:44:47 | sean-k-mooney | ya so checking man git-review | |
| 18:44:50 | sean-k-mooney | -R, --no-rebase | |
| 18:45:10 | sean-k-mooney | Do not automatically perform a rebase before submitting the change to Gerrit. | |
| 18:45:13 | sean-k-mooney | When submitting a change for review, you will usually want it to be based on the tip of upstream branch in order to avoid possible conflicts. | |
| 18:45:15 | sean-k-mooney | When amending a change and rebasing the new patchset, the Gerrit web interface will show a difference between the two patchsets which contains | |
| 18:45:17 | sean-k-mooney | all commits in between. This may confuse many reviewers that would expect to see a much simpler difference. | |
| 18:45:17 | chateaulav | yeah, i have that open. | |
| 18:45:19 | sean-k-mooney | Also can be used for --compare to skip automatic rebase of fetched reviews. | |
| 18:47:26 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/822053 i the current patch right | |
| 18:47:42 | sean-k-mooney | oh you have them as 3 seperate reviews right | |
| 18:47:54 | sean-k-mooney | but not in a relation chain | |
| 18:48:07 | sean-k-mooney | ya so that is simpel to fix using the steps above | |
| 18:48:19 | chateaulav | sean-k-mooney: awesome, ill wait for tomorrow then after the merge and then submit next patchset. following that method. Thank you again! | |
| 18:48:31 | sean-k-mooney | no worries | |
| 18:48:44 | sean-k-mooney | just so you know i normaly just use an interactive rebase locally | |
| 18:49:12 | sean-k-mooney | so on the local branch you aget all the patches in the relation change working and then git review | |
| 18:49:32 | sean-k-mooney | and if you are working with other people patches as a base add -R | |
| 18:51:19 | chateaulav | Makes sense. im steadily getting super familiar with the various processes. Thanks! | |
| 18:51:55 | sean-k-mooney | i have quickly just fixed the topic by the way https://review.opendev.org/q/topic:bp%252Fpick-guest-arch-based-on-host-arch-in-libvirt-driver | |
| 18:52:21 | sean-k-mooney | so now they how up correctly although you still need to fix the git history | |
| 19:03:58 | chateaulav | ok | |
| 20:19:08 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 20:19:09 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 20:19:09 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 20:28:46 | chateaulav | sean-k-mooney: one more question if i may. so i think i got the relational aspect done. i understand what you mean now. so with working with each patchset is it best to have a different local branch for each patchset, or just one local branch and switch between the commits? anyone can chime in too, I truly appreciate all the help! | |
| 20:42:49 | opendevreview | Merged openstack/nova master: Update announce self workaround opt description https://review.opendev.org/c/openstack/nova/+/826829 | |
| 20:59:48 | opendevreview | Merged openstack/nova master: [yoga] Include pf mac and vf num in port updates https://review.opendev.org/c/openstack/nova/+/824833 | |
| 20:59:57 | opendevreview | Merged openstack/nova master: Introduce remote_managed tag for PCI devs https://review.opendev.org/c/openstack/nova/+/824834 | |
| 21:00:04 | opendevreview | Merged openstack/nova master: Bump os-traits to 2.7.0 https://review.opendev.org/c/openstack/nova/+/826675 | |
| 21:00:12 | opendevreview | Merged openstack/nova master: Add supports_remote_managed_ports capability https://review.opendev.org/c/openstack/nova/+/827839 | |
| 21:00:34 | opendevreview | Merged openstack/nova master: Filter computes without remote-managed ports early https://review.opendev.org/c/openstack/nova/+/812111 | |
| 21:00:42 | opendevreview | Merged openstack/nova master: [yoga] Add support for VNIC_REMOTE_MANAGED https://review.opendev.org/c/openstack/nova/+/824835 | |
| 21:09:13 | opendevreview | Merged openstack/nova master: requirements: Bump minimum testtools to 2.5.0 https://review.opendev.org/c/openstack/nova/+/822820 | |
| 21:09:20 | opendevreview | Merged openstack/nova master: Move optional build dependencies to 'extras' https://review.opendev.org/c/openstack/nova/+/822749 | |
| 21:09:27 | opendevreview | Merged openstack/nova master: tox: Install extras https://review.opendev.org/c/openstack/nova/+/822750 | |
| 21:32:24 | opendevreview | Merged openstack/placement master: Refactor trait normalization https://review.opendev.org/c/openstack/placement/+/825847 | |
| 21:32:30 | opendevreview | Merged openstack/nova master: docs: Document virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/792362 | |
| 21:32:36 | opendevreview | Merged openstack/nova master: doc: Correct version for virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/828601 | |
| 22:26:54 | opendevreview | melanie witt proposed openstack/nova stable/xena: libvirt: Add announce-self post live-migration workaround https://review.opendev.org/c/openstack/nova/+/825064 | |
| #openstack-nova - 2022-02-10 | |||
| 02:06:06 | spatel | Any idea what is wrong with this error - ERROR oslo_service.service oslo_messaging.exceptions.MessagingTimeout: Timed out waiting for a reply to message ID 32738247b2bc4024bd0a4e65d900729d | |
| 02:06:19 | spatel | my nova-compute throwing that error | |
| 02:06:41 | spatel | Even i rebuild my RabbitMQ from scratch | |
| 02:33:03 | spatel | to me look like a bug | |
| 02:33:27 | spatel | https://paste.opendev.org/show/bFtAhaCLfed1R3ptNr1F/ | |
| 02:39:50 | spatel | what are the option i have here? | |
| 03:01:55 | opendevreview | sean mooney proposed openstack/nova master: [WIP] add healthcheck manager to manager base https://review.opendev.org/c/openstack/nova/+/827844 | |
| 03:06:45 | spatel | sean-k-mooney are you around? | |
| 05:37:45 | opendevreview | Ghanshyam proposed openstack/nova master: Make more project level APIs scoped to project only https://review.opendev.org/c/openstack/nova/+/828670 | |
| 07:41:58 | frickler | gibi: gmann: wouldn't https://bugs.launchpad.net/devstack/+bug/1960346 rather be a nova issue than devstack? | |
| 07:48:55 | __ministry | hi all, I have a question that is: "Can we plug multiple vGPU at the same time into a compute node?" | |
| 07:49:11 | __ministry | Please, help me. | |
| 07:53:39 | gibi | frickler: it more feels like a libvirt regression between 6.0.0 and 8.0.0 but sure it is probably not a devstack issue | |
| 07:55:53 | gibi | __ministry: you probably want to plug vGPUs to the guest VMs as compute nodes are physical things so they have physical gpus plugged | |
| 07:56:23 | gibi | __ministry: I think nova support multiple pGPUs per compute as well as multiple vGPUs per guest | |
| 07:57:34 | __ministry | yep. I want know to estimate amount of devices to make order. | |
| 07:58:23 | __ministry | thank you. | |
| 08:16:03 | frickler | gibi: how confident are you that it is actually a regression and not an intentional change that nova would have to adapt to? anyway I'll assign it to nova then to find out more details | |
| 08:16:39 | gibi | frickler: yeah, you are right, as there is major version bump, it can be an intended change too | |
| 08:19:35 | __ministry | gibi: multiple physical GPUs which vGPU supported in a compute node, we can? | |
| 08:20:05 | gibi | __ministry: I think so. bauzas do we have limitations around that ^^ ? | |
| 08:21:12 | bauzas | __ministry: gibi: which exact question do you want to know about vGPUs ? | |
| 08:21:47 | gibi | bauzas: as far as I understand __ministry asking in nova supports multiple pGPUs providing vGPUs in a single compute | |
| 08:21:49 | bauzas | most of the limitations are written here https://docs.openstack.org/nova/latest/admin/virtual-gpu.html#caveats | |
| 08:22:01 | bauzas | gibi: oh this totally works | |
| 08:22:37 | bauzas | sometimes with some GPU board (like a Tesla T-something) you actually get more than 1 pGPU per board :) | |
| 08:23:02 | bauzas | since stein, we just create a resource provider per physical PCI device, that's it | |
| 08:23:07 | __ministry | I want plug multiple vGPU to a nova instance. | |
| 08:23:16 | bauzas | oh then the other way around | |