| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-05 | |||
| 17:01:05 | opendevreview | Takashi Kajinami proposed openstack/placement master: db: Remove use of non-integer/slice indices https://review.opendev.org/c/openstack/placement/+/801104 | |
| 17:01:06 | opendevreview | Takashi Kajinami proposed openstack/placement master: db: Replace deprecated 'FromClause.select().whereclause' parameter https://review.opendev.org/c/openstack/placement/+/801105 | |
| 17:01:06 | opendevreview | Takashi Kajinami proposed openstack/placement master: db: Use explicit transactions https://review.opendev.org/c/openstack/placement/+/801106 | |
| 17:01:08 | opendevreview | Takashi Kajinami proposed openstack/placement master: db: Remove unnecessary use of '_mapping' https://review.opendev.org/c/openstack/placement/+/801107 | |
| 17:01:08 | opendevreview | Takashi Kajinami proposed openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | |
| 17:21:37 | opendevreview | Takashi Kajinami proposed openstack/os-resource-classes master: setup.cfg: Replace dashes by underscores https://review.opendev.org/c/openstack/os-resource-classes/+/828009 | |
| #openstack-nova - 2022-02-06 | |||
| 12:00:57 | opendevreview | Ilya Popov proposed openstack/nova master: Fix to implement 'pack' or 'spread' VM's NUMA cells https://review.opendev.org/c/openstack/nova/+/805649 | |
| #openstack-nova - 2022-02-07 | |||
| 07:20:39 | opendevreview | Attila Fazekas proposed openstack/nova master: Note the deleyad address view https://review.opendev.org/c/openstack/nova/+/827856 | |
| 08:34:30 | yuval | Hey is there any special keyword I can reply to my patch to make zuul re-test my patch? | |
| 08:36:45 | gibi | yuval: say: recheck <reason, e.g. the bug number your patch hit> | |
| 08:42:07 | yuval | gibi: in this chat or on the gerrit gui? | |
| 08:42:25 | gibi | yuval: in gerrit as a reply | |
| 08:42:30 | yuval | thanks | |
| 10:27:53 | opendevreview | Merged openstack/nova master: docs: Follow-ups for cells v2, architecture docs https://review.opendev.org/c/openstack/nova/+/827336 | |
| 11:25:36 | opendevreview | Tobias Urdin proposed openstack/nova master: Update announce self workaround opt description https://review.opendev.org/c/openstack/nova/+/826829 | |
| 11:34:38 | gibi | sean-k-mooney: hi! I'm +2 on the off-path networking series now | |
| 11:35:00 | sean-k-mooney | ack that is nice to hear | |
| 11:39:38 | gibi | sean-k-mooney: also looked at your healthcheck wip patch and left some notes | |
| 11:51:41 | sean-k-mooney | thanks i need to spend more time on that in general but once i have the basic infra working adding the checks should be fairly quick | |
| 12:00:37 | gibi | yepp | |
| 12:03:43 | sean-k-mooney | im currenly thinking about what to keep and what to factor out into the resoucetracker class or whatever i end up calling it | |
| 12:04:03 | sean-k-mooney | but looking a the current manager ther eare clearly 2 types of functiosn and data | |
| 12:04:16 | gibi | yes | |
| 12:04:30 | gibi | that run method makes it an active component, but also it encapsulates some response data | |
| 12:05:01 | sean-k-mooney | ya so run sleep and generating the responce feel like tehy should all be on one class | |
| 12:05:19 | sean-k-mooney | and the data storage and querying its state shoudl be in anohter | |
| 12:06:16 | sean-k-mooney | gibi: i did not quite understand what you ment by https://review.opendev.org/c/openstack/nova/+/825015/3/nova/healthcheck/manager.py#31 | |
| 12:08:15 | sean-k-mooney | i always split imports into 8 groups , standar lib, external lib, openstack libs, nova and in each of those 4 i split into imports then from x import | |
| 12:09:33 | sean-k-mooney | were you saying that i have split it into more groups then you were expecting or something else? | |
| 12:10:24 | gibi | sean-k-mooney: I meant that in nova I see 3 groups: stdlib, 3pp lib, repo local import | |
| 12:10:35 | gibi | sean-k-mooney: but I have no real problem with more groups | |
| 12:11:16 | gibi | so feel free to ignore that command | |
| 12:11:19 | gibi | *comment | |
| 12:20:36 | sean-k-mooney | gibi: i use the same groups in nova for my other work | |
| 12:21:03 | sean-k-mooney | hacking allows both i really hate when we mix from and import in the same group | |
| 12:21:25 | gibi | OK, I can adapt to it per file :) | |
| 12:21:30 | sean-k-mooney | i used to go fix that but now i more or less deal with the impoort confution | |
| 12:22:07 | sean-k-mooney | i find it really diffuct to parse how i should order things when you mix the import and from together | |
| 12:22:48 | sean-k-mooney | i have considered proposing we us automatic import sorting at one point but there are more importnat hills to die on | |
| 12:24:10 | sean-k-mooney | gibi: but effectivly you were suggestign treating openstack libs and third party python libs the same | |
| 12:25:26 | gibi | sean-k-mooney: our current nova style do so. I have no hard feelings either way | |
| 12:25:36 | sean-k-mooney | we are not super consitent with that | |
| 12:25:57 | sean-k-mooney | sometimes we include evently in the standardlib section :) | |
| 12:27:21 | sean-k-mooney | if people want me to change it i can but ill leave it for now until i have it working end to end | |
| 12:29:47 | gibi | leave it :) | |
| 12:30:01 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Update 'select()' calls https://review.opendev.org/c/openstack/placement/+/801103 | |
| 12:30:02 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove use of non-integer/slice indices https://review.opendev.org/c/openstack/placement/+/801104 | |
| 12:30:02 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace deprecated 'FromClause.select().whereclause' parameter https://review.opendev.org/c/openstack/placement/+/801105 | |
| 12:30:03 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Use explicit transactions https://review.opendev.org/c/openstack/placement/+/801106 | |
| 12:30:03 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove unnecessary use of '_mapping' https://review.opendev.org/c/openstack/placement/+/801107 | |
| 12:30:04 | opendevreview | Stephen Finucane proposed openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | |
| 12:30:04 | opendevreview | Stephen Finucane proposed openstack/placement master: tests: Restore - don't reset - warning filters https://review.opendev.org/c/openstack/placement/+/828119 | |
| 12:31:01 | sean-k-mooney | hehe speaking of placement ^ gibi how is you any trait series coming | |
| 12:32:27 | stephenfin | sean-k-mooney: I'd appreciate reviews on that, btw :) It's all very simple stuff but preps us for sqla 2.0 | |
| 12:32:44 | stephenfin | Need to find time to finish the equivalent nova series /o\ | |
| 12:33:23 | sean-k-mooney | stephenfin: ack i can take a look. im going to try an go thorugh the off path seires this morning maybe this afternoon | |
| 13:01:11 | gibi | sean-k-mooney: melwitt gave +2 on the next patch in the any-traits series | |
| 13:01:20 | gibi | sean-k-mooney: you your eyese are appreciated there too :) | |
| 13:05:56 | bauzas | folks, I'm a bit on and off today, I think I'm impacted by the COVID | |
| 13:07:00 | elodilles | ohh, bauzas get well soon :S | |
| 13:08:34 | elodilles | (i just wanted to ask for a stable review, but then i won't disturb you with that :S) | |
| 13:08:56 | gibi | bauzas: take care! | |
| 13:09:16 | gibi | bauzas: if you need I can cover you tomorrow on the weekly meeting | |
| 13:09:59 | bauzas | gibi: no, unfortunately in France if you're impacted but you WFH, they don't give you some offtime | |
| 13:10:26 | gibi | that sounds bad | |
| 13:10:49 | gibi | anyhow I'm not bound by the french law so I can still cover you if you want :) | |
| 13:16:21 | opendevreview | Tobias Urdin proposed openstack/nova master: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/827865 | |
| 13:16:27 | bauzas | for the moment, I don't have a lot of issues, just some cough, a sore throat and nose blowing | |
| 13:18:00 | bauzas | like if it was a small rhinitis | |
| 13:19:34 | bauzas | fwiw, my daughter got the same on Tuesday and we saw the positif test on Wed so I tested myself too on Wed morning with a selftest, then an antigenic test on Wed evening, and then a PCR test on Thursday | |
| 13:19:41 | bauzas | eventually a last selftest on Friday | |
| 13:19:46 | bauzas | all of them were negative | |
| 13:20:27 | bauzas | but yesterday evening, I selftested again (ie. after 5 days of being negative) and eventually it was positive :( | |
| 13:20:38 | bauzas | hence the PCR test today | |
| 13:20:59 | bauzas | so, see, maybe testing yourself up to J+4 doesn't work | |
| 13:21:11 | bauzas | D+4 I mean | |
| 13:22:31 | gibi | yeah | |
| 13:22:39 | gibi | I heard similar stories | |
| 13:25:06 | bauzas | from what I read, this is specific to Omicron | |
| 13:25:20 | bauzas | for Delta, this worked | |
| 13:25:57 | bauzas | but now, symptoms arrive before the viral charge | |
| 13:26:07 | bauzas | or at the same time | |
| 13:26:41 | bauzas | so, previously, testing yourself at D+3 was verifying your viral charge | |
| 13:28:18 | bauzas | while now, your viral charge would only arrive around D+5 | |
| 13:28:31 | bauzas | the more people know, the better it will be | |
| 13:40:06 | sean-k-mooney | dmitriis: -1 for https://review.opendev.org/c/openstack/nova/+/824833/7/nova/network/neutron.py#1527 | |
| 13:40:39 | dmitriis | sean-k-mooney: looking | |
| 13:41:18 | sean-k-mooney | tl;dr we cant assume a PF has a netdev | |
| 13:41:37 | sean-k-mooney | so you cant assume it has a mac | |
| 13:42:06 | sean-k-mooney | your new fucntion will be called for all VFs not just remote managed ones | |
| 13:42:12 | sean-k-mooney | so you need to not raise | |
| 13:42:28 | sean-k-mooney | just dont include the info if it cant be recived | |
| 13:42:36 | sean-k-mooney | *retrived | |
| 13:43:45 | dmitriis | sean-k-mooney: yeah, a PF can be something else, much like a PF with a netdev can have non-netdev VFs | |
| 13:43:47 | dmitriis | good point | |
| 13:44:28 | sean-k-mooney | we broke this in the past | |
| 13:44:59 | sean-k-mooney | by always trying to get the netdev name for bandwith qos and i broke it differently in a different bugfix | |
| 13:45:07 | sean-k-mooney | so we have been bitten by it twice | |
| 13:46:40 | sean-k-mooney | dmitriis: actully just to reinforce that you cant assume all VFs are nics | |
| 13:46:58 | gibi | ohh, I knew that we cannot assume that netdev exists but I did not realized that to get the MAC we need the netdev | |