Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2022-02-01
15:05:24 gibi dmitriis: ack, I will check back at some point
15:15:48 gibi sean-k-mooney: when you read further into the smartnic series, I would like to see your opinion about the dynamicy capability handling at https://review.opendev.org/c/openstack/nova/+/812111/16/nova/compute/resource_tracker.py#1176 I have not problem with it but it is someting new
15:16:47 sean-k-mooney dynamicy capability handeling?
15:17:06 opendevreview Jonathan Race proposed openstack/nova master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053
15:17:21 sean-k-mooney oh the traits reporting
15:17:21 artom Is "'name': old_flavor['name'] + 'extra-' + data_utils.rand_int_id(),
15:17:21 artom TypeError: can only concatenate str (not "int") to str" a known thing
15:17:27 artom Happening in nova-next
15:17:51 sean-k-mooney gibi: we have something simiarl i belive else where but slightly less clever in implemenation
15:17:56 artom Looks like a Tempest code error, perhaps data_utils.rand_int_id() changed to return an int or something, but I feel like if it was tempest it would be all over the place
15:18:24 gibi artom: that logic is a recent addition in tempest
15:18:52 sean-k-mooney artom: so ya that looks like it shoudl have a str() call
15:18:59 artom gibi, ah, right, cae966812a4a5070c3e7f82d16ebe697da57e5c5
15:19:04 sean-k-mooney althoguh personally i woudl be tempted to use an fstring
15:19:04 artom Well, it's breaking nova-next
15:19:12 gibi yepp you were faster finding it
15:19:23 gibi artom: thanks
15:20:00 sean-k-mooney the fix is firly simple just use sting interpulation of fstring instead fo concationation or cast
15:20:01 gibi sean-k-mooney: cool
15:20:58 sean-k-mooney normally we do simple things like this https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L395-L420
15:20:59 gibi artom: the orginal tempest fix did not trigger nova-next (or an ovs full tempest from neutron) and therefore the test case that is changed was not run for the tempest patch
15:21:19 artom Yeah, all good. Quick enough fix
15:21:30 artom It'll take me longer to file the LP bug than changing the code :P
15:21:41 sean-k-mooney but we also build trait dymically like this https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8412-L8434
15:21:52 gibi artom: please add a DNM patch in nova that depends on the tempest fix to see nova-next is green after it :)
15:21:58 sean-k-mooney gibi: is your concern that htis is a mor dynimic capblity
15:22:03 sean-k-mooney not just a dynmic trait
15:22:04 artom gibi, good idea
15:22:15 gibi sean-k-mooney: this is a new thing and it will create precedent
15:22:32 gibi sean-k-mooney: I mean that we dinamically apply capability based on resource inventory
15:23:19 gibi sean-k-mooney: so I'd like to make a conscious introducing it
15:23:21 sean-k-mooney oh as in it only reports the trait when we have a pool that support it
15:23:26 gibi yepp
15:23:41 sean-k-mooney right
15:23:50 gibi but personally I have no problem with it
15:24:01 sean-k-mooney well we technially dont need to do that actully
15:24:05 sean-k-mooney i dont really either
15:24:16 sean-k-mooney but we coudl jsut always report it
15:24:20 sean-k-mooney if the host support it
15:24:34 gibi it is basically indirectly config driver (by the whitelist config) and we already have config driven capabilities
15:24:37 sean-k-mooney the inventory check is going to be enforce by the pci filter after the fact
15:24:48 gibi s/driver/driven/
15:24:50 sean-k-mooney yes we do
15:25:07 sean-k-mooney the main advantage to having it is the filtering will partly be done by placment
15:25:44 gibi yepp
15:25:47 gibi that is a good thing
15:25:59 sean-k-mooney the smart nics port dont have inventories in placement currntly but this will at least find host with them in the resouce tracker
15:26:25 sean-k-mooney so ya in the long run i agree i think this better and also that yes this is a new thing and setting precident
15:26:46 gibi awesome, then we are on the same page
15:27:24 sean-k-mooney am since we are talking about pci i agree with you regfarding the pack/spread change. i raised the behaivor delta in a prevous version
15:28:06 gibi ohh, cool then
15:28:21 sean-k-mooney i kind fo feel like we shoudl ignore the pack config option for pci devices for backward compatiablity with the excption that if you ask for one we shoudl actully prefer the nodes with pci devices
15:28:37 sean-k-mooney today we dont prefer if you ask for a pci device we jsut avoid if we dont
15:29:13 opendevreview Artom Lifshitz proposed openstack/nova master: DNM: Test fix for bug 1959682 https://review.opendev.org/c/openstack/nova/+/827306
15:29:15 sean-k-mooney i had said in the previous version i was ok with debating that in a followup if others agreed to mvoe it forward
15:29:30 sean-k-mooney i have remvoed my +2 for now so we can disucss it in the patch
15:31:03 gibi ok
15:46:46 opendevreview Jonathan Race proposed openstack/nova master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053
15:50:25 bauzas reminder : nova meeting here in 10 mins
15:57:05 bauzas elodilles: no agenda for stable branches ?
15:59:40 elodilles bauzas: well, i forgot to update it well before you so i waited a bit... maybe for too long o:) sorry :)
15:59:47 bauzas elodilles: just do it now
15:59:49 bauzas I'll refresh
15:59:52 elodilles let me update it quickly :)
15:59:59 elodilles (not so much to update)
15:59:59 bauzas #startmeeting nova
15:59:59 opendevmeet Meeting started Tue Feb 1 15:59:59 2022 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:59:59 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:59:59 opendevmeet The meeting name has been set to 'nova'
16:00:06 bauzas hello everybody
16:00:13 bauzas #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
16:00:21 elodilles o/
16:00:25 chateaulav \o
16:00:33 gibi o/
16:01:34 bauzas ok let's start, should be quick hopefully
16:01:45 bauzas #topic Bugs (stuck/critical)
16:01:50 bauzas #info No Critical bug
16:01:54 bauzas #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 39 new untriaged bugs (+3 since the last meeting)
16:01:58 bauzas #help Nova bug triage help is appreciated https://wiki.openstack.org/wiki/Nova/BugTriage
16:02:02 bauzas #link https://storyboard.openstack.org/#!/project/openstack/placement 27 open stories (+2 since the last meeting) in Storyboard for Placement
16:02:08 bauzas I need to do a bit of triage
16:02:28 bauzas but working on Tempest trampled me
16:02:57 bauzas anyway, we'll discuss about the new gate failure bug after this topic
16:03:08 bauzas any other bug to want to discuss ?
16:03:24 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: live-migration: only wait for external events for active VIFs https://review.opendev.org/c/openstack/nova/+/827314
16:04:02 bauzas looks not
16:04:07 bauzas #topic Gate status
16:04:12 bauzas #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs
16:04:35 bauzas gibi: do you want to discuss about https://bugs.launchpad.net/nova/+bug/1959677 ?
16:04:37 ganso o/
16:04:44 gibi bauzas: nope
16:04:48 gibi bauzas: I had not time to investigate
16:04:56 gibi bauzas: just so it happening and reported it
16:04:56 bauzas okay
16:05:03 bauzas I'll triage it btw.
16:05:05 artom Someone needs to tag https://bugs.launchpad.net/tempest/+bug/1959682 as a Nova gate failure, I don't have Tempest bug tagging powers
16:05:50 gibi artom: I added the tag but that does not mean much as the bug is against tempest project
16:06:09 gibi artom: btw, somebody was faster than you proposing the fix
16:06:13 bauzas is it a problem for nova ?
16:06:13 artom Yeah, and anyways it should go away quickly enough

Earlier   Later