| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-01-26 | |||
| 14:34:39 | sean-k-mooney | speaking to people internally we are hoping that a new live migration capablity will be reported via sysfs which can then be reported by libvirt or quired by nova. | |
| 14:35:20 | sean-k-mooney | both the dest and source host have a new enough kernel and qemu then nova could allow the migratoin to proceed but right now its not possibel to transfer the guest vgpu state as part of the live migration | |
| 14:35:38 | sean-k-mooney | gsantos: so your only option is too use cold migration today | |
| 14:37:05 | gsantos | sean-k-mooney: ah, I see. I was afraid that there would be no workarounds for it :( but thank you very much for the info | |
| 14:45:45 | opendevreview | sean mooney proposed openstack/placement master: update placement for os-traits 2.7.0 release https://review.opendev.org/c/openstack/placement/+/826478 | |
| 14:46:05 | sean-k-mooney | gibi ^ | |
| 14:46:48 | sean-k-mooney | actully this wont pass without the upperconstrait change but the upper constratit change can merge without this | |
| 14:46:53 | sean-k-mooney | how do we resolve that | |
| 14:47:27 | gibi | sean-k-mooney: in the past I did that like this https://review.opendev.org/c/openstack/placement/+/805830 | |
| 14:47:49 | gibi | so a single patch | |
| 14:48:13 | sean-k-mooney | that wont work or at least should not | |
| 14:48:39 | sean-k-mooney | it shoudl still get clamped by https://github.com/openstack/placement/blob/master/tox.ini#L17 | |
| 14:49:07 | gibi | it worked in the past, what changed? | |
| 14:49:20 | sean-k-mooney | so if i raise it which i realise i should in requirements and lower-constratis the upper constraits will still clamp it | |
| 14:49:32 | sean-k-mooney | gibi: we likely did not have placment functional in the requirements repo | |
| 14:49:43 | gibi | hm | |
| 14:51:05 | sean-k-mooney | ill make those chagnes quickly but i expect it to not be able to install the tox env when i do | |
| 14:52:39 | opendevreview | sean mooney proposed openstack/placement master: update placement for os-traits 2.7.0 release https://review.opendev.org/c/openstack/placement/+/826478 | |
| 14:53:47 | gibi | yepp we did not have placement functional job in the req repo last time | |
| 14:54:17 | gibi | so I think we need to 1) disable the test 2) merge the req bump 3) enable the test | |
| 14:54:26 | gibi | or change the test to e more forgiving | |
| 15:01:23 | gsantos | sean-k-mooney: just out of curiosity, since live migrating doesn't work with mdevs, would it work with pci-passthrough? | |
| 15:02:03 | sean-k-mooney | gsantos: no for the same reason | |
| 15:02:15 | sean-k-mooney | we have a hack for neutron sriov ports | |
| 15:02:42 | sean-k-mooney | where if ti addev via a macvtap devie we allow it or if its a direct assinged sriov port we will do a detach and attach | |
| 15:03:02 | sean-k-mooney | gsantos: for nics thats kind of ok since you can do bonding to cover the gap | |
| 15:03:09 | sean-k-mooney | but for anything else its not really ok | |
| 15:04:18 | gsantos | ack thanks | |
| 15:04:32 | sean-k-mooney | gibi: for now ill put a patch underneat to comment out the test, update the requiremetns patch to depend on it then make the placment patch depend on the requireemts patch and updte and uncomment the test | |
| 15:05:23 | sean-k-mooney | we can see if there is a better long term solution. | |
| 15:06:02 | sean-k-mooney | perhaps addign a functional-next that uses uncapped requiremetn for the requiremts repo job or something like that | |
| 15:06:23 | gibi | sean-k-mooney: I'm OK with the comment-out solution | |
| 15:06:38 | gibi | sean-k-mooney: I think if we need to do this once per cycle then OK | |
| 15:06:57 | sean-k-mooney | well its every os-traits release so its multiple times | |
| 15:07:17 | gibi | yes, but in the last cycle we had one such release | |
| 15:07:18 | sean-k-mooney | ill see if we can do this more intelegently | |
| 15:07:26 | sean-k-mooney | fair | |
| 15:07:50 | sean-k-mooney | for now ill do the quick solution and then think about a clearer approch later | |
| 15:07:59 | gibi | ok | |
| 15:08:03 | gibi | thanks for taking care of it | |
| 15:09:13 | sean-k-mooney | no worries. i just want to make sure that the inflight things are not blocked and didnt want to dump this on a new nova contributor to figure out | |
| 15:16:56 | opendevreview | sean mooney proposed openstack/placement master: update placement for os-traits 2.7.0 release https://review.opendev.org/c/openstack/placement/+/826478 | |
| 15:16:56 | opendevreview | sean mooney proposed openstack/placement master: disable traits count check to allow os-traits 2.7.0 https://review.opendev.org/c/openstack/placement/+/826486 | |
| 15:54:13 | opendevreview | Balazs Gibizer proposed openstack/placement master: Extend the RP db query to support any-traits https://review.opendev.org/c/openstack/placement/+/825848 | |
| 15:54:19 | opendevreview | Balazs Gibizer proposed openstack/placement master: Enhance doc of _get_trees_with_traits https://review.opendev.org/c/openstack/placement/+/825780 | |
| 15:54:19 | opendevreview | Balazs Gibizer proposed openstack/placement master: Extend the RP tree DB query to support any-traits https://review.opendev.org/c/openstack/placement/+/825849 | |
| 15:54:20 | opendevreview | Balazs Gibizer proposed openstack/placement master: DB layer should only depend on trait id not names https://review.opendev.org/c/openstack/placement/+/826490 | |
| 15:54:35 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add any-traits support for listing resource providers https://review.opendev.org/c/openstack/placement/+/826491 | |
| 15:54:40 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add any-traits support for allocation candidates https://review.opendev.org/c/openstack/placement/+/826492 | |
| 15:54:45 | opendevreview | Balazs Gibizer proposed openstack/placement master: Remove unused compatibility code https://review.opendev.org/c/openstack/placement/+/826493 | |
| 15:58:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: run nova tests with any--traits placement feature https://review.opendev.org/c/openstack/nova/+/825914 | |
| 18:01:10 | opendevreview | Gustavo Santos proposed openstack/nova stable/wallaby: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/821978 | |
| 18:05:50 | opendevreview | Gustavo Santos proposed openstack/nova stable/victoria: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/821980 | |
| 18:07:11 | opendevreview | Gustavo Santos proposed openstack/nova stable/ussuri: Reattach mdevs to guest on resume https://review.opendev.org/c/openstack/nova/+/821987 | |
| 20:11:48 | lyarwood | Apologies in advance for the spam | |
| 20:12:05 | opendevreview | Lee Yarwood proposed openstack/nova master: func: Allow compute_driver to be set and used by _IntegratedTestBase https://review.opendev.org/c/openstack/nova/+/764484 | |
| 20:12:05 | opendevreview | Lee Yarwood proposed openstack/nova master: image_meta: Add ephemeral encryption properties https://review.opendev.org/c/openstack/nova/+/760454 | |
| 20:12:06 | opendevreview | Lee Yarwood proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | |
| 20:12:06 | opendevreview | Lee Yarwood proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | |
| 20:12:07 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | |
| 20:12:07 | opendevreview | Lee Yarwood proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | |
| 20:12:08 | opendevreview | Lee Yarwood proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter https://review.opendev.org/c/openstack/nova/+/760456 | |
| 20:12:09 | opendevreview | Lee Yarwood proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | |
| 20:12:09 | opendevreview | Lee Yarwood proposed openstack/nova master: WIP libvirt: Enable ephemeral encryption support for qcow2 https://review.opendev.org/c/openstack/nova/+/772273 | |
| 20:12:11 | opendevreview | Lee Yarwood proposed openstack/nova master: block_device_info: Add swap to inline https://review.opendev.org/c/openstack/nova/+/826523 | |
| 20:12:11 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Improve creating images INFO log https://review.opendev.org/c/openstack/nova/+/826524 | |
| 20:12:13 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Remove defunct comment https://review.opendev.org/c/openstack/nova/+/826525 | |
| 20:12:13 | opendevreview | Lee Yarwood proposed openstack/nova master: imagebackend: default by_name image_type to config correctly https://review.opendev.org/c/openstack/nova/+/826526 | |
| 20:12:15 | opendevreview | Lee Yarwood proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info https://review.opendev.org/c/openstack/nova/+/826527 | |
| 20:12:15 | opendevreview | Lee Yarwood proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks https://review.opendev.org/c/openstack/nova/+/826528 | |
| 20:12:17 | opendevreview | Lee Yarwood proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | |
| 20:12:17 | opendevreview | Lee Yarwood proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | |
| #openstack-nova - 2022-01-27 | |||
| 10:10:03 | opendevreview | Frode Nordahl proposed openstack/nova master: Ensure binding profile keys added by Nova are cleared https://review.opendev.org/c/openstack/nova/+/826601 | |
| 10:41:42 | gibi | bauzas: can we land this? https://review.opendev.org/q/topic:bug%252F1952941 I'm getting pressure from downstream... | |
| 11:14:34 | opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: [yoga] Include pf mac and vf num in port updates https://review.opendev.org/c/openstack/nova/+/824833 | |
| 11:31:13 | guesswhat | is xen ( xcp-ng ) supported in openstack as nova driver? seems its deprecated, right ? | |
| 11:44:05 | dmitriis | sean-k-mooney: o/ question about https://review.opendev.org/c/openstack/nova/+/824834/1/nova/pci/stats.py#530. Looking at pci_passthrough_whitelist alone without runtime checks we can't tell if a device is a PF or not. There may be a case where a device is present in the config but not yet hot-plugged into the host or deployment tooling may apply | |
| 11:44:05 | dmitriis | the same config for various PCI devices which may or may not be present in all servers. So I am trying to decide whether implementing runtime checks during pci_passthrough_whitelist parsing is a good idea or not. | |
| 12:51:05 | sean-k-mooney | dmitriis: its not that tere wont be any runtime checks its that when we first inistalise the pci tracker and iterate over the pci devcied on the host we can check once and either raise an error that prevent the agent form starting or strip out the pf depending on the configurtion | |
| 12:53:51 | sean-k-mooney | dmitriis: you do not use the same config on all servers | |
| 12:53:59 | sean-k-mooney | the pci whitelist is differnt per host | |
| 12:54:44 | sean-k-mooney | i dont enforce this today but its logcially an error to list a device in the pci whitelist if its not present on the host. | |
| 12:55:01 | sean-k-mooney | the only reason we dont enforce it is it could alredy be pass through to a vm | |
| 12:55:16 | dmitriis | sean-k-mooney: What about the hot-plug case? I know it's a niche one and I haven't actually seen this to be used | |
| 12:55:42 | sean-k-mooney | dmitriis: we do not support hotplug of pci device on the host | |
| 12:56:10 | sean-k-mooney | libvirt caches the pci device list and you woudl have ot restart it for libvirt to work and then restart the nova agent | |
| 12:56:21 | dmitriis | sean-k-mooney: ah, ok, so then it's not a problem and I can make a runtime check when whitelist is parsed | |
| 12:56:30 | sean-k-mooney | so for the lifetime of the nova agent hot-plug on the host is not supported | |
| 12:56:37 | sean-k-mooney | yes | |
| 12:56:53 | sean-k-mooney | we can ensure the PFs never actully make it to the db in the first plance | |
| 12:57:05 | sean-k-mooney | and therefore can never be a candiate for selection | |
| 12:57:22 | dmitriis | sean-k-mooney: right, presumably the compute node will filter out PCI devices obtained from libvirt based on the whitelist | |
| 12:58:05 | dmitriis | sean-k-mooney: what about the "if PF is specified in a request with a remote_managed tag"? Do I need to support this? | |
| 12:59:33 | sean-k-mooney | well there wont be any pf with remote managed in the db because we filtered them at start up so it will be handeled automaticaly | |
| 12:59:54 | sean-k-mooney | vnic-type direct-phsyical will only match PFs without remote-managed=true | |
| 13:00:02 | sean-k-mooney | because that is all tha will exist | |
| 13:00:15 | sean-k-mooney | and vnic-type smartnic will only match VFs | |
| 13:00:20 | sean-k-mooney | so i think that is covered | |
| 13:00:48 | sean-k-mooney | you do not need to specificlyu request remote_mannaged=false in the driect-physical case | |
| 13:00:51 | dmitriis | sean-k-mooney: ok, so I can just drop the check here https://review.opendev.org/c/openstack/nova/+/824834/1/nova/pci/stats.py#505 | |