| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-11-12 | |||
| 15:50:12 | bauwser | elodilles: done :) | |
| 15:52:26 | elodilles | bauwser: cool, thanks! \o/ I'll update the nova ussuri-em patch after this has merged | |
| 15:52:38 | bauwser | ;) | |
| 16:50:06 | opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | |
| 16:52:49 | opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | |
| 16:55:02 | elodilles | bauwser if you are still here: ussuri relese patch has merged and the ussuri-em patch is updated: https://review.opendev.org/c/openstack/releases/+/817606 | |
| 16:55:21 | bauwser | elodilles: last call, indeed. | |
| 16:56:51 | elodilles | bauwser: uh, didn't want to leave it to end of the day, but somehow forgot to ping you earlier :S sorry :/ | |
| 16:57:05 | bauwser | np :) | |
| 17:08:15 | artom | dansmith, hey, if we do an instance.save() for example, but no fields have changed, we don't actually do the DB update, correct? | |
| 17:16:04 | bauwser | elodilles: I could be wrong but I said 'no' to https://review.opendev.org/c/openstack/releases/+/817606 | |
| 17:16:57 | dansmith | artom: https://github.com/openstack/nova/blob/171138146a648d22474b7021ac730e26f03455f8/nova/objects/instance.py#L810-L811 | |
| 17:17:38 | artom | dansmith, oh, it's only in instance, not provided by base ovo? | |
| 17:17:53 | dansmith | artom: not all objects even have a save | |
| 17:18:03 | artom | Doh, right | |
| 17:18:14 | dansmith | artom: base ovo provides dirty tracking for the fields, but what you do with it is up to you | |
| 17:20:07 | artom | dansmith, yeah, makes sense | |
| 17:58:38 | sean-k-mooney | giblet: yes those are the two cases it uses it | |
| 18:01:02 | opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | |
| 18:12:44 | elodilles | bauwser: sorry, yes, so those patches are not relevant from release perspective :) | |
| 18:14:06 | elodilles | bauwser: why would we force customers to upgrade those packages on production systems because of some TOX and zuul and gerrit related changes? o:) | |
| 18:15:06 | sean-k-mooney[m] | which packages | |
| 18:15:23 | elodilles | osc-placement and python-novaclient | |
| 18:15:48 | elodilles | sean-k-mooney[m]: see this patch: https://review.opendev.org/c/openstack/releases/+/817606 | |
| 18:18:49 | sean-k-mooney[m] | the oscp placment tox changes wont alter what is installed | |
| 18:19:16 | sean-k-mooney[m] | it just uses the ussuri upper-constratings instead of master | |
| 18:22:26 | elodilles | yepp, exactly :) | |
| 18:23:08 | sean-k-mooney[m] | elodilles i would personally update the shas to the latest if we are doing a release anyway but i dont see any issues that would need a release to be packaged | |
| 18:23:48 | sean-k-mooney[m] | there is a fix for one func test in novaclient | |
| 18:23:56 | sean-k-mooney[m] | but again wont affect end users | |
| 18:24:46 | elodilles | sean-k-mooney[m]: the *-em tag is not a "release" it is a tag against the latest release. and releases should be meaningful for end users as far as i know | |
| 20:25:35 | opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | |
| 20:26:39 | opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | |
| 21:53:52 | opendevreview | Artom Lifshitz proposed openstack/nova master: DNM: Test token expiration during live migration https://review.opendev.org/c/openstack/nova/+/817778 | |
| 23:00:24 | opendevreview | David Hill proposed openstack/nova stable/ussuri: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/817689 | |
| 23:00:38 | opendevreview | David Hill proposed openstack/nova stable/train: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/817830 | |
| #openstack-nova - 2021-11-13 | |||
| 03:52:18 | opendevreview | melanie witt proposed openstack/nova master: Replace eventlet.spawn_n() with eventlet.spawn() https://review.opendev.org/c/openstack/nova/+/813114 | |
| 17:38:38 | EugenMayer | on an instance with multiple interfaces, can i define that one should not push a gateway or just define which one is the default gateway? | |
| 18:09:37 | opendevreview | melanie witt proposed openstack/nova master: Replace eventlet.spawn_n() with eventlet.spawn() https://review.opendev.org/c/openstack/nova/+/813114 | |
| #openstack-nova - 2021-11-15 | |||
| 02:41:04 | opendevreview | Jun Chen proposed openstack/nova master: Catch an exception in power off procedure https://review.opendev.org/c/openstack/nova/+/817176 | |
| 08:31:48 | bauzas | good morning Nova | |
| 08:57:50 | elodilles | good morning bauzas o/ i've replied to your comment here: https://review.opendev.org/c/openstack/releases/+/817606 | |
| 08:58:06 | elodilles | so if you'll have time... o:) | |
| 09:00:17 | giblet | morning | |
| 09:14:38 | bauzas | elodilles: ack, saw your ping on Friday | |
| 09:16:39 | bauzas | elodilles: mmm, look at the last comment I just provided in https://review.opendev.org/c/openstack/releases/+/817606 | |
| 10:25:38 | opendevreview | Brin Zhang proposed openstack/nova master: WIP: Cyborg suspend/resume support https://review.opendev.org/c/openstack/nova/+/729945 | |
| 10:29:36 | kashyap | sean-k-mooney[m]: giblet: Hi, when you're about: can we move this forward? - https://review.opendev.org/c/openstack/nova/+/798680 (libvirt: Switch the default video model from 'cirrus' to 'virtio') | |
| 10:30:13 | songwenping_ | bauzas: i install nvidia-smi driver(470.82.00) for my vgpu ubuntu vm(20.04) and run nvidia-smi, but get the error NVIDIA-SMI has failed because it couldn't communicate with the NVIDIA driver. from the dmesg |grep -i nvidia, i found the error: probe of 0000:00:06.0 failed with error -1. | |
| 10:30:59 | songwenping_ | hava you met before and is there some solutions? | |
| 10:31:13 | kashyap | sean-k-mooney[m]: I have answered all the questions there. Please re-adjust your -1. I don't see any technical obstacles here | |
| 10:37:08 | gibi | kashyap: sure, I will re-read the patch | |
| 10:37:21 | gibi | kashyap: but you should get the bp approved https://blueprints.launchpad.net/nova/+spec/virtio-as-default-display-device | |
| 10:37:25 | kashyap | Thank you | |
| 10:37:27 | kashyap | Ohh, right | |
| 10:38:03 | opendevreview | Takashi Kajinami proposed openstack/nova master: Deprecate [wsgi] secure_proxy_ssl_header https://review.opendev.org/c/openstack/nova/+/817927 | |
| 10:38:07 | kashyap | gibi: It's a tiny patch; also see my summary of testing from 04 Aug. | |
| 10:38:46 | gibi | bauzas: ^^ | |
| 10:39:18 | kashyap | (I've got some real live migration tests done by Red Hat QE folks to have Windows + Linux guests - and it all works as expected.) | |
| 10:40:14 | opendevreview | Takashi Kajinami proposed openstack/nova master: Deprecate [wsgi] secure_proxy_ssl_header https://review.opendev.org/c/openstack/nova/+/817927 | |
| 10:42:02 | opendevreview | Takashi Kajinami proposed openstack/nova master: Deprecate [wsgi] secure_proxy_ssl_header https://review.opendev.org/c/openstack/nova/+/817927 | |
| 10:45:12 | kashyap | gibi: Unrelated: Oddly, this simple class addition is failing only in the CI, not locally here. You see what I'm missing here? - https://paste.opendev.org/show/810997/ | |
| 10:46:28 | bauzas | songwenping_: sorry I was afk | |
| 10:46:57 | bauzas | songwenping_: honestly, I don't know, it looks like a nvidia driver issue | |
| 10:47:25 | bauzas | gibi: what do you want me to look ? | |
| 10:47:33 | songwenping_ | bauzas:ok, thanks. | |
| 10:58:40 | gibi | bauzas: kashyap: would like to get a specless bp approved | |
| 10:59:00 | kashyap | bauzas: This one - https://blueprints.launchpad.net/nova/+spec/virtio-as-default-display-device | |
| 10:59:03 | bauzas | gibi: ok, let's discuss this during tomorrow's meeting | |
| 10:59:10 | bauzas | kashyap: add it to the meeting agenda | |
| 10:59:34 | bauzas | and please be around tomorrow during the meeting :) | |
| 10:59:52 | kashyap | Yes, I'll be around | |
| 10:59:57 | kashyap | Yea; thx | |
| 11:02:03 | gibi | ack, I will be on the meeting | |
| 11:17:59 | elodilles | bauzas: (sorry for the late reply) thanks, i've created the python-novaclient release: https://review.opendev.org/c/openstack/releases/+/817930 | |
| 11:18:29 | elodilles | and rebased the ussuri-em patch on top of this | |
| 11:43:03 | opendevreview | Takashi Kajinami proposed openstack/nova master: Deprecate [wsgi] secure_proxy_ssl_header https://review.opendev.org/c/openstack/nova/+/817927 | |
| 12:22:32 | sean-k-mooney | gibi: so technially the guest abi is mostly maintained when goign form cirrus to virtio as virtio has a vga compatiable interface that is compatiable with cirrus. it would be a guest visabel change | |
| 12:22:51 | sean-k-mooney | it apparently is not a harmful guest visable change | |
| 12:25:03 | sean-k-mooney | if we are ok with the change in default affectign existing instnace the kasahyap patch is workable if not then i would like him to adress the comments i left in the patch | |
| 12:27:28 | kashyap | Yep, this is a benign case. | |
| 12:27:52 | kashyap | sean-k-mooney[m]: What else comments? I addressed what you (incorrectly) thought was a problem | |
| 12:27:58 | kashyap | I don't see any outstanding questions there. | |
| 12:28:07 | kashyap | Also, recall: | |
| 12:28:27 | sean-k-mooney | you ignored all the other comment i made and you have not | |
| 12:28:43 | kashyap | In the patch comments, I've also outlined the integration tests (Windows + Linux) done by Red Hat QE as well | |
| 12:28:50 | sean-k-mooney | what i sated as a probelm is that the xml would change for existign instace after a hard reboot | |
| 12:29:14 | sean-k-mooney | it still will for vms create before the patch | |
| 12:29:30 | kashyap | I need to evaluate the merits of the other comments and see if they make sense. | |
| 12:29:39 | kashyap | Some of them maybe non-problems | |
| 12:29:39 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/798680/3/nova/virt/libvirt/driver.py | |
| 12:31:12 | sean-k-mooney | kashyap: the disconenct is that when we discussed this with dan and other before we said you should follow the patteren we used for machine type and recorerd the current video model for all instnace and just change the behavior for new ones | |
| 12:31:35 | sean-k-mooney | now you have shown that changing the behaivor for new isntnace should be safe | |
| 12:31:53 | sean-k-mooney | that is great it does not change the fact that we had previously agreed not too | |
| 12:31:55 | kashyap | Correct | |
| 12:31:59 | kashyap | Well | |
| 12:32:14 | kashyap | We should revisit previous "agreements" if they don't make sense in light of new info | |
| 12:32:16 | sean-k-mooney | if people are ok with makeing the change we can but we should at least disucss that | |
| 12:32:44 | kashyap | Yes, but I hope it won't become a big drag. | |
| 12:35:35 | gibi | kashyap, sean-k-mooney: OK, so the cirros -> virtio change is considered harmless during a hard reboot, then I'm OK with the direction of the patch | |