| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-10-13 | |||
| 13:23:25 | sean-k-mooney | ack | |
| 14:23:33 | sean-k-mooney | does this look familar to anyone | |
| 14:23:35 | sean-k-mooney | https://paste.opendev.org/show/809977/ | |
| 14:23:46 | sean-k-mooney | ] GET /placement/resource_providers?in_tree=4838f356-678a-477c-a2b8-7a743ad0842c => generated 162 bytes in 5 msecs (HTTP/1.1 404) | |
| 14:24:11 | sean-k-mooney | but in the debug logs the path is wrong | |
| 14:24:12 | sean-k-mooney | 92.168.1.10 "GET /placemen//resource_providers?in_tree=4838f356-678a-477c-a2b8-7a743ad0842c" status: 404 | |
| 14:25:39 | sean-k-mooney | the apach2 config just has ProxyPass "/placement" "unix:/var/run/uwsgi/placement-api.socket|uwsgi://uwsgi-uds-placement-api/" retry=0 | |
| 14:26:41 | sean-k-mooney | this is causeing "/usr/local/bin/nova-status --config-file /etc/nova/nova.conf upgrade check" to fail which breaks devstack | |
| 14:26:57 | alecorps | hello | |
| 14:27:44 | alecorps | is someone can have a look to the PR 808791 ? | |
| 14:28:14 | sean-k-mooney | PR as in pull request | |
| 14:28:21 | gibi | sean-k-mooney: you have wrong config in you apache proxy | |
| 14:28:24 | gibi | sean-k-mooney: in devstack | |
| 14:28:32 | gibi | sean-k-mooney: searching for the commit... | |
| 14:28:49 | gibi | sean-k-mooney: https://review.opendev.org/c/openstack/devstack/+/811303 | |
| 14:28:51 | sean-k-mooney | gibi: i guess i need to pull devstack? | |
| 14:28:59 | gibi | probably yes | |
| 14:29:15 | gibi | you need the above fix is you have a new enough apache | |
| 14:29:24 | sean-k-mooney | oh ok | |
| 14:29:31 | sean-k-mooney | it removed the / on the socket | |
| 14:30:37 | sean-k-mooney | alecorps: what is PR 808791 | |
| 14:30:56 | alecorps | https://review.opendev.org/c/openstack/nova/+/808791 | |
| 14:31:00 | alecorps | yes pull request :) | |
| 14:31:06 | alecorps | sorry | |
| 14:31:15 | sean-k-mooney | alecorps: ok that is not a pull request | |
| 14:31:21 | sean-k-mooney | its a gerrit reivew | |
| 14:31:25 | alecorps | yes sorry | |
| 14:31:46 | sean-k-mooney | they are diffenet code review systems we used ot somtiem get PRs to the github mirror | |
| 14:32:11 | sean-k-mooney | ok so that is a new feature | |
| 14:32:22 | sean-k-mooney | dos it have a approve spec or blueprint | |
| 14:33:13 | sean-k-mooney | https://blueprints.launchpad.net/nova/+spec/vmware-fcd | |
| 14:33:40 | sean-k-mooney | ok so that is not approved currently | |
| 14:34:17 | sean-k-mooney | so ideally we need to review that at the next team meeting and either approve as a specless blueprint or request a spec if its invalice | |
| 14:34:33 | alecorps | ok, do i need to be there ? | |
| 14:34:34 | sean-k-mooney | it looks likke its self contained to the vmware code | |
| 14:34:52 | sean-k-mooney | it just need to be put on the adgenda | |
| 14:35:04 | sean-k-mooney | hovever we might not have next weeks meeting because of the ptg | |
| 14:35:07 | sean-k-mooney | so the meeting after | |
| 14:35:18 | alecorps | ok cool | |
| 14:35:25 | sean-k-mooney | i can take a look at it in the mean time but procetully its blocked until the paper work is done | |
| 14:35:34 | sean-k-mooney | you could just add it to the ptg adgenda too | |
| 14:35:39 | alecorps | understood, thanks | |
| 14:37:37 | alecorps | I iwll add it in the agenda | |
| 14:47:22 | alecorps | i added it in open discussion on the wiki | |
| 14:47:31 | alecorps | let me know if it's ok for you ? thanks | |
| 14:49:34 | sean-k-mooney | yep that shoudl be fine | |
| 14:50:04 | sean-k-mooney | if your going to attend the PTG next week you could also add it to https://etherpad.opendev.org/p/nova-yoga-ptg | |
| 14:50:31 | sean-k-mooney | otherwise we will likely cover it tuseday week as i expect next weeks meeing is cancled for the ptg | |
| 14:53:23 | gmann | gibi: ack, as i have removed the use of tox_extra_args now but yes in future if we use then this is something to note down. | |
| 14:54:16 | alecorps | thanks Sean, not sure for ptg, i will try | |
| 15:38:06 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Move the implemented specs for the xena release https://review.opendev.org/c/openstack/nova-specs/+/812248 | |
| 15:39:01 | bauzas | gibi: stephenfin (if you're around) : approval for the xena implemented specs would be appreciated ^ | |
| 15:39:19 | bauzas | i just rebased my own change into brinzhang's change as he was missing a few bits | |
| 15:57:11 | stephenfin | bauzas: done | |
| 15:58:39 | bauzas | stephenfin: ta | |
| 15:59:06 | bauzas | sean-k-mooney: I moved your PTG point about rbac for novaclient during the rbac popup team meeting session we plan | |
| 15:59:26 | bauzas | but we can put it off this slot and just discuss between us | |
| 15:59:27 | sean-k-mooney | ok | |
| 16:00:07 | bauzas | or we can leave it there during the meeting and we don't have time to go thru it, we can try to find another time | |
| 16:00:15 | sean-k-mooney | well basically i think we shoudl be deprecating the novaclinet cli so i dont think we shoudl add the project id passthough feature to novaclinet for rbac | |
| 16:00:26 | bauzas | sean-k-mooney: sorry, I messed up your colors by pasting, btw. | |
| 16:00:36 | sean-k-mooney | its fine | |
| 16:00:46 | sean-k-mooney | move things as you see fit | |
| 16:04:43 | bauzas | I'm just doing a first round | |
| 16:05:07 | bauzas | probably something like "paperwork nova", then "general nova", then others | |
| 16:22:05 | opendevreview | Merged openstack/nova-specs master: Move the implemented specs for the xena release https://review.opendev.org/c/openstack/nova-specs/+/812248 | |
| 16:26:06 | stephenfin | melwitt: good spot on https://review.opendev.org/c/openstack/nova/+/812144 | |
| 16:31:19 | stephenfin | dansmith: So nova-compute doesn't access the DB and iirc, you're expected to upgrade all services at once, right? i.e. the N and N-1 in a single deployment only applies to nova-compute N-1 | |
| 16:31:51 | sean-k-mooney | stephenfin: nova-compute only accesses the db via the conductor | |
| 16:31:55 | dansmith | stephenfin: you're expected to upgrade all the non-compute services at once, yes, largely because of schema but not only for that | |
| 16:32:25 | stephenfin | Okay, so that being the case, why do we insist that DB columns are removed in a later cycle than the corresponding SQLAlchemy model fields? | |
| 16:32:44 | opendevreview | Merged openstack/nova-specs master: Re-propose Unified Limits in Nova https://review.opendev.org/c/openstack/nova-specs/+/809020 | |
| 16:32:45 | dansmith | so you can apply new schema before you roll any of that new code | |
| 16:32:54 | stephenfin | ah | |
| 16:33:14 | dansmith | schema apply being potentially very expensive, rewriting tables, etc | |
| 16:33:24 | dansmith | it's in the upgrade doc somewhere, I just linked it the other day | |
| 16:33:25 | stephenfin | yup, and having to come first for the additive stuff | |
| 16:33:55 | dansmith | ideally if you've rolled the schema, then "upgrading" is just starting new containers, which can be pretty quick | |
| 16:37:55 | gibi | gmann: ack, I will file a bug to zuul when I have time about the quoting issue | |
| 16:37:59 | sean-k-mooney | provieded we have only made aditive changes in principal for something like an FFU we can fully upgrade the db schema while running n-3 compute nodes and then do all the online migration when we bounce the containers. | |
| 16:38:53 | sean-k-mooney | the queens to train ffu in oo however stop on each release to do the db sync for some reaons | |
| 16:39:42 | sean-k-mooney | so i dont think they have ever actuly done that in practice where tehy did the db sync rom the targent n release while the n-3 contianer where running | |
| 16:40:23 | melwitt | stephenfin: thanks for the detailed explanation about the auto-generation stuff! | |
| 16:40:40 | stephenfin | nw, it's *very* cool, if you ask me | |
| 16:40:42 | stephenfin | zzzeek++ | |
| 16:54:55 | gibi | sean-k-mooney: I manage to make a stable local reproduction for the unshelve func test bug https://bugs.launchpad.net/nova/+bug/1946339/comments/6 | |
| 16:55:25 | gibi | now I just have to debug it to find the leaking global state between the tests | |
| 16:58:04 | sean-k-mooney | that great | |
| 16:58:23 | opendevreview | sean mooney proposed openstack/nova master: [WIP] adress intermitent failure of functional tests https://review.opendev.org/c/openstack/nova/+/813695 | |
| 16:58:31 | sean-k-mooney | i just fixed the pep8 issues with ^ | |
| 16:59:04 | sean-k-mooney | gibi: also thanks for the devstack tip it fixed my placment issue | |
| 17:02:48 | sean-k-mooney | gibi: could it be form this | |
| 17:02:50 | sean-k-mooney | https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_fake.py#L148-L159 | |
| 17:03:05 | sean-k-mooney | gibi: could we be reusing the same exchange between tests | |
| 17:04:05 | sean-k-mooney | if we initalise the fake messaign drver without passing a unique exchange name per test | |
| 17:04:34 | sean-k-mooney | gibi: tox allows use to group test per class correct | |
| 17:04:43 | sean-k-mooney | coudl you try that with your reopducecer and see it that helps | |
| 17:11:58 | sean-k-mooney | gibi: we do try and cleanup the exchanges https://github.com/openstack/nova/blob/7b063e4d0518af3e57872bc0288a94edcd33c19d/nova/tests/fixtures/nova.py#L741-L744 | |
| 17:13:02 | sean-k-mooney | but that does not reset self._default_exchange | |
| 17:13:32 | sean-k-mooney | i guess that is not required | |