| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-10-07 | |||
| 11:39:45 | sean-k-mooney | we just take the value form /sys which should be lower case | |
| 11:40:26 | sean-k-mooney | sean@p50:~/repos/nova$ cat /sys/class/net/enp0s31f6/address | |
| 11:40:28 | sean-k-mooney | 8c:16:45:81:48:b5 | |
| 11:41:26 | sean-k-mooney | for the unique constraint in the db for the virtual interfaces table we are also useing the mac un normalised | |
| 11:41:28 | sean-k-mooney | https://github.com/openstack/nova/blob/66574018b517f14dc26e581d0ddaa7788806f83e/nova/network/neutron.py#L1307-L1308 | |
| 11:42:26 | sean-k-mooney | noonedeadpunk: likely we should just fix your inital case in this patch but we should think about the other cases at some point | |
| 11:43:17 | noonedeadpunk | well neutron is not normalazing https://paste.opendev.org/show/809839/ | |
| 11:43:58 | sean-k-mooney | yep that would appear to be the case | |
| 11:44:40 | sean-k-mooney | whcih mean sif you were ever to change the mac on the neutron port it could break things in nova unless we propagate that update in some cases | |
| 11:44:53 | noonedeadpunk | actually I thought that in domain xml mac is also stored non-normalized | |
| 11:45:13 | noonedeadpunk | And I saw that issue first when was live-migrating instances from bionic to focal computes | |
| 11:45:37 | sean-k-mooney | libvirt normalises the xml we provide so the one we provide is not the one that it actully uses | |
| 11:45:47 | sean-k-mooney | so we likely dont normalise it when we give it to libvirt | |
| 11:45:55 | noonedeadpunk | was it always like that ? | |
| 11:46:01 | sean-k-mooney | yep | |
| 11:46:24 | noonedeadpunk | huh, okay then. Wondering why it's haven't been spotted before then... | |
| 11:46:25 | sean-k-mooney | the xml you see with virsh dumpxml is not the one that nova provided | |
| 11:46:37 | sean-k-mooney | well neutron default to lower case | |
| 11:46:39 | noonedeadpunk | Yeah, that's what I saw as well | |
| 11:46:49 | sean-k-mooney | so unless you provdided a mac it wont be an issue | |
| 11:47:15 | noonedeadpunk | yeah, maybe we saw that because we were doing really mass migrations of all vms in our deployments... | |
| 11:47:16 | sean-k-mooney | so i think this is only an issue for user provided macs | |
| 11:47:36 | noonedeadpunk | yeah, indeed | |
| 11:47:46 | noonedeadpunk | Ok, so then I will change that to lower() | |
| 11:48:54 | sean-k-mooney | if the test fallout of that is no horrific then yes please do | |
| 11:49:29 | sean-k-mooney | i suspect it will not be that bad | |
| 12:22:06 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | |
| 12:22:18 | noonedeadpunk | yeah you was right, it's not bad at all) | |
| 13:48:01 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | |
| 15:08:58 | bauzas | gibi: sean-k-mooney: shit, I remember we need to move the merged specs into implemented https://specs.openstack.org/openstack/nova-specs/specs/xena/ | |
| 15:09:18 | gibi | bauzas: yeah, we tend to forget that | |
| 15:09:31 | bauzas | gibi: I can do it | |
| 15:09:38 | gibi | there is script for that | |
| 15:09:41 | gibi | thans | |
| 15:09:44 | gibi | thanks | |
| 16:21:16 | lyarwood | bauzas: https://review.opendev.org/c/x/gerrit-dash-creator/+/813050 | |
| 16:25:14 | bauzas | gibi: oh, I wasn't knowing | |
| 16:27:56 | melwitt | bauzas: there's some instructions here too https://docs.openstack.org/nova/latest/contributor/ptl-guide.html | |
| 16:28:47 | bauzas | melwitt: /me facepalms | |
| 16:29:03 | lyarwood | https://review.opendev.org/c/openstack/nova/+/812392 - bauzas / gibi / melwitt ; this should be good now the stable/xena devstack change is in the gate | |
| 16:29:04 | bauzas | I have this link open as a tab since a month and I forgot about this | |
| 16:29:44 | melwitt | :) | |
| 16:44:59 | opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Move Xena implemented specs https://review.opendev.org/c/openstack/nova-specs/+/813051 | |
| 16:45:10 | bauzas | gibi: melwitt: there there ^ | |
| 16:53:55 | melwitt | bauzas: I just remembered you'll want to do the placement repo too. have to do it manually afaik, placement doesn't use launchpad https://docs.openstack.org/placement/latest/specs/index.html#xena they are located under placement/doc/source/specs/ | |
| 16:56:31 | melwitt | gmann: in case you didn't see my comment on https://review.opendev.org/c/openstack/devstack/+/812092 I think stable/train is also broken in the same way cc elodilles | |
| 16:57:54 | gmann | melwitt: checking, stable/train still run tempest master so it should be ok. | |
| 16:59:05 | melwitt | gmann: oh, so my patch has jsonschema fail bc of the stable/stein side of grenade /facepalm ok I understand now | |
| 16:59:58 | gmann | melwitt: yeah, once stable/stein patch is merged then we can recheck or, we can make depends-on just to be sure | |
| 17:00:44 | melwitt | yeah I see. I'm writing up a comment about the novnc issue. I don't understand why it's happening though so can't fix it yet :( | |
| 17:01:44 | gmann | thanks, I will try to dig into that next week or so. | |
| 17:03:31 | elodilles | melwitt: thanks for the heads up, i will also add this to my TODO list and try to debug it :S | |
| 17:04:35 | melwitt | elodilles: to correct myself it's stable/stein that needs a fix but it's failing for a novnc issue that I don't understand how is happening. I'm writing a comment for gmann's patch ^ with what I found so far | |
| 17:13:28 | elodilles | melwitt: ack, thanks! | |
| 18:54:17 | melwitt | gmann: just a fyi, I think I finally figured out why the tempest 20.0.0 patch failed on stable/stein https://review.opendev.org/c/openstack/devstack/+/812092/1#message-348d913f2bbcf909533d62c3cb4e02d6a0100664 cc elodilles | |
| 22:21:40 | gmann | melwitt: ah thanks, let me try 24.0.0 which should work as it has old jsonschema in requirement filr https://github.com/openstack/tempest/blob/24.0.0/requirements.txt#L6 | |
| 22:22:04 | gmann | oh, you already updated, great | |
| 22:22:30 | melwitt | gmann: I already updated your patch, I hope you don't mind. I did not update the commit message or code comment yet as it's just for testing. if it works well, we can update the writings | |
| 22:23:09 | gmann | melwitt: +1. | |
| 22:27:55 | opendevreview | Merged openstack/nova master: zuul: Move live migration jobs back to voting https://review.opendev.org/c/openstack/nova/+/812392 | |
| 22:37:30 | melwitt | gmann: the novnc problem went away but we have a new problem now on the minimum basic scenario test image create: FileNotFoundError: [Errno 2] No such file or directory: '/opt/stack/new/devstack/files/images/cirros-0.3.1-x86_64-uec/cirros-0.3.1-x86_64-vmlinuz' | |
| 22:37:42 | gmann | checking | |
| 22:38:53 | gmann | may be that is because we change the configuration of image location in tempest and devstack for tempest 25.0.0, let me check the patch which we can revert. | |
| 22:40:52 | gmann | melwitt: this one. we did backport it to stable/stein as tempest 26.0.0 was used there and img location changes done in tempest 25.0.0 but now as we have to use tempest 24.0.0 in stable/stein we should revert it https://review.opendev.org/c/openstack/devstack/+/770839 | |
| 22:41:28 | melwitt | oh I see | |
| 22:42:01 | gmann | let me do revert and squash the both | |
| 22:43:53 | melwitt | kk | |
| 23:53:54 | opendevreview | melanie witt proposed openstack/nova master: Make the CellDatabases fixture work with fasteners >= 0.15 https://review.opendev.org/c/openstack/nova/+/813114 | |
| #openstack-nova - 2021-10-08 | |||
| 00:30:57 | opendevreview | Merged openstack/nova master: tests: Walk database migrations in correct order https://review.opendev.org/c/openstack/nova/+/810291 | |
| 00:31:24 | opendevreview | Merged openstack/nova master: tests: Address some nits with database migration series https://review.opendev.org/c/openstack/nova/+/810856 | |
| 00:31:54 | opendevreview | Merged openstack/nova master: tests: Silence noise from database tests https://review.opendev.org/c/openstack/nova/+/810857 | |
| 00:51:18 | opendevreview | melanie witt proposed openstack/nova master: DNM Run against unmerged oslo.limit changes https://review.opendev.org/c/openstack/nova/+/812236 | |
| 00:51:18 | opendevreview | melanie witt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | |
| 00:51:19 | opendevreview | melanie witt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | |
| 00:51:19 | opendevreview | melanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | |
| 00:51:20 | opendevreview | melanie witt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | |
| 00:51:20 | opendevreview | melanie witt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | |
| 00:51:21 | opendevreview | melanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | |
| 00:51:21 | opendevreview | melanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | |
| 00:51:22 | opendevreview | melanie witt proposed openstack/nova master: Add legacy limits and usage to placement unified limits https://review.opendev.org/c/openstack/nova/+/713498 | |
| 00:51:23 | opendevreview | melanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | |
| 00:51:23 | opendevreview | melanie witt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | |
| 00:51:25 | opendevreview | melanie witt proposed openstack/nova master: WIP Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | |
| 01:22:27 | gmann | melwitt: its green now https://review.opendev.org/c/openstack/devstack/+/812092/4 | |
| 01:22:44 | melwitt | gmann: \o/ | |
| 01:25:29 | opendevreview | Merged openstack/nova master: Reproduce bug 1945310 https://review.opendev.org/c/openstack/nova/+/811394 | |
| 02:36:42 | opendevreview | Merged openstack/nova master: Update min supported service version for Yoga https://review.opendev.org/c/openstack/nova/+/809932 | |
| 03:25:07 | opendevreview | pengzhang proposed openstack/nova master: the vif_name error leads virsh domifstat cant work https://review.opendev.org/c/openstack/nova/+/813119 | |
| 05:46:10 | opendevreview | pengzhang proposed openstack/nova master: the vif_name error leads virsh domifstat cant work https://review.opendev.org/c/openstack/nova/+/813119 | |
| 07:33:04 | opendevreview | norman shen proposed openstack/nova master: Recreate mdev devices according to placement https://review.opendev.org/c/openstack/nova/+/810220 | |
| 08:12:47 | bauzas | good (late) morning Nova | |
| 08:15:16 | lyarwood | \o | |
| 08:17:23 | gibi | o/ | |
| 09:16:36 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Ensure MAC addresses characters are in the same case https://review.opendev.org/c/openstack/nova/+/811947 | |
| 09:38:11 | opendevreview | Elod Illes proposed openstack/nova stable/train: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791807 | |
| 09:38:48 | opendevreview | Elod Illes proposed openstack/nova stable/train: address open redirect with 3 forward slashes https://review.opendev.org/c/openstack/nova/+/806629 | |
| 10:20:15 | gibi | sean-k-mooney: what is the reason of not waiting for network-vif-plugged events during hard reboot? I hard reboot does unplug / plug but does not wait for plugged event. Compared that to boot where we do plug and then wait for plugged event before we let the VM to run | |
| 10:20:44 | gibi | in normal ovs case I see that during hard reboot neutron eventually sends the unplugged and plugged events to us we just not waiting for it | |
| 10:24:19 | sean-k-mooney | you are correct it will in most cases | |
| 10:24:39 | sean-k-mooney | technically linux bridge might miss the removal and not send it | |