| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-24 | |||
| 09:24:44 | bauzas | context : https://bugs.launchpad.net/nova/+bug/1944031 | |
| 09:25:48 | bauzas | hmmmm, looking at https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8226 | |
| 09:26:10 | bauzas | we update the provider tree | |
| 09:26:28 | bauzas | but I guess if we have resource providers, we don't verify whether they're still used | |
| 09:47:14 | opendevreview | Pierre Riteau proposed openstack/nova master: Create empty pcpuset for unpinned instances https://review.opendev.org/c/openstack/nova/+/810849 | |
| 10:11:17 | gibi | bauzas: hm, it could be that we never had to delete any RP before VGPU move to its own RP | |
| 10:11:29 | gibi | from nova-compute | |
| 10:11:36 | gibi | so we might missed that case | |
| 11:06:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1944759 https://review.opendev.org/c/openstack/nova/+/810763 | |
| 11:14:55 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Walk database migrations in correct order https://review.opendev.org/c/openstack/nova/+/810291 | |
| 11:14:55 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Add migration to resolve shadow table discrepancies https://review.opendev.org/c/openstack/nova/+/805738 | |
| 11:14:56 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Address some nits with database migration series https://review.opendev.org/c/openstack/nova/+/810856 | |
| 11:14:56 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Silence noise from database tests https://review.opendev.org/c/openstack/nova/+/810857 | |
| 11:41:52 | opendevreview | Lee Yarwood proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | |
| 12:05:23 | gibi | sean-k-mooney: do you remember where we are with mixing numa aware live migration with sriov live migration? Does src_compute(PF-numa0) -> dest_compute(PF-numa1) works? | |
| 12:05:42 | gibi | I do remember that we had issues but I don't if we solved them or just punted them for later | |
| 12:06:14 | gibi | and I only have lab nodes where both PF on numa1 so I cannot test it | |
| 12:10:10 | sean-k-mooney | gibi: yes it should | |
| 12:10:53 | sean-k-mooney | although most of the testing i did was with nic that did not report numa affinity | |
| 12:11:30 | sean-k-mooney | but i did force cross numa migration viat the cpu_dedicated_set and test that with sriov | |
| 12:12:06 | sean-k-mooney | but i would have been using the prefer policy effectivly by relaying on the fact my nics did not report numa affinity | |
| 12:12:42 | sean-k-mooney | gibi: you can try testing it with the prefer policy in your case | |
| 12:13:14 | sean-k-mooney | the ohter way to test it is technially the numa filed in /sys is writable | |
| 12:13:25 | gibi | hm, interesting :D | |
| 12:13:29 | sean-k-mooney | so if you echo 0 into the file and restart libvirt ... | |
| 12:13:42 | sean-k-mooney | i have done that in the past to fake it too with my hardware | |
| 12:13:59 | gibi | OK, I can try that, thanks for the idea | |
| 12:14:26 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Repropose flavour and image defined ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/810867 | |
| 12:14:27 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Repropose Add libvirt support for flavor and image defined ephemeral encryption https://review.opendev.org/c/openstack/nova-specs/+/810868 | |
| 12:15:13 | sean-k-mooney | gibi: since i have you have you seen nova.exception.PortNotUsable: Port 123c94fa-a71a-48c1-9195-ec2a1d6d2f40 not usable for instance 36441284-b272-439d-b8cf-f7c62efc9151. before | |
| 12:15:54 | gibi | hm I saw but I have to dig, I think there are multiple reasons for that | |
| 12:16:13 | sean-k-mooney | i must have been lucky to never hit it till now | |
| 12:16:27 | sean-k-mooney | im currently trying to test vdpa with ovn | |
| 12:16:38 | gibi | one reason is that the port is in a different project than the instance | |
| 12:16:39 | sean-k-mooney | ill dig into it on the neutron side and see whats going on | |
| 12:16:50 | gibi | nova explicitly checks that | |
| 12:17:03 | sean-k-mooney | it is failing in _validate_requested_port_ids so maybe | |
| 12:17:21 | gibi | https://github.com/openstack/nova/blob/c8940f9d60f1b0290ebea94fb6174efac9a1632e/nova/network/neutron.py#L737 | |
| 12:17:28 | gibi | yepp that will be it | |
| 12:17:34 | sean-k-mooney | yep https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L736-L738 | |
| 12:19:12 | sean-k-mooney | ya ok prot is owned by demo and vm is owned by admin | |
| 12:19:45 | sean-k-mooney | ok so horrizon does not work with vdpa ports | |
| 12:20:14 | sean-k-mooney | they dont show up in the port list in the instance create as demo | |
| 12:20:24 | sean-k-mooney | maybe i shoudl just recreated it and test this form the cli | |
| 12:22:17 | sean-k-mooney | oh active :) | |
| 12:22:24 | sean-k-mooney | i was not expecting that :P | |
| 12:31:42 | opendevreview | Pierre Riteau proposed openstack/nova master: Create empty pcpuset for unpinned instances https://review.opendev.org/c/openstack/nova/+/810849 | |
| 13:06:48 | bauzas | gibi: I guess we would have the same concern (deleting old and not used RPs) for vpmems, nope ? | |
| 13:08:24 | gibi | vpmems has its own RP? | |
| 13:08:33 | gibi | or is it tracked on the compute RP? | |
| 13:21:58 | opendevreview | sean mooney proposed openstack/nova master: [DMN] test removal of CAP_DAC_OVERRIDE https://review.opendev.org/c/openstack/nova/+/810906 | |
| 13:22:17 | bauzas | gibi: my bad, those are just inventories from the same RP | |
| 13:22:19 | sean-k-mooney | gibi: i think its on the compute node currently | |
| 13:22:31 | gibi | yepp that what was I assumed | |
| 13:22:33 | bauzas | sean-k-mooney: yeah, https://github.com/openstack/nova/blob/62406b5728077afa9cd38d5c5d510bba64c43bd7/nova/virt/libvirt/driver.py#L8379 | |
| 13:22:33 | sean-k-mooney | with 1 inventory per namespace | |
| 13:22:50 | sean-k-mooney | *namespace size | |
| 13:23:06 | bauzas | then, maybe bandwidth-aware resource providers could be impacted or is that only a VGPU thing ? | |
| 13:23:23 | bauzas | actually, this doesn't come from the virt driver | |
| 13:23:28 | gibi | bauzas: bwm RPs are managed by neutron agents | |
| 13:23:32 | bauzas | yeah | |
| 13:23:38 | sean-k-mooney | what are you currently talking about by the way | |
| 13:23:39 | bauzas | so I guess this is maybe unrelate | |
| 13:23:43 | gibi | to be precies RP and inventory is managed by neutron, allocation managed by nova | |
| 13:24:05 | bauzas | sean-k-mooney: https://bugs.launchpad.net/nova/+bug/1944031 | |
| 13:24:06 | sean-k-mooney | for bandwith and pps inventories? | |
| 13:24:08 | gibi | sean-k-mooney: https://bugs.launchpad.net/nova/+bug/1944031 | |
| 13:24:14 | bauzas | shoooooot | |
| 13:24:17 | sean-k-mooney | ah right that | |
| 13:24:58 | sean-k-mooney | well for things on the root rp its simple to fix | |
| 13:25:09 | sean-k-mooney | for nested RPs without an owner trait on the RP its harder | |
| 13:25:40 | sean-k-mooney | e.g. if RP had ownwer_nova and its not in the tree nova just compute then it should be removed | |
| 13:25:59 | sean-k-mooney | without that its very hard to figure out it the RP is owned by nova or by cyborg/neutorn | |
| 13:27:06 | sean-k-mooney | if vgpus were tracked in the db we woudl also have another way to figure this out but since we dont have them in the resouce table or pci_devices table | |
| 13:27:20 | sean-k-mooney | we cant use the nova db to determin if it was an rp we created | |
| 13:27:25 | bauzas | sean-k-mooney: yeah tbh, I think it should be the responsibility of the virt driver to compare the provider tree before and after the update and eventually remove unused RPs | |
| 13:27:53 | sean-k-mooney | bauzas: it should but we dont have the info in placment to be able to do that correctly today | |
| 13:28:30 | bauzas | sean-k-mooney: this could be done in https://github.com/openstack/nova/blob/62406b5728077afa9cd38d5c5d510bba64c43bd7/nova/virt/libvirt/driver.py#L8472 | |
| 13:28:43 | sean-k-mooney | bauzas: not today | |
| 13:28:51 | bauzas | of course | |
| 13:28:59 | bauzas | but we have the actual state in provider_tree | |
| 13:29:04 | sean-k-mooney | bauzas: you can know if the nested RP is own by neutron or cyborg | |
| 13:29:05 | bauzas | that's given | |
| 13:29:13 | sean-k-mooney | so it not safe to remove it | |
| 13:29:35 | bauzas | sean-k-mooney: we namespace the RPs | |
| 13:29:42 | sean-k-mooney | we do not | |
| 13:29:50 | gibi | what we can do is to assume that if the RP had VGPU inventory before then it is owned by nova | |
| 13:29:53 | bauzas | for GPUs ? we totally do | |
| 13:29:53 | gibi | :) | |
| 13:30:07 | gibi | or we use the name of the RP | |
| 13:30:21 | sean-k-mooney | gibi: only if we intend to make it so cyborg cannot use the vgpu inventory type | |
| 13:30:25 | bauzas | the problem is that this naming could be used by *something else* | |
| 13:31:10 | bauzas | but if we consider that https://github.com/openstack/nova/blob/62406b5728077afa9cd38d5c5d510bba64c43bd7/nova/virt/libvirt/driver.py#L8505 is only used by the virt driver, then you can look at all existing RPs matching this | |
| 13:31:25 | sean-k-mooney | any resilance on nameing or RC usage is fragile | |
| 13:31:35 | gibi | yep it is fragile I agree | |
| 13:31:41 | bauzas | agreed tho | |
| 13:31:47 | gibi | RP naming is a bit better than RC I think | |
| 13:32:00 | gibi | so fixing this as a bug I would go with relying on RP naming | |
| 13:32:09 | sean-k-mooney | if we prefixed them all with nova_ then i would strongly agree | |
| 13:32:20 | sean-k-mooney | fight now however we may have collitions although its unlikely | |