| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-10 | |||
| 16:41:29 | artom | Fun surprises every day | |
| 16:41:41 | sean-k-mooney | that is also not the correct way to get image properties | |
| 16:41:45 | sean-k-mooney | i mean it works | |
| 16:41:54 | sean-k-mooney | but we shoudl be using hte objects | |
| 16:42:52 | sean-k-mooney | oh i see why its not useing the object | |
| 16:42:56 | sean-k-mooney | its not in the object | |
| 16:43:45 | sean-k-mooney | so image_os_shutdown_timeout or os_shutdown_timeout is not a legal image property | |
| 16:43:46 | artom | At this point in the rabbit hole we're going to poke out in Australia | |
| 16:44:10 | sean-k-mooney | this is just code form before we made the image props ovos | |
| 16:44:16 | kashyap | artom: I politely "well-actuallyed" (I strongly avoid this) here on destroy() behaviour: https://review.opendev.org/c/openstack/nova/+/808474. Hope you don't mind. :) | |
| 16:44:18 | sean-k-mooney | that was likely an extenion | |
| 16:44:40 | kashyap | artom: But your broader goal is a good catch -- with volumes, i.e | |
| 16:45:38 | artom | kashyap, valid points | |
| 16:45:48 | artom | Well, I guess you're heading out, will continue in the review | |
| 16:46:06 | sean-k-mooney | artom: care to add a todo to remove supprot for image_os_shutdown_timeout or add it to the image proprties properly in the future | |
| 16:46:26 | artom | sean-k-mooney, sure, just stick it in gerrit please | |
| 16:57:20 | sean-k-mooney | artom: ok it should be all there | |
| 17:01:05 | artom | Cheers! | |
| 17:40:03 | melwitt | gibi: here's my patch for fixing the placement func test jobs https://review.opendev.org/c/openstack/placement/+/808477 | |
| 17:49:19 | dansmith | melwitt: +2d that | |
| 17:49:30 | dansmith | melwitt: did the other thing to separate the transactions merge? | |
| 17:49:52 | melwitt | dansmith: no it's stuck behind this recent fail. I'm about to rebase onto ^ | |
| 17:50:03 | dansmith | oh really, okay dang | |
| 17:50:06 | melwitt | also thanks for the +2 | |
| 17:50:08 | melwitt | yeah :( | |
| 17:50:26 | dansmith | was going to say, we were still "recheck nova fail"-ing again yesterday | |
| 17:50:39 | dansmith | who else is around to slam this trivial fix in I wonder? | |
| 17:51:06 | melwitt | dansmith: yeah bauzas +W'ed earlier today (the transaction thing) | |
| 17:51:47 | melwitt | oh maybe gmann | |
| 17:52:15 | melwitt | gmann: are you around to review this gate fix for placement? https://review.opendev.org/c/openstack/placement/+/808477 | |
| 17:52:30 | dansmith | ++ | |
| 17:52:31 | gmann | melwitt: sure, checking | |
| 17:53:13 | melwitt | \o/ | |
| 17:53:49 | melwitt | hm actually I'm not sure whether I will need to rebase on the fix. I get confused about whether/when zuul does it automatically | |
| 17:57:10 | gmann | melwitt: +A | |
| 17:57:36 | melwitt | gmann: thank you!! :) | |
| 17:58:05 | dansmith | melwitt: rebase.. rebase like the wind! | |
| 17:58:32 | gmann | dansmith: melwitt as it is different file it should not require rebase, and zuul should merge it once fix is merged | |
| 17:58:45 | gmann | we can try recheck once 808477 is merged | |
| 17:58:49 | dansmith | gmann: there's another fix that depends on this | |
| 17:59:04 | dansmith | rebase so we can make sure this lands before that | |
| 17:59:53 | gmann | 807014 this one ? | |
| 18:00:11 | dansmith | yeah | |
| 18:01:13 | gmann | I think 807014 should pass with recheck once 808477 is merged | |
| 18:01:57 | dansmith | right, | |
| 18:02:17 | dansmith | but 807014 is breaking lots of *other* gates, so we want that in the queue ASAP | |
| 18:03:20 | gmann | ohk. | |
| 18:03:47 | gmann | or try re/another +w can trigger gate pipeline directly ? | |
| 18:05:03 | gmann | but it might do check also. yeah rebase is more safer to put it queue asap | |
| 18:05:06 | melwitt | gmann: it's this if you want to try https://review.opendev.org/c/openstack/placement/+/807014 | |
| 18:05:12 | melwitt | ok, will do then | |
| 18:05:24 | dansmith | I think rebasing is better, | |
| 18:05:34 | dansmith | because if they get kicked out, we want them to stay in the right order for the next trip | |
| 18:05:46 | gmann | ok | |
| 18:06:25 | opendevreview | melanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction https://review.opendev.org/c/openstack/placement/+/807014 | |
| 18:06:53 | dansmith | melwitt: got it | |
| 18:07:09 | melwitt | thanks! | |
| 19:00:05 | opendevreview | Merged openstack/placement master: Call Engine.execute() in func tests for oslo.db 11.0.0 https://review.opendev.org/c/openstack/placement/+/808477 | |
| 19:58:08 | admin1 | hi all .. is this s known error ? is this a known error coming up when launching new instances "Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible. |
|
| 20:03:32 | melwitt | admin1: that means an unhandled exception bubbled up to the api. need to check the nova-api.log to see what happened | |
| 21:09:25 | opendevreview | Merged openstack/placement master: Narrow scope of set allocations database transaction https://review.opendev.org/c/openstack/placement/+/807014 | |
| 23:35:27 | opendevreview | Merged openstack/nova master: [doc] port-resource-request-groups not landed in Xena https://review.opendev.org/c/openstack/nova/+/807564 | |
| #openstack-nova - 2021-09-11 | |||
| 02:57:06 | opendevreview | melanie witt proposed openstack/placement master: Commonize code for updating and creating allocations https://review.opendev.org/c/openstack/placement/+/808535 | |
| 05:59:03 | gibi | melwitt: thank you. | |
| 09:15:54 | opendevreview | Merged openstack/nova master: hardware: Add TODO to remove '(un)pin_cpu_with_siblings' https://review.opendev.org/c/openstack/nova/+/705666 | |
| 10:04:41 | opendevreview | Merged openstack/python-novaclient master: Update master for stable/xena https://review.opendev.org/c/openstack/python-novaclient/+/808461 | |
| 11:10:05 | opendevreview | Merged openstack/python-novaclient master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/python-novaclient/+/808462 | |
| 13:34:50 | opendevreview | xiaoxin yang proposed openstack/nova master: Secure boot requires SMM feature enabled https://review.opendev.org/c/openstack/nova/+/808126 | |
| 14:12:22 | opendevreview | Merged openstack/nova stable/queens: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/791421 | |
| #openstack-nova - 2021-09-12 | |||
| 13:08:20 | opendevreview | Takashi Natsume proposed openstack/osc-placement master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/osc-placement/+/808565 | |
| #openstack-nova - 2021-09-13 | |||
| 08:57:16 | gibi | good morning | |
| 09:03:14 | lyarwood | Morning all \o | |
| 09:13:03 | gibi | lyarwood: there is a fairly easy bug repro and fix for placement that I'd like to land before RC1. melwitt already +2d it. So if you have time I would appreciate some review https://review.opendev.org/q/topic:story-2009167 | |
| 09:13:20 | lyarwood | ack I'll look this morning | |
| 09:15:32 | gibi | thanks | |
| 09:39:21 | gibi | it is just my devstack or we broke $nova-manage db version ? | |
| 09:40:50 | sean-k-mooney | it now uses alembic | |
| 09:40:58 | sean-k-mooney | so its proably changed | |
| 09:41:42 | gibi | https://paste.opendev.org/show/809276/ | |
| 09:42:29 | sean-k-mooney | that is not what i was expecting | |
| 09:42:33 | gibi | yeah | |
| 09:42:40 | gibi | me neither | |
| 09:42:57 | lyarwood | oh fun | |
| 09:43:10 | sean-k-mooney | Engine' object has no attribute 'get_main_option' | |
| 09:43:16 | sean-k-mooney | that should be a config object | |
| 09:43:21 | sean-k-mooney | not an engine right | |
| 09:43:37 | sean-k-mooney | oh its from alembic_version = alembic_api.current(engine) | |
| 09:43:50 | sean-k-mooney | not script_location = config.get_main_option("script_location") | |
| 09:44:09 | sean-k-mooney | are we passing things in the wrong order | |
| 09:45:32 | sean-k-mooney | https://alembic.sqlalchemy.org/en/latest/api/commands.html?highlight=current#alembic.command.current | |
| 09:45:50 | sean-k-mooney | i think ya we are passing the engine insteasd of the config | |
| 09:46:54 | sean-k-mooney | here https://github.com/openstack/nova/blob/master/nova/db/migration.py#L172-L173 | |
| 09:48:13 | sean-k-mooney | we should probaly factor this out into a function https://github.com/openstack/nova/blob/master/nova/db/migration.py#L127-L139 | |
| 09:49:04 | gibi | sean-k-mooney: thanks for the quick check, I will try it in devstack | |
| 09:49:24 | sean-k-mooney | cool i was going to hack something quickly and push it | |
| 09:50:57 | gibi | your suggestion seem to work | |
| 09:50:58 | gibi | https://paste.opendev.org/show/809277/ | |
| 09:52:09 | opendevreview | Merged openstack/os-vif stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/os-vif/+/808452 | |
| 09:52:11 | opendevreview | Merged openstack/os-vif stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/os-vif/+/808453 | |
| 09:52:58 | gibi | sean-k-mooney: is it OK to you if I file a bug and push a fix? | |