Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-09-02
08:21:27 lyarwood ^_^
08:21:38 lyarwood Yeah I guess that part was always useful
08:22:03 kashyap lyarwood: That's quite some etched memory about your first day at school :)
08:22:32 lyarwood s/etched/chiseled/g
08:22:38 kashyap Haha
08:32:35 gibi being at the end of the name list would have other advanteges at least here. We had a big book with the stundents in the class ordered by surname containing basic information and the grades and marks for the student. And teachers tend to use this book to randomly generate a student for oral exam / quiz at the beginning of a class. But humans are bad at randomly opening book...
08:33:15 gibi people in the middle of the book got selected a lot more than the first and the last person
08:35:38 gibi and here in Hungary the primary and middle school are basically a single school, then we have high scool and then university
08:45:02 opendevreview melanie witt proposed openstack/placement master: Add reproducer for Project creation race bug https://review.opendev.org/c/openstack/placement/+/806730
08:45:09 opendevreview melanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction https://review.opendev.org/c/openstack/placement/+/807014
08:48:01 melwitt gibi: sorry for updating your test ^, I got carried away. feel free to revert it if desired. also not sure the fix approach is the best one but I couldn't think of anything better
08:48:02 gibi add a topic on the ptg retrospective about the asia friendly meeting slot https://etherpad.opendev.org/p/nova-yoga-ptg L60 now
08:48:17 gibi melwitt: ack, I will check
08:49:22 gibi thanks for working on it
08:49:26 melwitt tl;dr is I removed the helper method that was being called and thought "oh maybe we can test this higher up the stack" and then I got into the weeds
08:50:44 melwitt no thanks needed. I'm sorry consumer types has been a pain
09:08:15 gibi melwitt: don't be hard on yourself
09:15:06 bauzas sean-k-mooney: just in case you haven't seen my -1 for a doc nit https://review.opendev.org/c/openstack/nova/+/792362/6
09:27:28 stephenfin lyarwood: Can we get a release note for this? https://review.opendev.org/c/openstack/python-openstackclient/+/804377
09:29:26 lyarwood ack I'll respin shortly
10:02:08 opendevreview Stephen Finucane proposed openstack/python-novaclient master: tests: Add missing 'nova update' unit tests https://review.opendev.org/c/openstack/python-novaclient/+/806916
10:02:08 opendevreview Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.90 - Configurable hostnames https://review.opendev.org/c/openstack/python-novaclient/+/806917
10:02:09 opendevreview Stephen Finucane proposed openstack/python-novaclient master: trivial: Remove use of kwargs https://review.opendev.org/c/openstack/python-novaclient/+/806918
10:09:00 stephenfin gibi: lyarwood: Could we merge this ancient release notes patch? I still think the information contained within is useful https://review.opendev.org/c/openstack/nova/+/705667
10:15:21 gibi stephenfin: is it impacting an old release's reno?
10:15:43 gibi does the tooling handle that properly or it will show up in our Xena renos?
10:16:02 stephenfin nope, it'll just update the previous release note
10:16:08 gibi cool
10:16:12 gibi then I will +2 shortly
10:16:22 stephenfin (the release note's "location" is determined by the initial commit)
10:19:23 gibi gthiemonge: hi! mellwit proposed a fix for the placement issue you reported on Tuesday https://review.opendev.org/c/openstack/placement/+/807014 Would it be possible to trigger octavia jobs with a commit that depends-on the fix?
10:20:53 gthiemonge gibi: oh cool! yes, I'll trigger it!
10:21:07 gibi gthiemonge: let us know how it looks
10:21:10 gibi and thanks
10:22:14 stephenfin gibi: Oh, I also need eyes on https://review.opendev.org/c/openstack/nova/+/705666/ too, since it's below the release note change, please + thank you :)
10:22:33 stephenfin I have a series to remove all that crud but I haven't rebased it in a while :-(
10:22:33 gthiemonge gibi: melwitt: thanks
10:22:53 gibi stephenfin: looking
10:24:14 stephenfin ty
10:25:44 lyarwood stephenfin: I'll have to look this afternoon sorry, getting sucked in by a downstream thing
10:37:10 opendevreview sean mooney proposed openstack/nova master: docs: Document virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/792362
10:37:10 opendevreview sean mooney proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware https://review.opendev.org/c/openstack/nova/+/792364
10:37:20 sean-k-mooney bauzas: done ^
11:11:07 opendevreview Stephen Finucane proposed openstack/nova master: neutron: Rework how we check for extensions https://review.opendev.org/c/openstack/nova/+/705792
11:11:08 opendevreview Stephen Finucane proposed openstack/nova master: neutron: Remove references to dead 'qos-queue' extension https://review.opendev.org/c/openstack/nova/+/754448
11:24:58 stephenfin sean-k-mooney: Left comments on that patch ^ fwict, the changes you've made aren't complete. I'd suggest reverting back to the previous version and instead inserting a preceding patch to change the base exception for FlavorImageConflict instead
11:25:14 stephenfin I can do that if you're swamped, given today is feature freeze (?)
11:29:58 sean-k-mooney stephenfin: if you want to go for it
11:30:10 sean-k-mooney i havent fully pasrced what you wrote
11:30:22 sean-k-mooney are you concerned about the other places you have used that
11:30:35 sean-k-mooney i noticed you did not add that excption in the first patch
11:30:54 sean-k-mooney unless i missed it
11:31:15 stephenfin I'm concerned about the other places _others_ have used it
11:31:41 sean-k-mooney ah ok ya i tought about that but didnt have a chance to look
11:32:45 sean-k-mooney stephenfin: you could also just make that a follow up change that change the base code
11:48:06 opendevreview Stephen Finucane proposed openstack/nova master: Add 'hw:vif_multiqueue_enabled' flavor extra spec https://review.opendev.org/c/openstack/nova/+/792356
11:48:07 opendevreview Stephen Finucane proposed openstack/nova master: docs: Document virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/792362
11:48:07 opendevreview Stephen Finucane proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware https://review.opendev.org/c/openstack/nova/+/792364
11:48:29 stephenfin sean-k-mooney: Okay, new comments left. I've respin it to drop that code setting on the back of said comments. Let me know if I missed anything obvious
11:48:39 sean-k-mooney stephenfin: so https://github.com/openstack/nova/blob/75f719e0/nova/api/openstack/compute/servers.py#L854-L855 will still change the code form a 403 to a 400 right
11:49:04 sean-k-mooney so that is still not correct?
11:49:12 stephenfin It will result in a HTTP 400. Where are you getting HTTP 403 from?
11:49:27 sean-k-mooney the orginial expciton inherited form forbiden
11:49:32 sean-k-mooney which returned a 403
11:49:49 stephenfin which original exception?
11:51:02 sean-k-mooney this one
11:51:04 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/792364/8/nova/exception.py
11:51:06 sean-k-mooney in the followup
11:51:20 stephenfin sean-k-mooney: that's a different review
11:51:29 sean-k-mooney yes
11:51:45 sean-k-mooney hum
11:51:52 stephenfin ohhhhh
11:51:54 sean-k-mooney ok its also in INVALID_FLAVOR_IMAGE_EXCEPTIONS
11:52:01 sean-k-mooney so it was getting converted too
11:52:08 sean-k-mooney ok it should be good
11:52:17 stephenfin so because we were introducing this new helper in that change, you suggested changing it there
11:52:26 stephenfin that was not at all obvious :-D context, lad
11:52:45 stephenfin anyway, yeah, it was all getting translated to HTTP 400 in the end
11:52:54 stephenfin and even if it wasn't, this would be an okay change IMO
11:53:06 sean-k-mooney to a 400
11:53:13 sean-k-mooney yes to a 500 no
11:53:26 stephenfin yup, fair
11:53:28 sean-k-mooney anyway ok it should be good again
11:53:34 stephenfin yup, should be
11:54:50 sean-k-mooney and no i was chaning the code in hte bottom change becasue i tought it was not being caught there
11:55:08 stephenfin gotcha
11:55:53 sean-k-mooney we have a top level excption handeler above that that catuche anything that inherits form NovaException
11:56:11 sean-k-mooney that is not caught else whwere i tought we were going all the way to that
11:56:31 stephenfin The whole nova.exception module needs a rework to either double down on exception inheritance or remove it entirely. It's all very confusing. That rework would be seriously tedious though and I doubt anyone sane will want to do it :)
11:57:07 sean-k-mooney ya espcially since we marshal between them in a few places too
11:57:16 stephenfin yup
11:57:36 opendevreview Balazs Gibizer proposed openstack/nova master: Add --sleep option for archive_deleted_rows --until-complete https://review.opendev.org/c/openstack/nova/+/771749
12:10:07 kashyap sean-k-mooney: Heya, are you able to tell what's off with this negative test (only remaining failure from the CI for me) - It passed when I posted the patch locally; https://cpaste.org/?e49aa4ae738ca284#5xdtN3VCgvzp3P5fFPXDmYJ8gYxVRQvuGaKyfxsRjYfb
12:11:02 sean-k-mooney do you have a link to the review
12:12:00 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/794796?
12:12:04 kashyap Yep
12:12:11 kashyap Sorry, was just about to fetch it
12:12:30 sean-k-mooney simple
12:12:45 sean-k-mooney 1.30 is not less then 1.30 https://review.opendev.org/c/openstack/nova/+/794796/3/nova/objects/image_meta.py#190
12:12:46 kashyap (I fixed the trivial notification object part; so ignore that test, pls)

Earlier   Later