Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-08-25
18:26:45 sean-k-mooney melwitt: by the way im just looking at the db tests i assume somehting in here https://github.com/openstack/nova/blob/master/nova/tests/unit/db/main/test_migrations.py that uses the OpportunisticDBTestMixin would be what you want for the alembic urls
18:30:34 melwitt sean-k-mooney: ah, cool. I have used that mixin once before I think. fwiw I wasn't clear on whether we need a database to cover some test inputs or if we only need the config parser behind it. whatever works
18:31:18 melwitt want to be able to do at least a couple of cases, one with the encoded chars and one with a password for example with a literal "%" in it
18:31:41 melwitt or I guess that could just be one case by putting both together in one example
18:32:28 sean-k-mooney ok im just going thought the different fixture we have aviable to us
18:32:30 sean-k-mooney https://github.com/openstack/oslo.db/blob/22b44ee18b1585bc2943a29ddaa18051cb1344ed/oslo_db/sqlalchemy/test_fixtures.py#L399
18:32:46 sean-k-mooney we have the fix ture and the mixins
18:32:55 melwitt ah ok
18:33:39 sean-k-mooney the adhock db fixture allows us to pass a url https://github.com/openstack/oslo.db/blob/22b44ee18b1585bc2943a29ddaa18051cb1344ed/oslo_db/sqlalchemy/test_fixtures.py#L273
18:34:30 sean-k-mooney the opertunistic mixin can be combind with any of the fixture i think
18:35:32 sean-k-mooney we need to modify the engin url if we want to test this right before tuning the db sync
18:36:56 melwitt meanwhile, the consumer types patches are failing on that dang server delete fail for AllocationDeleteFailed conflict 😑
18:37:04 sean-k-mooney melwitt: i have updated stephens exisitng test case already just trying to see if theyer is a good way to also add the extra tests you where hoping for
18:37:46 sean-k-mooney if only there was a patch we could merge for that :)
18:37:52 sean-k-mooney thats furstrating
18:38:32 melwitt sean-k-mooney: ok, cool. lmk if you need a hand with it, I can try to help
20:01:31 opendevreview sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663
20:01:33 sean-k-mooney melwitt: ok that did not work but i found another way to test this
20:02:04 sean-k-mooney i realised after i fot the adhoc fixture working that would not test any of our config loading ectra
20:02:19 sean-k-mooney which is what we actully wanted to test
20:02:47 sean-k-mooney well initalising the alembic config form our config
20:10:26 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Update PCI requests in request spec on resize https://review.opendev.org/c/openstack/nova/+/806049
20:15:41 melwitt sean-k-mooney: sweet! just added some comments
22:18:12 opendevreview Merged openstack/nova stable/wallaby: Allow X-OpenStack-Nova-API-Version header in CORS https://review.opendev.org/c/openstack/nova/+/796860
22:18:15 opendevreview Merged openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170
22:18:30 opendevreview Merged openstack/placement master: Microversion 1.38: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441
22:18:38 opendevreview Merged openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486
#openstack-nova - 2021-08-26
00:35:26 opendevreview Merged openstack/nova stable/train: Raise InstanceMappingNotFound if StaleDataError is encountered https://review.opendev.org/c/openstack/nova/+/777254
02:45:33 jameshyde is this a known bug? every time after live migrating a VM from one hypervisor (source) to another hypervisor (target), nova-compute service is still up and running, but nova-conductor from controller keeps saying this: Failed to compute_task_migrate_server: Compute service of hostname_here is unavailable at this time.: nova.exception.ComputeServiceUnavailable: Compute service of hostname_here is
02:46:25 jameshyde it complains about nova compute service on source host
02:47:31 jameshyde restarting nova-compute works around this issue, but this requiring restarting nova-compute every time after vm live migration away from source host.
06:57:05 opendevreview Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209
07:28:11 kevinz sean-k-mooney: thanks for the update, will ping them next week.
08:11:58 lyarwood jamesdenton: That sounds like a bug if the source service is marked as up and active
08:12:27 lyarwood jameshyde sorry
09:59:31 opendevreview sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663
10:00:16 sean-k-mooney lyarwood: it proably just the bug where rabbit mq loses i thin the topic on the compute recive queue
10:00:54 opendevreview Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550
10:00:55 opendevreview Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732
10:00:55 opendevreview Stephen Finucane proposed openstack/nova master: policy: Deprecate field from 'os-extended-server-attributes' policy https://review.opendev.org/c/openstack/nova/+/806131
10:00:57 sean-k-mooney the one where the compute agent can send rpcs like the heartbeat but not recive them until you recreate the queue
10:01:22 sean-k-mooney eight that or the hostname has change to the instace.host does not match the current host
10:01:57 sean-k-mooney both would break the conductors ablity to manage vms on the host but the agent would be up
10:02:01 lyarwood I was assuming it came from here and the servicegroup API tbh
10:02:02 lyarwood https://github.com/openstack/nova/blob/2a78626a85954997d35f5fe62c50de297e2ca92d/nova/conductor/tasks/live_migrate.py#L284-L288
10:02:12 lyarwood so assuming that's using the db driver
10:02:53 sean-k-mooney well the host in that case comes form instnace.host
10:03:06 sean-k-mooney so if the host name changed on the node that would not fine it properly
10:03:31 lyarwood yup right
10:05:45 sean-k-mooney lyarwood: melwitt by the way just updated the db url test assertin gthe content of the alembic conf and equating it to the the input string
10:06:03 lyarwood ah awesome missed that above
10:06:35 sean-k-mooney just did
10:06:43 sean-k-mooney altought its complaing about failing to merge?
10:06:58 sean-k-mooney oh we both did
10:07:48 sean-k-mooney right pep8...
10:08:08 sean-k-mooney for some reason i dont have pre-commmit in this once copy of nova
10:08:15 lyarwood failed to merge was just because you pushed a new ps of the nova change
10:08:25 sean-k-mooney oh ok
10:11:50 sean-k-mooney oh melwitt was right about the glbal needing to be reset
10:12:32 sean-k-mooney depending on order the test breaks ill fix that and push it again
10:58:58 sean-k-mooney this is infuriating
10:59:33 sean-k-mooney my test works on its own but the connection string is not being passed to alembic if i run multiple db tests
10:59:55 sean-k-mooney reference = 'sqlite:///:memory:?read_default_group=data+with%2Fa+percent_%25-and+symbols%21'
10:59:57 sean-k-mooney actual = 'sqlite://'
11:02:56 sean-k-mooney ok i think i have it working
11:03:08 sean-k-mooney but its one of those thing where you need to run it many times to be sure
11:07:12 opendevreview sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663
11:14:33 opendevreview sean mooney proposed openstack/nova master: db: Handle parameters in DB strings https://review.opendev.org/c/openstack/nova/+/805663
11:15:28 sean-k-mooney lyarwood: ok unless there is review feedback ^ is the final version of that patch
11:15:53 sean-k-mooney i have also restarted the ooo dnm patch so we will see if it works for them in a while
11:16:57 sean-k-mooney stephenfin: oh you reviewd at some point am i did not see that until i looked at my eamil
11:23:00 lyarwood melwitt: https://review.opendev.org/c/openstack/nova/+/800634/12..13/nova/tests/unit/cmd/test_manage.py - would you mind taking another look at this today when you're online, I think I've finally addressed everything.
11:47:29 opendevreview sean mooney proposed openstack/nova master: [FUP] minor cleanup in db migration tests https://review.opendev.org/c/openstack/nova/+/806143
11:48:11 opendevreview sean mooney proposed openstack/nova master: [FUP] minor cleanup in db URL tests https://review.opendev.org/c/openstack/nova/+/806143
12:10:20 artom Heh, why the fup? Original patch hasn't gotten a single +2 yet? :)
12:10:37 artom Ah, gate
12:13:36 sean-k-mooney ya i want to see the results
12:13:40 sean-k-mooney ill likely squash it
13:26:20 gibi something is happening with placement concurrent allocation update issue https://paste.opendev.org/show/808348/
13:27:02 gibi the amount of job failure due to that getting significantly worse
13:27:21 sean-k-mooney hehe that one way to shorten a url
13:27:38 gibi if you have a hammer ...
13:27:49 sean-k-mooney yes it hit melwitt patches yesterday i think
13:28:05 sean-k-mooney i this the same issue that is cause by a concurent delete request
13:28:20 sean-k-mooney if so melwitt has patches for that as im sure your aware
13:28:25 gibi probably we always had this as in http://status.openstack.org/elastic-recheck/#1836754
13:28:33 gibi but now it become significant
13:32:57 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/688802 this is what i was thinking of
13:33:35 sean-k-mooney although i think we shoudl jsut go back to calling delete on the allocation and ignoring the version personally instead of doing a put
13:35:50 opendevreview sean mooney proposed openstack/nova master: Add autopep8 to tox and pre-commit https://review.opendev.org/c/openstack/nova/+/806182
13:41:50 artom sean-k-mooney, we may need for melwitt to wake up for this one, but... does the database fixture actually mock out anything?
13:41:58 artom I don't grok how it's actually used
13:42:35 sean-k-mooney its creating a real db using sqlight in memory database feature
13:43:10 artom OK... So for instance if you pass it a connection URL, it'll create a new context and use its engine: https://github.com/openstack/nova/blob/master/nova/tests/fixtures/nova.py#L625
13:43:43 sean-k-mooney its an interesting question though if i need it now that i have added the other fixture for get engine
13:43:49 artom But then the migration code will always just use the main_db_api.get_engine: https://github.com/openstack/nova/blob/master/nova/db/migration.py#L47
13:44:23 sean-k-mooney ill try droping it now that i have added the addtional fixture and see if that is enough
13:44:43 artom Reason I'm asking is - I've tried using the connection=url kwarg to the Database fixture to avoid your mocking while still fixing the global engine issue
13:44:48 sean-k-mooney i am using this to run a db sync after all so i dont need the db fixture to set other things up for me
13:45:06 sean-k-mooney artom: ya i trided that too but it wont work for 2 reaons

Earlier   Later