| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-24 | |||
| 19:57:37 | sean-k-mooney | im sure we used to update it at least in memory | |
| 19:57:46 | artom | It's kinda tricky to see - *adding* stuff normally fails as expected if no hosts can provide it, because the resource claim uses the flavor and image directly | |
| 19:57:49 | sean-k-mooney | we may not have commited it back to the db | |
| 19:58:03 | sean-k-mooney | but we did use them at some point for scudliign and creatign the xml | |
| 19:58:33 | artom | But *removing* stuff can go wrong, because despite having hosts that can fit the new thing, the scheduler tries to schedule according to the old request spec | |
| 19:59:54 | sean-k-mooney | ok well its broke now so we should fix an backport in anycase | |
| 20:00:21 | artom | Yar | |
| 20:00:39 | sean-k-mooney | but im pretty sure this used to work in icehouse as im pretty sure i tested resizeing to and from vms with pci deviecs back then | |
| 20:01:12 | artom | Perhaps - icehouse was a while ago - and it's pretty specific to hit | |
| 20:01:58 | lyarwood | cuts to titanic 80 years gif | |
| 20:02:17 | sean-k-mooney | hehe | |
| 20:02:57 | sean-k-mooney | yes it was i just remember testing this in the past althogu hit was specific realted to cpu pinnign and pci passtough so i dont know | |
| 20:03:36 | sean-k-mooney | no one complained and the xmls seams to eb right althgu we know that there are several placese where this si broken for move operations in the past so im not that surprised | |
| 20:04:01 | sean-k-mooney | artom: dont we have whitebox test fo this by the way | |
| 20:04:23 | artom | sean-k-mooney, we might... | |
| 20:04:42 | artom | But say you have two hosts with PCI devices - and you resize the instance from "PCI" to "no PCI" | |
| 20:05:03 | artom | It'll work fine - scheduling will pass with the bad old request spec because all hosts have PCI devices | |
| 20:05:17 | artom | It'll only bit you if you only have left hosts with *no* PCI devices | |
| 20:05:24 | artom | *bite you | |
| 20:05:37 | artom | Because then the old request spec can't be scheduled anywhere | |
| 20:05:52 | sean-k-mooney | artom: we not if we were validating the pci claims in the test like we should be | |
| 20:05:58 | sean-k-mooney | but looking we dont have test for this | |
| 20:06:21 | artom | I think claims use the flavor and image directly, so that part's fine | |
| 20:06:35 | artom | By pure luck, really | |
| 20:06:38 | artom | But it's fine :) | |
| 20:06:39 | sean-k-mooney | well we do | |
| 20:06:41 | sean-k-mooney | https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/whitebox_tempest_plugin/api/compute/test_vpmu.py | |
| 20:06:46 | sean-k-mooney | the vpum tests | |
| 20:06:58 | sean-k-mooney | i know we added this recently for a feature | |
| 20:07:06 | sean-k-mooney | *knew | |
| 20:07:25 | sean-k-mooney | the probel with https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/whitebox_tempest_plugin/api/compute/test_vpmu.py#L64-L74 | |
| 20:07:39 | sean-k-mooney | is that we are not asserting anyting baout the request spec | |
| 20:07:41 | sean-k-mooney | just the xml | |
| 20:08:04 | sean-k-mooney | which means on the destination host we are correctly using the new flavor | |
| 20:08:24 | sean-k-mooney | but as you said the scudler is not nessisarly useing the correct extra specs | |
| 20:09:30 | sean-k-mooney | artom: so you have a repoducer do you know where the bug is? | |
| 20:09:34 | sean-k-mooney | or is that still TBD | |
| 20:14:12 | artom | sean-k-mooney, well, I know vaguely where it is - we went through that code together to figure out the OSP 10 resize issue | |
| 20:14:25 | artom | But I don't have a fix yet, will need ot go through it again to figure out the best place for it | |
| 20:14:47 | artom | That code is full of potential races and side effects | |
| 20:15:48 | sean-k-mooney | ack ya ok. | |
| 20:38:39 | opendevreview | Merged openstack/nova master: Fix documentation about cpu topologies https://review.opendev.org/c/openstack/nova/+/805833 | |
| 20:43:27 | lyarwood | elodilles: https://review.opendev.org/c/openstack/nova/+/795435 - would you mind taking a look at this if you have time? | |
| 20:43:46 | NobodyCam | sean-k-mooney: FYI "resource provider / generation" for the win | |
| 20:52:36 | opendevreview | Merged openstack/nova stable/wallaby: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/805304 | |
| 21:38:50 | opendevreview | Merged openstack/nova master: api: Introduce microversion 2.89 adjusting os-volume_attachments https://review.opendev.org/c/openstack/nova/+/804275 | |
| 22:08:32 | opendevreview | Merged openstack/nova master: Follow up from bp/pci-socket-affinity series https://review.opendev.org/c/openstack/nova/+/779556 | |
| #openstack-nova - 2021-08-25 | |||
| 01:36:00 | NobodyCam | sean-k-mooney: I clarify that there is a reserve inventory instance that is tripping up our readiness checks.. | |
| 01:46:43 | opendevreview | Merged openstack/nova stable/stein: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/804615 | |
| 02:25:34 | opendevreview | Merged openstack/nova stable/stein: Prevent archiving of pci_devices records because of 'instance_uuid' https://review.opendev.org/c/openstack/nova/+/760984 | |
| 02:25:43 | opendevreview | Merged openstack/nova master: fup: Remove unused legacy block_device_info format https://review.opendev.org/c/openstack/nova/+/804286 | |
| 02:25:54 | opendevreview | Merged openstack/nova master: fup: Increase service_down_time beyond INITIAL_REPORTING_DELAY in test https://review.opendev.org/c/openstack/nova/+/805667 | |
| 08:56:18 | opendevreview | test proposed openstack/nova master: Add some missing parameters in docs of os-cells https://review.opendev.org/c/openstack/nova/+/805972 | |
| 09:26:57 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 09:51:38 | opendevreview | Balazs Gibizer proposed openstack/placement master: Restrict amqp indirect dep to speed up pip resolution https://review.opendev.org/c/openstack/placement/+/805979 | |
| 09:51:45 | opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | |
| 09:55:59 | lyarwood | gibi: https://review.opendev.org/q/topic:remove_luks_workarounds some simple cleanups here if you have time | |
| 09:56:12 | elodilles | lyarwood: I've commented on the stable/train's CI patch. I'm not completely against it, but it is not necessary in Train so I wouldn't merge it in all cost, plus I see one difference that would reduce coverage if I'm not mistaken: py2 grenade | |
| 09:56:33 | gibi | lyarwood: ack, lookgin | |
| 09:56:37 | lyarwood | elodilles: ack I'll look | |
| 09:56:57 | lyarwood | gibi: thanks, I'm trying to get to your qos series btw, almost there :) | |
| 09:57:04 | gibi | lyarwood: thanks in advance :) | |
| 10:16:24 | opendevreview | Merged openstack/nova master: fup: Fix os-volume_attachments api-ref parameters https://review.opendev.org/c/openstack/nova/+/805876 | |
| 10:24:08 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 10:24:09 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 11:14:15 | opendevreview | Lee Yarwood proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | |
| 11:14:15 | opendevreview | Lee Yarwood proposed openstack/placement master: Restrict amqp indirect dep to speed up pip resolution https://review.opendev.org/c/openstack/placement/+/805979 | |
| 11:14:37 | lyarwood | gibi: ^ just had to reorder these to avoid the 2.6.0 test failure | |
| 11:30:16 | opendevreview | Merged openstack/nova master: Reproduce bug 1941005 https://review.opendev.org/c/openstack/nova/+/805882 | |
| 11:39:56 | kevinz | kashyap: sbauza: Hi, could you help to review this live migration patch? https://review.opendev.org/c/openstack/nova/+/763928, the comments has been addressed. | |
| 11:40:29 | kevinz | kashyap: sbauza: live migration on arm64 patch, really appreciated! | |
| 12:04:15 | sean-k-mooney | kevinz: they are both on vaction this week | |
| 12:04:25 | gibi | lyarwood: right that is the correct order. I knew I wanted to do something with them but I got distracted | |
| 12:04:26 | sean-k-mooney | ill try and take a look at it | |
| 12:04:28 | gibi | thanks | |
| 12:05:53 | gibi | lyarwood: wait, now the 2.6.0 is the first patch, but that will fail due to timeout without the amqp restriciton | |
| 12:06:22 | gibi | do we have a deadlock then | |
| 12:06:25 | gibi | ? | |
| 12:07:30 | gibi | the global req was bumped causing that we need the gabbit update, but that is failing as lower constraints is timing out without the amqp change, but the amqp patch alone will fail due to the gabbit failures | |
| 12:14:45 | opendevreview | Merged openstack/nova master: compute: Query the service group API within check_instance_host https://review.opendev.org/c/openstack/nova/+/802317 | |
| 12:17:16 | lyarwood | gibi: yeah sorry I didn't think the amqp change was causing a failure | |
| 12:17:29 | lyarwood | gibi: in that case we should squash both changes into one I guess | |
| 12:17:40 | gibi | yes, I don't see any other way around | |
| 12:17:45 | gibi | I will squash them in a minute | |
| 12:24:05 | opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-traits to latest 2.6.0 https://review.opendev.org/c/openstack/placement/+/805830 | |
| 12:24:45 | gibi | lyarwood: this should be green now ^^ | |
| 13:09:19 | opendevreview | Merged openstack/python-novaclient master: Microversion 2.89 - os-volume_attachments https://review.opendev.org/c/openstack/python-novaclient/+/805022 | |
| 13:25:17 | opendevreview | lmercl proposed openstack/nova master: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805995 | |
| 13:29:59 | opendevreview | lmercl proposed openstack/nova stable/wallaby: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805997 | |
| 13:40:50 | opendevreview | lmercl proposed openstack/nova master: nova-api add flavorid value to server's flavor part https://review.opendev.org/c/openstack/nova/+/805995 | |
| 14:20:53 | opendevreview | Rodrigo Barbieri proposed openstack/nova stable/victoria: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/806004 | |
| 14:25:50 | gmann | stephenfin: gibi replied on hostname policy chekcs https://review.opendev.org/c/openstack/nova/+/778550/10/nova/api/openstack/compute/views/servers.py#414 | |
| 14:26:04 | gmann | we can chat to conclude it quickly | |
| 14:26:34 | gmann | my point is, this is policy change and should not be controlled with microversion instead just deprecate and remove in next cycle for old microversion also | |
| 14:26:42 | gmann | that is how other policy changes we do | |
| 14:27:56 | gmann | old microversion in this case i mean >2.3 for GET and >2.75 for PUT/Rebuild as this attribute was added for them. | |
| 14:40:44 | gibi | gmann: does this mean we are not implementing the POST /servers change to allow passing hostname in Xena? If we do implement that then delaying the policy change (at least of the new microversion) with deprecation does not make sense from usability perspective | |
| 14:41:15 | gibi | I want see what I passed in | |
| 14:43:58 | gibi | so what if in Xena we deprecate the policy BUT also in xena in the microversion that allows passing hostname in server create we introduce the hostname in the responses. Then in Yoga we remove the policy from the hostname attribute and that results that hostname will be shown in every microversion | |
| 14:44:41 | gibi | this allows that the current POST change be usable in Xena and also follows deprecation policy | |