| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-19 | |||
| 12:25:37 | lyarwood | can't recall no | |
| 12:25:45 | lyarwood | link? | |
| 12:25:53 | sean-k-mooney | https://review.opendev.org/q/topic:%22workaround-disable-apic%22 | |
| 12:26:35 | sean-k-mooney | lyarwood: i mentioned it to you when they were doing the cirrus image respine for the sata dirver | |
| 12:26:59 | sean-k-mooney | i also had a devstack based fix https://review.opendev.org/c/openstack/devstack/+/766079 | |
| 12:28:16 | lyarwood | kk I honestly don't remember this coming up before tbh | |
| 12:29:13 | sean-k-mooney | the guest command line is not used normally by the way | |
| 12:29:25 | sean-k-mooney | lyarwood: it wont be used with qcow images for example | |
| 12:29:35 | sean-k-mooney | its only used if we pass a seperate kernel image | |
| 12:29:36 | lyarwood | eh? | |
| 12:29:52 | lyarwood | right, that's the command line embedded in the image itself | |
| 12:29:55 | lyarwood | so that's always used | |
| 12:30:10 | sean-k-mooney | not in the nova patch | |
| 12:30:16 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/96090 | |
| 12:30:21 | lyarwood | right | |
| 12:30:25 | sean-k-mooney | that wont be used by default | |
| 12:30:27 | lyarwood | I'm talking about my change in Cirros | |
| 12:30:32 | sean-k-mooney | ah right | |
| 12:31:05 | lyarwood | that's why I pushed this, I didn't think we could just leave out the entire apic libvirt conf part out tbh | |
| 12:31:16 | lyarwood | if that's an option we can revive your workaround | |
| 12:31:29 | sean-k-mooney | it can be disabled yes | |
| 12:31:45 | lyarwood | then lets do that I guess | |
| 12:31:45 | sean-k-mooney | or we can change to the split image which is what my devstack patch does | |
| 12:32:08 | lyarwood | right, I'm not keen on that tbh | |
| 12:32:25 | sean-k-mooney | ok lets keep the cirrus patch and ill revive the nova ones which we can use as a workaround until cirrus is fixed | |
| 12:32:36 | lyarwood | if it's fixed tbh | |
| 12:32:42 | sean-k-mooney | altough really they should just update there kerenl | |
| 12:32:42 | lyarwood | I don't think they will go for this | |
| 12:32:47 | lyarwood | yeah | |
| 12:35:20 | sean-k-mooney | ok those are revieved https://review.opendev.org/q/topic:%22workaround-disable-apic%22+(status:open%20OR%20status:merged) we can update the DNM chagne to set it on our jobs or better yet do that in the base devstack job | |
| 12:35:40 | lyarwood | yeah mind if I rebase and play around with it? | |
| 12:36:00 | sean-k-mooney | go for it | |
| 12:36:15 | opendevreview | Lee Yarwood proposed openstack/nova master: fixtures: Add legacy APIs to cinder fixture https://review.opendev.org/c/openstack/nova/+/805195 | |
| 12:36:15 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 12:36:18 | sean-k-mooney | nice find by the way | |
| 12:36:41 | sean-k-mooney | i saw the perodic hang so if fixed it but did not link that to the detach issue | |
| 12:37:12 | sean-k-mooney | most of the cases i saw prevent cloud init form working initally so we did not get that far | |
| 12:38:38 | lyarwood | thanks yeah the tempest rewrite that dumps the console log finally found it | |
| 12:38:47 | lyarwood | might try to add that in other places as well tbh | |
| 12:39:59 | sean-k-mooney | the console dump ya that how i saw it for cloud init since that is dumped anyway | |
| 12:40:28 | sean-k-mooney | without that i would not have seen it either so it is very useful if the test fails | |
| 12:48:56 | sean-k-mooney | lyarwood: feel like doing some os-traits reviews? there are 3 that would be nice to land by client freeze | |
| 12:49:15 | sean-k-mooney | * non-client freeze | |
| 12:49:18 | lyarwood | yeah sure I'll clean this up and take a look | |
| 12:49:42 | sean-k-mooney | https://review.opendev.org/c/openstack/os-traits/+/794807 https://review.opendev.org/c/openstack/os-traits/+/779495 and https://review.opendev.org/c/openstack/os-traits/+/753579 | |
| 12:50:02 | sean-k-mooney | first one is kasyaps and then next two are stephens | |
| 13:02:35 | ganso | gibi, sean-k-mooney, melwitt: Hi! I believe all concerns so far have been addressed, if you have a minute could you please take another look at that 1vcpu patch https://review.opendev.org/c/openstack/nova/+/804303 ? Thanks in advance | |
| 13:05:00 | sean-k-mooney | im ok with this version although you could have used instance.flavor instead of instance.get_flavor() but its fine | |
| 13:05:06 | sean-k-mooney | it will do the same thing | |
| 13:13:32 | opendevreview | sean mooney proposed openstack/os-vif master: extend per-port bridge support to vhost-user https://review.opendev.org/c/openstack/os-vif/+/805214 | |
| 13:15:47 | sean-k-mooney | stephenfin: can you cast your eyes over ^ i think i fixed the nits form the previous patch for tap interfaces too. | |
| 13:17:54 | opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/766043 | |
| 13:18:16 | gibi | lyarwood: left feedback in https://review.opendev.org/c/openstack/nova/+/800634 | |
| 13:22:43 | lyarwood | ack thanks | |
| 13:49:00 | opendevreview | sean mooney proposed openstack/os-vif master: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/805223 | |
| 14:06:56 | opendevreview | Merged openstack/os-traits master: Add a trait for the "bochs" display device https://review.opendev.org/c/openstack/os-traits/+/794807 | |
| 14:18:55 | opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | |
| 14:31:17 | opendevreview | Merged openstack/os-traits master: Add 'COMPUTE_FIRMWARE_UEFI', 'COMPUTE_FIRMWARE_BIOS' https://review.opendev.org/c/openstack/os-traits/+/779495 | |
| 14:32:20 | opendevreview | Merged openstack/os-traits master: List traits in documentation https://review.opendev.org/c/openstack/os-traits/+/753579 | |
| 15:01:59 | opendevreview | sean mooney proposed openstack/os-vif master: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/805223 | |
| 15:03:44 | gibi | sean-k-mooney: I'm out tomorrow (national holiday). Do you think we need to wait with the os-vif last release for Xena? | |
| 15:05:08 | gibi | sean-k-mooney: I can probably check back tomorrow late afternoon and approve the updated release patch if needed | |
| 15:05:59 | opendevreview | Merged openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | |
| 16:01:46 | opendevreview | Merged openstack/nova-specs master: Revert "Amend configurable-instance-hostnames to include response changes" https://review.opendev.org/c/openstack/nova-specs/+/803895 | |
| 16:18:53 | sean-k-mooney | gibi: am honestly i can just backport the things im working on so no we can go ahead | |
| 16:19:14 | gibi | sean-k-mooney: ok, then I approve the release patch | |
| 16:19:41 | sean-k-mooney | cool enjoy your PTO tomorrow | |
| 16:20:39 | gibi | sean-k-mooney: thanks | |
| 16:21:19 | stephenfin | grr, once again bitten by the fact that setting Mock.return_value and Mock.side_effect seems to return the former once and then fall back to the side_effect for all other calls :-( | |
| 16:22:04 | gibi | interesting | |
| 16:22:31 | stephenfin | I think you mean annoying :) | |
| 16:22:40 | gibi | :) | |
| 16:22:43 | gibi | interesting design | |
| 16:22:56 | gibi | I would make return_value and side_effect mutually exclusive | |
| 16:23:15 | stephenfin | So would I. Doing it any other way seems like an anti-pattern | |
| 16:23:32 | stephenfin | If you want a different result or the first call from every other, implement that in the side effect | |
| 16:23:48 | stephenfin | I suspect a bug or edge case, tbh | |
| 16:26:11 | gibi | agree | |
| 16:28:19 | sean-k-mooney | dont we normally | |
| 16:28:23 | sean-k-mooney | i have never seen both used | |
| 16:28:36 | sean-k-mooney | at least i have always used only one or the other | |
| 16:28:39 | opendevreview | Lee Yarwood proposed openstack/nova master: api: Introduce microversion 2.89 adjusting os-volume_attachments https://review.opendev.org/c/openstack/nova/+/804275 | |
| 16:28:43 | stephenfin | I was using a mock configured in a setUp way up in the file | |
| 16:28:44 | sean-k-mooney | perhaps we should add a hacking chekc | |
| 16:29:04 | stephenfin | and missed the fact that it was configured with side_effect | |
| 16:29:17 | sean-k-mooney | ah ok | |
| 16:29:23 | sean-k-mooney | that is harder to catch | |
| 16:29:53 | stephenfin | it was particularly annoying since normally when I see the error I was seeing, it's because I've mocked something twice by accident | |
| 16:30:08 | stephenfin | so I was looking exclusively for that, but the ID of the mock objects were the same in multiple places (i.e. it wasn't that) | |
| 16:30:11 | stephenfin | anyway | |
| 16:44:18 | opendevreview | Merged openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 16:52:52 | opendevreview | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.89 - os-volume_attachments https://review.opendev.org/c/openstack/python-novaclient/+/805022 | |
| 16:53:51 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 16:53:51 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 16:56:04 | lyarwood | melwitt: https://review.opendev.org/c/openstack/nova/+/800634 - Would you mind taking a look at this and the stack under it this week if you get time? | |
| 17:33:33 | gmann | lyarwood: as we are renaming 'id' field too can you quickly append the spec also before we merge the code https://review.opendev.org/c/openstack/nova-specs/+/794799 | |
| 17:34:05 | gmann | I am hoping no issue to update the spec now. gibi ? | |
| 17:37:27 | sean-k-mooney | gmann:the spec is already approved and this would be a minor change so i think that is ok | |
| 17:38:04 | gmann | sean-k-mooney: yeah, it is just to update documentation for what we agreed during implementation | |
| 18:02:54 | opendevreview | Merged openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | |