| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-18 | |||
| 08:08:51 | lyarwood | ctay: so rally might be able to help with this and/or our functional test framework could also assert the behaviour for you | |
| 08:10:57 | lyarwood | https://github.com/openstack/nova/blob/370830e9445c9825d1e34e60cca01fdfe88d5d82/nova/tests/functional/test_scheduler.py but it's pretty limited | |
| 08:45:40 | ctay | lyarwood: from the quick look at the functional test framework for scheduler, it just checks whether it does what it should...that doesn't help us, as we'd like to "predict" how the changes in scheduling will affect the distribution of VM's in the cloud from the current state. | |
| 08:45:40 | gibi | ctay: If I were you I would try to build someting top of the existing functional test env as lyarwood suggested. That env allows you to simulate a huge amount of computes and schedule huge amount of VMs on them without having to provide the real hardware for it. | |
| 08:46:24 | gibi | ctay: you can simply build up a many compute many VM scenario in the func test env and see how the scheduler distribute the VMs with and without your weigher | |
| 08:48:51 | lyarwood | ctay: yeah as gibi said, you can assert the behaviour of the weigher in a similar sized env to your own, we don't have anything that could simulate things on an existing env | |
| 08:49:09 | lyarwood | ctay: using our func framework that is | |
| 08:54:55 | opendevreview | Fabian Wiesel proposed openstack/nova master: VMWare: Use WithRetrieval to get all results https://review.opendev.org/c/openstack/nova/+/804968 | |
| 08:56:02 | ctay | okay, thanks for the advices ... it seems like building upon the existing func framework is a way to go then | |
| 09:19:11 | gibi | lyarwood: I have a question in https://review.opendev.org/c/openstack/nova/+/804230/3/nova/compute/manager.py#8215 | |
| 09:23:57 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/804299/2/nova/tests/functional/compute/test_live_migration.py - ack yeah I added this later in the series after artom asked, it's also covered elsewhere in a regression test iirc | |
| 09:25:50 | gibi | lyarwood: ohh cool | |
| 09:26:21 | lyarwood | https://review.opendev.org/q/topic:bug/1899835 was the regression test but the fix isn't complete yet | |
| 09:42:29 | gibi | lyarwood: there is a bugfix that needs a second set of eyes https://review.opendev.org/c/openstack/nova/+/803603 | |
| 09:42:44 | lyarwood | ack looking | |
| 09:42:49 | gibi | thanks | |
| 09:45:12 | gibi | and if you are on fire then there is a second one here https://review.opendev.org/q/topic:bug/1939193 | |
| 09:55:10 | gibi | lyarwood: as per https://review.opendev.org/c/openstack/nova/+/804275 regarding the 2.88 support in novaclient I think that was landed here https://github.com/openstack/python-novaclient/commit/54d4da112a6e84db5bda497364a49b9debfc2904 | |
| 09:55:41 | lyarwood | weird, the tree I was working on only had 2.87 | |
| 09:55:41 | gibi | lyarwood: the patch that is open in novaclient for 2.88 is acutally for a feature that havent landed yet in nova | |
| 09:55:59 | lyarwood | ack I did wonder | |
| 09:56:07 | lyarwood | okay let me try to rebase/pull things again | |
| 09:56:18 | lyarwood | and I'll push what I have for 2.89 shortly | |
| 09:56:26 | gibi | OK cool | |
| 11:07:48 | opendevreview | Vadym Markov proposed openstack/nova master: Fix for concurrent DB update issue https://review.opendev.org/c/openstack/nova/+/804985 | |
| 11:08:04 | opendevreview | Vadym Markov proposed openstack/nova master: Fix for concurrent DB update issue https://review.opendev.org/c/openstack/nova/+/804985 | |
| 12:47:56 | gibi | \o/ alembic integration is on the gate | |
| 12:48:35 | lyarwood | oh is that what the burning smell is | |
| 12:48:47 | lyarwood | stephenfin++ | |
| 12:48:54 | sean-k-mooney | :) | |
| 12:51:30 | opendevreview | Rodrigo Barbieri proposed openstack/nova master: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/804303 | |
| 12:54:46 | opendevreview | Merged openstack/nova master: db: Unify 'nova.db.api', 'nova.db.sqlalchemy.api' https://review.opendev.org/c/openstack/nova/+/799524 | |
| 12:55:01 | opendevreview | Merged openstack/nova master: db: Exclude the 'use_db_reconnect' option https://review.opendev.org/c/openstack/nova/+/803778 | |
| 12:55:15 | opendevreview | Merged openstack/nova master: db: Move remaining 'nova.db.sqlalchemy' modules https://review.opendev.org/c/openstack/nova/+/799525 | |
| 12:55:28 | opendevreview | Merged openstack/nova master: db: Post reshuffle cleanup https://review.opendev.org/c/openstack/nova/+/799526 | |
| 13:01:50 | opendevreview | Fabian Wiesel proposed openstack/nova master: VMWare: Use get_hardware_devices throughout https://review.opendev.org/c/openstack/nova/+/805017 | |
| 13:14:40 | yonglihe | hello, nova | |
| 13:18:21 | yonglihe | gibi, thanks your review, and the first one still be in +1, https://review.opendev.org/c/openstack/nova/+/771362/38 | |
| 13:18:54 | gibi | yonglihe: hi! fixed it | |
| 13:19:31 | yonglihe | cool! | |
| 13:23:49 | mgariepy | hello, is there a way to add a quota on pci devices or vgpus with nova? | |
| 13:25:37 | sean-k-mooney | not yet | |
| 13:25:45 | sean-k-mooney | it will be supported with unified limits | |
| 13:25:49 | sean-k-mooney | in the future | |
| 13:25:56 | mgariepy | is there a BP ? | |
| 13:26:45 | sean-k-mooney | https://review.opendev.org/q/topic:%22bp%252Funified-limits-nova%22+(status:open%20OR%20status:merged) | |
| 13:27:07 | mgariepy | awesome :D thanks | |
| 13:27:08 | sean-k-mooney | this is the spec https://review.opendev.org/c/openstack/nova-specs/+/789585 ^ is the full set of patches | |
| 13:27:58 | lyarwood | sean-k-mooney: forgot to say that I have that all open for review at somepoint today or tomorrow btw | |
| 13:28:34 | mgariepy | Target release is X or Z i guess ? | |
| 13:28:39 | lyarwood | sean-k-mooney: apologies for not replying last night, got stuck in traffic on the way back from nursery | |
| 13:29:01 | sean-k-mooney | no worries | |
| 13:31:28 | opendevreview | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.89 - Add attachment ids to os-volume_attachments GETs https://review.opendev.org/c/openstack/python-novaclient/+/805022 | |
| 13:47:24 | opendevreview | Fabian Wiesel proposed openstack/nova master: VmWare: Fix deprecation warning in unit tests https://review.opendev.org/c/openstack/nova/+/805024 | |
| 14:07:28 | opendevreview | Merged openstack/nova master: db: Avoid use of ALTER in initial migration https://review.opendev.org/c/openstack/nova/+/800076 | |
| 14:09:43 | opendevreview | Takashi Kajinami proposed openstack/nova stable/victoria: Fix request path to query a resource provider by uuid https://review.opendev.org/c/openstack/nova/+/803550 | |
| 14:10:13 | opendevreview | Takashi Kajinami proposed openstack/nova stable/ussuri: Fix request path to query a resource provider by uuid https://review.opendev.org/c/openstack/nova/+/805004 | |
| 14:27:32 | opendevreview | Merged openstack/nova master: db: Add initial alembic migration for main DB https://review.opendev.org/c/openstack/nova/+/799527 | |
| 14:28:09 | opendevreview | Merged openstack/nova master: db: Add initial alembic migration for API DB https://review.opendev.org/c/openstack/nova/+/799528 | |
| 14:28:41 | opendevreview | Merged openstack/nova master: db: Trivial style changes https://review.opendev.org/c/openstack/nova/+/799529 | |
| 14:29:03 | opendevreview | Merged openstack/nova master: db: Normalize migrations tests https://review.opendev.org/c/openstack/nova/+/799684 | |
| 14:29:33 | opendevreview | Merged openstack/nova master: db: Integrate alembic https://review.opendev.org/c/openstack/nova/+/799530 | |
| 14:30:16 | opendevreview | Merged openstack/nova master: db: Enable auto-generation of migrations https://review.opendev.org/c/openstack/nova/+/800077 | |
| 14:30:42 | opendevreview | Merged openstack/nova master: docs: Add documentation on database migrations https://review.opendev.org/c/openstack/nova/+/800078 | |
| 14:31:10 | opendevreview | Merged openstack/nova master: db: Final cleanups https://review.opendev.org/c/openstack/nova/+/800484 | |
| 14:31:40 | opendevreview | Merged openstack/nova master: tests: Enable SADeprecationWarning warnings https://review.opendev.org/c/openstack/nova/+/804708 | |
| 14:34:30 | gibi | hm, that landed easily | |
| 14:42:56 | gibi | :D | |
| 14:43:08 | opendevreview | Merged openstack/nova master: Block servers with vGPU and device profile in heal_allocations https://review.opendev.org/c/openstack/nova/+/803603 | |
| 14:48:36 | opendevreview | Merged openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 15:09:03 | stephenfin | gibi++ lyarwood++ Thank you both \o/ | |
| 15:09:17 | gibi | stephenfin: thank you for making it happen | |
| 15:09:39 | lyarwood | and fixing any bugs that come up before ga | |
| 15:10:03 | lyarwood | and for fixing* | |
| 15:10:09 | stephenfin | probably not a great time to talk about my forthcoming two month PTO | |
| 15:10:23 | stephenfin | if the French can do it... | |
| 15:10:52 | lyarwood | that isn't PTO that's desertion | |
| 15:11:14 | lyarwood | get planning finally? | |
| 15:12:09 | stephenfin | Ah, no, I'm kidding. Just two weeks of vacation in September | |
| 15:12:41 | stephenfin | No word on planning permission either :'( | |
| 15:15:41 | lyarwood | ah that sucks | |
| 15:16:12 | stephenfin | Out of curiosity, is there any value in me addressing the remaining SQLAlchemy 2.x issues or is bandwidth too limited? https://review.opendev.org/c/openstack/nova/+/804878/ They'll have to be fixed eventually but not necessarily right now | |
| 15:17:15 | stephenfin | The pro being I have the context on this right now that I'm likely to lose and the con being it'll be another 10 patches (or fewer more complex patches, obv) | |
| 15:17:39 | lyarwood | I'm happy to review them if you have the time and context still | |
| 15:18:29 | stephenfin | okay, cool, I'll try whip them together Friday once I've reviewed the few series on my todo list | |
| 15:36:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: [nova-manage]support extended resource request https://review.opendev.org/c/openstack/nova/+/802060 | |
| 15:37:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reno for qos-minimum-guaranteed-packet-rate https://review.opendev.org/c/openstack/nova/+/805046 | |
| 16:00:03 | NobodyCam | Good Morning Nova folks, would anyone have a recommendation for a efficient way to provide kilobytes of metadata... to instances, the Compute meta data is working perfectly but not with larger amounts of data. looking at a requirement to provide 8 to 16 Kb of dynamic metadata over the life of a lease. | |
| 16:00:08 | lyarwood | melwitt: https://review.opendev.org/q/topic:bug/1939545 - would you mind taking a look at this bugfix series this week if you have time? | |
| 16:00:56 | lyarwood | https://review.opendev.org/c/openstack/nova/+/802317 also if you have time | |
| 16:28:46 | melwitt | lyarwood: sure, will do | |
| 18:01:05 | opendevreview | Merged openstack/nova master: libvirt: Abort live-migration job when monitoring fails https://review.opendev.org/c/openstack/nova/+/764435 | |
| 19:07:19 | melwitt | bauzas: sorry to bother you, I wasn't sure if you saw there are two more patches in the placement consumer types series starting here https://review.opendev.org/c/openstack/placement/+/679441 if you might be able to get to them before FF | |
| 20:01:54 | lyarwood | https://bugs.launchpad.net/nova/+bug/1939108/comments/1 \o/ found the source of our weird volume detach issues, a kernel panic during boot... | |
| 20:18:43 | melwitt | lyarwood: nice find!! | |
| 20:25:37 | lyarwood | https://review.opendev.org/c/openstack/nova/+/96090 All this has happened before, and all this will happen again.... | |
| 20:29:29 | melwitt | :( | |
| 23:29:22 | gmann | lyarwood: gibi can we remove 'id' field also in this which was very confused with attachment_id https://review.opendev.org/c/openstack/nova/+/804275/5/nova/api/openstack/compute/volumes.py#256 | |
| 23:32:52 | artom | gmann, heh, I was saying something similar on the spec review | |
| 23:33:49 | artom | https://review.opendev.org/c/openstack/nova-specs/+/794799 | |