| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-08-03 | |||
| 16:18:44 | gibi | sorry | |
| 16:18:47 | bauzas | nah | |
| 16:18:58 | gibi | do we need to bump min version? | |
| 16:19:02 | bauzas | nothing urgent but I'll be off the grid for the next 3 weeks | |
| 16:19:20 | bauzas | gibi: good question, I don't know | |
| 16:19:25 | bauzas | that's why i asked for it | |
| 16:20:06 | bauzas | but meh, let's move on | |
| 16:20:59 | gibi | last time we bumped in wallaby https://review.opendev.org/c/openstack/nova/+/754700 | |
| 16:21:52 | gibi | anyhow if somebody feels that we need a libvirt min version bump then it is the good time to propose it | |
| 16:22:28 | gibi | going back to | |
| 16:22:31 | gibi | #topic Open discussion | |
| 16:22:56 | gibi | 1) this week Thrusday we will have the Asia friendly meeting slot | |
| 16:23:05 | gibi | Aug 5 2021 8:00 UTC #openstack-nova (http://www.timeanddate.com/worldclock/fixedtime.html?iso=2021-08-05T08:00:00) | |
| 16:23:16 | gibi | I will chair it as usual | |
| 16:23:40 | gibi | 2) I will be on PTO next week so I need somebody to chair the next week's weekly meeting | |
| 16:23:45 | gibi | or I will cancel itt | |
| 16:23:46 | gibi | it | |
| 16:24:16 | bauzas | can't run it | |
| 16:24:23 | bauzas | as I'll be on PTO for the next 3 weeks | |
| 16:26:05 | gibi | then I will cancel it | |
| 16:26:09 | gibi | no worries | |
| 16:26:11 | bauzas | heh | |
| 16:26:17 | gibi | any other topic for today? | |
| 16:26:48 | stephenfin | yeah, cancelling seems best given the amount of people that won't be around (I'm thinking I'll be out next week too) | |
| 16:27:23 | stephenfin | no other topics from me | |
| 16:27:44 | gibi | we should just close nova next week :D | |
| 16:28:14 | gibi | so if no other topic then that was it | |
| 16:28:17 | gibi | thanks for joining today | |
| 16:28:39 | gibi | #endmeeting | |
| 16:28:39 | opendevmeet | Meeting ended Tue Aug 3 16:28:39 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:28:39 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2021/nova.2021-08-03-16.00.html | |
| 16:28:39 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2021/nova.2021-08-03-16.00.txt | |
| 16:28:39 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2021/nova.2021-08-03-16.00.log.html | |
| 16:28:50 | bauzas | gibi: thanks | |
| 16:28:56 | gmann | thanks gibi | |
| 16:29:01 | gibi | bauzas: thanks for running it last week | |
| 16:29:28 | bauzas | gibi: well, we had more people than last time I ran, so this was good :D | |
| 16:30:10 | gibi | :) | |
| 16:50:37 | opendevreview | Sylvain Bauza proposed openstack/nova master: Rename vgpu options to mdev https://review.opendev.org/c/openstack/nova/+/801607 | |
| 16:50:37 | opendevreview | Sylvain Bauza proposed openstack/nova master: Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 16:50:38 | opendevreview | Sylvain Bauza proposed openstack/nova master: Provide and use other RCs for mdevs if needed https://review.opendev.org/c/openstack/nova/+/803233 | |
| 16:50:38 | opendevreview | Sylvain Bauza proposed openstack/nova master: Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 16:50:39 | opendevreview | Sylvain Bauza proposed openstack/nova master: Change the admin-visible logs for mdev support https://review.opendev.org/c/openstack/nova/+/803378 | |
| 16:50:39 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: Cleanup GPU vs. mdev wording https://review.opendev.org/c/openstack/nova/+/803379 | |
| 16:50:54 | bauzas | gibi: the last change is for you ^ ;) | |
| 16:51:29 | gibi | thank <3 | |
| 16:51:29 | gibi | s | |
| 17:54:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 17:56:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 17:56:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: WIP support extended res req in heal port allocation https://review.opendev.org/c/openstack/nova/+/802060 | |
| 20:03:07 | opendevreview | Merged openstack/nova stable/victoria: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/797040 | |
| 22:24:13 | opendevreview | Merged openstack/nova stable/ussuri: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/797050 | |
| #openstack-nova - 2021-08-04 | |||
| 08:06:07 | lyarwood | FWIW https://review.opendev.org/c/openstack/nova/+/803322 has hit both https://bugs.launchpad.net/nova/+bug/1938021 and https://bugs.launchpad.net/nova/+bug/1936849 now, I've not had a chance to look at these really so if anyone has time this morning please take a look. | |
| 08:50:09 | gibi | lyarwood: ack, those bugs are on my radar too, but I have conflicting priorities :/ | |
| 08:50:24 | gibi | I will try to look at them this week | |
| 08:54:54 | bauzas | lyarwood: i can try to take a look | |
| 08:55:35 | bauzas | in the meantime, can someone explain me the weirdo issue with mypy in https://review.opendev.org/c/openstack/nova/+/802918/7/nova/virt/libvirt/driver.py#511 ? | |
| 08:55:56 | bauzas | oh, because I used a lambda function | |
| 08:57:00 | bauzas | gibi: any idea how I could tell mypy to *not* ask for a type annotation for a lambda function ? | |
| 08:59:15 | gibi | bauzas: either you gave it a ty.Any annotation | |
| 08:59:16 | gibi | or | |
| 08:59:28 | gibi | there is some comment to silence mypy... | |
| 08:59:42 | gibi | # type: ignore | |
| 08:59:59 | gibi | bauzas: why don't you want to define the type? is it a complicated one? | |
| 09:00:25 | bauzas | gibi: I don't get why myty doesn't ask for an annotation here : https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L474 | |
| 09:00:34 | bauzas | and why it asks for https://review.opendev.org/c/openstack/nova/+/802918/7/nova/virt/libvirt/driver.py#511 | |
| 09:03:01 | bauzas | oh, the type annotation is for the new attribute | |
| 09:03:21 | bauzas | I guess because mypy can't statically guess it | |
| 09:03:35 | bauzas | as it uses a lambda function | |
| 09:03:50 | gibi | bauzas: you can check what mypy can guess reveal_type(<variable>) | |
| 09:04:23 | gibi | as far as I see local variables only resolved if the function is resolved by mypy | |
| 09:04:36 | gibi | so if the function has no annotation on the signature then mypy will not check the locals | |
| 09:05:32 | bauzas | which is the case for __init__ | |
| 09:05:42 | bauzas | but | |
| 09:05:46 | gibi | would be interesting to see what type self._sysinfo_serial_func got from mypy | |
| 09:06:29 | gibi | but anyhow self.mdev_class_mapping is a Dict[str, str] isn't it? | |
| 09:06:30 | bauzas | let me run reveal_type on both mdev_class_mapping and pgpu_class_mapping | |
| 09:06:40 | bauzas | gibi: exact, annotation is simple | |
| 09:08:34 | bauzas | hum, very interesting | |
| 09:10:18 | bauzas | gibi: https://paste.opendev.org/show/807878/ | |
| 09:10:46 | bauzas | if I ask reveal_type() this forces mypy to introspect local variables | |
| 09:11:06 | bauzas | so I guess we now need to add annotations every time | |
| 09:14:38 | opendevreview | Sylvain Bauza proposed openstack/nova master: Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 09:14:39 | opendevreview | Sylvain Bauza proposed openstack/nova master: Provide and use other RCs for mdevs if needed https://review.opendev.org/c/openstack/nova/+/803233 | |
| 09:14:39 | opendevreview | Sylvain Bauza proposed openstack/nova master: Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 09:14:40 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: Cleanup GPU vs. mdev wording https://review.opendev.org/c/openstack/nova/+/803379 | |
| 09:21:34 | gibi | bauzas: I think that only means that mypy did not assign any type to either of those variables but mypy needed to use some type for mdev_class_mapping for something else later so mypy asked the typehint from you. When you added reveal_type you forced mypy to try to assign type to both variables hence is asked typehint for both from you | |
| 09:22:21 | bauzas | gibi: yup, that's what I found | |
| 09:22:30 | bauzas | static typing, my love | |
| 09:22:57 | bauzas | anyway, this is fixed in the last rev, I added an annotation | |
| 09:23:56 | gibi | ack | |
| 09:25:04 | gibi | I'm done with the re-review of the mdev series so far so good :) | |
| 09:25:24 | bauzas | see, I haven't grumbled about mypy | |
| 09:26:20 | bauzas | sure, it's important to tell that a variable using a collections.defaultdict is a dict :p | |
| 09:26:43 | bauzas | just in case people don't know :D | |
| 09:41:38 | bauzas | gibi: I replied to your (good) concern https://review.opendev.org/c/openstack/nova/+/803233/3//COMMIT_MSG#17 | |
| 09:54:07 | stephenfin | kashyap: not an option, I'm afraid https://governance.openstack.org/tc/reference/tags/assert_follows-standard-deprecation.html | |
| 09:57:12 | kashyap | Yeah, I know "standards" | |
| 10:32:27 | sean-k-mooney | kashyap: well in this case its openstacks standard | |
| 10:32:47 | sean-k-mooney | which nova does follow | |