| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-27 | |||
| 17:36:46 | dansmith | I dunno, I have a hard time ever seeing this being not fraught with pain | |
| 17:36:53 | sean-k-mooney | so i think the work flow is project a start the tansfer then project b acclets it | |
| 17:37:01 | dansmith | transferring a volume in isolation is a lot simpler than an instance with tentacles | |
| 17:37:11 | sean-k-mooney | yes true | |
| 17:37:51 | sean-k-mooney | but i like the idea of the transfering state as you said and potentally blocking all or most operation when its in that state | |
| 17:38:12 | sean-k-mooney | we might still want to supprot apport or delete | |
| 17:38:17 | sean-k-mooney | *abort | |
| 17:38:42 | sean-k-mooney | aborting and roling back though is anohter can of worms | |
| 17:38:54 | dansmith | yeah, for serious | |
| 17:40:07 | sean-k-mooney | so the current spec is for instance that dont have volumes only but honestly im not sure how useful it is at that point | |
| 17:40:36 | dansmith | well, you will always have a port, maybe more, so the problem is already bad without volumes | |
| 17:40:42 | dansmith | might as well include the volumes of course | |
| 17:40:48 | sean-k-mooney | also they are adding that stiplulation to avoid the cinder interaction but its still there for neutron and cyborg so really unless we have a solution for all the things im not sure i see the point | |
| 17:41:02 | sean-k-mooney | yep | |
| 17:41:02 | dansmith | what about backups? aren't those somehow linked to the instance? | |
| 17:41:14 | sean-k-mooney | hehe i was just thinking about snapshots in glance | |
| 17:41:34 | sean-k-mooney | which might be store in swift or cinder on the backend | |
| 17:41:37 | melwitt | +1 there are so many worms. but I'm not completely closed off to the idea if other people think it's worth the trouble | |
| 17:42:16 | sean-k-mooney | although i think the volumes / objecst are technialy onwed by glance in that case not the ownere of the image but still | |
| 17:42:23 | dansmith | correct | |
| 17:42:31 | dansmith | the backend wouldn't be a thing I don't think | |
| 17:42:55 | sean-k-mooney | we do store tpm data in swift for shelved instance though | |
| 17:43:06 | sean-k-mooney | and secrets in barbican | |
| 17:43:24 | sean-k-mooney | melwitt: im not agaisnt the idea either just the spec ist trivialising what is a very hard thing to do | |
| 17:43:29 | sean-k-mooney | well to do right | |
| 17:44:24 | melwitt | yeah agree | |
| 18:24:15 | opendevreview | Merged openstack/nova master: docs: Fold in MDS security flaw doc https://review.opendev.org/c/openstack/nova/+/782411 | |
| 18:24:24 | opendevreview | Merged openstack/nova master: docs: Change formatting of hypervisor config guides https://review.opendev.org/c/openstack/nova/+/781439 | |
| 18:24:34 | opendevreview | Merged openstack/nova master: docs: Add libvirt misc doc https://review.opendev.org/c/openstack/nova/+/781440 | |
| 18:38:28 | opendevreview | Merged openstack/placement master: Add periodic-stable-jobs template https://review.opendev.org/c/openstack/placement/+/775384 | |
| 20:02:14 | melwitt | zzzeek: do you know what TypeError("Boolean value of this clause is not defined") means in the context of trying to add a column with nullable=True? (I'm trying the statement you suggested on the review) https://pastebin.com/cVRZjhLk | |
| 20:04:07 | zzzeek | it means the wrong kind of input is either being passed to op.add_column() or something internal in alembic | |
| 20:04:13 | zzzeek | that looks like an older version of alembic at least | |
| 20:04:19 | zzzeek | melwitt: ^^ | |
| 20:05:38 | melwitt | ok thanks for the hint | |
| 20:06:24 | zzzeek | could be a bug woudl have to see the calling code | |
| 20:08:59 | melwitt | this is the | |
| 20:09:02 | melwitt | with op.batch_alter_table('consumers') as batch_op: | |
| 20:09:02 | melwitt | batch_op.add_column('consumers', sa.Column('consumer_type_id', sa.Integer(), sa.ForeignKey('consumer_types.id'), nullable=True)) | |
| 20:09:32 | zzzeek | melwitt: can you run the migration directly? does it only fail when running the test suite? | |
| 20:09:38 | zzzeek | ohhh | |
| 20:09:39 | zzzeek | wait | |
| 20:09:42 | zzzeek | take the table name out | |
| 20:09:54 | zzzeek | batch_op.add_column(sa.Column(...)) | |
| 20:10:09 | zzzeek | ^^^^ | |
| 20:12:02 | melwitt | zzzeek: that looks to have worked, thank you! | |
| 20:13:00 | zzzeek | yup | |
| 20:51:49 | opendevreview | Lee Yarwood proposed openstack/nova master: trivial: Cleanup a comment about a now removed libvirt version check https://review.opendev.org/c/openstack/nova/+/802617 | |
| 20:59:04 | opendevreview | Lee Yarwood proposed openstack/nova master: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/802011 | |
| 20:59:05 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/801990 | |
| 21:21:10 | opendevreview | Merged openstack/nova master: scheduler: Remove 'USES_ALLOCATION_CANDIDATES' https://review.opendev.org/c/openstack/nova/+/773640 | |
| 21:21:35 | opendevreview | Lee Yarwood proposed openstack/nova master: fup: Move _wait_for_volume_attach into InstanceHelperMixin https://review.opendev.org/c/openstack/nova/+/802623 | |
| 21:25:34 | opendevreview | Merged openstack/nova master: scheduler: 'USES_ALLOCATION_CANDIDATES' removal cleanup https://review.opendev.org/c/openstack/nova/+/797513 | |
| 21:58:30 | opendevreview | melanie witt proposed openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170 | |
| 21:58:39 | opendevreview | melanie witt proposed openstack/placement master: Microversion 1.38: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | |
| 21:58:44 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 21:59:54 | opendevreview | Merged openstack/nova master: scheduler: Remove 'hosts_up' https://review.opendev.org/c/openstack/nova/+/773641 | |
| 22:00:02 | opendevreview | Merged openstack/nova master: trivial: Remove FakeScheduler (for realz) https://review.opendev.org/c/openstack/nova/+/773642 | |
| #openstack-nova - 2021-07-28 | |||
| 09:44:08 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace implicit conversion of SELECT into FROM https://review.opendev.org/c/openstack/placement/+/800910 | |
| 09:44:09 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace 'as_scalar()' with 'scalar_subquery()' https://review.opendev.org/c/openstack/placement/+/801100 | |
| 09:44:09 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Update 'select()' calls https://review.opendev.org/c/openstack/placement/+/801103 | |
| 09:44:10 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove use of non-integer/slice indices https://review.opendev.org/c/openstack/placement/+/801104 | |
| 09:44:10 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace deprecated 'FromClause.select().whereclause' parameter https://review.opendev.org/c/openstack/placement/+/801105 | |
| 09:44:11 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Use explicit transactions https://review.opendev.org/c/openstack/placement/+/801106 | |
| 09:44:11 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove unnecessary use of '_mapping' https://review.opendev.org/c/openstack/placement/+/801107 | |
| 09:44:12 | opendevreview | Stephen Finucane proposed openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | |
| 10:19:16 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'Migration' https://review.opendev.org/c/openstack/nova/+/723572 | |
| 10:19:17 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'InstancePCIRequest' https://review.opendev.org/c/openstack/nova/+/723573 | |
| 10:27:08 | lyarwood | stephenfin: haha are you about to remove that from BlockDeviceMapping | |
| 10:27:31 | lyarwood | stephenfin: ./me was about to look at that this cycle once the nova-manage stuff was done | |
| 10:47:41 | sean-k-mooney | that was part of the cleanup you wanted to do be fore encypeted stroage right | |
| 10:49:13 | lyarwood | nope unrelated, just cruft. | |
| 10:49:52 | sean-k-mooney | oh ok i know using the dict accessor on much of that has been considerd tech debt for sometime | |
| 10:50:04 | sean-k-mooney | well using NovaObjectDictCompat in general | |
| 12:57:53 | opendevreview | Artom Lifshitz proposed openstack/nova master: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/801285 | |
| 12:57:54 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802697 | |
| 13:19:37 | opendevreview | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/c/openstack/nova/+/705657 | |
| 13:19:37 | opendevreview | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/c/openstack/nova/+/705658 | |
| 13:19:38 | opendevreview | Stephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures https://review.opendev.org/c/openstack/nova/+/764806 | |
| 13:19:38 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170 | |
| 16:48:46 | opendevreview | sean mooney proposed openstack/os-vif stable/wallaby: add configurable per port bridges https://review.opendev.org/c/openstack/os-vif/+/802475 | |
| 17:01:18 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | |
| 17:01:19 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | |
| 18:00:30 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Add --task-log option to nova-manage db archive_deleted_rows https://review.opendev.org/c/openstack/nova/+/802766 | |
| 19:42:11 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Do not mark disabled but down services as in maintenance https://review.opendev.org/c/openstack/nova/+/802317 | |
| 19:42:11 | opendevreview | Lee Yarwood proposed openstack/nova master: Add regression test for bug 1938326 https://review.opendev.org/c/openstack/nova/+/802801 | |
| 19:54:13 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | |
| 19:54:30 | opendevreview | Lee Yarwood proposed openstack/nova master: trivial: Cleanup a comment about a now removed libvirt version check https://review.opendev.org/c/openstack/nova/+/802617 | |
| #openstack-nova - 2021-07-29 | |||
| 08:45:59 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802840 | |
| 08:46:00 | opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/802841 | |
| 08:49:39 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802842 | |
| 08:49:40 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/802843 | |
| 08:57:03 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802846 | |
| 08:57:04 | opendevreview | Artom Lifshitz proposed openstack/nova stable/ussuri: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/802847 | |
| 09:01:03 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802848 | |
| 09:01:04 | opendevreview | Artom Lifshitz proposed openstack/nova stable/train: Allow deletion of compute service with no compute nodes https://review.opendev.org/c/openstack/nova/+/802849 | |
| 09:56:37 | opendevreview | Qiu Fossen proposed openstack/nova master: Allow migrating PMEM's data https://review.opendev.org/c/openstack/nova/+/802225 | |
| 11:07:42 | opendevreview | Merged openstack/placement master: Fix SQL query counting the number of individual consumers having allocations by only selecting the aggregated consumer_id column. https://review.opendev.org/c/openstack/placement/+/801419 | |
| 11:26:49 | stephenfin | bauzas: lyarwood: Dead simple typo fix here if you have 5 seconds https://review.opendev.org/c/openstack/nova/+/800855 | |
| 11:27:01 | bauzas | ack | |