| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-23 | |||
| 07:18:12 | bauzas | gibi: saw your email about the CI issue | |
| 07:19:07 | bauzas | gibi: thanks for following it | |
| 07:29:12 | gibi | bauzas: good morning | |
| 07:29:40 | gibi | bauzas: it was a full gate block for nova, so it needed to be resolved | |
| 07:29:50 | bauzas | that's what I saw | |
| 07:29:57 | bauzas | but the fix is merged, right? | |
| 07:30:04 | bauzas | oh, a new email :) | |
| 07:30:18 | gibi | yepp gtema fixed it while we slept | |
| 07:44:39 | gibi | sean-k-mooney: when you are up, melwitt holds her +A on the PR re-parenting patch waiting for your re-review. https://review.opendev.org/c/openstack/placement/+/784020 | |
| 07:44:51 | gibi | sean-k-mooney: so if you have time then a quick look would be appreciated | |
| 08:48:31 | opendevreview | Felix Huettner proposed openstack/nova master: Fix duplicate BDMs in compute manager https://review.opendev.org/c/openstack/nova/+/801990 | |
| 09:27:46 | opendevreview | Christian Rohmann proposed openstack/placement master: Fix SQL query counting the number of individual consumers having allocations by only selecting the aggregated consumer_id column. https://review.opendev.org/c/openstack/placement/+/801419 | |
| 10:50:25 | sean-k-mooney | gibi: a sorry about that was not looking at irc. ill be away for then next 30 mins but ill get it when im back | |
| 10:50:34 | gibi | sean-k-mooney: thanks! | |
| 11:06:37 | sean-k-mooney | ok you successfully nerd sniped me i did the review so +1 ok now ill be away for 30 mins :) | |
| 11:07:22 | gibi | sean-k-mooney: thanks a lot | |
| 11:50:50 | opendevreview | Lee Yarwood proposed openstack/nova master: WIP: Add functional test for duplicate bdms https://review.opendev.org/c/openstack/nova/+/802011 | |
| 12:28:27 | sean-k-mooney | bauzas: can you prioritiese reviewing https://review.opendev.org/c/openstack/nova/+/797428/2 i would like to see if we can get that landed this week so we can start backporting it | |
| 12:28:45 | bauzas | ack | |
| 12:29:08 | bauzas | hmpf, a os-vif change | |
| 12:29:10 | bauzas | I'll try | |
| 12:29:16 | sean-k-mooney | we were waitign for it a nova one | |
| 12:29:59 | sean-k-mooney | its fixing a bug i had in my patch that always delectas pluging to os-vif for ovs | |
| 12:31:53 | sean-k-mooney | we were waitign for that pacth to pass ci before mergeing the proceeding patch https://review.opendev.org/c/openstack/nova/+/797142/1 since we wanted to merge them at the same time | |
| 12:38:45 | bauzas | sean-k-mooney: I trusted you as I said in the comment : https://review.opendev.org/c/openstack/nova/+/797428 | |
| 12:39:25 | sean-k-mooney | thanks i was adding you since your revied the preceeding patch | |
| 12:39:44 | sean-k-mooney | mind adding +w to https://review.opendev.org/c/openstack/nova/+/797142 as well | |
| 12:39:48 | opendevreview | Felix Huettner proposed openstack/nova master: Fix duplicate BDMs in compute manager https://review.opendev.org/c/openstack/nova/+/801990 | |
| 12:43:02 | sean-k-mooney | * pinging you | |
| 12:53:59 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Deprecate support for floppy drives in 'Xena' https://review.opendev.org/c/openstack/nova/+/802022 | |
| 13:18:46 | opendevreview | Lee Yarwood proposed openstack/nova master: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/802011 | |
| 13:18:47 | opendevreview | Lee Yarwood proposed openstack/nova master: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/801990 | |
| 13:43:07 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | |
| 14:29:20 | opendevreview | Stephen Finucane proposed openstack/nova master: Remove redundant service version check https://review.opendev.org/c/openstack/nova/+/768195 | |
| 14:29:21 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Use correct microversion for server group tests https://review.opendev.org/c/openstack/nova/+/768196 | |
| 14:30:36 | stephenfin | Yo, anyone care to look at these two scheduler-related functional tests? bauzas perhaps? https://review.opendev.org/q/topic:%22scheduler-filter-tests%22+(status:open%20OR%20status:merged) | |
| 14:31:14 | gibi | stephenfin: I will try before my vacation | |
| 14:31:18 | bauzas | sure, I can try to look | |
| 14:39:37 | gibi | stephenfin: one nit in https://review.opendev.org/c/openstack/nova/+/754115/1/nova/tests/functional/test_scheduler.py#104 | |
| 14:48:27 | bauzas | stephenfin: you misses a few tests | |
| 14:48:37 | bauzas | but thanks for the fish | |
| 14:49:49 | sean-k-mooney | is it me or does this debug log not make sense https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L1032-L1033 | |
| 14:50:09 | sean-k-mooney | if we take the else branch we are not applying any migration context | |
| 14:50:22 | sean-k-mooney | let alone one that does not belog to this instance | |
| 14:53:21 | gibi | stephenfin: also one more nit in https://review.opendev.org/c/openstack/nova/+/754116/1 | |
| 14:54:36 | gibi | sean-k-mooney: I guess it try to say that no migration context is set on the instance | |
| 14:54:55 | sean-k-mooney | right that would make sense | |
| 14:55:20 | sean-k-mooney | i might submit a 2 liner patch to adress that | |
| 14:55:56 | gibi | :) | |
| 14:55:58 | sean-k-mooney | the code is form 6 years ago so its possibel that the function signiture has changeed and it was possibel before or something like that and the message just never got fixed | |
| 14:57:04 | sean-k-mooney | re reading it i can see the interpertation you are suggesting just looking at it in the nova logs it looks odd | |
| 14:57:15 | gibi | I looked at the blame for that reason but I don't see signature changes | |
| 15:04:55 | stephenfin | bauzas: RE: your comment here https://review.opendev.org/c/openstack/nova/+/754116/1/nova/tests/functional/test_scheduler.py#150, is that a thing? | |
| 15:05:02 | stephenfin | the code says no | |
| 15:05:19 | stephenfin | I don't see us stripping the prefix from the metadata properties | |
| 15:05:25 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 15:05:28 | bauzas | did I miss to provide the URL ? my bad | |
| 15:05:58 | bauzas | https://github.com/openstack/nova/blob/3508263f236ea6003a76661b9e657ded4d46b413/nova/scheduler/filters/aggregate_instance_extra_specs.py#L55-L58 | |
| 15:06:32 | bauzas | stephenfin: this both doesn't verify keys with not the prefix, but also strips the key if the prefix is right | |
| 15:06:47 | stephenfin | it does that for the flavor though | |
| 15:06:57 | stephenfin | not the aggregate | |
| 15:07:06 | bauzas | oh, whoops, you're absolutely right | |
| 15:07:31 | stephenfin | I don't want to test the unprefixed variant since that behavior is deprecated and would be rejected with recent microversions | |
| 15:07:32 | bauzas | it's a flavor key, not a metadata extra spec | |
| 15:07:35 | stephenfin | yeah | |
| 15:07:55 | bauzas | stephenfin: ah | |
| 15:08:16 | bauzas | did we deprecated non-prefixed keys ? | |
| 15:08:30 | sean-k-mooney | bauzas: we did i think | |
| 15:08:39 | sean-k-mooney | bauzas: ut the filter still check them | |
| 15:08:40 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 15:08:46 | stephenfin | sort of | |
| 15:09:02 | stephenfin | the docs tell you not to use them, but there's no in-code warning | |
| 15:09:05 | bauzas | my brain fucked somehow | |
| 15:09:07 | sean-k-mooney | we deprecated it because you cant use the aggret extra specs filter and compute capablities filter at the same time if you use unprefixed keys | |
| 15:09:20 | bauzas | sean-k-mooney: sure, I remember why we have this prefix | |
| 15:09:36 | bauzas | but I thought we only *documented* to use it if you were using both filters | |
| 15:09:45 | bauzas | not if you were only using one | |
| 15:09:56 | stephenfin | Multiple values can be given, as a comma-separated list. For backward compatibility, also works with non-scoped specifications; this action is highly discouraged because it conflicts with ComputeCapabilitiesFilter filter when you enable both filters. | |
| 15:10:04 | stephenfin | from way back in Mitaka https://docs.openstack.org/mitaka/config-reference/compute/scheduler.html | |
| 15:10:14 | stephenfin | "highly discouraged" is pretty strong :) | |
| 15:10:26 | bauzas | okay, so this is docs | |
| 15:10:35 | stephenfin | I can add the tests if you really want them though? | |
| 15:10:42 | sean-k-mooney | yes but with the intorctution of the flavor vlaidation it should be even more discuraged | |
| 15:10:42 | bauzas | the problem is that I know more ops that use this filter than the computecaps one | |
| 15:11:04 | bauzas | as the computecapabilities one is pretty useless now we have traits | |
| 15:11:20 | sean-k-mooney | bauzas: it can do thing tratis cant | |
| 15:11:36 | bauzas | stephenfin: as you wish, I won't both | |
| 15:11:38 | bauzas | bother | |
| 15:11:47 | bauzas | stephenfin: you added code, you proved me I was wrong | |
| 15:11:54 | bauzas | so that's a good start | |
| 15:12:02 | stephenfin | well I've done it now | |
| 15:12:07 | stephenfin | so you're getting the tests | |
| 15:12:11 | stephenfin | and you'll be happy with them | |
| 15:12:14 | sean-k-mooney | for what its worth i suggest we require custom: as a prefix when we were adding the flavor extra spec validation | |
| 15:12:38 | opendevreview | Stephen Finucane proposed openstack/nova master: Add tests for 'AggregateImagePropertiesIsolation' https://review.opendev.org/c/openstack/nova/+/754115 | |
| 15:12:38 | opendevreview | Stephen Finucane proposed openstack/nova master: Add tests for 'AggregateInstanceExtraSpecsFilter' https://review.opendev.org/c/openstack/nova/+/754116 | |
| 15:12:46 | stephenfin | gibi, bauzas: comments addressed ^ | |
| 15:13:10 | bauzas | stephenfin: looking again, then | |
| 15:14:20 | stephenfin | I'm pretty sure I had a fairly thorough reworking of the scheduler filter docs at some point. I wonder if that merged? | |
| 15:14:58 | stephenfin | nope https://review.opendev.org/c/openstack/nova/+/773645 | |