| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-15 | |||
| 09:47:24 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Silence SQLAlchemy warnings https://review.opendev.org/c/openstack/nova/+/800900 | |
| 09:47:25 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Remove unnecessary warnings filter https://review.opendev.org/c/openstack/nova/+/800901 | |
| 09:54:04 | stephenfin | bauzas: Think you could look at the first of those. It's dead simple and would remove a *lot* of noise from our CI logs. I'll bug gibi/melwitt when they're back | |
| 09:54:08 | stephenfin | / around | |
| 10:03:27 | bauzas | stephenfin: ack | |
| 10:43:58 | opendevreview | Stephen Finucane proposed openstack/placement master: objects: Replace implicit conversion of SELECT into FROM https://review.opendev.org/c/openstack/placement/+/800910 | |
| 10:43:59 | opendevreview | Stephen Finucane proposed openstack/placement master: tox: Remove psycopg2 warning filter https://review.opendev.org/c/openstack/placement/+/800911 | |
| 10:44:28 | stephenfin | bauzas: Another two for you. That should get rid of all of our warnings, hopefully ^ | |
| 11:00:10 | stephenfin | gibi: Care to look at https://review.opendev.org/c/openstack/nova/+/800900 to silence all those awful SQLAlchemy warnings for now? | |
| 11:13:15 | gibi | stephenfin: thanks for creating that WA ^^ | |
| 11:16:48 | opendevreview | Merged openstack/placement master: Move placement specs from nova https://review.opendev.org/c/openstack/placement/+/800769 | |
| 11:44:01 | opendevreview | Merged openstack/nova master: tests: Silence SQLAlchemy warnings https://review.opendev.org/c/openstack/nova/+/800900 | |
| 11:44:47 | gibi | gmann: I've read the spec and the IRC discussion about the hypervisor uuid. I think if we want to make progress in X then we should go with the microversion route (option 3 in the spec) as we have specfreeze today. This should not prevent us to continue talking about creating some solution that is backportable. | |
| 11:46:16 | gibi | gmann: regarding the backportable fix; is there a way today for the admin to customize the new RBAC policies in a way to implement option 1? | |
| 11:47:03 | gibi | I got that our default is not good for them out of the box, but is there a way for them to change the policy.yaml in a way that solves the listing problem? | |
| 11:50:56 | opendevreview | Merged openstack/nova-specs master: Re-propose nova-audit spec for Xena https://review.opendev.org/c/openstack/nova-specs/+/800570 | |
| 12:08:14 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 12:08:15 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 12:08:16 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - create arqs https://review.opendev.org/c/openstack/nova/+/758944 | |
| 12:08:16 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | |
| 12:08:17 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | |
| 12:08:17 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 12:08:19 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 12:52:08 | ganso | bauzas, lyarwood: Hi! sorry to bother about this again, if you could please take a look at backport https://review.opendev.org/c/openstack/nova/+/800114 when you have a minute, it is the last in the series, just needs one last +2 and +W to go. Thanks in advance! | |
| 14:07:20 | opendevreview | Alexandre arents proposed openstack/nova master: libvirt: Abort live-migration job when monitoring fails https://review.opendev.org/c/openstack/nova/+/764435 | |
| 14:12:55 | aarents | lyarwood: thks for review https://review.opendev.org/c/openstack/nova/+/764435 , I fixed the nits, As I said in comments I'm wondering if it closes also https://bugs.launchpad.net/nova/+bug/1536589 https://bugs.launchpad.net/nova/+bug/1924585 | |
| 14:13:43 | aarents | (older bugs I didn't see before) | |
| 14:26:52 | gmann | gibi: for option1, it cannot be olved via modified poliyc.yaml as GET hypervisor API is scoped to 'system' which is not overridable in policy. | |
| 14:28:32 | gmann | gibi: but we have workaround in different way, 1. system admin give hypervisor name to project admin via non-api way (some document, email or so) 2. assigning the multi role to token like project admin gets the system admin role for that specific request. | |
| 14:30:06 | gibi | gmann: I guess making the scope overridable via policy.yaml would also be considered a feature and hence wont be backportable | |
| 14:30:07 | gmann | gibi: regarding spec for Xena, as we still support legacy policy we have not broken operator yet. I am not so confident/confirm on what solution is best for which use case from operator. I think it is better not to hurry for Xena. | |
| 14:30:54 | gmann | gibi: humm, that will change the design of new RBAC. initial thought was to keep scope as hardcoded for secure security. | |
| 14:31:49 | gibi | gmann: OK, then that is probably a rabbit hole we don't want to go down | |
| 14:32:16 | gmann | yeah, or need more discussion as these project-admin issue were not considered before | |
| 14:32:51 | gmann | I think we should discuss this again in PTG, and also what other project doing for their project-mapped resources need system info | |
| 14:33:18 | gmann | having a consistent solution among all service will matter for operator even that is not best | |
| 14:33:21 | gibi | maybe we can create a simple WA config flag in nova conf that changes the scope of the hypervisor API. that would be ugly but backportable | |
| 14:35:28 | gmann | we have flag to disable the scope check so that is what operator can do. for scope, I am more inclined towards hardcoded only. | |
| 14:35:41 | gmann | but that flag is for all the policy not for particular one | |
| 14:36:55 | gmann | gibi: dansmith but on backport I am re-thinking - does it solve the issue of interrogability or feature-notification ? as many cloud might be upgrading from ocata or less where we cannot backport ? | |
| 14:37:29 | gmann | gibi: dansmith ah sorry, new RBAC is since ussuri so we are good if any backportable soltuion. | |
| 14:37:56 | gmann | and for < ussuri, we anyways have old policy keep working for them | |
| 14:40:48 | gibi | gmann: so the disable scope check flag can be used as a WA? | |
| 14:41:49 | gmann | gibi: right, "disable scope check + override policy.yaml" is WA | |
| 14:42:10 | gmann | that way I think this is not so bad right? | |
| 14:42:26 | gibi | is that enough for stable branches or you would like some extra help for the deployers? | |
| 14:42:41 | gibi | for me it does not sound bad | |
| 14:43:06 | gmann | and fix the default with microversion... ? | |
| 14:43:44 | gibi | yep, fix the situation master | |
| 14:45:14 | gmann | my only concern is disable scope check is for all the policy. BUT nobody has moved to scope check yet so I think it is fine. | |
| 14:45:52 | gmann | gibi: do i have time to make it in Xena. if i update the spec today (right after the TC meeting 1.15 hr from now) ? | |
| 14:46:31 | gmann | I think I am fine on 'doing it in microversion + document the WA' | |
| 15:10:18 | melwitt | elodilles: heads up, I backported the super squash to stable/train https://review.opendev.org/c/openstack/nova/+/795435 here, although ... afaict the gate is no longer broken on train? not sure what happened | |
| 15:10:19 | gibi | gmann: sure. I will review the spec after you updated and we can ask sean-k-mooney or dansmith to give the other +2 | |
| 15:12:43 | gmann | gibi: thanks | |
| 15:13:35 | gibi | gmann: also I don't think anyone will be mad if we land that spec tomorrow :) | |
| 15:17:17 | gmann | gibi: ack | |
| 15:18:27 | gibi | gmann: just ping me when the spec is up. I will be on and off during my evening / night but I will be working as my wife does too | |
| 15:19:10 | gmann | gibi: sure, thanks | |
| 15:25:07 | opendevreview | Merged openstack/nova stable/stein: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/800114 | |
| 15:39:47 | opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | |
| 15:41:18 | elodilles | melwitt: the gate was not broken in train, but tosky suggested that for convenience we should backport the zuulv3 job patch to train as well. however I am not fond of this patch to backport when we don't really need it o:) | |
| 15:42:21 | melwitt | elodilles: ah, ok, I wasn't 100% clear on the context there. I am neutral about it | |
| 15:43:49 | elodilles | well, I don't have hard feelings either, so if stable cores insist then I'm not completely against it :) | |
| 15:45:23 | melwitt | I think I got lost in all the CI fail that I thought stable/train was also failing 😆 | |
| 15:45:43 | opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port data https://review.opendev.org/c/openstack/nova/+/800085 | |
| 15:45:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 15:45:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | |
| 15:45:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | |
| 15:45:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test]Refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | |
| 15:45:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 15:45:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 15:50:14 | elodilles | melwitt: Lee explained somewhere why it is not failing in Train, but I don't find that comment now :/ but anyway, fortunately Train is not blocked by this \o/ | |
| 15:51:22 | melwitt | ack | |
| 17:02:43 | tosky | elodilles, melwitt: yeah, I've added my comments to the patch, I think it makes sense anyway (the long term plan was to remove the legacy jobs anyway) | |
| 17:17:55 | opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | |
| 17:30:49 | opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | |
| 17:40:27 | opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | |
| 17:49:10 | gmann | gibi: dansmith melwitt sean-k-mooney As we need to do the hypervisor uuid support via microversion, and while updating spec for that, I thought it is good chance to remove the legacy way of force host things (via availability_zone) in same microversion + standardizing existing field itself instead of adding new one. | |
| 17:49:45 | gmann | with that I will leave this for xena and we can discuss in PTG for the improvement I added here https://review.opendev.org/c/openstack/nova-specs/+/793011/3/specs/xena/approved/allow-project-admin-list-hypervisors.rst#44 | |
| 17:51:42 | dansmith | gmann: I'm okay with that and I think others are pro-that as well | |
| 17:52:01 | gibi | gmann: ack. please add it to the ptg etherhpad https://etherpad.opendev.org/p/nova-yoga-ptg | |
| 17:52:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | |
| 17:52:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | |
| 17:52:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | |
| 17:52:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | |
| 17:52:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | |
| 17:52:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | |
| 17:52:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | |
| 17:52:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump os-resource-classes to 1.1.0 https://review.opendev.org/c/openstack/nova/+/800976 | |
| 17:52:42 | gmann | sure | |
| 17:59:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | |
| 18:01:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | |
| 18:01:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | |
| 18:01:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor asserts in qos tests https://review.opendev.org/c/openstack/nova/+/798930 | |
| 18:05:16 | gmann | gibi: done | |
| 18:07:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | |
| 18:07:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port data https://review.opendev.org/c/openstack/nova/+/800085 | |
| 18:07:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 18:14:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | |