| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-08 | |||
| 10:50:34 | lyarwood | stephenfin: ship it | |
| 10:56:04 | opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: Add regression test for bug #1909120 https://review.opendev.org/c/openstack/nova/+/773320 | |
| 10:56:05 | opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: api: Reject requests to detach a volume when the compute is down https://review.opendev.org/c/openstack/nova/+/773321 | |
| 12:15:35 | mnaser | does anyone of the top of their mind know what rescue behaviour will be if the vm is bfv? | |
| 12:19:04 | gibi | mnaser: I think normally we don't allow resuce of bfv, but we have stable device rescue that allows it https://docs.openstack.org/nova/latest/user/rescue.html#stable-device-instance-rescue | |
| 12:21:25 | sean-k-mooney | i think it was added recently | |
| 12:21:52 | sean-k-mooney | mnaser: we used to not supprot it at all at one point but i think it was added around train | |
| 12:22:18 | sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/virt-bfv-instance-rescue.html | |
| 12:22:21 | sean-k-mooney | so ussuri | |
| 12:22:57 | sean-k-mooney | mnaser: so no i think it shoudl work like a normal guest | |
| 12:24:02 | sean-k-mooney | it does depend on the stable device rescue too | |
| 12:28:44 | mnaser | oh, stable device rescue is very neat | |
| 12:36:15 | opendevreview | Merged openstack/nova stable/victoria: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/795175 | |
| 12:52:25 | sean-k-mooney | stephenfin: how do we deprecate commands in osc | |
| 12:52:59 | sean-k-mooney | im asking because we shoudl proably start issueing warning whenever someone uses "openstack host list" or similar | |
| 12:53:32 | stephenfin | I'm not sure. I guess with an update to the help string. Using Python's 'warning' lib might be a bit too noisy | |
| 12:53:35 | sean-k-mooney | can we have it output a warnign to std:error and remove it in the future | |
| 12:54:28 | sean-k-mooney | i would like it to shot at people when they use it so they know not too idealy | |
| 12:54:42 | stephenfin | you need to support old clouds though | |
| 12:54:49 | stephenfin | so we don't remove things from OSC, typically | |
| 12:55:11 | sean-k-mooney | ya we can issue the warning based on micorverison | |
| 12:55:24 | gibi | jinx, I wanted to say the same | |
| 12:55:26 | sean-k-mooney | https://docs.openstack.org/api-ref/compute/?expanded=create-image-createimage-action-detail#hosts-os-hosts-deprecated | |
| 12:55:46 | sean-k-mooney | it was depercated in 2.43 and removed in later microverions | |
| 12:56:16 | sean-k-mooney | most of this api was only used by zen i think too | |
| 13:36:49 | lyarwood | mnaser: sorry was on a call earlier, did stable device rescue work for your bfv instance? | |
| 13:55:49 | opendevreview | Merged openstack/nova stable/train: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/798717 | |
| 14:08:41 | mnaser | lyarwood: haven’t tried it yet! | |
| 14:09:15 | lyarwood | kk let me know if you run into any issues :) | |
| 16:15:15 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for main DB https://review.opendev.org/c/openstack/nova/+/799527 | |
| 16:15:15 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for API DB https://review.opendev.org/c/openstack/nova/+/799528 | |
| 16:15:16 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Trivial style changes https://review.opendev.org/c/openstack/nova/+/799529 | |
| 16:15:16 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Normalize migrations tests https://review.opendev.org/c/openstack/nova/+/799684 | |
| 16:15:17 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Integrate alembic https://review.opendev.org/c/openstack/nova/+/799530 | |
| 16:15:17 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Avoid use of ALTER in initial migration https://review.opendev.org/c/openstack/nova/+/800076 | |
| 16:15:18 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Enable auto-generation of migrations https://review.opendev.org/c/openstack/nova/+/800077 | |
| 16:15:19 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Add documentation on database migrations https://review.opendev.org/c/openstack/nova/+/800078 | |
| 16:15:19 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP db: Add our first alembic migration https://review.opendev.org/c/openstack/nova/+/800079 | |
| 16:19:28 | stephenfin | gibi: lyarwood: bauzas: I think that DB series is basically good to go now. I need to wrap up docs and work on that initial migration to identify the test coverage gap that let it through, but it's otherwise in good shape IMO ^ | |
| 16:19:48 | bauzas | stephenfin: I won't be able to review it until end of next week | |
| 16:20:03 | lyarwood | stephenfin: I'll queue it up for tomorrow | |
| 16:20:08 | bauzas | gibi: stephenfin: fwiw, /me goes on PTO tonight till Wed July 14th (incl.) | |
| 16:20:19 | stephenfin | bauzas: ack, no rush | |
| 16:20:34 | stephenfin | well, there is a little rush but nothing more important than PTO :P | |
| 16:21:05 | gibi | stephenfin: ack, I will added to my queue. I try to wrap up the pps code series in the coming day so I think we can traid reviews there :) | |
| 16:21:48 | stephenfin | gibi: yup, I've been keeping an eye on it and am simply waiting for the TODOs in the base patches to disappear before I take a look :) | |
| 16:22:12 | gibi | stephenfin: good decision. I'm constantly reorganizing the series to make it easyier to review | |
| 16:22:17 | gibi | bauzas: have a nice PTO | |
| 16:22:40 | gibi | stephenfin: I will let you know when it make sense to start reviewing | |
| 16:22:46 | stephenfin | ack | |
| 17:06:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | |
| 17:06:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 17:06:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port https://review.opendev.org/c/openstack/nova/+/800085 | |
| 17:09:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 17:09:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | |
| 17:09:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | |
| 17:17:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test]Refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | |
| 17:19:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 19:22:13 | opendevreview | melanie witt proposed openstack/nova stable/train: [CI] Fix gate by using zuulv3 live migration and grenade jobs https://review.opendev.org/c/openstack/nova/+/795435 | |
| 19:34:03 | opendevreview | melanie witt proposed openstack/nova master: Add func test for nova-manage db archive_deleted_rows --before https://review.opendev.org/c/openstack/nova/+/796744 | |
| 19:44:57 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Initialize global data separately and run_once in WSGI app init https://review.opendev.org/c/openstack/nova/+/785061 | |
| 19:59:45 | opendevreview | melanie witt proposed openstack/nova stable/train: Initialize global data separately and run_once in WSGI app init https://review.opendev.org/c/openstack/nova/+/785064 | |
| 21:01:42 | opendevreview | melanie witt proposed openstack/nova stable/train: Initialize global data separately and run_once in WSGI app init https://review.opendev.org/c/openstack/nova/+/785064 | |
| 21:09:59 | opendevreview | Rodrigo Barbieri proposed openstack/nova stable/stein: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/800114 | |
| 21:23:24 | opendevreview | Merged openstack/nova stable/wallaby: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/797039 | |
| #openstack-nova - 2021-07-09 | |||
| 03:08:59 | opendevreview | Merged openstack/nova stable/victoria: Stop leaking ceph df cmd in RBD utils https://review.opendev.org/c/openstack/nova/+/791938 | |
| 09:53:01 | lyarwood | melwitt: https://bugs.launchpad.net/nova/+bug/1931707 btw, that's the same issue as downstream right? | |
| 09:56:52 | stephenfin | lyarwood: gibi: With an operator-like hat on, is there any reason to keep the VERSION argument in 'nova-manage db sync [VERSION]' ? | |
| 09:56:59 | stephenfin | given we don't allow downgrades | |
| 09:57:10 | stephenfin | and you can't really run nova without the latest DB schema | |
| 09:58:33 | sean-k-mooney | stephenfin: my only resevation with removing it is if you want to do the migrations in batches | |
| 09:58:42 | gibi | stephenfin: I think stoping at an intermittent version, do some manual checks / fixes inconsistencies, then continue forward might make sense | |
| 09:59:00 | sean-k-mooney | thats basicaly what i was thinking | |
| 09:59:13 | sean-k-mooney | but if we did things correctly that should not be required | |
| 09:59:14 | gibi | yeah, also batching might make sense if there are heavy transformations | |
| 09:59:39 | gibi | if we never have bugs leading to db inconsistencies then yeah :D | |
| 09:59:54 | sean-k-mooney | stephenfin: with a down stream hat on i dont know if there are FFU cases where we would want to stop an an intermidite release | |
| 10:00:33 | gibi | what my empoyer do during Mitaka -> Victoria FFU is to stop at Pike and Train then go to Victoria | |
| 10:01:19 | gibi | sorry, stop at Newton and Pike | |
| 10:01:35 | stephenfin | okay, batching or step by step upgrades makes sense | |
| 10:01:45 | sean-k-mooney | we might want to stop on n+2 before n+3 to run some online migrations | |
| 10:02:10 | stephenfin | alembic allows us to separate migrations into those that expand (can be done online) and those that contract (requires downtime) | |
| 10:02:24 | sean-k-mooney | ya it does | |
| 10:02:34 | stephenfin | so we might be able to look at finally removing a lot of dead tables and columns in contract migrations | |
| 10:02:38 | sean-k-mooney | is it problematic to continue to supprot this | |
| 10:02:55 | stephenfin | is that a question or a statement? | |
| 10:03:15 | sean-k-mooney | a quetion is it difficult to support db sync version? | |
| 10:03:33 | sean-k-mooney | im wondering why you asked | |
| 10:03:36 | stephenfin | no, not at all | |
| 10:03:43 | stephenfin | I was just wondering if it's worth keeping | |
| 10:04:04 | lyarwood | Yeah I think it is, would avoid the need to ship every release for db migrations | |
| 10:04:04 | sean-k-mooney | ok personally i do not know if it really widely used. typically i would not expect it to be | |
| 10:04:26 | stephenfin | Well, it's slightly tricky. I'm not allowing people to select an sqlalchemy-migrate version. Only alembic ones | |
| 10:04:27 | lyarwood | if we kept a few releases in tree at once that is | |
| 10:04:30 | sean-k-mooney | lyarwood: well we dont drop the db migrations | |
| 10:04:48 | stephenfin | So you won't be able to select any of the migrations > Train, < Xena | |
| 10:04:59 | stephenfin | which I think is fine because they're all placeholders rn | |
| 10:05:11 | lyarwood | right the ones you squashed? | |
| 10:05:24 | stephenfin | I squashed everything up to Train | |
| 10:05:35 | stephenfin | we haven't had a real DB migration since then | |