| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-25 | |||
| 12:23:40 | sean-k-mooney | thats only on master actully we could backport that | |
| 12:24:18 | sean-k-mooney | gibi: i spoke to otherwiseguy about this last night and they have repoduced the issue and a plocibel fix | |
| 12:24:47 | sean-k-mooney | gibi: https://gist.github.com/otherwiseguy/af8f6ede8a09ccf5cef259c93bb00792 | |
| 12:25:12 | sean-k-mooney | that evenlet.sleep will fix it https://gist.github.com/otherwiseguy/af8f6ede8a09ccf5cef259c93bb00792#file-test_eventlet_reconnect-py-L17 | |
| 12:25:58 | gibi | ack | |
| 12:27:18 | gibi | lyarwood: does the os-vif WA helped decreasing the LM issue but not fully avoidet it? | |
| 12:27:28 | gibi | decreasing the frequency | |
| 12:28:56 | sean-k-mooney | gibi: i think lyarwood is a way for a while just an fyi but he will see that when he gets back | |
| 12:31:44 | gibi | sean-k-mooney: thanks | |
| 12:44:42 | opendevreview | Luigi Toscano proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | |
| 12:47:04 | tosky | now that https://review.opendev.org/c/openstack/nova/+/795432/ seems to pass (just need a new +2!), I suspect 795374 may work too | |
| 12:57:08 | opendevreview | Merged openstack/nova master: db: Fold in indexes https://review.opendev.org/c/openstack/nova/+/786296 | |
| 13:08:59 | ganso | lyarwood, elodilles: Could you please re-workflow https://review.opendev.org/c/openstack/nova/+/795432 now that the CI has passed? | |
| 13:23:09 | elodilles | ganso: I'll let lyarwood approve that, as I was who updated the commit message | |
| 14:54:45 | gibi | I hate that I can only choose between a) duplicate the qos functional test to cover pps, b) reimplement a lot of production logic in the test to have dynamic asserts that works both for the old resource request format and the new one. | |
| 14:56:45 | sean-k-mooney | c) dont have tests and just assume its broken? | |
| 14:57:01 | sean-k-mooney | cause that my default when a or b is not done :) | |
| 14:57:42 | gibi | it is in the state of broken now, as I have a buch of TODOs to fix before the new resource request format and logic start fully working. So I've already achieved c) :D | |
| 14:58:35 | gibi | and with simple changes in the production logic I can make some scenarios work, but when I want to add test coverage to it I end up hating any solution I come up with | |
| 14:58:55 | sean-k-mooney | can you point me at the test quickly | |
| 14:59:08 | sean-k-mooney | im going to finsih shortly but maybe something will occure to me | |
| 15:00:01 | sean-k-mooney | this one https://review.opendev.org/c/openstack/nova/+/787205 | |
| 15:00:26 | sean-k-mooney | oh you have them spread over multiple patches | |
| 15:03:04 | sean-k-mooney | o/ | |
| 15:03:05 | gibi | sean-k-mooney: I can make https://review.opendev.org/c/openstack/nova/+/792394/9/nova/tests/functional/test_servers.py#6770 scenario to work locally with some modification in nova's neutron client code. But when I want to make that test actually pass I have to blow up the original test case to modify the asserts | |
| 15:03:12 | gibi | sean-k-mooney: have a nice weekend | |
| 15:04:15 | sean-k-mooney | ah ya i was looking at that | |
| 15:04:31 | sean-k-mooney | but did not see really what it was doiing | |
| 15:04:52 | sean-k-mooney | when you said neutron cleint code do you mean realy code or fixtures | |
| 15:05:10 | sean-k-mooney | i assume /nova/network/neutron.py | |
| 15:05:14 | gibi | that one ^^ | |
| 15:05:43 | sean-k-mooney | ok if it was just the fixture i woudl have jsut said make two | |
| 15:06:14 | gibi | I have multiple fixtures to support old and new resource request format | |
| 15:06:21 | gibi | that is a relatively small duplication | |
| 15:06:32 | gibi | https://review.opendev.org/c/openstack/nova/+/794306/2 | |
| 15:06:59 | gibi | and here https://review.opendev.org/c/openstack/nova/+/792394/9/nova/tests/fixtures/neutron.py | |
| 15:07:51 | gibi | the test logic, especially the the asserts needs to be changed as a) there will be more allocations b) the bindig profile allocation key changes format | |
| 15:09:01 | gibi | I could pull out all the asserts to functions and override the functions in the child test class according to the new needs | |
| 15:10:09 | gibi | it just probably needs a lot of refactoring, and a way to foresee how all assert will look like in the with the new resource request format in place | |
| 15:10:29 | gibi | to know what direction to refactor to | |
| 15:11:25 | sean-k-mooney | it might be simpler to just duplicate things | |
| 15:11:37 | sean-k-mooney | and if you have time later see if the commonality can be abstrated | |
| 15:12:03 | gibi | yeah that is one way to go | |
| 15:12:12 | sean-k-mooney | rather then trying to do both up front | |
| 15:12:45 | gibi | if i copy paste, then I need some reminder not to forget to abstract things out later | |
| 15:12:51 | gibi | as I will be lazy | |
| 15:13:14 | gibi | so not a reminder like a # TODO, but a reminder like a pain in the ass | |
| 15:13:58 | sean-k-mooney | have a test that emails you every time it runs :P | |
| 15:14:28 | gibi | :D | |
| 15:14:50 | sean-k-mooney | duplication when its not extream i think is ok | |
| 15:16:10 | gibi | yeah, in test I allow duplication if in return it helps seeing the test scenario cleanly | |
| 15:16:38 | gibi | I'm affraid there will be extreme copy past now to have all the server create scenarios and then all the server move scenarios covered | |
| 15:16:48 | gibi | ~1000 LOC | |
| 15:17:20 | gibi | anyhow you are right If I cannot predic which direction I should refactor then probably I need to duplicate first | |
| 15:17:29 | opendevreview | Merged openstack/nova master: tests: Allow bindep and test-setup.sh to run on EL distros https://review.opendev.org/c/openstack/nova/+/796428 | |
| 15:40:36 | opendevreview | Merged openstack/nova master: zuul: Add nova-tox-functional-centos8-py36 job https://review.opendev.org/c/openstack/nova/+/796684 | |
| 16:19:05 | opendevreview | Elod Illes proposed openstack/nova stable/stein: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/c/openstack/nova/+/744554 | |
| 16:24:05 | gibi | stephenfin: can we release https://review.opendev.org/c/openstack/oslo.db/+/797426 so that nova can benefit from the silence deprecation warning? | |
| 16:24:16 | stephenfin | gibi: sure | |
| 16:25:20 | stephenfin | I'll ping hberaud | |
| 16:25:27 | stephenfin | in a call atm | |
| 16:25:31 | gibi | cool, thanks | |
| 16:37:13 | opendevreview | Elod Illes proposed openstack/nova stable/train: Use absolute path during qemu img rebase https://review.opendev.org/c/openstack/nova/+/757084 | |
| 16:41:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | |
| 16:42:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | |
| 16:43:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | |
| 16:45:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | |
| 16:46:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | |
| 16:47:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | |
| 16:49:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | |
| 16:50:37 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | |
| 16:51:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | |
| 16:53:21 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | |
| 16:54:43 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208 | |
| 16:56:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | |
| 16:57:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | |
| 16:59:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 17:10:19 | opendevreview | Rodrigo Barbieri proposed openstack/nova stable/ussuri: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/796719 | |
| 17:51:10 | opendevreview | Elod Illes proposed openstack/nova stable/victoria: Stop leaking ceph df cmd in RBD utils https://review.opendev.org/c/openstack/nova/+/791938 | |
| 18:02:46 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: api: Validate host belongs to availability zone https://review.opendev.org/c/openstack/nova/+/798145 | |
| 18:03:25 | stephenfin | gibi: bauzas: Would appreciate input on https://review.opendev.org/c/openstack/nova/+/798145 on Monday, just so I know I'm not wasting my time on that solution. I'll write up a bug if there isn't one already available | |
| 19:30:32 | opendevreview | Merged openstack/nova stable/train: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/c/openstack/nova/+/757177 | |
| 23:11:15 | opendevreview | Merged openstack/nova stable/train: Use absolute path during qemu img rebase https://review.opendev.org/c/openstack/nova/+/757084 | |
| #openstack-nova - 2021-06-26 | |||
| 01:47:42 | opendevreview | Jorhson Deng proposed openstack/nova master: process instance in soft-deleting task state during _init_instance https://review.opendev.org/c/openstack/nova/+/761264 | |
| 09:58:17 | opendevreview | Eric Xie proposed openstack/nova master: Add logs when cannot fit numa https://review.opendev.org/c/openstack/nova/+/798187 | |
| 10:08:38 | opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | |
| #openstack-nova - 2021-06-27 | |||
| 03:04:07 | opendevreview | sean mooney proposed openstack/os-vif master: [WIP] add configurable per port bridges https://review.opendev.org/c/openstack/os-vif/+/798055 | |
| 07:27:07 | opendevreview | Merged openstack/nova stable/wallaby: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/796607 | |
| 11:07:40 | opendevreview | Eric Xie proposed openstack/nova master: Add logs when cannot fit numa https://review.opendev.org/c/openstack/nova/+/798187 | |
| 13:18:03 | gibi | stephenfin: left comments in https://review.opendev.org/c/openstack/nova/+/798145 . I agree with teh generic idea to validate the input | |
| #openstack-nova - 2021-06-28 | |||
| 05:44:40 | opendevreview | Slawek Kaplonski proposed openstack/nova stable/ussuri: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787253 | |
| 06:06:38 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 06:06:39 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 06:06:42 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - create arqs https://review.opendev.org/c/openstack/nova/+/758944 | |
| 06:06:42 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | |
| 06:06:43 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 06:06:45 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 06:06:45 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | |
| 07:39:54 | gibi | sean-k-mooney[m]: do you still hold your -1 on https://review.opendev.org/c/openstack/nova/+/797142 ? the follow up is green | |
| 07:49:34 | gibi | lyarwood: I have a comment in https://review.opendev.org/c/openstack/nova/+/779275 about the assumption that size is always provided to create_image | |