Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-06-23
15:12:12 lyarwood I really need to land https://review.opendev.org/c/openstack/tempest/+/794757 so we can get some guestOS logs in this case
15:13:30 gibi lyarwood: that run is from stable/victoria so we don't have the new detach code there. Do you think it would help if we try to backport the new detach code? or is it possibly unrelated?
15:13:31 lyarwood or we could just Depends-On that from a DNM stable/victoria change
15:13:38 elodilles lyarwood: so you are saying that this is similar like bug #1931716 but not the exact same case?
15:14:04 lyarwood gibi: we've seen failures of this test on master so this time I don't think backporting that code is going to help
15:14:06 lyarwood brb
15:15:15 gibi lyarwood: OK, then I agree to land the tempest improvement first to get more info
15:18:44 opendevreview Elod Illes proposed openstack/nova stable/victoria: DNM: volume detach test https://review.opendev.org/c/openstack/nova/+/797675
15:19:30 elodilles I've created the DNM patch what lyarwood suggested ^^^
15:21:51 lyarwood elodilles: thanks
15:22:23 elodilles np. let's see what happens :)
15:30:06 lyarwood elodilles: I have a change to skip the test on master btw that we could also backport if we see the same soft lockups
15:30:42 opendevreview Stephen Finucane proposed openstack/nova stable/victoria: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/797680
15:30:43 opendevreview Stephen Finucane proposed openstack/nova stable/victoria: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/797681
15:35:54 elodilles lyarwood: thanks, good to know that, we might need to backport that then if needed
15:46:02 kashyap gibi: lyarwood: sean-k-mooney: When you get a min, have a look to see if you spot any holes there: https://blueprints.launchpad.net/nova/+spec/virtio-as-default-display-device
15:50:50 sean-k-mooney that will need a spec most likely
15:51:11 sean-k-mooney im not agaisnt it but we need to record the current modele in use
15:51:17 sean-k-mooney and then only change the default for new instnaces
15:59:48 sean-k-mooney lyarwood: so in this case we dont actully want to do the detach on succesful migration right
16:00:01 sean-k-mooney that is jsut an artifcat of the way the cleanup is done
16:00:11 sean-k-mooney we just want to delete the vm then delete the volume
16:00:19 lyarwood sean-k-mooney: yeah it's just part of the tempest cleanup code that's added when we initially attach
16:00:33 sean-k-mooney could we modify that
16:00:45 lyarwood indeed, we don't need to detach as part of this test
16:00:52 sean-k-mooney add a flag to attach e.g cleanup=false
16:00:55 lyarwood so we could just nuke the instance and move on with our lives
16:01:18 sean-k-mooney yep
16:01:21 lyarwood yup, the only issue is that there's duplication in the tempest code base with lots of this utility code
16:01:32 lyarwood but I can do this for the compute attach volume part at least
16:01:42 lyarwood I think there's another helper in the volume api tests
16:01:47 lyarwood and maybe the scenario manager
16:02:21 sean-k-mooney it should in thoery decrease test execution time
16:03:12 lyarwood Yup we would however drop some coverage of detaching volumes
16:34:00 sean-k-mooney lyarwood: we would but in principal we have tests for that specifically
16:34:23 sean-k-mooney detach is not really a part of what we are testing in this case
16:34:37 sean-k-mooney it does expose racecondition more as we see here
16:34:49 sean-k-mooney but im not sure that is always a good thing
17:19:37 opendevreview Lee Yarwood proposed openstack/nova master: WIP compute: Avoid calling detach with src connection_info during LM rollback https://review.opendev.org/c/openstack/nova/+/797725
17:27:29 sean-k-mooney that was quick
17:39:33 ganso lyarwood: hi! is there anything pending on https://review.opendev.org/c/openstack/nova/+/795432 so it can be merged? That patch was the latest one to pass CI. There are several patches (including one with +W) that haven't had a single positive CI run
19:37:58 lyarwood elodilles: https://review.opendev.org/c/openstack/nova/+/795432 - can you hit this in the morning? I've upgraded my +1 to +2 to move it along.
19:38:17 lyarwood ganso: apologies, I'll work with elodilles and the other stable cores to unblock things in the morning
19:39:47 ganso lyarwood: np! thank you very much! I was mostly wondering if something else was pending because I had rebased on top of it and it still failed. See latest comments in https://review.opendev.org/c/openstack/nova/+/796719
#openstack-nova - 2021-06-24
07:25:05 opendevreview Slawek Kaplonski proposed openstack/nova stable/ussuri: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787253
07:47:10 opendevreview Elod Illes proposed openstack/nova stable/ussuri: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794675
07:51:55 elodilles lyarwood: uhh, I almost messed up the supermegasquash :S
07:52:19 elodilles lyarwood: btw, do we really need there the "Replace nova-live-migration with zuulv3 jobs" ?
07:52:26 elodilles :/
08:18:32 elodilles lyarwood: anyway, I've +2+W'd the supermegasquash
08:23:16 elodilles lyarwood: I also abandoned the ussuri patches that were squashed into the supermegasquash
08:23:40 elodilles just to clean up a bit
08:40:05 lyarwood ganso: ah apologies I see now, the nova-next failure in your stable/ussuri change looks like a known issue with the bionic version of QEMU
08:40:59 lyarwood ganso: we used the zuulv3 change to the live migration jobs to fix this in later releases by moving to Focal but that isn't an option on Ussuri, Train etc.
08:41:20 lyarwood ganso: so tl;dr the zuulv3 changes might not resolve this issue
08:41:42 lyarwood ganso: however we could skip the test if it's failing constantly across the remaining Bionic based branches
08:42:35 lyarwood elodilles: as above I'm not sure that we do need that back on stable/ussuri but at the same time it shouldn't hurt
08:43:18 lyarwood elodilles: the label is defined in the parent tempest job and everything in our job definition should be generic (with the edits I made to the evacuation test role) to run on Bionic
08:46:34 elodilles lyarwood: ok, thanks, meanwhile I came to the same conclusion that it probably doesn't hurt but on the other hand fixes the gate, so i +w'd the patch :)
08:47:04 lyarwood that's the thing, I've not seen an example where it clearly does just yet but hopefully I've missed something
08:48:00 lyarwood the paused instance live migration failure is a known bionic issue and something that we saw back during Victoria that prompted us to move the jobs to Focal as part of the zuulv3 migration
09:38:38 opendevreview Lee Yarwood proposed openstack/nova master: compute: Avoid calling detach with src connection_info during LM rollback https://review.opendev.org/c/openstack/nova/+/797725
09:42:19 opendevreview Lee Yarwood proposed openstack/nova master: compute: Avoid calling detach with src connection_info during LM rollback https://review.opendev.org/c/openstack/nova/+/797725
10:14:21 opendevreview Lee Yarwood proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519
10:20:20 opendevreview Lee Yarwood proposed openstack/nova master: libvirt: Create qcow2 disks with the correct size without extending https://review.opendev.org/c/openstack/nova/+/779275
11:24:58 opendevreview Stephen Finucane proposed openstack/nova stable/ussuri: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/797878
11:24:59 opendevreview Stephen Finucane proposed openstack/nova stable/ussuri: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/797879
11:35:20 opendevreview Stephen Finucane proposed openstack/nova stable/train: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/797880
11:35:21 opendevreview Stephen Finucane proposed openstack/nova stable/train: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/797881
13:23:15 ganso lyarwood: thanks for the response! I've rechecked your patch. failed on grenade job
13:49:13 opendevreview Elod Illes proposed openstack/nova stable/queens: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/c/openstack/nova/+/751249
16:10:07 sean-k-mooney stephenfin: by the way do we want to have comments enabeld in the github mirror?
16:10:23 stephenfin wdym?
16:10:27 sean-k-mooney stephenfin: im not sure how you saw that tread intitally
16:10:41 sean-k-mooney stephenfin: they way we were talking about the client change via github
16:10:57 sean-k-mooney stephenfin: i was wondering if we should talk to infra and see if we can disable that
16:11:06 stephenfin ahh, gotcha
16:11:13 stephenfin I don't think you can disable that
16:11:31 stephenfin and I don't mind, really. I could always ignore the request if I wanted to
16:13:08 sean-k-mooney you can disable Discussions
16:13:13 sean-k-mooney im not sure if that is what that was
16:13:40 sean-k-mooney no not that
16:18:30 sean-k-mooney stephenfin: ya i think its part of the code review feature and cant be disable
16:18:52 sean-k-mooney it was more signeling to people that we do not use it for comunication
16:20:05 stephenfin eh, like I said, I don't think it's a huge deal. I'm happy to be pinged that way. I'll just prod them to other channels
16:20:43 opendevreview Stephen Finucane proposed openstack/nova stable/stein: libvirt: Start checking compute usage in functional tests https://review.opendev.org/c/openstack/nova/+/797974
16:20:45 opendevreview Stephen Finucane proposed openstack/nova stable/stein: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/797975
16:20:46 opendevreview Stephen Finucane proposed openstack/nova stable/stein: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/797976
16:21:03 stephenfin oh, that first patch wasn't supposed to be there
16:21:08 sean-k-mooney yep i just think i have my github notificaiton turned off
16:21:29 sean-k-mooney well no i have them on by they go to my personal email
16:21:43 sean-k-mooney so ill see it eventually
16:23:59 opendevreview Stephen Finucane proposed openstack/nova stable/stein: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/797975
16:24:00 opendevreview Stephen Finucane proposed openstack/nova stable/stein: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/797976
16:47:05 opendevreview Stephen Finucane proposed openstack/nova stable/rocky: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/797981
16:47:06 opendevreview Stephen Finucane proposed openstack/nova stable/rocky: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/797982
16:57:57 opendevreview Stephen Finucane proposed openstack/nova stable/queens: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/797987
16:57:58 opendevreview Stephen Finucane proposed openstack/nova stable/queens: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/797988
17:49:47 sean-k-mooney gmann: i should proably know this but is there a config option or something to disable the nova legacy api i.e. v2.0
17:58:29 sean-k-mooney gmann: i just removed the endpoint definitions form keystone so that will more or less have the same effect so dont worry about it

Earlier   Later