Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-06-22
13:15:39 gibi if we do that the the default should be still to validate the policy
13:15:39 sean-k-mooney the real question is why is the existing code not validating it when we have the json scmea files to do that and unit test that apprently are testing the validation
13:16:08 sean-k-mooney gibi: yep agreed if we have a config option it shoudl default to validating
13:16:25 gibi good question. unfortunately I have swamped with other things right now
13:57:33 sean-k-mooney am.... wehre do we actully do the jsonscema validation fo the api schema https://codesearch.opendev.org/?q=jsonschema&i=nope&files=&excludeFiles=&repos=openstack/nova
14:27:07 sean-k-mooney ah this is how we import them https://codesearch.opendev.org/?q=from%20nova.api.openstack.compute.schemas%20import&i=nope&files=nova%2Fapi&excludeFiles=&repos=openstack/nova
14:27:42 sean-k-mooney and this is where we use the server group schema https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/server_groups.py#L26
14:29:15 sean-k-mooney and this is where we apply the vlaidations https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/server_groups.py#L182-L184
14:42:56 gibi sean-k-mooney: there is a bug around VDPA https://bugs.launchpad.net/nova/+bug/1933096
14:43:42 sean-k-mooney that should not happen
14:43:53 sean-k-mooney we have a version check for this
14:44:23 sean-k-mooney let me triple check but im pretty sure we only try to use that if libvirt is knew enouch
14:47:11 sean-k-mooney its used here https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/virt/libvirt/host.py#L1338
14:48:36 sean-k-mooney which is called form here https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/virt/libvirt/vif.py#L537-L540
14:49:03 sean-k-mooney i guess we dont have a libvirt verion check here
14:49:30 sean-k-mooney but they would only hit this if they were using a vdpa port with a version of libvirt that did not uspprot this
14:50:13 sean-k-mooney although form the trace it looks like this is from the perodic
14:51:07 sean-k-mooney which is protected by the version check
14:51:09 sean-k-mooney https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/virt/libvirt/driver.py#L7346-L7349
14:55:50 gibi sean-k-mooney: the bug report says they see it on libvirt 7.0.0
14:56:00 gibi that would pass our version check
14:56:17 sean-k-mooney yep just responding i think there version fo libvirt python is older then there libvirt version
14:56:25 sean-k-mooney which is not supported
14:59:53 sean-k-mooney hum successfully installed libvirt-python-7.4.0
14:59:56 sean-k-mooney that should work
15:16:27 kashyap The libvirt commit that introduced that _CAP_VDPA should be available from v.6.9.0 (including the Pyth bindings too):
15:16:30 kashyap $> git tag --sort version:refname --contains 53aec799fa31 | head -1
15:16:32 kashyap v6.9.0
15:16:33 kashyap (That was on libvirt Git repo)
15:21:16 sean-k-mooney yep next thing to check is the libvirt-python version on pypi
15:24:43 sean-k-mooney so "sean@p50:~/Downloads/libvirt-python-7.4.0$ grep -i VDPA -r *" should have found something but it has not
15:36:01 opendevreview Stephen Finucane proposed openstack/nova master: libvirt: Always delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797428
15:53:22 gibi nova weekly meeting starts in 6 minutes here in the channel
16:00:05 gibi #startmeeting nova
16:00:05 opendevmeet Meeting started Tue Jun 22 16:00:05 2021 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:05 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:05 opendevmeet The meeting name has been set to 'nova'
16:00:25 bauzas \o
16:00:54 dansmith o/ (kinda)
16:01:00 sean-k-mooney o/
16:01:35 elodilles o/
16:01:41 gibi \o
16:02:08 alistarle o/
16:02:18 gibi #topic Bugs (stuck/critical)
16:02:25 gibi No critical bugs
16:02:30 gibi #link 21 new untriaged bugs (+7 since the last meeting): #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New
16:02:43 stephenfin o/
16:02:51 gibi our backlog is growing so please if you have some time then look at it and triage some bugs
16:03:36 gibi is there any specific bug that we need to discuss now?
16:04:10 sean-k-mooney gibi: i am pretty sure that https://bugs.launchpad.net/nova/+bug/1933096
16:04:16 sean-k-mooney is a bug in ther ci env
16:04:24 sean-k-mooney so hopefully we can close that soon
16:04:45 gibi sean-k-mooney: cool. thanks for looking into that
16:05:53 gibi if nothing else then
16:05:53 gibi #topic Gate status
16:05:58 gibi Nova gate bugs #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure
16:06:01 bauzas gibi: I'll look at open bugs
16:06:16 gibi bauzas: thank you
16:06:23 gibi I don't see fresh gate bug in that list
16:06:31 gibi last week we merged couple of fixes
16:06:46 gibi how do you feel, does the gate improved?
16:06:46 sean-k-mooney am any suggestions on who i should ping to move https://review.opendev.org/c/openstack/devstack/+/796826 along in devstack
16:07:06 bauzas thanks lyarwood btw.
16:07:13 bauzas for the gate failures fixes
16:07:44 gibi sean-k-mooney: gmann could be one
16:08:09 sean-k-mooney i assume that we are still seeing the intermitant failures due to the agent haning
16:08:31 sean-k-mooney so if we can merge that sooner rather then later it should help with gate stablity
16:08:32 gibi I was off yesterday and did not push any code today so I don't have the view what is failing ont he gate
16:08:46 gibi but I agree that devstack patch is a good step forwa4rd
16:09:17 gibi anything else about the gate?
16:10:34 gibi Placement periodic job status #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly
16:10:38 gibi placement jobs are green
16:10:47 gibi #topic Release Planning
16:10:51 gibi Milestone 2 is 15 of July which is spec freeze
16:10:55 gibi Spec review day is 6th of July #link http://lists.openstack.org/pipermail/openstack-discuss/2021-June/023083.html
16:11:01 gibi anything else about the coming milestone?
16:12:47 gibi #topic Stable Branches
16:12:52 gibi copying notes from elodilles
16:12:56 gibi stable/ussuri is blocked (fix needs to be merged: https://review.opendev.org/c/openstack/nova/+/794675 )
16:13:00 gibi other branches should be OK (however, there are quite frequent volume detach failures for example on stable/victoria)
16:13:05 gibi stable/ocata branches of nova are EOL, branches are deleted ( https://review.opendev.org/c/openstack/releases/+/795664 )
16:13:08 gibi EOM
16:13:25 elodilles sorry, I was lost in the ussuri gate fixing patches,
16:13:35 gibi the detach failure has a fix on master
16:13:36 elodilles i will try to sort it out in the coming days
16:13:59 gibi https://review.opendev.org/c/openstack/nova/+/796255
16:14:05 gibi this needs to be backported I think
16:14:10 gibi hm
16:14:23 gibi no\
16:14:24 gibi sorry
16:14:32 gibi I'm not sure
16:15:28 gibi that fix helps with the detach issue on master where we have the new notification based detach
16:15:46 sean-k-mooney it would need to be backported to any release using the events?
16:15:56 sean-k-mooney but not where we poll?
16:16:12 sean-k-mooney so if we backport the events based detach we need to backport both
16:16:30 gibi sean-k-mooney: that is my understanding yes
16:16:42 elodilles I saw lot of failures in victoria as I said, can it be valid backport there?
16:17:18 sean-k-mooney i think its a relitivly safe backport in either case
16:17:36 gibi elodilles: the detach modification is pretty huge patch but it does not change external interfaces
16:17:51 sean-k-mooney gibi: did we backport your events patch to victoria?

Earlier   Later