Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-06-21
14:13:09 stephenfin sean-k-mooney: ^ will wait and see how the stable/ussuri change goes (I can't run all tests locally in my env) but that _should_ be it
14:17:30 sean-k-mooney ok good
14:17:40 sean-k-mooney did you hit any issue with python2 compatiablity
14:17:53 sean-k-mooney or other funcitonal test issue
14:19:22 opendevreview Merged openstack/nova master: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/769601
14:22:56 stephenfin sean-k-mooney: not that I can tell. The modified tests did pass
14:23:04 stephenfin (I could run those)
14:23:42 stephenfin gibi: Are you around today? Care to look at https://review.opendev.org/c/openstack/nova/+/797142 if so?
14:23:42 sean-k-mooney i was ok cool from thje commit it looks like the conflict were not as bad as i was fearing
14:24:06 sean-k-mooney s/i was//
16:11:44 opendevreview Stephen Finucane proposed openstack/nova stable/ussuri: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797291
16:20:11 opendevreview Stephen Finucane proposed openstack/nova stable/train: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797316
17:51:36 sean-k-mooney stephenfin: https://zuul.opendev.org/t/openstack/build/73f734b9ffe745bd833ffe90f324d6d8/log/controller/logs/screen-n-cpu.txt#7643-7653
17:51:55 sean-k-mooney stephenfin: its still using <interface type=bridge>
17:52:22 sean-k-mooney stephenfin: it should be <interface type=ethernet>
17:59:41 sean-k-mooney stephenfin: this is how i orginally set teh flag by the way https://review.opendev.org/c/openstack/nova/+/602432/29..30/nova/objects/migrate_data.py
18:02:05 sean-k-mooney i was trying to use udate which updates in place and returns None instead of the updated dict which was a bug
18:04:42 sean-k-mooney this is the only other thing that chaged that jumped out at me https://review.opendev.org/c/openstack/nova/+/602432/29..30/nova/conductor/tasks/live_migrate.py#b403
18:04:52 sean-k-mooney but i think that is logically the same thing
18:06:48 sean-k-mooney so we still have the same probelm that i was havign with that patch orginally when i put in the code to detect if the dest was patched it always disables the code even after fixing the profile update issue
18:07:04 sean-k-mooney even with https://review.opendev.org/c/openstack/nova/+/797142
18:07:53 sean-k-mooney i can try and take a look at this with you tomorow if you like but i think we need a functional test that assert the xml has interface type=ethernet
#openstack-nova - 2021-06-22
08:37:04 zigo Since Bullseye, live migration is broken on my system, with libvirt not listening on the qemu+tcp port (it's using socket activation). Does anyone know how to configure the new libvirt correctly for this?
08:58:09 stephenfin sean-k-mooney1: you're looking at the wrong XML, I think
08:59:47 stephenfin sean-k-mooney1: You can see the update happening here https://zuul.opendev.org/t/openstack/build/73f734b9ffe745bd833ffe90f324d6d8/log/compute1/logs/screen-n-cpu.txt#7468-7476
09:02:09 bauzas do someone know whether we use in our jobs the singleconductor devstack value ? https://github.com/openstack/devstack/blob/master/lib/nova#L537 ?
09:02:42 bauzas I was expecting us to create a superconductor by default even for a devstack AIO
09:09:06 bauzas nevermind, found it
09:09:15 bauzas this is just legacy
09:09:45 bauzas I can't see a single job running with a singleconductor
09:15:34 stephenfin bauzas: maybe remove it so?
09:15:41 stephenfin *we should
09:15:47 bauzas yup, think so
10:07:34 sean-k-mooney1 stephenfin the xml should always be ethernet
10:08:40 sean-k-mooney1 stephenfin: it is useing ethernet in that segment which is good
10:08:54 sean-k-mooney1 but it should spawn with it too
10:09:51 sean-k-mooney1 stephenfin: ok so we need to determin why its only taking effect on migration and not on inital spawn
10:10:12 sean-k-mooney1 that narrows it down at least
10:14:54 stephenfin sean-k-mooney: We never set the 'delegate_create' attribute of the VIF object anywhere except as part of a migration
10:15:37 stephenfin sean-k-mooney: https://github.com/openstack/nova/commit/a62dd42c0dbb6b2ab128e558e127d76962738446#diff-d47af556a60631b879ac4f609e24b5616aa81643d152583b1591ef90848382bbR108
10:16:01 stephenfin which means it's never set as part of the os-vif object https://github.com/openstack/nova/commit/a62dd42c0dbb6b2ab128e558e127d76962738446#diff-918e740344fd54062b1d2040fc7d83a6fb349e33a484b3a442d154977a7f872bR350
10:16:05 sean-k-mooney ah ok that was my orginal error then. i used to do it uncondtionally then i added the code to do the patch detection
10:17:05 sean-k-mooney so we want to default it to true but have the migration code check and disable if the dest is not supported
10:19:49 stephenfin I can look into that. It's a different issue than the one I'm fixing in that patch though, so I think that patch is still valid by itself
10:22:03 opendevreview Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209
10:22:35 sean-k-mooney it is but without that other change its a really odd behavior
10:22:45 sean-k-mooney i kind of think they need to be in one patch
10:23:16 sean-k-mooney we dont want the interface to be differn after a live migration and have it chagne back after a hard reboot do we
10:23:26 sean-k-mooney we could do that but it feels odd
10:23:59 sean-k-mooney its also not what i had planned in that libvirt would still be invovled in port plugging
10:24:41 sean-k-mooney stephenfin: we can just set it here i belive https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L2972
10:26:10 sean-k-mooney although that technically would mean it should be in the vif model object
10:27:06 opendevreview Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209
10:28:02 sean-k-mooney this is where we make the desision currently
10:28:25 stephenfin sean-k-mooney: we create the VIF just after we call that function https://github.com/openstack/nova/blob/5979c648462b03a2fe90148f20f099c964cdd298/nova/network/neutron.py#L3078
10:28:31 sean-k-mooney stephenfin: we need create port to default to true
10:28:36 stephenfin so we can just set it there always
10:28:55 stephenfin there's no reason it ever needs to be false - it will be ignored for backends where it doesn't make sense
10:29:46 sean-k-mooney am we could but you will have to extend the vif model object if you do that which will change the versioned notifcations
10:29:51 sean-k-mooney and that wont be backportable
10:30:04 sean-k-mooney we need to do this slightly different
10:30:11 stephenfin that's no an o.vo
10:30:13 stephenfin *not
10:30:18 sean-k-mooney its not but its in one
10:30:23 sean-k-mooney the network info cache
10:30:35 sean-k-mooney its got a list of vifs
10:30:55 stephenfin but the VIF model has already been modified https://github.com/openstack/nova/commit/a62dd42c0dbb6b2ab128e558e127d76962738446#diff-dfa43d5033ab6af143d8772d584ed93255e60deb7bc58d87eb7305b19f8fa2ffR381
10:30:59 sean-k-mooney i guess we normally dont change for compostion but it does change the hash
10:31:24 sean-k-mooney by addign a constant and properties
10:31:31 sean-k-mooney both of which do not change the version of the object
10:31:51 sean-k-mooney oh
10:31:56 sean-k-mooney sorry you ar just setting the property
10:32:10 sean-k-mooney ya so that is why that property stores its data in the profile
10:32:20 sean-k-mooney to avoid the ovo change and be backportable
10:32:22 sean-k-mooney ok
10:32:32 sean-k-mooney so yes we can just set the property to true uncondtionally
10:33:37 sean-k-mooney but we als have https://github.com/openstack/nova/blob/5979c648462b03a2fe90148f20f099c964cdd298/nova/network/model.py#L405
10:33:41 sean-k-mooney ok im confused
10:34:01 sean-k-mooney i tought that was an ovo issue but maybe not
10:34:06 stephenfin those are just dics
10:34:08 stephenfin *dicts
10:34:17 stephenfin so we can store whatever we want in them
10:34:17 sean-k-mooney ok so we just pass delegate_create=True
10:34:44 sean-k-mooney stephenfin: they are but they are also https://github.com/openstack/nova/blob/master/nova/objects/instance_info_cache.py#L38
10:35:21 sean-k-mooney i guess thats a network model
10:35:31 stephenfin all that that's doing is calling '.json' on the object https://github.com/openstack/nova/blob/5979c648462b03a2fe90148f20f099c964cdd298/nova/objects/fields.py#L1084
10:35:37 stephenfin so it doesn't really matter
10:36:08 sean-k-mooney well its is using https://github.com/openstack/nova/blob/5979c648462b03a2fe90148f20f099c964cdd298/nova/network/model.py#L512
10:36:19 sean-k-mooney ok i guess its fine
10:36:28 sean-k-mooney i had issue adding other filds in the past
10:36:37 sean-k-mooney but maybe i was chanign something else
10:36:52 sean-k-mooney in anycase i think your right we can just set it to true there
10:37:11 sean-k-mooney but we need to ensure in the migration path we set it to false wehn its not present orginally
11:13:44 gibi stephenfin, sean-k-mooney: for me https://review.opendev.org/c/openstack/nova/+/797142 looks fine, but sean-k-mooney has a -1 on it so I'm affraid of approving it
11:15:55 sean-k-mooney gibi: thats what we were discussign above stephen fixed it for migration but its still using the wrong interface type on boot
11:16:17 gibi OK, so there will be changes. thanks
11:16:26 sean-k-mooney so with that patch as is we boot with interface type=bridge then we migrate with ethernet and hard reboot back to bridge
11:16:49 sean-k-mooney the orignal intent was to always use ethernet
11:17:21 sean-k-mooney gibi: technically as is this should actully fix the migration issue we were trying to fix
11:17:35 sean-k-mooney but its a little odd to change the type just for the migration

Earlier   Later