| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-18 | |||
| 13:55:56 | gibi | I think we need get rid of the foo.bar['aaa'] by returning a frozen dict | |
| 13:55:56 | stephenfin | at least not in tests | |
| 13:56:28 | sean-k-mooney | stephenfin: its suoudl this was one of the things i had to workaround when writhing tha tpatch | |
| 13:56:31 | gibi | as the getter returns a copy of the underlining data not a reference for it | |
| 13:56:48 | gibi | so we have to tell the caller that it is copy | |
| 13:56:52 | gibi | not a live ref | |
| 13:56:55 | jkulik | frozen dict sounds good. then nobody can accidentally use the non-working pattern | |
| 13:57:49 | sean-k-mooney | frozen dict wont work | |
| 13:58:03 | sean-k-mooney | the issue is we are storing a json string | |
| 13:58:19 | gibi | sean-k-mooney: it does not solve the problem, it forces the caller to avoid modifying what is returned | |
| 13:58:23 | stephenfin | well it would indicate that you can't update it | |
| 13:58:25 | sean-k-mooney | and then we are returning it as a dict and we want update to that property to modify the json | |
| 13:58:37 | sean-k-mooney | gibi: right but we want them to be able to do that | |
| 13:58:38 | stephenfin | however, there's no such thing in stdlib | |
| 13:58:43 | gibi | sean-k-mooney: I don't :) | |
| 13:58:56 | sean-k-mooney | well for this code we are talkign too we do | |
| 13:59:10 | sean-k-mooney | other wise we shoudl jsut remove the property | |
| 13:59:21 | sean-k-mooney | and force use to work direclty on the json | |
| 13:59:43 | opendevreview | Merged openstack/nova-specs master: Fix the bp link in the cyborg admin token spec https://review.opendev.org/c/openstack/nova-specs/+/795493 | |
| 13:59:45 | sean-k-mooney | the only reason the properties exist is to to give a dict like interface to the json blobs | |
| 14:00:00 | sean-k-mooney | stephenfin: what test is failing | |
| 14:00:08 | gibi | sean-k-mooney: then we need to make it one level deper allowing to set per key | |
| 14:00:24 | gibi | like foo.bar.test = 'aaa' | |
| 14:00:25 | stephenfin | none currently, because we don't have tests covering this code path | |
| 14:00:46 | gibi | sean-k-mooney: but that needs more work on the implementation side | |
| 14:01:16 | sean-k-mooney | stephenfin: the quick fix is as follows | |
| 14:01:18 | sean-k-mooney | self.profile[OS_VIF_DELEGATION] = supported | |
| 14:01:24 | sean-k-mooney | becomes | |
| 14:01:38 | kashyap | Am I hallucinating, or were the check marks of x, ✔, and ? used to be in colour on the support-matrix page? - https://docs.openstack.org/nova/wallaby/user/support-matrix.html | |
| 14:02:09 | sean-k-mooney | data = jsonutils.loads(self.profile_json); data[OS_VIF_DELEGATION]=supported; self.profile_json = jsonutils.dumps(data); | |
| 14:02:27 | sean-k-mooney | stephenfin: here https://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py#L89 | |
| 14:03:01 | sean-k-mooney | kashyap: they were yes | |
| 15:14:23 | gibi | stephenfin: could you please hit https://review.opendev.org/c/openstack/osc-placement/+/794276 when you have time | |
| 15:54:47 | gmann | stephenfin: lyarwood if that broken on fedora having py3.9 ? but we do have py3.9 job running successfully though those are n-v | |
| 15:56:32 | gmann | is that | |
| 16:22:21 | opendevreview | Merged openstack/nova master: Handle OPERATION_FAILED error during detach https://review.opendev.org/c/openstack/nova/+/796255 | |
| 17:15:25 | stephenfin | lyarwood: Good thing you asked for that test. This code is doing nothing currently 😇 | |
| 17:15:54 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Fix VIFMigrateData.supports_os_vif_delegation setter https://review.opendev.org/c/openstack/nova/+/797142 | |
| 17:15:59 | stephenfin | sean-k-mooney: ^ | |
| 17:16:24 | stephenfin | I haven't run those tests locally. I want to push it to the gate and see if the interfaces are correctly created in the Tempest job | |
| 17:16:53 | stephenfin | gmann: The main issue I was seeing is that the deps in lower-constraints don't work with Python 3.9 | |
| 17:17:20 | stephenfin | gmann: However, in the past the functional tests didn't work with Python 3.9. It could be possible that things have been fixed since | |
| 17:18:05 | stephenfin | gmann: However, regardless, there's no reason we should be running different things locally and in the CI. Something could conceivably pass locally (where we're using Python 3.9) but fail in the gate (using Python 3.8) | |
| 17:18:36 | stephenfin | gibi: done | |
| 17:18:40 | gmann | stephenfin: yeah, l-c can be dropped :) which i am not much worried about. | |
| 17:19:36 | gmann | stephenfin: cases like passing py3.9 and failing py3.8 should not be much right as at next cycle we want all code to run on both | |
| 17:20:12 | gmann | stephenfin: i am not against of that change to test py3.8 as default locally but it just add extra work you mentioned in commit msg | |
| 17:20:18 | stephenfin | Sure, but what about when Fedora introduces Python 3.10 | |
| 17:20:41 | stephenfin | Fedora is bleeding edge, and there will always be a delay between when Fedora introduces a Python version and when nova supports it | |
| 17:21:07 | stephenfin | we already have to update setup.cfg to state our supported versions so this is minimal extra work IMO | |
| 17:21:42 | gmann | yeah that is automated in release script i think and may we can add tox basepython update also.. | |
| 17:22:02 | stephenfin | that would be helpful | |
| 17:25:16 | gmann | stephenfin: we can merge that I am not -1 on that. I will see if we can automate in release script sometime later | |
| 17:27:51 | opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/790447 | |
| 17:30:27 | opendevreview | Merged openstack/osc-placement master: default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | |
| 17:39:00 | opendevreview | Stephen Finucane proposed openstack/nova stable/victoria: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/797144 | |
| 17:39:31 | stephenfin | hmm, why can't I leave -W on stable/wallaby? | |
| 17:39:36 | stephenfin | but I can on stable/victoria | |
| 17:48:15 | gmann | stephenfin: because of owner? | |
| 17:49:47 | stephenfin | ohhh | |
| 17:49:51 | stephenfin | yeah, that's it | |
| 17:49:58 | stephenfin | whoops :) | |
| #openstack-nova - 2021-06-19 | |||
| 01:03:59 | opendevreview | Merged openstack/nova master: db: Remove 'nova.db.sqlalchemy.utils' https://review.opendev.org/c/openstack/nova/+/786292 | |
| 01:04:24 | opendevreview | Merged openstack/nova master: db: Reintroduce validation of shadow table schema https://review.opendev.org/c/openstack/nova/+/796814 | |
| 01:04:41 | opendevreview | Merged openstack/nova stable/wallaby: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/794186 | |
| 13:28:32 | opendevreview | Merged openstack/nova stable/wallaby: Stop leaking ceph df cmd in RBD utils https://review.opendev.org/c/openstack/nova/+/791939 | |
| 13:28:50 | opendevreview | Merged openstack/nova master: db: Remove unused DB methods https://review.opendev.org/c/openstack/nova/+/786293 | |
| 18:48:11 | opendevreview | Merged openstack/nova stable/wallaby: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791577 | |
| #openstack-nova - 2021-06-20 | |||
| 15:10:18 | opendevreview | Merged openstack/nova stable/stein: Validate id as integer for os-aggregates https://review.opendev.org/c/openstack/nova/+/764308 | |
| #openstack-nova - 2021-06-21 | |||
| 01:46:34 | opendevreview | jiang guodao proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 01:55:06 | swp20 | gmann: hi, our cyborg-tempest-plugin test failed, seems there are no accelerator resources on the zuul server, please help us: https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/796977 | |
| 03:23:56 | opendevreview | jiang guodao proposed openstack/nova stable/victoria: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787252 | |
| 05:58:29 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 05:58:30 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 05:58:31 | opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 05:58:32 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 05:58:33 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 07:09:51 | opendevreview | Eric Xie proposed openstack/nova master: Fix error '404 Not Found' https://review.opendev.org/c/openstack/nova/+/797233 | |
| 08:32:34 | slaweq | elodilles hi, can You +W patch https://review.opendev.org/c/openstack/nova/+/787252 ? It was rebased recently | |
| 08:34:19 | elodilles | slaweq: +W'd | |
| 08:36:41 | elodilles | I hope it really merges now... the gate is in surprisingly bad shape according to the rechecks on this patch :/ | |
| 08:37:55 | elodilles | despite that a number of gate improvements were merged :X | |
| 08:56:15 | lyarwood | sean-k-mooney / gibi / artom / bauzas ; https://review.opendev.org/c/openstack/nova/+/797142 - can you all take a look at this when you get a chance? Blocks the already in progress backport of https://review.opendev.org/q/I11fb5d3ada7f27b39c183157ea73c8b72b4e672e | |
| 08:56:21 | lyarwood | oh and morning btw :) | |
| 08:56:30 | bauzas | fer sur | |
| 08:56:44 | bauzas | and bonjour | |
| 09:27:22 | slaweq | elodilles thx a lot | |
| 09:37:20 | elodilles | slaweq: np | |
| 10:52:28 | stephenfin | sean-k-mooney: It's working for real this time now https://review.opendev.org/c/openstack/nova/+/797142 | |
| 10:53:32 | sean-k-mooney | stephenfin: yep reviewing it again | |
| 10:54:16 | sean-k-mooney | i did not have a chance to test that since i added the detection mechanium in a real mixed env only with the ci | |
| 10:54:35 | sean-k-mooney | its annoying that this sliped though but im about to +1 that | |
| 10:55:16 | stephenfin | lyarwood: I'd rather avoid addressing those nits on ^, since I've already prepared the backports (with a -1 to prevent anyone merging yet) and don't want to drag more work on myself :-D | |
| 10:55:31 | stephenfin | I could do a follow-up but they seem too minor to bother, for once | |
| 10:56:21 | sean-k-mooney | i dont think the new=... | |
| 10:56:24 | sean-k-mooney | is needed | |
| 10:56:31 | sean-k-mooney | its defenetly nice to prefer to do that | |
| 10:56:38 | sean-k-mooney | if the mock is not required in the test | |
| 10:57:04 | sean-k-mooney | but we didnt do that until about a year or so ago because we did not know we could | |
| 10:57:22 | sean-k-mooney | so its not inconsitnet with thte exsiting test just not the optimal way | |