| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-17 | |||
| 15:24:15 | kashyap | stephenfin: sean-k-mooney: NUMA-related: you might find it interesting - libvirt upstream is wiring up "HMAT" - which defines the different latencies and bandwidths b/n NUMA nodes: | |
| 15:24:19 | kashyap | [quote] | |
| 15:24:21 | kashyap | "Links between NUMA nodes can have different latencies and bandwidths. This info is newly defined in ACPI 6.2 under Heterogeneous Memory Attribute Table (HMAT) table. Linux kernel learned how to report these values under sysfs and thus we can expose them in our capabilities XML. The sysfs interface is documented in kernel's Documentation/admin-guide/mm/numaperf.rst." | |
| 15:24:27 | kashyap | [/quote] | |
| 15:24:58 | kashyap | This is called "NUMA interconnects", apparently: https://listman.redhat.com/archives/libvir-list/2021-June/msg00268.html | |
| 15:28:12 | sean-k-mooney | ill take a look | |
| 15:46:21 | sean-k-mooney | kashyap: that could be useful yes | |
| 15:46:56 | kashyap | Yep; noted | |
| 16:42:10 | opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/790447 | |
| 16:42:11 | opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: fixup! libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/796891 | |
| 16:43:21 | opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/790447 | |
| 16:50:29 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796262 | |
| 17:04:02 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fixtures: Handle binding of first port https://review.opendev.org/c/openstack/nova/+/796905 | |
| 17:04:03 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Neutron fixture: don't clobber profile and vif_details if empty https://review.opendev.org/c/openstack/nova/+/796906 | |
| 17:04:04 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/c/openstack/nova/+/796907 | |
| 17:04:05 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Test SRIOV port move operations with PCI conflicts https://review.opendev.org/c/openstack/nova/+/796908 | |
| 17:04:07 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Update SRIOV port pci_slot when unshelving https://review.opendev.org/c/openstack/nova/+/796909 | |
| 17:06:36 | opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796259 | |
| 17:06:37 | opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796260 | |
| 17:06:38 | opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: Trival Change: Remove redundant code in instance delete https://review.opendev.org/c/openstack/nova/+/796912 | |
| 17:14:51 | lyarwood | melwitt: https://review.opendev.org/c/openstack/nova/+/796626 - Would you mind taking a look at this today if you get a chance, stephenfin is looking to split out the cherry-pick.sh script from the pep8 job. | |
| 17:16:08 | melwitt | sure | |
| 17:16:46 | lyarwood | thanks | |
| 17:20:37 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796262 | |
| 17:20:38 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/c/openstack/nova/+/796263 | |
| 17:20:39 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796264 | |
| 17:20:40 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: Trival Change: Remove redundant code in instance delete https://review.opendev.org/c/openstack/nova/+/796929 | |
| 17:22:26 | melwitt | stephenfin: does this empty deps = do something? https://review.opendev.org/c/openstack/nova/+/796626/2/tox.ini#87 | |
| 17:22:46 | sean-k-mooney | melwitt: i beleive it prevent use installing any deps | |
| 17:22:56 | melwitt | ok | |
| 17:23:10 | sean-k-mooney | we just need bash so this shoud make it slightly faster | |
| 17:23:17 | sean-k-mooney | sicne we ware just looking at the commit message | |
| 17:24:25 | melwitt | thanks | |
| 18:19:20 | opendevreview | Lee Yarwood proposed openstack/nova stable/train: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796935 | |
| 18:19:21 | opendevreview | Lee Yarwood proposed openstack/nova stable/train: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/c/openstack/nova/+/796936 | |
| 18:19:22 | opendevreview | Lee Yarwood proposed openstack/nova stable/train: Handle unset 'connection_info' https://review.opendev.org/c/openstack/nova/+/796937 | |
| 18:19:23 | opendevreview | Lee Yarwood proposed openstack/nova stable/train: Trival Change: Remove redundant code in instance delete https://review.opendev.org/c/openstack/nova/+/796938 | |
| 18:19:25 | opendevreview | Lee Yarwood proposed openstack/nova stable/train: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796939 | |
| 21:42:28 | opendevreview | Merged openstack/nova master: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/796626 | |
| #openstack-nova - 2021-06-18 | |||
| 02:47:33 | opendevreview | HYSong proposed openstack/nova master: fix vm deleted incorrectly when restoring failed https://review.opendev.org/c/openstack/nova/+/796985 | |
| 03:49:22 | opendevreview | wangzhenmeng proposed openstack/nova master: Three CPU parameters, mode, model and vendor_id, are added to flavor, some guest os do not support new CPU, so you need to specify a specific CPU when starting. https://review.opendev.org/c/openstack/nova/+/796986 | |
| 07:01:01 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 07:01:03 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 07:01:06 | opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 07:01:09 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 07:01:11 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 07:07:03 | yonglihe | alex_xu, addressed comments for 'smartnic support'. | |
| 08:49:24 | kevinz | Hi Nova, would be really appreciated if you can help to review this patch for live migrate on Arm64: https://review.opendev.org/c/openstack/nova/+/763928, the patch has been updated | |
| 08:50:54 | opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | |
| 08:50:59 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 08:52:26 | melwitt | gibi: just added a whackadoodle func test for the race scenario ^. I'm off tomorrow and next week so I just wanted to push this for now. still have to fix the rollback logic and address your other comments, will do that week after next | |
| 08:53:28 | melwitt | feel free to reapply your -1 to flag it | |
| 08:55:04 | gibi | melwitt: ack, thank. have a nice time off | |
| 08:55:30 | melwitt | thanks o/ | |
| 08:55:36 | gibi | o/ | |
| 09:15:30 | stephenfin | gibi: I've addressed your comments on https://review.opendev.org/c/openstack/nova/+/786292/ if you have time today | |
| 09:48:19 | opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/797039 | |
| 09:49:54 | opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/797040 | |
| 10:24:23 | stephenfin | Is it just me, or does building lower-constraints locally take, like, 5-10 minutes to run? | |
| 10:24:31 | stephenfin | guess there's a lot of dependency resolution going on | |
| 10:26:19 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/797050 | |
| 10:27:18 | opendevreview | Lee Yarwood proposed openstack/nova stable/train: Move 'check-cherry-picks' test to gate, n-v check https://review.opendev.org/c/openstack/nova/+/797052 | |
| 10:27:23 | lyarwood | can't say I've tried recently but I can give it a go now | |
| 10:28:39 | stephenfin | yeah, it's still ongoing here 10 minutes later | |
| 10:29:13 | gibi | stephenfin: it is slow to me too | |
| 10:30:51 | stephenfin | aaaand it failed because it's trying to run with the default python3 version, so 3.9.5 on my host :-( | |
| 10:31:09 | opendevreview | Stephen Finucane proposed openstack/nova stable/wallaby: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/790447 | |
| 10:32:49 | lyarwood | stephenfin: lol it failed in like 30 seconds for me because of 3.9 | |
| 10:33:15 | lyarwood | stephenfin: building greenlet right? | |
| 10:33:18 | stephenfin | yup | |
| 10:33:26 | stephenfin | I guess you had the packages locally already | |
| 10:34:19 | lyarwood | right so it isn't pip for you at least | |
| 10:34:33 | lyarwood | ah well I guess it does that before downloading | |
| 10:34:37 | lyarwood | so maybe it is | |
| 10:34:58 | gibi | yup greenlet for me too | |
| 10:35:13 | gibi | it take 5 minutes on my laptop to fail | |
| 10:36:21 | lyarwood | with 3.8 it takes ~30 seconds before tests start running | |
| 10:36:42 | opendevreview | Stephen Finucane proposed openstack/nova master: tox: Encode specific Python versions https://review.opendev.org/c/openstack/nova/+/797054 | |
| 10:36:44 | lyarwood | with a fresh .tox folder but lots cached on the host | |
| 10:36:47 | stephenfin | lyarwood: gibi: ^ | |
| 10:37:07 | lyarwood | stephenfin: I'm sure I suggested this in the past but gmann had reasons not to do it | |
| 10:37:13 | stephenfin | it'll be nice to be able to use the 'functional' env (vs. 'functional-py38') again | |
| 10:37:20 | lyarwood | aye | |
| 10:37:52 | lyarwood | https://governance.openstack.org/tc/reference/runtimes/xena.html tbh 3.9 isn't listed as a supported runtime anyway so we should really cap | |
| 10:37:56 | stephenfin | I don't see any disadvantage other than the busywork aspect I've noted | |
| 10:38:38 | stephenfin | we use 'py3' as a default env in oslo land but the oslo libs are far simpler with fewer dependencies likely to cause issues on other python versions | |
| 10:57:58 | stephenfin | lyarwood: Okay, got lower-constraints working and https://review.opendev.org/c/openstack/nova/+/790447 is now passing locally. Could you take a look today or early next week? I'd ping melwitt too but she's out now | |
| 10:58:22 | stephenfin | I purposefully pushed the changes up separately, so you should be able to diff PS1 and PS3 to see what I did, in case the commit message isn't clear | |
| 10:58:32 | stephenfin | *changes from the master version | |
| 11:32:37 | lyarwood | stephenfin: left some quick comments, I might be missing something tbh but I don't see tests for the check_can_live_migrate_destination changes? | |
| 11:34:50 | opendevreview | sean mooney proposed openstack/nova master: Test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/769601 | |
| 11:34:51 | opendevreview | sean mooney proposed openstack/nova master: Fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/769614 | |
| 11:35:45 | opendevreview | Lee Yarwood proposed openstack/nova master: tests: Allow bindep and test-setup.sh to run on EL distros https://review.opendev.org/c/openstack/nova/+/796428 | |
| 11:35:45 | opendevreview | Lee Yarwood proposed openstack/nova master: zuul: Add nova-tox-functional-centos8-py36 job https://review.opendev.org/c/openstack/nova/+/796684 | |
| 11:38:29 | sean-k-mooney | wow my console is jsut being spamed by sqlacmy warnings when i run the functional test | |
| 11:39:06 | sean-k-mooney | TypeDecoratro softDeleteInterger somethign something | |
| 11:41:55 | sean-k-mooney | /home/sean/repos/openstack/nova/nova/db/sqlalchemy/api.py:419: SAWarning: TypeDecorator SoftDeleteInteger() will not produce a cache key because the ``cache_ok`` flag is not set to True. Set this flag to True if this type object's state is safe to use in a cache key, or False to disable this warning. | |
| 11:41:57 | sean-k-mooney | return dict(min_versions) | |
| 11:41:59 | sean-k-mooney | /home/sean/repos/openstack/nova/nova/db/sqlalchemy/api.py:473: SAWarning: TypeDecorator SoftDeleteInteger() will not produce a cache key because the ``cache_ok`` flag is not set to True. Set this flag to True if this type object's state is safe to use in a cache key, or False to disable this warning. | |
| 11:42:01 | sean-k-mooney | result = model_query(context, models.Service, read_deleted="no").\ | |